Re: Any hope for a fix of STORM-3032 ?
I thought the API changes for Storm 2.x were mostly minor. Which API changes are you being blocked by? Den søn. 22. sep. 2019 kl. 21.27 skrev Alexandre Vermeerbergen < avermeerber...@gmail.com>: > Hello Stig, > > Thank you very much for your answer. > > Upgrading to Storm 2.x is something I would like to try, but I know > that building with Storm 2.x API requires changing our topologies > since some API have changes (I used to try, and was kind of blocked by > the un-reversible changes that were required). > > Question: could our Storm 1.x topology work with Storm 2.x ? > > Kind regards, > Alexandre > > Le jeu. 19 sept. 2019 à 19:05, Stig Rohde Døssing > a écrit : > > > > Looking at the stack trace, the issue is not in the Kafka bolt, but in > some > > internal Storm statistics code. It seems likely to me that it has been > > fixed in 2.0.0, as we haven't heard of anyone encounter it there. Are you > > able to upgrade to 2.x to see if that fixes this? > > > > If not, the exception is coming from > > > https://github.com/apache/storm/blob/1.x-branch/storm-core/src/clj/org/apache/storm/stats.clj#L131 > . > > Looks like either "amt" or " (stats-rate stats) " in that line is null. > My > > guess would be stats. The equivalent code in 2.x uses primitive ints, so > > won't be throwing NPEs > > > https://github.com/apache/storm/blob/master/storm-client/src/jvm/org/apache/storm/stats/CommonStats.java#L63 > > > > If you have the ability to upgrade to 2.0.0 that would be best. > > > > I don't think simply catching the NPE is a good solution, we should > prevent > > the NPE from being thrown in the first place. If you want to take a look > at > > it, feel free to raise a PR. May want to also lobby to get a 1.2.4 > release > > out after that. > > > > Den ons. 18. sep. 2019 kl. 17.04 skrev Alexandre Vermeerbergen < > > avermeerber...@gmail.com>: > > > > > Hello, > > > > > > I have seen couple of occurrences of the NullPointerException in Storm > > > Kafka Spout with same stack trace as in > > > https://issues.apache.org/jira/browse/STORM-3032 > > > > > > Using Storm 1.2.3, with Kafka Client at 2.0.1 version, connected to a > > > cluster of Kafka Brokers at 2.2.1 version. > > > > > > Since the stack traces seems to tell that the NullPointerException > > > occurs in some code related to statistics computation, wouldn't it be > > > better to fix the issue by catching the NullPointerException to avoid > > > blocking Kafka consumption ? > > > > > > Kind regards, > > > Alexandre Vermeerbergen > > > >
Re: Any hope for a fix of STORM-3032 ?
Hello Stig, Thank you very much for your answer. Upgrading to Storm 2.x is something I would like to try, but I know that building with Storm 2.x API requires changing our topologies since some API have changes (I used to try, and was kind of blocked by the un-reversible changes that were required). Question: could our Storm 1.x topology work with Storm 2.x ? Kind regards, Alexandre Le jeu. 19 sept. 2019 à 19:05, Stig Rohde Døssing a écrit : > > Looking at the stack trace, the issue is not in the Kafka bolt, but in some > internal Storm statistics code. It seems likely to me that it has been > fixed in 2.0.0, as we haven't heard of anyone encounter it there. Are you > able to upgrade to 2.x to see if that fixes this? > > If not, the exception is coming from > https://github.com/apache/storm/blob/1.x-branch/storm-core/src/clj/org/apache/storm/stats.clj#L131. > Looks like either "amt" or " (stats-rate stats) " in that line is null. My > guess would be stats. The equivalent code in 2.x uses primitive ints, so > won't be throwing NPEs > https://github.com/apache/storm/blob/master/storm-client/src/jvm/org/apache/storm/stats/CommonStats.java#L63 > > If you have the ability to upgrade to 2.0.0 that would be best. > > I don't think simply catching the NPE is a good solution, we should prevent > the NPE from being thrown in the first place. If you want to take a look at > it, feel free to raise a PR. May want to also lobby to get a 1.2.4 release > out after that. > > Den ons. 18. sep. 2019 kl. 17.04 skrev Alexandre Vermeerbergen < > avermeerber...@gmail.com>: > > > Hello, > > > > I have seen couple of occurrences of the NullPointerException in Storm > > Kafka Spout with same stack trace as in > > https://issues.apache.org/jira/browse/STORM-3032 > > > > Using Storm 1.2.3, with Kafka Client at 2.0.1 version, connected to a > > cluster of Kafka Brokers at 2.2.1 version. > > > > Since the stack traces seems to tell that the NullPointerException > > occurs in some code related to statistics computation, wouldn't it be > > better to fix the issue by catching the NullPointerException to avoid > > blocking Kafka consumption ? > > > > Kind regards, > > Alexandre Vermeerbergen > >
Location for 2.0 blogs
I see that we have never published any blogs previouslyanywhere on the Apache Storm website.So wondering where would be a good location to publish the (overdue) 2.0 perf blog that I am close to completing. I guess that might dictate the format (html / wiki) the final version needs to be in. Suggestions ? -roshan
