Re: [VOTE] Release Apache Storm 2.2.0 (RC1)

2020-06-15 Thread Ethan Li 
Thanks Govind

> On Jun 15, 2020, at 1:28 PM, Kishorkumar Patil  
> wrote:
> 
> Thanks Govind.
> 
> -Kishor
> 
> On Mon, Jun 15, 2020 at 2:03 PM Govind Menon 
> wrote:
> 
>> Will close the vote and start a new one.
>> 
>> On Mon, 15 Jun 2020 at 12:57, Ethan Li  wrote:
>> 
>>> I cherry-picked the change to 2.2.x-branch. This unit test should be more
>>> stable in environments with low cpu resources now. Thanks.
>>> 
 On Jun 15, 2020, at 12:34 PM, Kishorkumar Patil <
>>> kishorvpa...@apache.org> wrote:
 
 The rest of the tests are working fine. Manual running of throughput vs
 latency and other manual checks for DRPC work fine.
 The unit test *ExecutorTransferMultiThreadingTest* we added fails
 consistently for me on VM/mac for low CPU. So -1 on this release
>>> candidate.
 Ethan has a patch to fix this -
 https://github.com/apache/storm/pull/3286/files. We  should cut the
>>> next
 release candidate with this patch.
 
 [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time
 elapsed: 1.582 s <<< FAILURE! - in
 org.apache.storm.executor.ExecutorTransferMultiThreadingTest
 [ERROR] testExecutorTransfer  Time elapsed: 1.582 s  <<< FAILURE!
 java.lang.AssertionError: expected:<10> but was:<0>
  at org.junit.Assert.fail(Assert.java:88)
  at org.junit.Assert.failNotEquals(Assert.java:834)
  at org.junit.Assert.assertEquals(Assert.java:645)
  at org.junit.Assert.assertEquals(Assert.java:631)
  at
>>> org.apache.storm.executor.ExecutorTransferMultiThreadingTest$SingleThreadedConsumer.finalCheck(ExecutorTransferMultiThreadingTest.java:187)
  at
>>> org.apache.storm.executor.ExecutorTransferMultiThreadingTest.testExecutorTransfer(ExecutorTransferMultiThreadingTest.java:136)
  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 
 -Kishor
 
 
 On Mon, Jun 15, 2020 at 1:55 AM Julien Nioche <
>>> lists.digitalpeb...@gmail.com>
 wrote:
 
> +1 (non binding)
> 
> I have been running a crawl with StormCrawler successfully for the
>>> last 2
> days, no errors or exceptions to report. Thanks everyone!
> 
> On Fri, 12 Jun 2020 at 00:03, Govind Menon  wrote:
> 
>> This is a call to vote on releasing Apache Storm 2.2.0 (As a personal
> note
>> I would like to thank P. Taylor Goetz and Ethan Li for all the
>> documentation they have set up to make releasing easier)
>> 
>> Full list of changes in this release:
>> 
>> 
>> 
> 
>>> https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.2.0-rc1/RELEASE_NOTES.html
>> 
>> The tag/commit to be voted upon is v2.2.0:
>> 
>> 
>> 
> 
>>> https://gitbox.apache.org/repos/asf?p=storm.git;a=commit;h=de1f107e58bfe61aa43ae87e26f657f76e004a19
>> 
>> The source archive being voted upon can be found here:
>> 
>> 
>> 
> 
>>> https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.2.0-rc1/apache-storm-2.2.0-src.tar.gz
>> 
>> Other release files, signatures and digests can be found here:
>> 
>> https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.2.0-rc1/
>> 
>> The release artifacts are signed with the following key:
>> 
>> https://www.apache.org/dist/storm/KEYS
>> 
>> The Nexus staging repository for this release is:
>> 
>> 
>>> https://repository.apache.org/content/repositories/orgapachestorm-1094
>> 
>> Please vote on releasing this package as Apache Storm 2.2.0.
>> 
>> When voting, please list the actions taken to verify the release.
>> 
>> This vote will be open for at least 72 hours.
>> 
>> [ ] +1 Release this package as Apache Storm 2.2.0
>> [ ]  0 No opinion
>> [ ] -1 Do not release this package because...
>> 
>> Thanks to everyone who contributed to this release.
>> 
> 
> 
> --
> 
> *Open Source Solutions for Text Engineering*
> 
> http://www.digitalpebble.com
> http://digitalpebble.blogspot.com/
> #digitalpebble 
> 
>>> 
>>>

Re: [VOTE] Release Apache Storm 2.2.0 (RC1)

2020-06-15 Thread Kishorkumar Patil 
Thanks Govind.

-Kishor

On Mon, Jun 15, 2020 at 2:03 PM Govind Menon 
wrote:

> Will close the vote and start a new one.
>
> On Mon, 15 Jun 2020 at 12:57, Ethan Li  wrote:
>
>> I cherry-picked the change to 2.2.x-branch. This unit test should be more
>> stable in environments with low cpu resources now. Thanks.
>>
>> > On Jun 15, 2020, at 12:34 PM, Kishorkumar Patil <
>> kishorvpa...@apache.org> wrote:
>> >
>> > The rest of the tests are working fine. Manual running of throughput vs
>> > latency and other manual checks for DRPC work fine.
>> > The unit test *ExecutorTransferMultiThreadingTest* we added fails
>> > consistently for me on VM/mac for low CPU. So -1 on this release
>> candidate.
>> > Ethan has a patch to fix this -
>> > https://github.com/apache/storm/pull/3286/files. We  should cut the
>> next
>> > release candidate with this patch.
>> >
>> > [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time
>> > elapsed: 1.582 s <<< FAILURE! - in
>> > org.apache.storm.executor.ExecutorTransferMultiThreadingTest
>> > [ERROR] testExecutorTransfer  Time elapsed: 1.582 s  <<< FAILURE!
>> > java.lang.AssertionError: expected:<10> but was:<0>
>> >   at org.junit.Assert.fail(Assert.java:88)
>> >   at org.junit.Assert.failNotEquals(Assert.java:834)
>> >   at org.junit.Assert.assertEquals(Assert.java:645)
>> >   at org.junit.Assert.assertEquals(Assert.java:631)
>> >   at
>> org.apache.storm.executor.ExecutorTransferMultiThreadingTest$SingleThreadedConsumer.finalCheck(ExecutorTransferMultiThreadingTest.java:187)
>> >   at
>> org.apache.storm.executor.ExecutorTransferMultiThreadingTest.testExecutorTransfer(ExecutorTransferMultiThreadingTest.java:136)
>> >   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>> >
>> > -Kishor
>> >
>> >
>> > On Mon, Jun 15, 2020 at 1:55 AM Julien Nioche <
>> lists.digitalpeb...@gmail.com>
>> > wrote:
>> >
>> >> +1 (non binding)
>> >>
>> >> I have been running a crawl with StormCrawler successfully for the
>> last 2
>> >> days, no errors or exceptions to report. Thanks everyone!
>> >>
>> >> On Fri, 12 Jun 2020 at 00:03, Govind Menon  wrote:
>> >>
>> >>> This is a call to vote on releasing Apache Storm 2.2.0 (As a personal
>> >> note
>> >>> I would like to thank P. Taylor Goetz and Ethan Li for all the
>> >>> documentation they have set up to make releasing easier)
>> >>>
>> >>> Full list of changes in this release:
>> >>>
>> >>>
>> >>>
>> >>
>> https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.2.0-rc1/RELEASE_NOTES.html
>> >>>
>> >>> The tag/commit to be voted upon is v2.2.0:
>> >>>
>> >>>
>> >>>
>> >>
>> https://gitbox.apache.org/repos/asf?p=storm.git;a=commit;h=de1f107e58bfe61aa43ae87e26f657f76e004a19
>> >>>
>> >>> The source archive being voted upon can be found here:
>> >>>
>> >>>
>> >>>
>> >>
>> https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.2.0-rc1/apache-storm-2.2.0-src.tar.gz
>> >>>
>> >>> Other release files, signatures and digests can be found here:
>> >>>
>> >>> https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.2.0-rc1/
>> >>>
>> >>> The release artifacts are signed with the following key:
>> >>>
>> >>> https://www.apache.org/dist/storm/KEYS
>> >>>
>> >>> The Nexus staging repository for this release is:
>> >>>
>> >>>
>> https://repository.apache.org/content/repositories/orgapachestorm-1094
>> >>>
>> >>> Please vote on releasing this package as Apache Storm 2.2.0.
>> >>>
>> >>> When voting, please list the actions taken to verify the release.
>> >>>
>> >>> This vote will be open for at least 72 hours.
>> >>>
>> >>> [ ] +1 Release this package as Apache Storm 2.2.0
>> >>> [ ]  0 No opinion
>> >>> [ ] -1 Do not release this package because...
>> >>>
>> >>> Thanks to everyone who contributed to this release.
>> >>>
>> >>
>> >>
>> >> --
>> >>
>> >> *Open Source Solutions for Text Engineering*
>> >>
>> >> http://www.digitalpebble.com
>> >> http://digitalpebble.blogspot.com/
>> >> #digitalpebble 
>> >>
>>
>>

Re: [VOTE] Release Apache Storm 2.2.0 (RC1)

2020-06-15 Thread Govind Menon 
Will close the vote and start a new one.

On Mon, 15 Jun 2020 at 12:57, Ethan Li  wrote:

> I cherry-picked the change to 2.2.x-branch. This unit test should be more
> stable in environments with low cpu resources now. Thanks.
>
> > On Jun 15, 2020, at 12:34 PM, Kishorkumar Patil 
> wrote:
> >
> > The rest of the tests are working fine. Manual running of throughput vs
> > latency and other manual checks for DRPC work fine.
> > The unit test *ExecutorTransferMultiThreadingTest* we added fails
> > consistently for me on VM/mac for low CPU. So -1 on this release
> candidate.
> > Ethan has a patch to fix this -
> > https://github.com/apache/storm/pull/3286/files. We  should cut the next
> > release candidate with this patch.
> >
> > [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time
> > elapsed: 1.582 s <<< FAILURE! - in
> > org.apache.storm.executor.ExecutorTransferMultiThreadingTest
> > [ERROR] testExecutorTransfer  Time elapsed: 1.582 s  <<< FAILURE!
> > java.lang.AssertionError: expected:<10> but was:<0>
> >   at org.junit.Assert.fail(Assert.java:88)
> >   at org.junit.Assert.failNotEquals(Assert.java:834)
> >   at org.junit.Assert.assertEquals(Assert.java:645)
> >   at org.junit.Assert.assertEquals(Assert.java:631)
> >   at
> org.apache.storm.executor.ExecutorTransferMultiThreadingTest$SingleThreadedConsumer.finalCheck(ExecutorTransferMultiThreadingTest.java:187)
> >   at
> org.apache.storm.executor.ExecutorTransferMultiThreadingTest.testExecutorTransfer(ExecutorTransferMultiThreadingTest.java:136)
> >   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> >
> > -Kishor
> >
> >
> > On Mon, Jun 15, 2020 at 1:55 AM Julien Nioche <
> lists.digitalpeb...@gmail.com>
> > wrote:
> >
> >> +1 (non binding)
> >>
> >> I have been running a crawl with StormCrawler successfully for the last
> 2
> >> days, no errors or exceptions to report. Thanks everyone!
> >>
> >> On Fri, 12 Jun 2020 at 00:03, Govind Menon  wrote:
> >>
> >>> This is a call to vote on releasing Apache Storm 2.2.0 (As a personal
> >> note
> >>> I would like to thank P. Taylor Goetz and Ethan Li for all the
> >>> documentation they have set up to make releasing easier)
> >>>
> >>> Full list of changes in this release:
> >>>
> >>>
> >>>
> >>
> https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.2.0-rc1/RELEASE_NOTES.html
> >>>
> >>> The tag/commit to be voted upon is v2.2.0:
> >>>
> >>>
> >>>
> >>
> https://gitbox.apache.org/repos/asf?p=storm.git;a=commit;h=de1f107e58bfe61aa43ae87e26f657f76e004a19
> >>>
> >>> The source archive being voted upon can be found here:
> >>>
> >>>
> >>>
> >>
> https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.2.0-rc1/apache-storm-2.2.0-src.tar.gz
> >>>
> >>> Other release files, signatures and digests can be found here:
> >>>
> >>> https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.2.0-rc1/
> >>>
> >>> The release artifacts are signed with the following key:
> >>>
> >>> https://www.apache.org/dist/storm/KEYS
> >>>
> >>> The Nexus staging repository for this release is:
> >>>
> >>> https://repository.apache.org/content/repositories/orgapachestorm-1094
> >>>
> >>> Please vote on releasing this package as Apache Storm 2.2.0.
> >>>
> >>> When voting, please list the actions taken to verify the release.
> >>>
> >>> This vote will be open for at least 72 hours.
> >>>
> >>> [ ] +1 Release this package as Apache Storm 2.2.0
> >>> [ ]  0 No opinion
> >>> [ ] -1 Do not release this package because...
> >>>
> >>> Thanks to everyone who contributed to this release.
> >>>
> >>
> >>
> >> --
> >>
> >> *Open Source Solutions for Text Engineering*
> >>
> >> http://www.digitalpebble.com
> >> http://digitalpebble.blogspot.com/
> >> #digitalpebble 
> >>
>
>

Re: [VOTE] Release Apache Storm 2.2.0 (RC1)

2020-06-15 Thread Ethan Li 
I cherry-picked the change to 2.2.x-branch. This unit test should be more 
stable in environments with low cpu resources now. Thanks.

> On Jun 15, 2020, at 12:34 PM, Kishorkumar Patil  
> wrote:
> 
> The rest of the tests are working fine. Manual running of throughput vs
> latency and other manual checks for DRPC work fine.
> The unit test *ExecutorTransferMultiThreadingTest* we added fails
> consistently for me on VM/mac for low CPU. So -1 on this release candidate.
> Ethan has a patch to fix this -
> https://github.com/apache/storm/pull/3286/files. We  should cut the next
> release candidate with this patch.
> 
> [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time
> elapsed: 1.582 s <<< FAILURE! - in
> org.apache.storm.executor.ExecutorTransferMultiThreadingTest
> [ERROR] testExecutorTransfer  Time elapsed: 1.582 s  <<< FAILURE!
> java.lang.AssertionError: expected:<10> but was:<0>
>   at org.junit.Assert.fail(Assert.java:88)
>   at org.junit.Assert.failNotEquals(Assert.java:834)
>   at org.junit.Assert.assertEquals(Assert.java:645)
>   at org.junit.Assert.assertEquals(Assert.java:631)
>   at 
> org.apache.storm.executor.ExecutorTransferMultiThreadingTest$SingleThreadedConsumer.finalCheck(ExecutorTransferMultiThreadingTest.java:187)
>   at 
> org.apache.storm.executor.ExecutorTransferMultiThreadingTest.testExecutorTransfer(ExecutorTransferMultiThreadingTest.java:136)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 
> -Kishor
> 
> 
> On Mon, Jun 15, 2020 at 1:55 AM Julien Nioche 
> wrote:
> 
>> +1 (non binding)
>> 
>> I have been running a crawl with StormCrawler successfully for the last 2
>> days, no errors or exceptions to report. Thanks everyone!
>> 
>> On Fri, 12 Jun 2020 at 00:03, Govind Menon  wrote:
>> 
>>> This is a call to vote on releasing Apache Storm 2.2.0 (As a personal
>> note
>>> I would like to thank P. Taylor Goetz and Ethan Li for all the
>>> documentation they have set up to make releasing easier)
>>> 
>>> Full list of changes in this release:
>>> 
>>> 
>>> 
>> https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.2.0-rc1/RELEASE_NOTES.html
>>> 
>>> The tag/commit to be voted upon is v2.2.0:
>>> 
>>> 
>>> 
>> https://gitbox.apache.org/repos/asf?p=storm.git;a=commit;h=de1f107e58bfe61aa43ae87e26f657f76e004a19
>>> 
>>> The source archive being voted upon can be found here:
>>> 
>>> 
>>> 
>> https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.2.0-rc1/apache-storm-2.2.0-src.tar.gz
>>> 
>>> Other release files, signatures and digests can be found here:
>>> 
>>> https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.2.0-rc1/
>>> 
>>> The release artifacts are signed with the following key:
>>> 
>>> https://www.apache.org/dist/storm/KEYS
>>> 
>>> The Nexus staging repository for this release is:
>>> 
>>> https://repository.apache.org/content/repositories/orgapachestorm-1094
>>> 
>>> Please vote on releasing this package as Apache Storm 2.2.0.
>>> 
>>> When voting, please list the actions taken to verify the release.
>>> 
>>> This vote will be open for at least 72 hours.
>>> 
>>> [ ] +1 Release this package as Apache Storm 2.2.0
>>> [ ]  0 No opinion
>>> [ ] -1 Do not release this package because...
>>> 
>>> Thanks to everyone who contributed to this release.
>>> 
>> 
>> 
>> --
>> 
>> *Open Source Solutions for Text Engineering*
>> 
>> http://www.digitalpebble.com
>> http://digitalpebble.blogspot.com/
>> #digitalpebble 
>>

[GitHub] [storm] Ethanlm commented on pull request #3286: [STORM-3651] Give producerTasks in ExecutorTransferMultiThreadingTest.testExecutorTransfer more time to finish

2020-06-15 Thread GitBox 


Ethanlm commented on pull request #3286:
URL: https://github.com/apache/storm/pull/3286#issuecomment-644279794


   cherry-picked to 2.2.x-branch 
https://github.com/apache/storm/commit/3d969c4d63be9fe2759f44af609d5d7a88d6a30a



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [VOTE] Release Apache Storm 2.2.0 (RC1)

2020-06-15 Thread Kishorkumar Patil 
The rest of the tests are working fine. Manual running of throughput vs
latency and other manual checks for DRPC work fine.
The unit test *ExecutorTransferMultiThreadingTest* we added fails
consistently for me on VM/mac for low CPU. So -1 on this release candidate.
Ethan has a patch to fix this -
https://github.com/apache/storm/pull/3286/files. We  should cut the next
release candidate with this patch.

[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time
elapsed: 1.582 s <<< FAILURE! - in
org.apache.storm.executor.ExecutorTransferMultiThreadingTest
[ERROR] testExecutorTransfer  Time elapsed: 1.582 s  <<< FAILURE!
java.lang.AssertionError: expected:<10> but was:<0>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:645)
at org.junit.Assert.assertEquals(Assert.java:631)
at 
org.apache.storm.executor.ExecutorTransferMultiThreadingTest$SingleThreadedConsumer.finalCheck(ExecutorTransferMultiThreadingTest.java:187)
at 
org.apache.storm.executor.ExecutorTransferMultiThreadingTest.testExecutorTransfer(ExecutorTransferMultiThreadingTest.java:136)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

-Kishor


On Mon, Jun 15, 2020 at 1:55 AM Julien Nioche 
wrote:

> +1 (non binding)
>
> I have been running a crawl with StormCrawler successfully for the last 2
> days, no errors or exceptions to report. Thanks everyone!
>
> On Fri, 12 Jun 2020 at 00:03, Govind Menon  wrote:
>
> > This is a call to vote on releasing Apache Storm 2.2.0 (As a personal
> note
> > I would like to thank P. Taylor Goetz and Ethan Li for all the
> > documentation they have set up to make releasing easier)
> >
> > Full list of changes in this release:
> >
> >
> >
> https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.2.0-rc1/RELEASE_NOTES.html
> >
> > The tag/commit to be voted upon is v2.2.0:
> >
> >
> >
> https://gitbox.apache.org/repos/asf?p=storm.git;a=commit;h=de1f107e58bfe61aa43ae87e26f657f76e004a19
> >
> > The source archive being voted upon can be found here:
> >
> >
> >
> https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.2.0-rc1/apache-storm-2.2.0-src.tar.gz
> >
> > Other release files, signatures and digests can be found here:
> >
> > https://dist.apache.org/repos/dist/dev/storm/apache-storm-2.2.0-rc1/
> >
> > The release artifacts are signed with the following key:
> >
> > https://www.apache.org/dist/storm/KEYS
> >
> > The Nexus staging repository for this release is:
> >
> > https://repository.apache.org/content/repositories/orgapachestorm-1094
> >
> > Please vote on releasing this package as Apache Storm 2.2.0.
> >
> > When voting, please list the actions taken to verify the release.
> >
> > This vote will be open for at least 72 hours.
> >
> > [ ] +1 Release this package as Apache Storm 2.2.0
> > [ ]  0 No opinion
> > [ ] -1 Do not release this package because...
> >
> > Thanks to everyone who contributed to this release.
> >
>
>
> --
>
> *Open Source Solutions for Text Engineering*
>
> http://www.digitalpebble.com
> http://digitalpebble.blogspot.com/
> #digitalpebble 
>

[GitHub] [storm] Ethanlm merged pull request #3286: [STORM-3651] Give producerTasks in ExecutorTransferMultiThreadingTest.testExecutorTransfer more time to finish

2020-06-15 Thread GitBox 


Ethanlm merged pull request #3286:
URL: https://github.com/apache/storm/pull/3286


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [storm] Ethanlm merged pull request #3249: [STORM-3624] Fix race condition when loading scheduler configs

2020-06-15 Thread GitBox 


Ethanlm merged pull request #3249:
URL: https://github.com/apache/storm/pull/3249


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org