Re: [PR] [STORM-3963] Add m2e plugin to storm-shaded-deps and few minor pom.xml fixes (storm)
rzo1 commented on code in PR #3573: URL: https://github.com/apache/storm/pull/3573#discussion_r1313319589 ## storm-shaded-deps/pom.xml: ## @@ -358,5 +357,34 @@ + + + + +org.eclipse.m2e +lifecycle-mapping +1.0.0 Review Comment: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [STORM-3963] Add m2e plugin to storm-shaded-deps and few minor pom.xml fixes (storm)
bipinprasad commented on code in PR #3573: URL: https://github.com/apache/storm/pull/3573#discussion_r1313314450 ## storm-shaded-deps/pom.xml: ## @@ -358,5 +357,34 @@ + + + + +org.eclipse.m2e +lifecycle-mapping +1.0.0 Review Comment: Wanted to keep it localized with the goal of removing this section completely when/if eclipse understands the class relocation. But on second thought, will pull this up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [STORM-3963] Add m2e plugin to storm-shaded-deps and few minor pom.xml fixes (storm)
bipinprasad commented on code in PR #3573: URL: https://github.com/apache/storm/pull/3573#discussion_r1313311313 ## storm-shaded-deps/pom.xml: ## @@ -337,7 +336,7 @@ --> org.codehaus.mojo build-helper-maven-plugin -3.3.0 +3.4.0 Review Comment: For some reason eclipse is better at understanding the phases on newer one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] STORM-3961 - Modernize Storm-UI Dependencies (storm)
bipinprasad merged PR #3572: URL: https://github.com/apache/storm/pull/3572 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [STORM-3970] Changes to storm-sql-core/pom.xml to avoid errors in Eclipse (storm)
rzo1 commented on PR #3578: URL: https://github.com/apache/storm/pull/3578#issuecomment-1703064106 I closed it. With the addition to the PMC, you should have enough Karma for Jira stuff. If not, we need to check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [STORM-3970] Changes to storm-sql-core/pom.xml to avoid errors in Eclipse (storm)
Hi Bipin,
That will be wonderful if you find the way to fix these last 3 errors
in pom.xml files, thanks !!
By the way, I never experienced Eclipse IDE being confused about
files' content : just make sure if you edit the file outside Eclipse
IDE to use "Refresh" (when I doubt, I select all projects from Package
Explorer view, and I use [F5] to get everything on filesystem synced
to Eclipse IDE).
Kind regards,
Alexandre
Le ven. 1 sept. 2023 à 12:30, Bipin Prasad
a écrit :
>
> Yes, I have fixes for those. They will be up there shortly. But at least you
> are up and running and can use the power of UI.
> One thing surprised me with the latest eclipse - it is very easy for the
> Editor to get confused about the content of a file (and loose the trailing
> end of a file). I had to go a couple times in “vi” just to make sure that the
> file did not end where eclipse screen showed.
>
>
> Sent from Yahoo Mail for iPhone
>
>
> On Friday, September 1, 2023, 8:53 AM, Alexandre Vermeerbergen
> wrote:
>
> And by the way, after copying the changes from STORM-3970 (and closing
> storm-cassandra project, for which I'm anticipating low community
> interest, so I'm skipping it), I only have 3 errors left in Eclipse
> IDE for Storm:
>
> On /storm-client/pom.xml:
> line 206 (which just contains tag) error message is:
> - Plugin execution not covered by lifecycle configuration:
> org.apache.maven.plugins:maven-dependency-plugin:2.8:unpack
> (execution: unpack, phase: process-test-resources)
> - Failed to execute mojo
> org.apache.maven.plugins:maven-dependency-plugin:2.8:unpack
> {execution: unpack}
> (org.apache.maven.plugins:maven-dependency-plugin:2.8:unpack:unpack:process-test-resources)
>
> On /storm-core/pom.xml:
> line 367 (which just contains tag) error message is:
> - Failed to execute mojo
> org.apache.maven.plugins:maven-dependency-plugin:3.6.0:copy-dependencies
> {execution: copy-dependencies}
> (org.apache.maven.plugins:maven-dependency-plugin:3.6.0:copy-dependencies:copy-dependencies:package)
>
> On /storm-core/pom.xml:
> line 381 (which just contains tag) error message is:
> - Failed to execute mojo
> org.apache.maven.plugins:maven-dependency-plugin:3.6.0:unpack
> {execution: unpack}
> (org.apache.maven.plugins:maven-dependency-plugin:3.6.0:unpack:unpack:process-test-resources)
>
> What is strange is although there are these 3 last errors, there are
> no more Java compilation errors...
>
> Any idea how to get rid of these 3 last ones (I'm intentionally
> forgetting storm-cassandra) ?
>
> Kind regards,
> Alexandre
>
> Le ven. 1 sept. 2023 à 11:44, avermeer (via GitHub) a écrit
> :
> >
> >
> > avermeer commented on PR #3578:
> > URL: https://github.com/apache/storm/pull/3578#issuecomment-1702951565
> >
> >I verified that this change greatly improves the situation is Eclipse
> > IDE (by manually copying the changes to my local temporary branch for test
> > purposes).
> >
> >May I merge it ?
> >
> >
> > --
> > This is an automated message from the Apache Git Service.
> > To respond to the message, please log on to GitHub and use the
> > URL above to go to the specific comment.
> >
> > To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
> >
> > For queries about this service, please contact Infrastructure at:
> > us...@infra.apache.org
> >
>
>
>
Re: [PR] [STORM-3970] Changes to storm-sql-core/pom.xml to avoid errors in Eclipse (storm)
avermeer commented on PR #3578: URL: https://github.com/apache/storm/pull/3578#issuecomment-1703022984 Merging done! But I cannot close the JIRA https://issues.apache.org/jira/projects/STORM/issues/STORM-3970?filter=allopenissues, as it is owned by Bipin. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [STORM-3970] Changes to storm-sql-core/pom.xml to avoid errors in Eclipse (storm)
avermeer merged PR #3578: URL: https://github.com/apache/storm/pull/3578 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [STORM-3970] Changes to storm-sql-core/pom.xml to avoid errors in Eclipse (storm)
rzo1 commented on PR #3578: URL: https://github.com/apache/storm/pull/3578#issuecomment-1703016184 Go ahead + close the Jira -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [STORM-3970] Changes to storm-sql-core/pom.xml to avoid errors in Eclipse (storm)
Yes, I have fixes for those. They will be up there shortly. But at least you
are up and running and can use the power of UI.
One thing surprised me with the latest eclipse - it is very easy for the Editor
to get confused about the content of a file (and loose the trailing end of a
file). I had to go a couple times in “vi” just to make sure that the file did
not end where eclipse screen showed.
Sent from Yahoo Mail for iPhone
On Friday, September 1, 2023, 8:53 AM, Alexandre Vermeerbergen
wrote:
And by the way, after copying the changes from STORM-3970 (and closing
storm-cassandra project, for which I'm anticipating low community
interest, so I'm skipping it), I only have 3 errors left in Eclipse
IDE for Storm:
On /storm-client/pom.xml:
line 206 (which just contains tag) error message is:
- Plugin execution not covered by lifecycle configuration:
org.apache.maven.plugins:maven-dependency-plugin:2.8:unpack
(execution: unpack, phase: process-test-resources)
- Failed to execute mojo
org.apache.maven.plugins:maven-dependency-plugin:2.8:unpack
{execution: unpack}
(org.apache.maven.plugins:maven-dependency-plugin:2.8:unpack:unpack:process-test-resources)
On /storm-core/pom.xml:
line 367 (which just contains tag) error message is:
- Failed to execute mojo
org.apache.maven.plugins:maven-dependency-plugin:3.6.0:copy-dependencies
{execution: copy-dependencies}
(org.apache.maven.plugins:maven-dependency-plugin:3.6.0:copy-dependencies:copy-dependencies:package)
On /storm-core/pom.xml:
line 381 (which just contains tag) error message is:
- Failed to execute mojo
org.apache.maven.plugins:maven-dependency-plugin:3.6.0:unpack
{execution: unpack}
(org.apache.maven.plugins:maven-dependency-plugin:3.6.0:unpack:unpack:process-test-resources)
What is strange is although there are these 3 last errors, there are
no more Java compilation errors...
Any idea how to get rid of these 3 last ones (I'm intentionally
forgetting storm-cassandra) ?
Kind regards,
Alexandre
Le ven. 1 sept. 2023 à 11:44, avermeer (via GitHub) a écrit :
>
>
> avermeer commented on PR #3578:
> URL: https://github.com/apache/storm/pull/3578#issuecomment-1702951565
>
> I verified that this change greatly improves the situation is Eclipse IDE
>(by manually copying the changes to my local temporary branch for test
>purposes).
>
> May I merge it ?
>
>
> --
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
>
> For queries about this service, please contact Infrastructure at:
> us...@infra.apache.org
>
Re: [PR] [STORM-3970] Changes to storm-sql-core/pom.xml to avoid errors in Eclipse (storm)
And by the way, after copying the changes from STORM-3970 (and closing
storm-cassandra project, for which I'm anticipating low community
interest, so I'm skipping it), I only have 3 errors left in Eclipse
IDE for Storm:
On /storm-client/pom.xml:
line 206 (which just contains tag) error message is:
- Plugin execution not covered by lifecycle configuration:
org.apache.maven.plugins:maven-dependency-plugin:2.8:unpack
(execution: unpack, phase: process-test-resources)
- Failed to execute mojo
org.apache.maven.plugins:maven-dependency-plugin:2.8:unpack
{execution: unpack}
(org.apache.maven.plugins:maven-dependency-plugin:2.8:unpack:unpack:process-test-resources)
On /storm-core/pom.xml:
line 367 (which just contains tag) error message is:
- Failed to execute mojo
org.apache.maven.plugins:maven-dependency-plugin:3.6.0:copy-dependencies
{execution: copy-dependencies}
(org.apache.maven.plugins:maven-dependency-plugin:3.6.0:copy-dependencies:copy-dependencies:package)
On /storm-core/pom.xml:
line 381 (which just contains tag) error message is:
- Failed to execute mojo
org.apache.maven.plugins:maven-dependency-plugin:3.6.0:unpack
{execution: unpack}
(org.apache.maven.plugins:maven-dependency-plugin:3.6.0:unpack:unpack:process-test-resources)
What is strange is although there are these 3 last errors, there are
no more Java compilation errors...
Any idea how to get rid of these 3 last ones (I'm intentionally
forgetting storm-cassandra) ?
Kind regards,
Alexandre
Le ven. 1 sept. 2023 à 11:44, avermeer (via GitHub) a écrit :
>
>
> avermeer commented on PR #3578:
> URL: https://github.com/apache/storm/pull/3578#issuecomment-1702951565
>
>I verified that this change greatly improves the situation is Eclipse IDE
> (by manually copying the changes to my local temporary branch for test
> purposes).
>
>May I merge it ?
>
>
> --
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
>
> For queries about this service, please contact Infrastructure at:
> us...@infra.apache.org
>
Re: [PR] [STORM-3970] Changes to storm-sql-core/pom.xml to avoid errors in Eclipse (storm)
avermeer commented on PR #3578: URL: https://github.com/apache/storm/pull/3578#issuecomment-1702951565 I verified that this change greatly improves the situation is Eclipse IDE (by manually copying the changes to my local temporary branch for test purposes). May I merge it ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: Any clue to import Storm's pom.xml in Eclipse for contributing purposes?
Hello Alexandre,
I spent some time trying to tweak the storm-cassandra pom.xml. Although this
will end up in a pull request, the actual error in eclipse about "The package
java.util is accessible from more than one module: , java.base" will
remain.
I might try one or two other things today, but it is not looking good.
The other issue with storm-client/storm-core should have been fixed with other
PRs that were merged or will be merged.
Thanks
--Bipin
On Thursday, August 31, 2023 at 10:30:13 AM PDT, Bipin Prasad
wrote:
I will look into this later today.
Your project (subproject) jvm shows jdk/jvm-11 (as visible in eclipse in
Package Explorer window?
On Thursday, August 31, 2023 at 06:15:55 AM PDT, Alexandre Vermeerbergen
wrote:
Hello,
Thank you very much Bipin for your advice.
I did it, and good news, now the number of errors is much lower : from
several thousand errors to 73 errors.
First set of errors is very strange: in
/storm-cassandra/src/test/java/org/apache/storm/cassandra/trident/WeatherBatchSpout.java,
I have these imports:
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.Random;
import java.util.UUID;
with all the same errror: "The package java.util is accessible from
more than one module: , java.base"
=> this look like an issue with the notion of Java modules
Another error is on /storm-client/pom.xml, at line 206 with this long
error message:
-
Multiple markers at this line - Plugin execution not covered by
lifecycle configuration: org.apache.maven.plugins:maven-
dependency-plugin:2.8:unpack (execution: unpack, phase:
process-test-resources) - Failed to execute mojo
org.apache.maven.plugins:maven-dependency-plugin:2.8:unpack
{execution: unpack} (org.apache.maven.plugins:maven-
dependency-plugin:2.8:unpack:unpack:process-test-resources)
org.eclipse.core.runtime.CoreException: Failed to execute
mojo org.apache.maven.plugins:maven-dependency-plugin:2.8:unpack
{execution: unpack} at
org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeMojo(MavenExecutionContext.java:340)
at
... (more lines)
-
Any idea how to solve these 2 types of errors ? anything missing or to
fix in related pom.xml files?
Kind regards,
Alexandre
Le mer. 30 août 2023 à 23:41, Bipin Prasad
a écrit :
>
> Looks like eclipse (Also IntelliJ) doesn’t know about the relocated (shaded)
> class. Solution that I have used is to build Storm-shaded-deps directly in
> maven (mvn install), and then closing the storm-shaded-deps subproject in
> eclipse/IntelliJ. This forces the IDE to use the storm-shaded-jar from -/.m2
> and errors go away.
>
>
> Sent from Yahoo Mail for iPhone
>
>
> On Wednesday, August 30, 2023, 8:19 PM, Alexandre Vermeerbergen
> wrote:
>
> Hello;
>
> I have created a branch in my own fork of storm Github projet, and
> merged Bipin's changes from these two branches on his own fork:
>
> [STORM-3963] Add m2e plugin to storm-shaded-deps and few minor
> pom.xml fixes => remotes/origin/storm-3963 =>
> storm-shaded-deps/pom.xml
> [STORM-3967] Specify generated sources directory
> => remotes/origin/storm-3967 => pom.xml
>
> I cleaned everything that I previously had in Eclipse, then I tried to
> again create an blank Eclipse workspace, then, using Eclipse's import
> projects... / Maven / Existing Maven Projects and point to the root
> directory of my local Storm git directory.
>
> Maybe one interesting point at this step is that I leave everything
> selected by default "as is", including the "[x} Add project(s) to
> working set", with "storm" as the associated value.
>
> then I clic on "Finish".
>
> After certain time of processing/downloading dependencies, Eclipse
> shows me the "Discover m2e connectors" dialog with same list as in my
> initial post, with again, no matter what I select, there is no way to
> use "Finish" button
>
> => from here, clicking "on cancel", brings me to Eclipse IDE showing
> tons of errors in the various storm projects created by the import
> process.
>
> first one is the following line:
>
> /storm-server/src/main/java/org/apache/storm/zookeeper/AclEnforcement.java
>
> The errors are because the following imports are not found:
>
>
> import org.apache.storm.shade.org.apache.curator.framework.CuratorFramework;
> import org.apache.storm.shade.org.apache.zookeeper.KeeperException;
> import org.apache.storm.shade.org.apache.zookeeper.ZooDefs;
> import org.apache.storm.shade.org.apache.zookeeper.data.ACL;
> import org.apache.storm.shade.org.apache.zookeeper.data.Id;
> import
> org.apache.storm.shade.org.apache.zookeeper.server.auth.DigestAuthenticationProvider;
>
> It is like storm-shaded-deps's pom.xml was not automatically
> generating the shared dependencies for storm-server module.
>
> Any idea what to do next ?
[PR] [STORM-3970] Changes to storm-sql-core/pom.xml to avoid errors in Eclipse (storm)
bipinprasad opened a new pull request, #3578: URL: https://github.com/apache/storm/pull/3578 ## What is the purpose of the change *storm-sql-core extract javacc parser definition from Calcite jar, adds it to distribution, then used javacc to generate classes that parser definition file. These java classes are then used in storm-sql-core. Eclipse does not properly recognize and execute these steps and then shows errors because of missing generated classes.* ## How was the change tested *Review the project in project explorer tab in eclipse and ensure that errors are gone. Also do a "mvn clean install" to ensure that maven build is not broken.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
