Re: [PR] Bump nokogiri from 1.16.2 to 1.16.5 [storm-site]
reiabreu merged PR #53: URL: https://github.com/apache/storm-site/pull/53 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump nokogiri from 1.16.2 to 1.16.5 in /content [storm-site]
reiabreu merged PR #52: URL: https://github.com/apache/storm-site/pull/52 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump rexml from 3.2.6 to 3.2.8 in /content [storm-site]
reiabreu merged PR #54: URL: https://github.com/apache/storm-site/pull/54 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump rexml from 3.2.6 to 3.2.8 in /content [storm-site]
dependabot[bot] opened a new pull request, #54:
URL: https://github.com/apache/storm-site/pull/54
Bumps [rexml](https://github.com/ruby/rexml) from 3.2.6 to 3.2.8.
Release notes
Sourced from https://github.com/ruby/rexml/releases;>rexml's
releases.
REXML 3.2.8 - 2024-05-16
Fixes
Suppressed a warning
REXML 3.2.7 - 2024-05-16
Improvements
Improve parse performance by using StringScanner.
https://redirect.github.com/ruby/rexml/issues/106;>GH-106
https://redirect.github.com/ruby/rexml/issues/107;>GH-107
https://redirect.github.com/ruby/rexml/issues/108;>GH-108
https://redirect.github.com/ruby/rexml/issues/109;>GH-109
https://redirect.github.com/ruby/rexml/issues/112;>GH-112
https://redirect.github.com/ruby/rexml/issues/113;>GH-113
https://redirect.github.com/ruby/rexml/issues/114;>GH-114
https://redirect.github.com/ruby/rexml/issues/115;>GH-115
https://redirect.github.com/ruby/rexml/issues/116;>GH-116
https://redirect.github.com/ruby/rexml/issues/117;>GH-117
https://redirect.github.com/ruby/rexml/issues/118;>GH-118
https://redirect.github.com/ruby/rexml/issues/119;>GH-119
https://redirect.github.com/ruby/rexml/issues/121;>GH-121
Patch by NAITOH Jun.
Improved parse performance when an attribute has many
s.
https://redirect.github.com/ruby/rexml/issues/124;>GH-124
Fixes
XPath: Fixed a bug of normalize_space(array).
https://redirect.github.com/ruby/rexml/issues/110;>GH-110
https://redirect.github.com/ruby/rexml/issues/111;>GH-111
Patch by flatisland.
XPath: Fixed a bug that wrong position is used with nested path.
https://redirect.github.com/ruby/rexml/issues/110;>GH-110
https://redirect.github.com/ruby/rexml/issues/122;>GH-122
Reported by jcavalieri.
Patch by NAITOH Jun.
Fixed a bug that an exception message can't be generated for
invalid encoding XML.
... (truncated)
Changelog
Sourced from https://github.com/ruby/rexml/blob/master/NEWS.md;>rexml's
changelog.
3.2.8 - 2024-05-16 {#version-3-2-8}
Fixes
Suppressed a warning
3.2.7 - 2024-05-16 {#version-3-2-7}
Improvements
Improve parse performance by using StringScanner.
https://redirect.github.com/ruby/rexml/issues/106;>GH-106
https://redirect.github.com/ruby/rexml/issues/107;>GH-107
https://redirect.github.com/ruby/rexml/issues/108;>GH-108
https://redirect.github.com/ruby/rexml/issues/109;>GH-109
https://redirect.github.com/ruby/rexml/issues/112;>GH-112
https://redirect.github.com/ruby/rexml/issues/113;>GH-113
https://redirect.github.com/ruby/rexml/issues/114;>GH-114
https://redirect.github.com/ruby/rexml/issues/115;>GH-115
https://redirect.github.com/ruby/rexml/issues/116;>GH-116
https://redirect.github.com/ruby/rexml/issues/117;>GH-117
https://redirect.github.com/ruby/rexml/issues/118;>GH-118
https://redirect.github.com/ruby/rexml/issues/119;>GH-119
https://redirect.github.com/ruby/rexml/issues/121;>GH-121
Patch by NAITOH Jun.
Improved parse performance when an attribute has many
s.
https://redirect.github.com/ruby/rexml/issues/124;>GH-124
Fixes
XPath: Fixed a bug of normalize_space(array).
https://redirect.github.com/ruby/rexml/issues/110;>GH-110
https://redirect.github.com/ruby/rexml/issues/111;>GH-111
Patch by flatisland.
XPath: Fixed a bug that wrong position is used with nested path.
https://redirect.github.com/ruby/rexml/issues/110;>GH-110
https://redirect.github.com/ruby/rexml/issues/122;>GH-122
Reported by jcavalieri.
Patch by NAITOH Jun.
Fixed a bug that an exception message can't be generated for
... (truncated)
Commits
https://github.com/ruby/rexml/commit/1cf37bab79d61d6183bbda8bf525ed587012b718;>1cf37ba
Add 3.2.8 entry
https://github.com/ruby/rexml/commit/b67081caa807fad48d31983137b7ed8711e7f0df;>b67081c
Remove an unused variable (https://redirect.github.com/ruby/rexml/issues/128;>#128)
https://github.com/ruby/rexml/commit/94e180e939baff8f7e328a287bb96ebbd99db6eb;>94e180e
Suppress a warning
https://github.com/ruby/rexml/commit/d574ba5fe1c40adbafbf16e47533f4eb32b43e60;>d574ba5
ci: install only gems required for running tests (https://redirect.github.com/ruby/rexml/issues/129;>#129)
https://github.com/ruby/rexml/commit/4670f8fc187c89d0504d027ea997959287143453;>4670f8f
Add missing Thanks section
[PR] Bump nokogiri from 1.16.2 to 1.16.5 [storm-site]
dependabot[bot] opened a new pull request, #53: URL: https://github.com/apache/storm-site/pull/53 Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.16.2 to 1.16.5. Release notes Sourced from https://github.com/sparklemotion/nokogiri/releases;>nokogiri's releases. v1.16.5 / 2024-05-13 Security [CRuby] Vendored libxml2 is updated to address CVE-2024-34459. See https://github.com/sparklemotion/nokogiri/security/advisories/GHSA-r95h-9x8f-r3f7;>GHSA-r95h-9x8f-r3f7 for more information. Dependencies [CRuby] Vendored libxml2 is updated to https://gitlab.gnome.org/GNOME/libxml2/-/releases/v2.12.7;>v2.12.7 from v2.12.6. (https://github.com/flavorjones;>@flavorjones) sha256 checksums: af0f44fa3e664dfb2aa10de8b551447d720c1e8d1f0aa3f35783dcc43e40a874 nokogiri-1.16.5-aarch64-linux.gem 23dc2357b26409a5c33b7e32a82902f0e9995305420f16d1a03ab3ea1a482fec nokogiri-1.16.5-arm-linux.gem 950d037530edb49f75ad35de0b8038b970a7dda57e2b6326895b0e49fadf6214 nokogiri-1.16.5-arm64-darwin.gem b7aefc94370c62476b8528e8d8abb6160203abd84a1f4eceda8f1aa8974d9989 nokogiri-1.16.5-java.gem ec2167160df8fec3137bf95d574ed80ebc1d002bb3b281546b60b4aa9002466e nokogiri-1.16.5-x64-mingw-ucrt.gem 6984200491fac69974005ecfa2de129d61843d345eafa5d6f58e8b908d1cf107 nokogiri-1.16.5-x64-mingw32.gem abdc389ab1ec6604492da16bd9d06ad746fdb6bd6a1bd274c400d61ffcadb3c4 nokogiri-1.16.5-x86-linux.gem 63d24981345856f2baf7f4089870a62d3042fb8d3021b280fb04fc052532e3c4 nokogiri-1.16.5-x86-mingw32.gem 71b5f54e378c433d13df67c3b71acc4716129da62402d8181f310c4216a63279 nokogiri-1.16.5-x86_64-darwin.gem 0ca238da870066bed2f7837af6f35791bb9b76c4c5638999c46aac44818a6a97 nokogiri-1.16.5-x86_64-linux.gem ec36162c68984fa0a90a5c4ae7ab7759460639e716cc1ce75f34c3cb54158ad2 nokogiri-1.16.5.gem v1.16.4 / 2024-04-10 Dependencies [CRuby] Vendored zlib in the precompiled native gems is updated to https://zlib.net/ChangeLog.txt;>v1.3.1 from v1.3. Nokogiri is not affected by the minizip CVE patched in this version, but this update may satisfy some security scanners. Related, see https://github.com/sparklemotion/nokogiri/discussions/3168;>this discussion about removing the compression libraries altogether in a future version of Nokogiri. sha256 checksums: bdb1dc4378ebcf3ade8f440c7df68f6d76946a1a96c4823a2b4c53c01a320cd5 nokogiri-1.16.4-aarch64-linux.gem 0c994b9996d5576eddcc3201a94ef2bff6fc3627c4ae4d2708b0ec9b9743ec6a nokogiri-1.16.4-arm-linux.gem 8e86abb64c93c06d3c588042a0e757279e8f1dc88b5210a00be892a9a7a27196 nokogiri-1.16.4-arm64-darwin.gem bf84fa28be4943692bd64772186e0832fb1061f80714ccb93e111e9d72b1cadc nokogiri-1.16.4-java.gem a46808467c1f63a2031e1ca0715cd5336bb4ec759e9c0e2f4c951c1cc30994ae nokogiri-1.16.4-x64-mingw-ucrt.gem 4cdf64bc5e9443ec3e0b595347ecc8affe21968d9ae934c0825d26630ef96468 nokogiri-1.16.4-x64-mingw32.gem d86d21bae47dd9f6f5223055e45d33fae08b0b89aad94cbc0ece4f4274fa7af5 nokogiri-1.16.4-x86-linux.gem d488b872884844686780fda7cf5da44ee884d32faa713a55aeb4736d76718168 nokogiri-1.16.4-x86-mingw32.gem a896e52a56951ffb0e6a9279afbf485d683e357a053d27f4cfcb2a73b0824628 nokogiri-1.16.4-x86_64-darwin.gem 92ff4f09910255fec84b3bc4c4b182e94cada3ed12b9f7a6ea058e0af186fb31 nokogiri-1.16.4-x86_64-linux.gem /tr/table ... (truncated) Changelog Sourced from https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md;>nokogiri's changelog. v1.16.5 Security [CRuby] Vendored libxml2 is updated to address CVE-2024-34459. See https://github.com/sparklemotion/nokogiri/security/advisories/GHSA-r95h-9x8f-r3f7;>GHSA-r95h-9x8f-r3f7 for more information. Dependencies [CRuby] Vendored libxml2 is updated to https://gitlab.gnome.org/GNOME/libxml2/-/releases/v2.12.7;>v2.12.7 from v2.12.6. (https://github.com/flavorjones;>@flavorjones) v1.16.4 / 2024-04-10 Dependencies [CRuby] Vendored zlib in the precompiled native gems is updated to https://zlib.net/ChangeLog.txt;>v1.3.1 from v1.3. Nokogiri is not affected by the minizip CVE patched in this version, but this update may satisfy some security scanners. Related, see https://github.com/sparklemotion/nokogiri/discussions/3168;>this discussion about removing the compression libraries altogether in a future version of Nokogiri. v1.16.3 / 2024-03-15 Dependencies [CRuby] Vendored libxml2 is updated to https://gitlab.gnome.org/GNOME/libxml2/-/releases/v2.12.6;>v2.12.6 from v2.12.5. (https://github.com/flavorjones;>@flavorjones) Changed [CRuby] XML::Reader sets the @encoding instance variable during reading if it is not passed into the initializer. Previously, it would remain nil. The behavior of Reader#encoding has not changed. This works around changes to how libxml2 reports the encoding used in v2.12.6. Commits
[PR] Bump nokogiri from 1.16.2 to 1.16.5 in /content [storm-site]
dependabot[bot] opened a new pull request, #52: URL: https://github.com/apache/storm-site/pull/52 Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.16.2 to 1.16.5. Release notes Sourced from https://github.com/sparklemotion/nokogiri/releases;>nokogiri's releases. v1.16.5 / 2024-05-13 Security [CRuby] Vendored libxml2 is updated to address CVE-2024-34459. See https://github.com/sparklemotion/nokogiri/security/advisories/GHSA-r95h-9x8f-r3f7;>GHSA-r95h-9x8f-r3f7 for more information. Dependencies [CRuby] Vendored libxml2 is updated to https://gitlab.gnome.org/GNOME/libxml2/-/releases/v2.12.7;>v2.12.7 from v2.12.6. (https://github.com/flavorjones;>@flavorjones) sha256 checksums: af0f44fa3e664dfb2aa10de8b551447d720c1e8d1f0aa3f35783dcc43e40a874 nokogiri-1.16.5-aarch64-linux.gem 23dc2357b26409a5c33b7e32a82902f0e9995305420f16d1a03ab3ea1a482fec nokogiri-1.16.5-arm-linux.gem 950d037530edb49f75ad35de0b8038b970a7dda57e2b6326895b0e49fadf6214 nokogiri-1.16.5-arm64-darwin.gem b7aefc94370c62476b8528e8d8abb6160203abd84a1f4eceda8f1aa8974d9989 nokogiri-1.16.5-java.gem ec2167160df8fec3137bf95d574ed80ebc1d002bb3b281546b60b4aa9002466e nokogiri-1.16.5-x64-mingw-ucrt.gem 6984200491fac69974005ecfa2de129d61843d345eafa5d6f58e8b908d1cf107 nokogiri-1.16.5-x64-mingw32.gem abdc389ab1ec6604492da16bd9d06ad746fdb6bd6a1bd274c400d61ffcadb3c4 nokogiri-1.16.5-x86-linux.gem 63d24981345856f2baf7f4089870a62d3042fb8d3021b280fb04fc052532e3c4 nokogiri-1.16.5-x86-mingw32.gem 71b5f54e378c433d13df67c3b71acc4716129da62402d8181f310c4216a63279 nokogiri-1.16.5-x86_64-darwin.gem 0ca238da870066bed2f7837af6f35791bb9b76c4c5638999c46aac44818a6a97 nokogiri-1.16.5-x86_64-linux.gem ec36162c68984fa0a90a5c4ae7ab7759460639e716cc1ce75f34c3cb54158ad2 nokogiri-1.16.5.gem v1.16.4 / 2024-04-10 Dependencies [CRuby] Vendored zlib in the precompiled native gems is updated to https://zlib.net/ChangeLog.txt;>v1.3.1 from v1.3. Nokogiri is not affected by the minizip CVE patched in this version, but this update may satisfy some security scanners. Related, see https://github.com/sparklemotion/nokogiri/discussions/3168;>this discussion about removing the compression libraries altogether in a future version of Nokogiri. sha256 checksums: bdb1dc4378ebcf3ade8f440c7df68f6d76946a1a96c4823a2b4c53c01a320cd5 nokogiri-1.16.4-aarch64-linux.gem 0c994b9996d5576eddcc3201a94ef2bff6fc3627c4ae4d2708b0ec9b9743ec6a nokogiri-1.16.4-arm-linux.gem 8e86abb64c93c06d3c588042a0e757279e8f1dc88b5210a00be892a9a7a27196 nokogiri-1.16.4-arm64-darwin.gem bf84fa28be4943692bd64772186e0832fb1061f80714ccb93e111e9d72b1cadc nokogiri-1.16.4-java.gem a46808467c1f63a2031e1ca0715cd5336bb4ec759e9c0e2f4c951c1cc30994ae nokogiri-1.16.4-x64-mingw-ucrt.gem 4cdf64bc5e9443ec3e0b595347ecc8affe21968d9ae934c0825d26630ef96468 nokogiri-1.16.4-x64-mingw32.gem d86d21bae47dd9f6f5223055e45d33fae08b0b89aad94cbc0ece4f4274fa7af5 nokogiri-1.16.4-x86-linux.gem d488b872884844686780fda7cf5da44ee884d32faa713a55aeb4736d76718168 nokogiri-1.16.4-x86-mingw32.gem a896e52a56951ffb0e6a9279afbf485d683e357a053d27f4cfcb2a73b0824628 nokogiri-1.16.4-x86_64-darwin.gem 92ff4f09910255fec84b3bc4c4b182e94cada3ed12b9f7a6ea058e0af186fb31 nokogiri-1.16.4-x86_64-linux.gem /tr/table ... (truncated) Changelog Sourced from https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md;>nokogiri's changelog. v1.16.5 Security [CRuby] Vendored libxml2 is updated to address CVE-2024-34459. See https://github.com/sparklemotion/nokogiri/security/advisories/GHSA-r95h-9x8f-r3f7;>GHSA-r95h-9x8f-r3f7 for more information. Dependencies [CRuby] Vendored libxml2 is updated to https://gitlab.gnome.org/GNOME/libxml2/-/releases/v2.12.7;>v2.12.7 from v2.12.6. (https://github.com/flavorjones;>@flavorjones) v1.16.4 / 2024-04-10 Dependencies [CRuby] Vendored zlib in the precompiled native gems is updated to https://zlib.net/ChangeLog.txt;>v1.3.1 from v1.3. Nokogiri is not affected by the minizip CVE patched in this version, but this update may satisfy some security scanners. Related, see https://github.com/sparklemotion/nokogiri/discussions/3168;>this discussion about removing the compression libraries altogether in a future version of Nokogiri. v1.16.3 / 2024-03-15 Dependencies [CRuby] Vendored libxml2 is updated to https://gitlab.gnome.org/GNOME/libxml2/-/releases/v2.12.6;>v2.12.6 from v2.12.5. (https://github.com/flavorjones;>@flavorjones) Changed [CRuby] XML::Reader sets the @encoding instance variable during reading if it is not passed into the initializer. Previously, it would remain nil. The behavior of Reader#encoding has not changed. This works around changes to how libxml2 reports the encoding used in v2.12.6. Commits
Re: [PR] STORM-4054 -Add Worker CPU Metric (storm)
jnioche merged PR #3639: URL: https://github.com/apache/storm/pull/3639 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] STORM-4054 -Add Worker CPU Metric (storm)
agresch commented on code in PR #3639:
URL: https://github.com/apache/storm/pull/3639#discussion_r1566440996
##
storm-client/src/jvm/org/apache/storm/metric/SystemBolt.java:
##
@@ -67,12 +68,56 @@ public Long getValue() {
context.registerGauge("newWorkerEvent", new NewWorkerGauge());
+context.registerGauge("workerCpuUsage", new WorkerCpuMetric());
int bucketSize =
ObjectReader.getInt(topoConf.get(Config.TOPOLOGY_BUILTIN_METRICS_BUCKET_SIZE_SECS));
registerMetrics(context, (Map)
topoConf.get(Config.WORKER_METRICS), bucketSize, topoConf);
registerMetrics(context, (Map)
topoConf.get(Config.TOPOLOGY_WORKER_METRICS), bucketSize, topoConf);
}
+private class WorkerCpuMetric implements Gauge {
+private long lastCalculationTimeNsec;
+private long previousCpuTotal;
+private double cpuUsage;
+
+WorkerCpuMetric() {
+lastCalculationTimeNsec = System.nanoTime();
+previousCpuTotal = getTotalCpuUsage();
+cpuUsage = 0.0d;
+}
+
+private long getTotalCpuUsage() {
+long totalCpuNsecs = 0L;
+ThreadMXBean threadMxBean = ManagementFactory.getThreadMXBean();
+for (Long threadId : threadMxBean.getAllThreadIds()) {
+long threadCpu = threadMxBean.getThreadCpuTime(threadId);
+if (threadCpu > 0L) {
+totalCpuNsecs += threadCpu;
+}
+}
+return totalCpuNsecs;
+}
+
+private void updateCalculation() {
+// we could have multiple reporters calling getValue() one right
+// after another, with inaccurate reporting due to the small time
difference.
+long elapsed = System.nanoTime() - this.lastCalculationTimeNsec;
+if (elapsed >= 10L) {
Review Comment:
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] STORM-4054 -Add Worker CPU Metric (storm)
rzo1 commented on code in PR #3639:
URL: https://github.com/apache/storm/pull/3639#discussion_r1566353967
##
storm-client/src/jvm/org/apache/storm/metric/SystemBolt.java:
##
@@ -67,12 +68,56 @@ public Long getValue() {
context.registerGauge("newWorkerEvent", new NewWorkerGauge());
+context.registerGauge("workerCpuUsage", new WorkerCpuMetric());
int bucketSize =
ObjectReader.getInt(topoConf.get(Config.TOPOLOGY_BUILTIN_METRICS_BUCKET_SIZE_SECS));
registerMetrics(context, (Map)
topoConf.get(Config.WORKER_METRICS), bucketSize, topoConf);
registerMetrics(context, (Map)
topoConf.get(Config.TOPOLOGY_WORKER_METRICS), bucketSize, topoConf);
}
+private class WorkerCpuMetric implements Gauge {
+private long lastCalculationTimeNsec;
+private long previousCpuTotal;
+private double cpuUsage;
+
+WorkerCpuMetric() {
+lastCalculationTimeNsec = System.nanoTime();
+previousCpuTotal = getTotalCpuUsage();
+cpuUsage = 0.0d;
+}
+
+private long getTotalCpuUsage() {
+long totalCpuNsecs = 0L;
+ThreadMXBean threadMxBean = ManagementFactory.getThreadMXBean();
+for (Long threadId : threadMxBean.getAllThreadIds()) {
+long threadCpu = threadMxBean.getThreadCpuTime(threadId);
+if (threadCpu > 0L) {
+totalCpuNsecs += threadCpu;
+}
+}
+return totalCpuNsecs;
+}
+
+private void updateCalculation() {
+// we could have multiple reporters calling getValue() one right
+// after another, with inaccurate reporting due to the small time
difference.
+long elapsed = System.nanoTime() - this.lastCalculationTimeNsec;
+if (elapsed >= 10L) {
Review Comment:
Maybe introduce a constant here? I think, that a constant instead of this
magic number would be more readable here. Something like `private static final
long THRESHOLD = TimeUnit.NANOSECONDS.convert(1, TimeUnit.SECONDS);` , wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] STORM-4053 - Include Client API / Runtime for HDFS (storm)
jnioche merged PR #3638: URL: https://github.com/apache/storm/pull/3638 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] STORM-4053 - Include Client API / Runtime for HDFS (storm)
rzo1 opened a new pull request, #3638: URL: https://github.com/apache/storm/pull/3638 Followed advice from Hadoop Devs: https://lists.apache.org/thread/f47s6bxrtslkxbc8s2gybwrxps8vk63x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [STORM-4053] Add Hadoop client API dependency back to storm-hdfs (storm)
jnioche merged PR #3637: URL: https://github.com/apache/storm/pull/3637 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [STORM-4053] Add Hadoop client API dependency back to storm-hdfs (storm)
rzo1 closed pull request #3636: [STORM-4053] Add Hadoop client API dependency back to storm-hdfs URL: https://github.com/apache/storm/pull/3636 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [STORM-4053] Add Hadoop client API dependency back to storm-hdfs (storm)
rzo1 commented on PR #3636: URL: https://github.com/apache/storm/pull/3636#issuecomment-2049694827 superseeded by https://github.com/apache/storm/pull/3637 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [STORM-4053] Add Hadoop client API dependency back to storm-hdfs (storm)
rzo1 opened a new pull request, #3637: URL: https://github.com/apache/storm/pull/3637 Superseeds https://github.com/apache/storm/pull/3636 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [STORM-4053] Add Hadoop client API dependency back to storm-hdfs (storm)
jnioche opened a new pull request, #3636: URL: https://github.com/apache/storm/pull/3636 ## What is the purpose of the change Dependency was removed by mistake See https://github.com/apache/incubator-stormcrawler/pull/1189 ## How was the change tested mvn clean test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] STORM-4052 - Simplify/Remove double delete/lookup in heartbeat cleanup code. (storm)
rzo1 merged PR #3635: URL: https://github.com/apache/storm/pull/3635 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] STORM-4052 - Simplify/Remove double delete/lookup in heartbeat cleanup code. (storm)
rzo1 commented on PR #3635: URL: https://github.com/apache/storm/pull/3635#issuecomment-2040483708 Thx for the contribution, @sammac -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Simplify/Remove double delete/lookup in heartbeat cleanup code. (storm)
sammac opened a new pull request, #3635: URL: https://github.com/apache/storm/pull/3635 ## What is the purpose of the change This changes slightly simplifies the heartbeat cleanup code so it no longer tries to delete the heartbeat files twice. It also removes an unneeded directory listing (and possible race) by truncating the versions list and using it for removal instead of for keeping. Removing the double delete attempt is important because it removes a lookup for now non-existent files. Looking up non existent files, especially highly unique (like timestamped) ones can adversely affect many operating systems as these lookups are cached as negative dentries. https://lwn.net/Articles/814535/ When cleanup runs, it iterates over the heartbeat directory that contains a token and version file for each heartbeat. It calls deleteVersion for each file in the directory which attempts to delete both files associated with the heartbeat. As deleteVersion already deletes both when it first iterates over the token file, the iteration for the version file has nothing to do. Before removing, the deleteVersion code checks for the existence of these now non existent files. On linux (and other OSs) a lookup for a non-existent path will create a negative dentry in the operating system's cache. On some configurations this cache can grow effectively unbounded leading to performance issues. On newer systems this cache is better managed, but this will still dilute an otherwise useful OS cache with useless entries. ## How was the change tested Ran tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] STORM-4051 - Scheduler needs to include acker memory for topology resources (storm)
rzo1 commented on PR #3633: URL: https://github.com/apache/storm/pull/3633#issuecomment-2040326042 Thanks @agresch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] STORM-4051 - Scheduler needs to include acker memory for topology resources (storm)
rzo1 merged PR #3633: URL: https://github.com/apache/storm/pull/3633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Release of Apache Storm 2.6.2 (storm)
rzo1 merged PR #3634: URL: https://github.com/apache/storm/pull/3634 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Release of Apache Storm 2.6.2 (storm)
rzo1 opened a new pull request, #3634: URL: https://github.com/apache/storm/pull/3634 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Scheduler needs to include acker memory for topology resources (storm)
rzo1 commented on PR #3633: URL: https://github.com/apache/storm/pull/3633#issuecomment-2040176179 @agresch guess you need to reset your ASF credentials via https://id.apache.org/reset/enter No blocker for that PR though. I can also create a Jira. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Scheduler needs to include acker memory for topology resources (storm)
agresch commented on PR #3633: URL: https://github.com/apache/storm/pull/3633#issuecomment-2040131535 @rzo1 - Storm JIRA is not taking my password for some reason. I asked to reset it and received this email. I am not sure how to get access to JIRA again based on this message. Any thoughts? This user account is managed in an external User Directory and Jira is not able to update your password. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Scheduler needs to include acker memory for topology resources (storm)
rzo1 commented on code in PR #3633:
URL: https://github.com/apache/storm/pull/3633#discussion_r1552209393
##
storm-server/src/main/java/org/apache/storm/utils/ServerUtils.java:
##
@@ -708,9 +708,24 @@ public static double
getEstimatedTotalHeapMemoryRequiredByTopo(Map topologyConf)
+throws InvalidTopologyException {
+topology = StormCommon.systemTopology(topologyConf, topology);
+Map boltResources =
ResourceUtils.getBoltsResources(topology, topologyConf);
+NormalizedResourceRequest entry =
boltResources.get(Acker.ACKER_COMPONENT_ID);
+Map componentParallelism =
getComponentParallelism(topologyConf, topology);
+int parallelism =
componentParallelism.getOrDefault(Acker.ACKER_COMPONENT_ID, 1);
+return entry.getTotalMemoryMb() * parallelism;
Review Comment:
is `entry`guaranteed to be not `null` since it comes out of a map, so maybe
`getOrDefault(...)` earlier?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Scheduler needs to include acker memory for topology resources (storm)
rzo1 commented on code in PR #3633: URL: https://github.com/apache/storm/pull/3633#discussion_r1552208523 ## storm-server/src/test/java/org/apache/storm/scheduler/blacklist/TestBlacklistScheduler.java: ## @@ -20,22 +20,25 @@ import com.google.common.collect.ImmutableList; import com.google.common.collect.ImmutableMap; import com.google.common.collect.Sets; +import org.apache.logging.log4j.Level; +import org.apache.logging.log4j.LogManager; +import org.apache.logging.log4j.core.config.Configurator; import org.apache.storm.Config; import org.apache.storm.DaemonConfig; -import org.apache.storm.scheduler.Cluster; -import org.apache.storm.scheduler.DefaultScheduler; -import org.apache.storm.scheduler.INimbus; -import org.apache.storm.scheduler.IScheduler; -import org.apache.storm.scheduler.SchedulerAssignmentImpl; -import org.apache.storm.scheduler.SupervisorDetails; -import org.apache.storm.scheduler.Topologies; -import org.apache.storm.scheduler.TopologyDetails; +import org.apache.storm.daemon.StormCommon; +import org.apache.storm.generated.Bolt; +import org.apache.storm.generated.InvalidTopologyException; +import org.apache.storm.generated.SpoutSpec; +import org.apache.storm.generated.StormTopology; +import org.apache.storm.scheduler.*; Review Comment: Can we avoid *-imports here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Scheduler needs to include acker memory for topology resources (storm)
rzo1 commented on PR #3633: URL: https://github.com/apache/storm/pull/3633#issuecomment-2037714316 Great so let's put it for 2.6.3. Will do a review later -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Scheduler needs to include acker memory for topology resources (storm)
agresch commented on PR #3633: URL: https://github.com/apache/storm/pull/3633#issuecomment-2037699322 The bug has existed for ages. I don't think it is critical. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Scheduler needs to include acker memory for topology resources (storm)
rzo1 commented on PR #3633: URL: https://github.com/apache/storm/pull/3633#issuecomment-2037650197 @agresch how critical is this? Would you like to re-roll the current 2.6.2 vote and include it or okay to wait for 2.6.3? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Scheduler needs to include acker memory for topology resources (storm)
agresch opened a new pull request, #3633: URL: https://github.com/apache/storm/pull/3633 ## What is the purpose of the change The scheduler has a bug where acker memory is not considered in the scheduling estimate. The case I found was where a topology should fit on two supervisors, but the cluster has 1 available and 2 blacklisted. The scheduler thinks the topology should fit on one supervisor and fails to schedule, but also fails to release a supervisor from the blacklist, resulting in the topology never getting scheduled. With this fix, the scheduler properly detects the topology will need to be scheduled on two supervisors and releases one from the blacklist and schedules successfully. Switched some scheduling logs from trace to debug to make debugging scheduling issues easier. ## How was the change tested Added a unit test to validate the topology will properly schedule after releasing a supervisor from the blacklist. The fix was also validated on our internal cluster integration tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] STORM-4042 - Bump org.clojure:clojure from 1.10.0 to 1.11.2 (storm)
rzo1 merged PR #3629: URL: https://github.com/apache/storm/pull/3629 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] STORM-4041 - Bump org.apache.zookeeper:zookeeper from 3.9.1 to 3.9.2 (storm)
rzo1 merged PR #3630: URL: https://github.com/apache/storm/pull/3630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] STORM-4040 Update Troubleshooting with workaround for Nimbus startup … (storm)
rzo1 merged PR #3632: URL: https://github.com/apache/storm/pull/3632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] STORM-4040 Update Troubleshooting with workaround for Nimbus startup … (storm)
Scomocouk opened a new pull request, #3632: URL: https://github.com/apache/storm/pull/3632 …issue on older CPUs ## What is the purpose of the change Addresses STORM-4040. This documentation update contains an explaination for Nimbus not startin up due to JVM illegal instruction exception on older CPUs. It also suggests two workarounds to get it working on the same CPU ## How was the change tested Documentation change only. (Verified workaround by swapping RocksdB from v8 in Storm 2.5.0 to v6.x.x) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [STORM-4039] Bump org.apache.commons:commons-configuration2 from 2.9.0 to 2.10.1 (storm)
jnioche merged PR #3631: URL: https://github.com/apache/storm/pull/3631 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.zookeeper:zookeeper from 3.9.1 to 3.9.2 (storm)
rzo1 commented on PR #3630: URL: https://github.com/apache/storm/pull/3630#issuecomment-2000350198 @dependabot rebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.clojure:clojure from 1.10.0 to 1.11.2 (storm)
rzo1 commented on PR #3629: URL: https://github.com/apache/storm/pull/3629#issuecomment-2000349989 @dependabot rebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] STORM-4038 - Cleanup Hadoop/HDFS dependencies (storm)
rzo1 merged PR #3628: URL: https://github.com/apache/storm/pull/3628 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.apache.zookeeper:zookeeper from 3.9.1 to 3.9.2 (storm)
dependabot[bot] opened a new pull request, #3630: URL: https://github.com/apache/storm/pull/3630 Bumps org.apache.zookeeper:zookeeper from 3.9.1 to 3.9.2. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/storm/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.clojure:clojure from 1.10.0 to 1.11.2 (storm)
dependabot[bot] opened a new pull request, #3629: URL: https://github.com/apache/storm/pull/3629 Bumps [org.clojure:clojure](https://github.com/clojure/clojure) from 1.10.0 to 1.11.2. Changelog Sourced from https://github.com/clojure/clojure/blob/master/changes.md;>org.clojure:clojure's changelog. Changes to Clojure in Version 1.11.1 https://clojure.atlassian.net/browse/CLJ-2701;>CLJ-2701 Pin serialVersionUID for Keyword and ArraySeq back to 1.10.3 values to retain binary serialization Changes to Clojure in Version 1.11.0 1 Compatibility 1.1 Security Because XML external entity (XXE) attacks can be used to disclose local files using file schemes or relative paths in the system identifier, clojure.xml/parse now disables external entity processing by default. See: https://owasp.org/www-community/vulnerabilities/XML_External_Entity_(XXE)_Processing">https://owasp.org/www-community/vulnerabilities/XML_External_Entity_(XXE)_Processing This change disables the following SAX parser features: http://apache.org/xml/features/nonvalidating/load-external-dtd http://xml.org/sax/features/external-general-entities http://xml.org/sax/features/external-parameter-entities If you rely on these features, modify your calls to clojure.xml/parse to explicitly supply startparse-sax function as the final argument: (clojure.xml/parse the-string clojure.xml/startparse-sax) This modification also works on prior Clojure versions. http://dev.clojure.org/jira/browse/CLJ-2611;>CLJ-2611 clojure.xml now disables XXE processing by default 1.2 Dependencies Updated dependencies: spec.alpha dependency to 0.3.218 - https://github.com/clojure/spec.alpha/blob/master/CHANGES.md;>changes core.specs.alpha dependency to 0.2.62 - https://github.com/clojure/core.specs.alpha/blob/master/CHANGES.md;>changes 2 Features 2.1 Keyword argument functions take a trailing map Keyword arguments are optional trailing variadic arguments of the form akey aval bkey bval.... In Clojure 1.11, functions taking keyword arguments can now be passed a map instead of or in addition to and following the key/value pairs. When a lone map is passed, it is used for destructuring, else a trailing map is added to the key/value pair map by conj. Also see: https://clojure.org/news/2021/03/18/apis-serving-people-and-programs;>https://clojure.org/news/2021/03/18/apis-serving-people-and-programs https://clojure.atlassian.net/browse/CLJ-2603;>CLJ-2603 Clojure keyword argument functions now also accept a map ... (truncated) Commits https://github.com/clojure/clojure/commit/218054f1f2ddfc69ef4f9d17f916de35e4a4effe;>218054f [maven-release-plugin] prepare release clojure-1.11.2 https://github.com/clojure/clojure/commit/63474dbaf356cbbc38ed9bd9f3a01c5800b8a6c4;>63474db update pom to snapshot version https://github.com/clojure/clojure/commit/5366a0e9e6df8ade159772703da3ac32c352fcdc;>5366a0e add github actions to clojure-1.11-dev branch https://github.com/clojure/clojure/commit/777456f5f485ed42cee386344fbce891c559ec4e;>777456f CLJ-2839 Infinite seq class hashCode() is infinite loop https://github.com/clojure/clojure/commit/ce55092f2b2f5481d25cff6205470c1335760ef6;>ce55092 [maven-release-plugin] prepare release clojure-1.11.1 https://github.com/clojure/clojure/commit/cef38abac0d7139f4d38324290eaf2c40b8924a7;>cef38ab [maven-release-plugin] prepare for next development iteration https://github.com/clojure/clojure/commit/3f1c36d779a43b1951ddaa9cdf6250b1d739621b;>3f1c36d [maven-release-plugin] prepare release clojure-1.11.1-rc1 https://github.com/clojure/clojure/commit/e917dcc003bdd56660d5057407ea7739d2736af2;>e917dcc Update changelog for 1.11.1 https://github.com/clojure/clojure/commit/1da6b07722790e898faa261a816a7a070fd93ac5;>1da6b07 CLJ-2701 Set serialVersionUIDs for Keyword and ArraySeq to retain 1.10.3 values https://github.com/clojure/clojure/commit/48818bd96afc2c8ee8ee76075f7a186289c6517a;>48818bd [maven-release-plugin] prepare for next development iteration Additional commits viewable in https://github.com/clojure/clojure/compare/clojure-1.10.0...clojure-1.11.2;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR:
Re: [PR] STORM-4035 - Remove ConfluentAvroSerializer (storm-hdfs) (storm)
jnioche merged PR #3627: URL: https://github.com/apache/storm/pull/3627 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [STORM-4030] Dependency upgrades (storm)
jnioche merged PR #3626: URL: https://github.com/apache/storm/pull/3626 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [STORM-4030] Dependency upgrades (storm)
rzo1 commented on PR #3626: URL: https://github.com/apache/storm/pull/3626#issuecomment-1959603586 awesome -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [STORM-4030] Dependency upgrades (storm)
jnioche commented on PR #3626: URL: https://github.com/apache/storm/pull/3626#issuecomment-1959602138 > Can we document the updated versions in the related Jira? Otherwise, it might be difficult for consumers to actually see the diff in the next release. done, see https://issues.apache.org/jira/browse/STORM-4030 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [STORM-4030] Dependency upgrades (storm)
jnioche commented on code in PR #3626: URL: https://github.com/apache/storm/pull/3626#discussion_r1499148766 ## pom.xml: ## @@ -97,31 +97,31 @@ 9.4.53.v20231009 0.2.3 1.6.0 -2.0 +2.2 4.5.14 4.4.16 2.0.1 0.9.0 -32.1.3-jre +33.0.0-jre 1.0-rc4 -4.1.100.Final +4.1.107.Final 1.0.2 -2.21.1 -1.7.36 +2.23.0 +2.0.12 3.2.6 4.11.0 3.9.1 1.1.10.4 0.9.94 3.1.3 -3.3.6 +3.4.0 Review Comment: looks like it is still at the RC level https://github.com/apache/hadoop/tags -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [STORM-4030] Dependency upgrades (storm)
jnioche commented on code in PR #3626: URL: https://github.com/apache/storm/pull/3626#discussion_r1499147592 ## pom.xml: ## @@ -97,31 +97,31 @@ 9.4.53.v20231009 0.2.3 1.6.0 -2.0 +2.2 4.5.14 4.4.16 2.0.1 0.9.0 -32.1.3-jre +33.0.0-jre 1.0-rc4 -4.1.100.Final +4.1.107.Final 1.0.2 -2.21.1 -1.7.36 +2.23.0 +2.0.12 3.2.6 4.11.0 3.9.1 1.1.10.4 0.9.94 3.1.3 -3.3.6 +3.4.0 Review Comment: The changes for 3.4.0 are not documented on https://hadoop.apache.org/docs/stable/ Will revert for now, we can work out whether hadoop-auth is needed later -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [STORM-4030] Dependency upgrades (storm)
rzo1 commented on code in PR #3626: URL: https://github.com/apache/storm/pull/3626#discussion_r1499139290 ## pom.xml: ## @@ -97,31 +97,31 @@ 9.4.53.v20231009 0.2.3 1.6.0 -2.0 +2.2 4.5.14 4.4.16 2.0.1 0.9.0 -32.1.3-jre +33.0.0-jre 1.0-rc4 -4.1.100.Final +4.1.107.Final 1.0.2 -2.21.1 -1.7.36 +2.23.0 +2.0.12 Review Comment: slf4j -> slf4j2 might require some changes in the log4j2 bindings used as the way the static logger bindings are loaded has changed in slf4j2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [STORM-4030] Dependency upgrades (storm)
rzo1 commented on code in PR #3626: URL: https://github.com/apache/storm/pull/3626#discussion_r1499138646 ## pom.xml: ## @@ -97,31 +97,31 @@ 9.4.53.v20231009 0.2.3 1.6.0 -2.0 +2.2 4.5.14 4.4.16 2.0.1 0.9.0 -32.1.3-jre +33.0.0-jre 1.0-rc4 -4.1.100.Final +4.1.107.Final 1.0.2 -2.21.1 -1.7.36 +2.23.0 +2.0.12 3.2.6 4.11.0 3.9.1 1.1.10.4 0.9.94 3.1.3 -3.3.6 +3.4.0 Review Comment: Looks like `3.4.0` purged `hadoop-auth` ? Isn't listed in https://mvnrepository.com/artifact/org.apache.hadoop/hadoop-auth anymore, so might be gone and needs migration? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [STORM-4030] Dependency upgrades (storm)
jnioche opened a new pull request, #3626: URL: https://github.com/apache/storm/pull/3626 ## What is the purpose of the change Update dependencies ## How was the change tested `mvn clean test` ran successfully -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] STORM-4029 - Bump org.apache.commons:commons-compress from 1.21 to 1.26.0 (storm)
rzo1 merged PR #3625: URL: https://github.com/apache/storm/pull/3625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.apache.commons:commons-compress from 1.21 to 1.26.0 (storm)
dependabot[bot] opened a new pull request, #3625: URL: https://github.com/apache/storm/pull/3625 Bumps org.apache.commons:commons-compress from 1.21 to 1.26.0. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/storm/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump nokogiri from 1.15.3 to 1.16.2 in /content [storm-site]
rzo1 merged PR #51: URL: https://github.com/apache/storm-site/pull/51 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump nokogiri from 1.15.3 to 1.16.2 [storm-site]
rzo1 merged PR #50: URL: https://github.com/apache/storm-site/pull/50 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump nokogiri from 1.15.3 to 1.16.2 [storm-site]
dependabot[bot] opened a new pull request, #50: URL: https://github.com/apache/storm-site/pull/50 Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.15.3 to 1.16.2. Release notes Sourced from https://github.com/sparklemotion/nokogiri/releases;>nokogiri's releases. v1.16.2 / 2024-02-04 Security [CRuby] Vendored libxml2 is updated to address CVE-2024-25062. See https://github.com/sparklemotion/nokogiri/security/advisories/GHSA-xc9x-jj77-9p9j;>GHSA-xc9x-jj77-9p9j for more information. Dependencies [CRuby] Vendored libxml2 is updated to https://gitlab.gnome.org/GNOME/libxml2/-/releases/v2.12.5;>v2.12.5 from v2.12.4. (https://github.com/flavorjones;>@flavorjones) sha256 checksums: 69ba15d2a2498324489ed63850997f0b8f684260114ea81116d3082f16551d2d nokogiri-1.16.2-aarch64-linux.gem 6a05ce42e3587a40cf8936ece0beaa5d32922254215d2e8cf9ad40588bb42e57 nokogiri-1.16.2-arm-linux.gem c957226c8e36b31be6a3afb8602e2128282bf8b40ea51016c4cd21aa2608d3f8 nokogiri-1.16.2-arm64-darwin.gem 122652bfc338cd8a54a692ac035e245e41fd3b8283299202ca26e7a7d50db310 nokogiri-1.16.2-java.gem 7344b5072ca69fc5bedb61cb01a3b765b93a27aae5a2a845c2ba7200e4345074 nokogiri-1.16.2-x64-mingw-ucrt.gem a2a5e184a424111a0d5b77947986484920ad708009c667f061e8d02035c562dd nokogiri-1.16.2-x64-mingw32.gem 833efddeb51a6c2c9f6356295623c2b2e0d50050d468695c59bd929162953323 nokogiri-1.16.2-x86-linux.gem e67fc0418dffaff9dc8b1dc65f0605282c3fee9488832d0223b620b4319e0b53 nokogiri-1.16.2-x86-mingw32.gem 5def799e5f139f21a79d7cf71172313a7b6fb0e4b2a31ab9bd5d4ad305994539 nokogiri-1.16.2-x86_64-darwin.gem 5b146240ac6ec6c40fd4367623e74442bca45a542bd3282b1d4d18b07b8e5dfe nokogiri-1.16.2-x86_64-linux.gem 68922ee5cde27497d995c46f2821957bae961947644eed2822d173daf7567f9c nokogiri-1.16.2.gem v1.16.1 / 2024-02-03 Dependencies [CRuby] Vendored libxml2 is updated to https://gitlab.gnome.org/GNOME/libxml2/-/releases/v2.12.4;>v2.12.4 from v2.12.3. (https://github.com/flavorjones;>@flavorjones) Fixed [CRuby] XML::Reader defaults the encoding to UTF-8 if it's not specified in either the document or as a method parameter. Previously non-ASCII characters were serialized as NCRs in this case. https://redirect.github.com/sparklemotion/nokogiri/issues/2891;>#2891 (https://github.com/flavorjones;>@flavorjones) [CRuby] Restored support for compilation by GCC versions earlier than 4.6, which was broken in v1.15.0 (540e9aee). https://redirect.github.com/sparklemotion/nokogiri/issues/3090;>#3090 (https://github.com/adfoster-r7;>@adfoster-r7) [CRuby] Patched upstream libxml2 to allow parsing HTML5 in the context of a namespaced node (e.g., foreign content like MathML). [#3112, https://redirect.github.com/sparklemotion/nokogiri/issues/3116;>#3116] (https://github.com/flavorjones;>@flavorjones) [CRuby] Fixed a small memory leak in libgumbo (HTML5 parser) when the maximum tree depth limit is hit. [#3098, https://redirect.github.com/sparklemotion/nokogiri/issues/3100;>#3100] (https://github.com/stevecheckoway;>@stevecheckoway) sha256 checksums: a541f35e5b9798a0c97300f9ee18f4217da2a2945a6d5499e4123b9018f9cafc nokogiri-1.16.1-aarch64-linux.gem 6b82affd195000ab2f9c36cc08744ec2d2fcf6d8da88d59a2db67e83211f7c69 nokogiri-1.16.1-arm-linux.gem /tr/table ... (truncated) Changelog Sourced from https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md;>nokogiri's changelog. v1.16.2 / 2024-02-04 Security [CRuby] Vendored libxml2 is updated to address CVE-2024-25062. See https://github.com/sparklemotion/nokogiri/security/advisories/GHSA-xc9x-jj77-9p9j;>GHSA-xc9x-jj77-9p9j for more information. Dependencies [CRuby] Vendored libxml2 is updated to https://gitlab.gnome.org/GNOME/libxml2/-/releases/v2.12.5;>v2.12.5 from v2.12.4. (https://github.com/flavorjones;>@flavorjones) v1.16.1 / 2024-02-03 Dependencies [CRuby] Vendored libxml2 is updated to https://gitlab.gnome.org/GNOME/libxml2/-/releases/v2.12.4;>v2.12.4 from v2.12.3. (https://github.com/flavorjones;>@flavorjones) Fixed [CRuby] XML::Reader defaults the encoding to UTF-8 if it's not specified in either the document or as a method parameter. Previously non-ASCII characters were serialized as NCRs in this case. https://redirect.github.com/sparklemotion/nokogiri/issues/2891;>#2891 (https://github.com/flavorjones;>@flavorjones) [CRuby] Restored support for compilation by GCC versions earlier than 4.6, which was broken in v1.15.0 (540e9aee). https://redirect.github.com/sparklemotion/nokogiri/issues/3090;>#3090 (https://github.com/adfoster-r7;>@adfoster-r7) [CRuby] Patched upstream libxml2 to allow parsing HTML5 in the context of a namespaced node (e.g., foreign content like MathML). [#3112,
[PR] Bump nokogiri from 1.15.3 to 1.16.2 in /content [storm-site]
dependabot[bot] opened a new pull request, #51: URL: https://github.com/apache/storm-site/pull/51 Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.15.3 to 1.16.2. Release notes Sourced from https://github.com/sparklemotion/nokogiri/releases;>nokogiri's releases. v1.16.2 / 2024-02-04 Security [CRuby] Vendored libxml2 is updated to address CVE-2024-25062. See https://github.com/sparklemotion/nokogiri/security/advisories/GHSA-xc9x-jj77-9p9j;>GHSA-xc9x-jj77-9p9j for more information. Dependencies [CRuby] Vendored libxml2 is updated to https://gitlab.gnome.org/GNOME/libxml2/-/releases/v2.12.5;>v2.12.5 from v2.12.4. (https://github.com/flavorjones;>@flavorjones) sha256 checksums: 69ba15d2a2498324489ed63850997f0b8f684260114ea81116d3082f16551d2d nokogiri-1.16.2-aarch64-linux.gem 6a05ce42e3587a40cf8936ece0beaa5d32922254215d2e8cf9ad40588bb42e57 nokogiri-1.16.2-arm-linux.gem c957226c8e36b31be6a3afb8602e2128282bf8b40ea51016c4cd21aa2608d3f8 nokogiri-1.16.2-arm64-darwin.gem 122652bfc338cd8a54a692ac035e245e41fd3b8283299202ca26e7a7d50db310 nokogiri-1.16.2-java.gem 7344b5072ca69fc5bedb61cb01a3b765b93a27aae5a2a845c2ba7200e4345074 nokogiri-1.16.2-x64-mingw-ucrt.gem a2a5e184a424111a0d5b77947986484920ad708009c667f061e8d02035c562dd nokogiri-1.16.2-x64-mingw32.gem 833efddeb51a6c2c9f6356295623c2b2e0d50050d468695c59bd929162953323 nokogiri-1.16.2-x86-linux.gem e67fc0418dffaff9dc8b1dc65f0605282c3fee9488832d0223b620b4319e0b53 nokogiri-1.16.2-x86-mingw32.gem 5def799e5f139f21a79d7cf71172313a7b6fb0e4b2a31ab9bd5d4ad305994539 nokogiri-1.16.2-x86_64-darwin.gem 5b146240ac6ec6c40fd4367623e74442bca45a542bd3282b1d4d18b07b8e5dfe nokogiri-1.16.2-x86_64-linux.gem 68922ee5cde27497d995c46f2821957bae961947644eed2822d173daf7567f9c nokogiri-1.16.2.gem v1.16.1 / 2024-02-03 Dependencies [CRuby] Vendored libxml2 is updated to https://gitlab.gnome.org/GNOME/libxml2/-/releases/v2.12.4;>v2.12.4 from v2.12.3. (https://github.com/flavorjones;>@flavorjones) Fixed [CRuby] XML::Reader defaults the encoding to UTF-8 if it's not specified in either the document or as a method parameter. Previously non-ASCII characters were serialized as NCRs in this case. https://redirect.github.com/sparklemotion/nokogiri/issues/2891;>#2891 (https://github.com/flavorjones;>@flavorjones) [CRuby] Restored support for compilation by GCC versions earlier than 4.6, which was broken in v1.15.0 (540e9aee). https://redirect.github.com/sparklemotion/nokogiri/issues/3090;>#3090 (https://github.com/adfoster-r7;>@adfoster-r7) [CRuby] Patched upstream libxml2 to allow parsing HTML5 in the context of a namespaced node (e.g., foreign content like MathML). [#3112, https://redirect.github.com/sparklemotion/nokogiri/issues/3116;>#3116] (https://github.com/flavorjones;>@flavorjones) [CRuby] Fixed a small memory leak in libgumbo (HTML5 parser) when the maximum tree depth limit is hit. [#3098, https://redirect.github.com/sparklemotion/nokogiri/issues/3100;>#3100] (https://github.com/stevecheckoway;>@stevecheckoway) sha256 checksums: a541f35e5b9798a0c97300f9ee18f4217da2a2945a6d5499e4123b9018f9cafc nokogiri-1.16.1-aarch64-linux.gem 6b82affd195000ab2f9c36cc08744ec2d2fcf6d8da88d59a2db67e83211f7c69 nokogiri-1.16.1-arm-linux.gem /tr/table ... (truncated) Changelog Sourced from https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md;>nokogiri's changelog. v1.16.2 / 2024-02-04 Security [CRuby] Vendored libxml2 is updated to address CVE-2024-25062. See https://github.com/sparklemotion/nokogiri/security/advisories/GHSA-xc9x-jj77-9p9j;>GHSA-xc9x-jj77-9p9j for more information. Dependencies [CRuby] Vendored libxml2 is updated to https://gitlab.gnome.org/GNOME/libxml2/-/releases/v2.12.5;>v2.12.5 from v2.12.4. (https://github.com/flavorjones;>@flavorjones) v1.16.1 / 2024-02-03 Dependencies [CRuby] Vendored libxml2 is updated to https://gitlab.gnome.org/GNOME/libxml2/-/releases/v2.12.4;>v2.12.4 from v2.12.3. (https://github.com/flavorjones;>@flavorjones) Fixed [CRuby] XML::Reader defaults the encoding to UTF-8 if it's not specified in either the document or as a method parameter. Previously non-ASCII characters were serialized as NCRs in this case. https://redirect.github.com/sparklemotion/nokogiri/issues/2891;>#2891 (https://github.com/flavorjones;>@flavorjones) [CRuby] Restored support for compilation by GCC versions earlier than 4.6, which was broken in v1.15.0 (540e9aee). https://redirect.github.com/sparklemotion/nokogiri/issues/3090;>#3090 (https://github.com/adfoster-r7;>@adfoster-r7) [CRuby] Patched upstream libxml2 to allow parsing HTML5 in the context of a namespaced node (e.g., foreign content like MathML). [#3112,
Re: [PR] Bump activesupport from 7.0.6 to 7.0.7.2 [storm-site]
rzo1 merged PR #47: URL: https://github.com/apache/storm-site/pull/47 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump activesupport from 7.0.6 to 7.0.7.2 in /content [storm-site]
rzo1 merged PR #48: URL: https://github.com/apache/storm-site/pull/48 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] STORM-4028 - Curator 5.6.0 (storm)
rzo1 merged PR #3624: URL: https://github.com/apache/storm/pull/3624 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] STORM-4027 - Kryo 5.6.0 (storm)
rzo1 merged PR #3623: URL: https://github.com/apache/storm/pull/3623 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] STORM-4026 - Thrift 0.19.0 (storm)
rzo1 merged PR #3622: URL: https://github.com/apache/storm/pull/3622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] STORM-4028 - Curator 5.6.0 (storm)
rzo1 opened a new pull request, #3624: URL: https://github.com/apache/storm/pull/3624 ## What is the purpose of the change [*(Explain why we should have this change)*](https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12314425=12353185) ## How was the change tested - CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] STORM-4027 - Kryo 5.6.0 (storm)
rzo1 opened a new pull request, #3623: URL: https://github.com/apache/storm/pull/3623 ## What is the purpose of the change - https://github.com/EsotericSoftware/kryo/releases ## How was the change tested - CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] STORM-4026 - Thrift 0.19.0 (storm)
rzo1 commented on PR #3622: URL: https://github.com/apache/storm/pull/3622#issuecomment-1910505380 Yeah, need to fix that license madness ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] STORM-4026 - Thrift 0.19.0 (storm)
rzo1 opened a new pull request, #3622: URL: https://github.com/apache/storm/pull/3622 ## What is the purpose of the change - Upgrades to Thrift 0.19.0 - Regenerate thrift code ## How was the change tested - CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [STORM-3713] fix race-condition by applying submitLock to leaderCallBack (storm)
jnioche commented on PR #3353: URL: https://github.com/apache/storm/pull/3353#issuecomment-1910015477 thanks @RuiLi8080, sorry it took so long but the project is now a bit more active thanks largely to @rzo1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [STORM-3713] fix race-condition by applying submitLock to leaderCallBack (storm)
jnioche merged PR #3353: URL: https://github.com/apache/storm/pull/3353 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix flaky tests testTopologyIsolation and testDefaultResourceAwareStrategySharedMemory (storm)
rzo1 commented on PR #3603: URL: https://github.com/apache/storm/pull/3603#issuecomment-1909968017 Got no response of the opener, no flaky tests observed in the last months / weeks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix flaky tests testTopologyIsolation and testDefaultResourceAwareStrategySharedMemory (storm)
rzo1 closed pull request #3603: fix flaky tests testTopologyIsolation and testDefaultResourceAwareStrategySharedMemory URL: https://github.com/apache/storm/pull/3603 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] STORM-4025 - ClassCastException when changing log level in Storm UI (storm)
rzo1 merged PR #3621: URL: https://github.com/apache/storm/pull/3621 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [STORM-4023] Background periodic Kerberos re-login should use same JAAS configuration as initial login (storm)
rzo1 merged PR #3619: URL: https://github.com/apache/storm/pull/3619 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] STORM-4024 Fix Bolt Input Stats are blank if topology.acker.executors… (storm)
rzo1 merged PR #3620: URL: https://github.com/apache/storm/pull/3620 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] STORM-4024 Fix Bolt Input Stats are blank if topology.acker.executors… (storm)
Scomocouk commented on PR #3620: URL: https://github.com/apache/storm/pull/3620#issuecomment-1908670566 **Additional Explanation** The 'id2procAvg' parameter of aggBoltStreamsLatAndCount method will always be null if topology.acker.executors is 0. In this scenario, the series of null checks at line 153 prevents the (non-null) id2execAv and id2numExec from being used to report Executed and Execute_latency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.springframework:spring-core from 5.3.27 to 6.0.15 in /examples/storm-jms-examples (storm)
dependabot[bot] commented on PR #3618: URL: https://github.com/apache/storm/pull/3618#issuecomment-1908599008 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.springframework:spring-core from 5.3.27 to 6.0.15 in /examples/storm-jms-examples (storm)
rzo1 closed pull request #3618: Bump org.springframework:spring-core from 5.3.27 to 6.0.15 in /examples/storm-jms-examples URL: https://github.com/apache/storm/pull/3618 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [STORM-4023] Background periodic Kerberos re-login should use same JAAS configuration as initial login (storm)
noslowerdna opened a new pull request, #3619: URL: https://github.com/apache/storm/pull/3619 ## What is the purpose of the change This change is needed to avoid having to specify `java.security.auth.login.config` as both a Storm configuration property (for initial login) and a Java system property (for background periodic re-login). ## How was the change tested Unit tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.springframework:spring-core from 5.3.27 to 6.0.15 in /examples/storm-jms-examples (storm)
dependabot[bot] opened a new pull request, #3618: URL: https://github.com/apache/storm/pull/3618 Bumps [org.springframework:spring-core](https://github.com/spring-projects/spring-framework) from 5.3.27 to 6.0.15. Release notes Sourced from https://github.com/spring-projects/spring-framework/releases;>org.springframework:spring-core's releases. v6.0.15 :star: New Features Skip buffer allocation in StreamUtils.copy(String) https://redirect.github.com/spring-projects/spring-framework/issues/31631;>#31631 :lady_beetle: Bug Fixes replaced-method / unnecessarily requires explicit arg-type since 6.0 https://redirect.github.com/spring-projects/spring-framework/issues/31828;>#31828 MergedAnnotations finds duplicate annotations on method in multi-level interface hierarchy https://redirect.github.com/spring-projects/spring-framework/issues/31824;>#31824 Fix condition for Too many elements in MimeTypeUtils.sortBySpecificity() https://redirect.github.com/spring-projects/spring-framework/issues/31773;>#31773 Spring unable to decode aggregated JSON content https://redirect.github.com/spring-projects/spring-framework/issues/31772;>#31772 Multipart messages with empty parts are not correctly parsed in WebFlux https://redirect.github.com/spring-projects/spring-framework/issues/31766;>#31766 PathEditor cannot handle absolute Windows paths with forward slashes https://redirect.github.com/spring-projects/spring-framework/issues/31727;>#31727 TraceId is missing in WebFlux controller handlers https://redirect.github.com/spring-projects/spring-framework/issues/31716;>#31716 Wrong observation status tag when a Not Found in a webflux application https://redirect.github.com/spring-projects/spring-framework/issues/31715;>#31715 Fail to register MBean with bean name containing invalid character https://redirect.github.com/spring-projects/spring-framework/issues/31708;>#31708 Include Hibernate's Query.scroll() in SharedEntityManagerCreator's queryTerminatingMethods set https://redirect.github.com/spring-projects/spring-framework/issues/31683;>#31683 TypeDescriptor does not check generics in equals method (for ConversionService caching) https://redirect.github.com/spring-projects/spring-framework/issues/31673;>#31673 SpEL expression on a reloadable type can no longer be resolved https://redirect.github.com/spring-projects/spring-framework/issues/31670;>#31670 Slow SpEL performance due to method sorting in ReflectiveMethodResolver https://redirect.github.com/spring-projects/spring-framework/issues/31664;>#31664 Jackson encoder releases resources in wrong order https://redirect.github.com/spring-projects/spring-framework/issues/31656;>#31656 Current Observation.Context missing from WebClient request https://redirect.github.com/spring-projects/spring-framework/issues/31646;>#31646 WebSocketMessageBrokerStats has null stats for stompSubProtocolHandler since 5.3.2 https://redirect.github.com/spring-projects/spring-framework/issues/31641;>#31641 jee:local-slsb no longer works with a business-interface attribute https://redirect.github.com/spring-projects/spring-framework/issues/31630;>#31630 GeneratedFiles#addSourceFile should not allow to add a source in the default package https://redirect.github.com/spring-projects/spring-framework/issues/31629;>#31629 PathResourceResolver.getResource() does not log warning if Resource#getURL() throws exception https://redirect.github.com/spring-projects/spring-framework/issues/31624;>#31624 :notebook_with_decorative_cover: Documentation Document explicit @ModelAttribute is required for reflection hints inference https://redirect.github.com/spring-projects/spring-framework/issues/31767;>#31767 Documentation needs to be updated with instructions for STOMP Client https://redirect.github.com/spring-projects/spring-framework/issues/31678;>#31678 Improve STOMP WebSocket documentation for input message buffer size https://redirect.github.com/spring-projects/spring-framework/issues/31654;>#31654 :hammer: Dependency Upgrades Upgrade to Reactor 2022.0.14 https://redirect.github.com/spring-projects/spring-framework/issues/31815;>#31815 v6.0.14 :star: New Features Provide caching for HandlerMappingIntrospector lookups https://redirect.github.com/spring-projects/spring-framework/issues/31588;>#31588 Log4jLog needs to re-resolve ExtendedLogger on deserialization (for compatibility with Log4J 2.21) https://redirect.github.com/spring-projects/spring-framework/issues/31582;>#31582 Optimize StandardTypeLocator for hotspot when the same classes are resolved https://redirect.github.com/spring-projects/spring-framework/issues/31579;>#31579 Add duplicate key exception error code for SAP HANA database https://redirect.github.com/spring-projects/spring-framework/pull/31554;>#31554 Do not delegate TRACE to HttpServlet on ERROR dispatch
Re: [PR] [STORM-4022] Do not log Exception when getting heartbeat timeout for dead topologies (storm)
jnioche merged PR #3617: URL: https://github.com/apache/storm/pull/3617 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [STORM-4022] Do not log Exception when getting heartbeat timeout for dead topologies (storm)
bipinprasad opened a new pull request, #3617: URL: https://github.com/apache/storm/pull/3617 ## What is the purpose of the change *In AWS EKS environment, the nimbus log seems to be flooded with heartbeat time exception messages for dead topologies* ## How was the change tested *Test run as part of this Pull Request* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] STORM-4018 - Wrong order of the params in Storm API resource (storm)
jnioche merged PR #3616: URL: https://github.com/apache/storm/pull/3616 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] STORM-4017 Fix for isAnyWindowsProcessAlive with multiple pids (storm)
jnioche commented on PR #3615: URL: https://github.com/apache/storm/pull/3615#issuecomment-1892317878 Thanks @Scomocouk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] STORM-4017 Fix for isAnyWindowsProcessAlive with multiple pids (storm)
jnioche merged PR #3615: URL: https://github.com/apache/storm/pull/3615 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] STORM-4017 Fix for isAnyWindowsProcessAlive with multiple pids (storm)
Scomocouk commented on PR #3615: URL: https://github.com/apache/storm/pull/3615#issuecomment-1881677336 As suggested from my previous pull request (https://github.com/apache/storm/pull/3614), I have resubmitted this for merging into master instead of 2.4.x-branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] STORM-4017 Fix for isAnyWindowsProcessAlive with multiple pids (storm)
Scomocouk opened a new pull request, #3615: URL: https://github.com/apache/storm/pull/3615 ## What is the purpose of the change Fixes STORM-4017 I raised recently so that isAnyWindowsProcessAlive works correctly in Windows. What prompted this was that we are evaluating Storm 2.5.0 under Windows and noticed that when workers are restarted the child processes are left running. We noticed logs reporting that "None of the processes , , are alive" when they were in fact still running. Further investigation showed why this was happening, hence raised STORM-4017 How was the change tested ## How was the change tested Existing unit test 'testIsAnyProcessAlive' in ServerUtilsTest.java did not work under Windows but now does with this fix. We have confirmed that we only now see the "None of the processes ... are alive" when the processes are genuinely not running See attached unit test run before and after fix   -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] STORM-4017 Fix for isAnyWindowsProcessAlive with multiple pids (storm)
Scomocouk closed pull request #3614: STORM-4017 Fix for isAnyWindowsProcessAlive with multiple pids URL: https://github.com/apache/storm/pull/3614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] STORM-4017 Fix for isAnyWindowsProcessAlive with multiple pids (storm)
rzo1 commented on PR #3614: URL: https://github.com/apache/storm/pull/3614#issuecomment-1881242017 Therefore, I suggest to target `main` with the change and post a related mail on dev@ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] STORM-4017 Fix for isAnyWindowsProcessAlive with multiple pids (storm)
rzo1 commented on PR #3614: URL: https://github.com/apache/storm/pull/3614#issuecomment-1881216003 Thanks for the PR. I definitley see it in the next release of Storm. However, given the limited amount of volunteers working on Storm (it was discussed to move it to the attic a couple of months ago due to limited resources / volunteers willing to contribute), there might be no intention / capacity to acutally release a 2.5.x version of Storm. You are free to bring up this topic on the dev@ mailing list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] STORM-4017 Fix for isAnyWindowsProcessAlive with multiple pids (storm)
Scomocouk commented on PR #3614: URL: https://github.com/apache/storm/pull/3614#issuecomment-1881120469 This request is to merge to 2.4.x-branch. However, we are actaully working with 2.5.0 but notice there is no corresponding 2.5.x-branch to merge in to. Can this be added? (We are working on 2.5.0 as this is the latest version to work with Java8, which we are currently restricted to) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] STORM-4017 Fix for isAnyWindowsProcessAlive with multiple pids (storm)
Scomocouk opened a new pull request, #3614: URL: https://github.com/apache/storm/pull/3614 ## What is the purpose of the change Fixes STORM-4017 I raised recently so that isAnyWindowsProcessAlive works correctly in Windows. What prompted this was that we are evaluating Storm 2.5.0 under Windows and noticed that when workers are restarted the child processes are left running. We noticed logs reporting that "None of the processes , , are alive" when they were in fact still running. Further investigation showed why this was happening, hence raised STORM-4017 ## How was the change tested Existing unit test 'testIsAnyProcessAlive' in ServerUtilsTest.java did not work under Windows but now does with this fix. We have confirmed that we only now see the "None of the processes ... are alive" when the processes are genuinely not running See attached unit test run before and after fix   -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [STORM-4015][DOCS] Update the minimum Java version required to Java 11 (storm)
rzo1 commented on PR #3613: URL: https://github.com/apache/storm/pull/3613#issuecomment-1877352598 Website is updated. Couldn't find you in the ASF Jira. Feel free to leave a comment in https://issues.apache.org/jira/browse/STORM-4015 and I will assign it to you later. Thanks for the doc contribution anyway! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [STORM-4015][DOCS] Update the minimum Java version required to Java 11 (storm)
engrravijain commented on PR #3613: URL: https://github.com/apache/storm/pull/3613#issuecomment-1877183419 Welcome @rzo1! :) Yes, I have a jira account with username **engrravijain** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [STORM-4015][DOCS] Update the minimum Java version required to Java 11 (storm)
rzo1 commented on PR #3613: URL: https://github.com/apache/storm/pull/3613#issuecomment-1877179116 Thanks @engrravijain - will re-generate the website + close the Jira afterwards. If you have a Jira account, plz let me know, so I can assign the issue accordingly ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [STORM-4015][DOCS] Update the minimum Java version required to Java 11 (storm)
jnioche merged PR #3613: URL: https://github.com/apache/storm/pull/3613 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [STORM-4015][DOCS] Update the minimum Java version required to Java 11 (storm)
engrravijain commented on PR #3613: URL: https://github.com/apache/storm/pull/3613#issuecomment-1877111485 @rzo1 please review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [STORM-4015][DOCS] Update the minimum Java version required to Java 11 (storm)
engrravijain opened a new pull request, #3613: URL: https://github.com/apache/storm/pull/3613 ## What is the purpose of the change Update the documentation to reflect the minimum version of Java required. *(Explain why we should have this change)* Updated documentation ## How was the change tested Checked the Java version against which storm is being built in github actions. *(Explain what tests did you do to verify the code change)* Not Applicable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [STORM-4016] KafkaSpout: moving to poll(Duration) due to deprecation of poll(long) (storm)
rzo1 commented on PR #3612: URL: https://github.com/apache/storm/pull/3612#issuecomment-1866000242 @reiabreu Great. Don't forget to assign the jira to you + set the fix version and close it :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [STORM-4016] KafkaSpout: moving to poll(Duration) due to deprecation of poll(long) (storm)
reiabreu merged PR #3612: URL: https://github.com/apache/storm/pull/3612 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [STORM-4016] KafkaSpout: moving to poll(Duration) due to deprecation of poll(long) (storm)
reiabreu commented on PR #3612: URL: https://github.com/apache/storm/pull/3612#issuecomment-1865996752 @rzo1 Cheers for that, the linking process was incomplete, I have solved that now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [STORM-4016] KafkaSpout: moving to poll(Duration) due to deprecation of poll(long) (storm)
rzo1 commented on PR #3612: URL: https://github.com/apache/storm/pull/3612#issuecomment-1865965588 @reiabreu You just need to link your ASF ID with GitHub via https://gitbox.apache.org/boxer/ (than it will automatically provide your GitHub account with the required permissions) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [STORM-4016] KafkaSpout: moving to poll(Duration) due to deprecation of poll(long) (storm)
reiabreu commented on PR #3612: URL: https://github.com/apache/storm/pull/3612#issuecomment-1865962703 @rzo1 I'm afraid I don't have write permissions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
