[GitHub] [storm] Ethanlm commented on pull request #3281: STORM-3647: Adds OFF HEAP to worker child opts

2020-06-04 Thread GitBox 


Ethanlm commented on pull request #3281:
URL: https://github.com/apache/storm/pull/3281#issuecomment-639118251


   Yes but if worker.childopts doesn't have `%OFF-HEAP-MEM%`, this setting is 
not really enforced, right? 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [storm] Ethanlm commented on pull request #3281: STORM-3647: Adds OFF HEAP to worker child opts

2020-06-04 Thread GitBox 


Ethanlm commented on pull request #3281:
URL: https://github.com/apache/storm/pull/3281#issuecomment-639111921


   How can a topology use off heap memory? Setting %OFF-HEAP-MEM% doesn't seem 
enough?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [storm] Ethanlm commented on pull request #3281: STORM-3647: Adds OFF HEAP to worker child opts

2020-06-04 Thread GitBox 


Ethanlm commented on pull request #3281:
URL: https://github.com/apache/storm/pull/3281#issuecomment-639090241


   please update commit message to also include the jira id



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org