[GitHub] storm issue #1665: STORM-2074: fix storm-kafka-monitor NPE bug
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1665 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1665: STORM-2074: fix storm-kafka-monitor NPE bug
Github user priyank5485 commented on the issue: https://github.com/apache/storm/pull/1665 +1 (non-binding) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1665: STORM-2074: fix storm-kafka-monitor NPE bug
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1665 @priyank5485 Updated. Can you take a look again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1665: STORM-2074: fix storm-kafka-monitor NPE bug
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1665 Oh, I missed it. Will update. Thanks @priyank5485 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1665: STORM-2074: fix storm-kafka-monitor NPE bug
Github user priyank5485 commented on the issue: https://github.com/apache/storm/pull/1665 @vesense Not sure if you saw my comment about exiting with a code of 1 in getOldConsumerOffsetsFromZk. Can you check that comment and address it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1665: STORM-2074: fix storm-kafka-monitor NPE bug
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1665 @HeartSaVioR OK, have a good time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1665: STORM-2074: fix storm-kafka-monitor NPE bug
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1665 I'd like to wait for @priyank5485 and @abellina to finish reviewing. I'm now reviewing and testing Supervisor V2 and it could take some times. FYI: I'm on vacation on next week, and will be traveling in several days (not too long but not available for that moment). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1665: STORM-2074: fix storm-kafka-monitor NPE bug
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1665 @HeartSaVioR Can we merge this in? and, it's very easy to cherry-pick to 1.x-branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1665: STORM-2074: fix storm-kafka-monitor NPE bug
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1665 Thanks @priyank5485 @abellina I think I have addressed your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #1665: STORM-2074: fix storm-kafka-monitor NPE bug
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1665 this should be merged into 1.x-branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
