[GitHub] storm issue #2042: STORM-2453 Move non-connectors into the top directory

2017-04-05 Thread harshach
Github user harshach commented on the issue:

https://github.com/apache/storm/pull/2042
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm issue #2042: STORM-2453 Move non-connectors into the top directory

2017-04-04 Thread vesense
Github user vesense commented on the issue:

https://github.com/apache/storm/pull/2042
  
LGTM +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm issue #2042: STORM-2453 Move non-connectors into the top directory

2017-04-04 Thread revans2
Github user revans2 commented on the issue:

https://github.com/apache/storm/pull/2042
  
Still +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm issue #2042: STORM-2453 Move non-connectors into the top directory

2017-04-04 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/2042
  
@revans2 Sorry IntelliJ automatically creates that file. Just removed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm issue #2042: STORM-2453 Move non-connectors into the top directory

2017-04-04 Thread revans2
Github user revans2 commented on the issue:

https://github.com/apache/storm/pull/2042
  
Oops I missed that the build failed because of 

```
[WARNING] Files with unapproved licenses:

  flux/flux-wrappers/src/main/resources/resources/__init__.py
```

We should fix this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---