[GitHub] storm issue #2249: STORM-2648/STORM-2357: Add storm-kafka-client support for...
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2249 Thanks for reviews. Opened the 1.x version here https://github.com/apache/storm/pull/2353. ---
[GitHub] storm issue #2249: STORM-2648/STORM-2357: Add storm-kafka-client support for...
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2249 Merged via https://github.com/apache/storm/commit/48f6969027e7b02a5b9220577189d3911aa2226d @srdo Sorry I forgot to add auto close message while squashing commits. Could you close this? And please craft the patch for 1.x branch since it doesn't looks like a clean cherry-pick. Thanks in advance! ---
[GitHub] storm issue #2249: STORM-2648/STORM-2357: Add storm-kafka-client support for...
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2249 This PR has been waiting for about 2 months, and once it gets +1 and no -1, it can be merged. I'm +1 and will just merge. @hmcl Please vote -1 later and rollback the merge if you have concern about the patch and would want to vote -1. ---
[GitHub] storm issue #2249: STORM-2648/STORM-2357: Add storm-kafka-client support for...
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2249 @hmcl Are you still reviewing this? It's fine if you don't have time to look at this, but please say so. I'd like to not keep holding this up. ---
[GitHub] storm issue #2249: STORM-2648/STORM-2357: Add storm-kafka-client support for...
Github user hmcl commented on the issue: https://github.com/apache/storm/pull/2249 @srdo apologies for the delay. I will finish today. ---
[GitHub] storm issue #2249: STORM-2648/STORM-2357: Add storm-kafka-client support for...
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2249 Thanks :) ---
[GitHub] storm issue #2249: STORM-2648/STORM-2357: Add storm-kafka-client support for...
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2249 @hmcl I don't mean to try to rush you, but please let me know if you're still reviewing. If not I'll probably merge in the next few days. ---
[GitHub] storm issue #2249: STORM-2648/STORM-2357: Add storm-kafka-client support for...
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2249 Still +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2249: STORM-2648/STORM-2357: Add storm-kafka-client support for...
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2249 @hmcl Are you reviewing this, or are you satisfied with it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm issue #2249: STORM-2648/STORM-2357: Add storm-kafka-client support for...
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2249 Added some tests and updated the docs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
