[GitHub] storm issue #2519: STORM-2903: Fix possible NullPointerException in Abstract...
Github user satishd commented on the issue: https://github.com/apache/storm/pull/2519 >@satishd @HeartSaVioR Unfortunately token.decodeIdentified() returns null value in Hive related Tokens. So previous code is broken for Hive. If we want this log, we need to add null check before printing token.decodeIdentified()..getUser() @omkreddy No harm in having null check and have good debug information in the logs. >Do we want to revert the commit, or craft a follow-up patch? @HeartSaVioR Better to have a followup patch. ---
[GitHub] storm issue #2519: STORM-2903: Fix possible NullPointerException in Abstract...
Github user omkreddy commented on the issue: https://github.com/apache/storm/pull/2519 @satishd @HeartSaVioR Unfortunately token.decodeIdentified() return null value in Hive related Tokens. So if we want this log, we need to add null check before printing token.decodeIdentified()..getUser() ---
[GitHub] storm issue #2519: STORM-2903: Fix possible NullPointerException in Abstract...
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2519 @omkreddy @arunmahadevan @satishd My bad I forgot what I was doing. Yes that was why I got user information from `token.decodeIdentified().getUser()`. Do we want to revert the commit, or craft a follow-up patch? ---
[GitHub] storm issue #2519: STORM-2903: Fix possible NullPointerException in Abstract...
Github user satishd commented on the issue: https://github.com/apache/storm/pull/2519 @arunmahadevan @omkreddy I have looked into that code before putting my initial comment. Not all `TokenIdentifier` implementations have implemented `toString()` with user information. `org.apache.hadoop.hbase.security.token.AuthenticationTokenIdentifier` does not implement toString() and the logging statement was added while fixing STORM-2555 with the change [here](https://github.com/apache/storm/commit/2544b6d99f163cd2552485a629651f8e97fff8ee#diff-a81e93604bd2f50eae45a7a3bee59d88) which is related to HBase delegation tokens. ---
[GitHub] storm issue #2519: STORM-2903: Fix possible NullPointerException in Abstract...
Github user arunmahadevan commented on the issue: https://github.com/apache/storm/pull/2519 +1 ---
[GitHub] storm issue #2519: STORM-2903: Fix possible NullPointerException in Abstract...
Github user omkreddy commented on the issue: https://github.com/apache/storm/pull/2519 @arunmahadevan thanks for the review. yes, printing token should be sufficient. reverting PR to first version ---
