[GitHub] storm issue #2907: STORM-2990, STORM-3279: Fix issue where Kafka Trident spo...

2018-12-14 Thread srdo 
Github user srdo commented on the issue:

https://github.com/apache/storm/pull/2907
  
Thanks for the reviews, merged to master.


---

[GitHub] storm issue #2907: STORM-2990, STORM-3279: Fix issue where Kafka Trident spo...

2018-12-14 Thread revans2 
Github user revans2 commented on the issue:

https://github.com/apache/storm/pull/2907
  
+1


---

[GitHub] storm issue #2907: STORM-2990, STORM-3279: Fix issue where Kafka Trident spo...

2018-11-29 Thread srdo 
Github user srdo commented on the issue:

https://github.com/apache/storm/pull/2907
  
Rebased to fix conflicts and squashed to one commit.


---

[GitHub] storm issue #2907: STORM-2990, STORM-3279: Fix issue where Kafka Trident spo...

2018-11-16 Thread srdo 
Github user srdo commented on the issue:

https://github.com/apache/storm/pull/2907
  
Added a check to `reEmitPartitionBatch`. Let me know if it looks 
reasonable, and I'll squash.


---

[GitHub] storm issue #2907: STORM-2990, STORM-3279: Fix issue where Kafka Trident spo...

2018-11-16 Thread srdo 
Github user srdo commented on the issue:

https://github.com/apache/storm/pull/2907
  
Regarding looping offsets, I don't believe Kafka really does anything 
special to handle offset value overflow (quick google turned up 
http://mail-archives.apache.org/mod_mbox/kafka-users/201510.mbox/%3CCAE+KEuHikS71hEam=imt4K2OOirYf5hed=f3yhu3eym3uow...@mail.gmail.com%3E
 and 
http://mail-archives.apache.org/mod_mbox/kafka-users/20.mbox/%3cCAFbh0Q3wXeivW9G+xre5eN8-SLVprdNLWyKmd+CcW6n=A=z...@mail.gmail.com%3e).

I think the assumption is that a long is large enough that wrapping around 
realistically won't happen.


---

[GitHub] storm issue #2907: STORM-2990, STORM-3279: Fix issue where Kafka Trident spo...

2018-11-14 Thread srdo 
Github user srdo commented on the issue:

https://github.com/apache/storm/pull/2907
  
Test failure looks unrelated.


---