[GitHub] storm issue #459: [STORM-2999] Add generics to static type of method paramet...

2018-03-21 Thread d2r 
Github user d2r commented on the issue:

https://github.com/apache/storm/pull/459
  
New changes are to remove warning suppression attributes and look good to 
me. +1 again.

Thanks @krichter722 for the changes and for your patience. I have merged 
this to master.


---

[GitHub] storm issue #459: [STORM-2999] Add generics to static type of method paramet...

2018-03-19 Thread roshannaik 
Github user roshannaik commented on the issue:

https://github.com/apache/storm/pull/459
  
@krichter722  thanks for this! 


---

[GitHub] storm issue #459: [STORM-2999] Add generics to static type of method paramet...

2018-03-19 Thread knusbaum 
Github user knusbaum commented on the issue:

https://github.com/apache/storm/pull/459
  
+1


---

[GitHub] storm issue #459: [STORM-2999] Add generics to static type of method paramet...

2018-03-19 Thread krichter722 
Github user krichter722 commented on the issue:

https://github.com/apache/storm/pull/459
  
> we can hold off if you want to clean up these unnecessary annotations.

Done.


---

[GitHub] storm issue #459: [STORM-2999] Add generics to static type of method paramet...

2018-03-19 Thread d2r 
Github user d2r commented on the issue:

https://github.com/apache/storm/pull/459
  
> I just realized that this PR makes a lot of @SuppressWarning("rawtypes") 
unnecessary. What do you think about adding that as a second commit to this PR?

@krichter722 Sorry for the delay; yes we can hold off if you want to clean 
up these unnecessary annotations.


---

[GitHub] storm issue #459: [STORM-2999] Add generics to static type of method paramet...

2018-03-19 Thread krichter722 
Github user krichter722 commented on the issue:

https://github.com/apache/storm/pull/459
  
I just realized that this PR makes a lot of `@SuppressWarning("rawtypes")` 
unnecessary. What do you think about adding that as a second commit to this PR?


---