[GitHub] storm pull request: [Minor] Removing changelog file from kafka-sto...
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/655#issuecomment-131806283 @lazyval Great! Thanks. Could you remove TODO, too? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: [Minor] Removing changelog file from kafka-sto...
Github user lazyval commented on the pull request: https://github.com/apache/storm/pull/655#issuecomment-130072102 @revans2 any love for it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: [Minor] Removing changelog file from kafka-sto...
GitHub user lazyval opened a pull request: https://github.com/apache/storm/pull/655 [Minor] Removing changelog file from kafka-storm sub-project No other storm/external project has changelog and it looks like log became obsolete ever since storm-kafka was incorporated into storm. You can merge this pull request into a Git repository by running: $ git pull https://github.com/lazyval/storm removing-kafkaspout-changelog Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/655.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #655 commit 36366c801dc74be7111bcb2e7f5d78e6fe3570f4 Author: Kostya Golikov johnysilv...@gmail.com Date: 2015-07-28T18:44:22Z No other storm/external project has changelog and looks like log became obsolete ever since storm-kafka was incorporated into storm. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: [Minor] Removing changelog file from kafka-sto...
Github user lazyval commented on the pull request: https://github.com/apache/storm/pull/655#issuecomment-125712502 I also doubt that https://github.com/apache/storm/blob/master/TODO should be around --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---