[GitHub] storm pull request: [STORM-591] exclude logback.xml from jar
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/352 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: [STORM-591] exclude logback.xml from jar
Github user knusbaum commented on the pull request: https://github.com/apache/storm/pull/352#issuecomment-193486500 Closing this. Feel free to reopen with updates. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: [STORM-591] exclude logback.xml from jar
Github user d2r commented on the pull request: https://github.com/apache/storm/pull/352#issuecomment-146660961 @Lewuathe , The file has been converted to log4j2.xml, so all we need to do get your branch upmerged. Would you take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: [STORM-591] exclude logback.xml from jar
Github user d2r commented on the pull request: https://github.com/apache/storm/pull/352#issuecomment-112214321 I like the change, but I think now we need to update for log4j2. @Lewuathe would you be willing to convert the syntax for log4j2? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: [STORM-591] exclude logback.xml from jar
Github user Lewuathe commented on the pull request: https://github.com/apache/storm/pull/352#issuecomment-68525425 I found logback searches logback-test.xml first and at eventually I renamed xml file and excluded it when it is packaged. I think it is a better way because it can show this xml file is only used for test explicitly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: [STORM-591] exclude logback.xml from jar
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/352#issuecomment-67997538 This seems to be used by the tests, after this change see a lot of DEBUG and INFO logs from zookeeper. Instead of deleting it, can we move it to a directory that is only on the classpath for tests? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: [STORM-591] exclude logback.xml from jar
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/352#issuecomment-67654350 @Lewuathe I think logback.xml is not being used anymore instead there is logback/cluster.xml, worker.xml. I think a better fix is to remove the file itself. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
