[GitHub] storm pull request: [STORM-768] Support JDK 8 compile and runtime.
Github user Lewuathe closed the pull request at: https://github.com/apache/storm/pull/519 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: [STORM-768] Support JDK 8 compile and runtime.
Github user Lewuathe commented on the pull request: https://github.com/apache/storm/pull/519#issuecomment-173802479 Sure, I'll close this. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: [STORM-768] Support JDK 8 compile and runtime.
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/519#issuecomment-173801187 IMO, since we're relying on JDK 7, we can close this pull request. @Lewuathe Could you please close this pull request, or would you don't mind that I close this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: [STORM-768] Support JDK 8 compile and runtime.
Github user efenderbosch commented on the pull request: https://github.com/apache/storm/pull/519#issuecomment-139293256 In the Apache JIRA, it looks like Java 8 support has been targeted for version 0.11.0. Is there any sort of timeline for the 0.11.0 release? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: [STORM-768] Support JDK 8 compile and runtime.
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/519#issuecomment-125651455 @lazyval Travis build failure you linked is about random failure of storm-core, not related to JDK version. Btw, we decided to drop supporting JDK 6 from 0.10.0 and higher. Pom.xml was changed to reflect it. https://github.com/apache/storm/blob/0.10.x-branch/pom.xml --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: [STORM-768] Support JDK 8 compile and runtime.
Github user lazyval commented on the pull request: https://github.com/apache/storm/pull/519#issuecomment-125667064 Hm, I tried to do the same on completely different machine (beefy linux server instead of OSX laptop) and results are the very same: ``` [INFO] [INFO] Reactor Summary: [INFO] [INFO] Storm .. SUCCESS [ 1.046 s] [INFO] maven-shade-clojure-transformer SUCCESS [ 1.756 s] [INFO] storm-maven-plugins SUCCESS [ 1.629 s] [INFO] multilang-javascript ... SUCCESS [ 0.109 s] [INFO] multilang-python ... SUCCESS [ 0.107 s] [INFO] multilang-ruby . SUCCESS [ 0.104 s] [INFO] Storm Core . FAILURE [03:24 min] [INFO] storm-starter .. SKIPPED [INFO] storm-kafka SKIPPED [INFO] storm-hdfs . SKIPPED [INFO] storm-hbase SKIPPED [INFO] storm-hive . SKIPPED [INFO] storm-jdbc . SKIPPED [INFO] storm-redis SKIPPED [INFO] storm-eventhubs SKIPPED [INFO] flux ... SKIPPED [INFO] flux-wrappers .. SKIPPED [INFO] flux-core .. SKIPPED [INFO] flux-examples .. SKIPPED [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 03:30 min [INFO] Finished at: 2015-07-28T16:12:37+00:00 [INFO] Final Memory: 62M/1550M [INFO] [ERROR] Failed to execute goal com.theoryinpractise:clojure-maven-plugin:1.7.1:test (test-clojure) on project storm-core: Clojure failed. - [Help 1] ``` So far reproduction rate is 100% --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: [STORM-768] Support JDK 8 compile and runtime.
Github user lazyval commented on the pull request: https://github.com/apache/storm/pull/519#issuecomment-125639681 Am I right that Storm still has no support for java 8? I tried to run test from master on my local machine, but they're failing: ``` » mvn clean install ... [INFO] [INFO] Reactor Summary: [INFO] [INFO] Storm .. SUCCESS [ 1.453 s] [INFO] maven-shade-clojure-transformer SUCCESS [ 2.123 s] [INFO] storm-maven-plugins SUCCESS [ 2.324 s] [INFO] multilang-javascript ... SUCCESS [ 0.048 s] [INFO] multilang-python ... SUCCESS [ 0.049 s] [INFO] multilang-ruby . SUCCESS [ 0.049 s] [INFO] Storm Core . FAILURE [02:41 min] [INFO] storm-starter .. SKIPPED [INFO] storm-kafka SKIPPED [INFO] storm-hdfs . SKIPPED [INFO] storm-hbase SKIPPED [INFO] storm-hive . SKIPPED [INFO] storm-jdbc . SKIPPED [INFO] storm-redis SKIPPED [INFO] storm-eventhubs SKIPPED [INFO] flux ... SKIPPED [INFO] flux-wrappers .. SKIPPED [INFO] flux-core .. SKIPPED [INFO] flux-examples .. SKIPPED [INFO] [INFO] BUILD FAILURE [INFO] » mvn -version Apache Maven 3.3.3 (7994120775791599e205a5524ec3e0dfe41d4a06; 2015-04-22T15:57:37+04:00) Maven home: /usr/local/Cellar/maven/3.3.3/libexec Java version: 1.8.0_25, vendor: Oracle Corporation Java home: /Library/Java/JavaVirtualMachines/jdk1.8.0_25.jdk/Contents/Home/jre Default locale: en_US, platform encoding: UTF-8 OS name: mac os x, version: 10.10.4, arch: x86_64, family: mac ``` Same happens on travis (e.g. https://travis-ci.org/apache/storm/builds/72494388). It looks like a quite major issue. Is there plans to address it? How can I help with it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: [STORM-768] Support JDK 8 compile and runtime.
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/519#issuecomment-92883455 @Lewuathe IMO, yes, at most JDK 7. Various users use Storm with various JDK versions. It may be unacceptable when I want to upgrade only Storm, but it also requires upgrade of JDK especially it isn't fully guaranteed to be stable with various libraries. Project could have many dependencies and Storm is just only one of things. Please note that we can use Storm with JDK 8 without compiling Storm codes to JDK 8. Furthermore, Oracle still supports JDK7 with Oracle Java SE support (though I don't subscribe), and there still exists OpenJDK 7. One more thing, Clojure, Scala, or sth. seems to be still more powerful than JDK 8. If you think that it is better for Storm to move to JDK 8, I encourage you to find spots from current Storm codebase which can take advantage of new JDK version. I think it is more important than just changing source / target JDK version. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: [STORM-768] Support JDK 8 compile and runtime.
GitHub user Lewuathe opened a pull request: https://github.com/apache/storm/pull/519 [STORM-768] Support JDK 8 compile and runtime. - [x] Unittests (exclude storm-hive) - [x] nimbus server - [x] supervisor server - [x] drpc server - [x] Topology submit and running (storm.starter.ExclamationTopology) storm-hive unittest fails even if we use JDK 1.7. It might be due to JDK 1.8. It looks fine to support JDK 1.8 here. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Lewuathe/storm update-jdk8 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/519.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #519 commit a4032cfecd5eb3525871c361b39bf89998a04560 Author: lewuathe lewua...@me.com Date: 2015-04-13T11:24:15Z Support JDK 1.8 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: [STORM-768] Support JDK 8 compile and runtime.
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/519#issuecomment-92337108 Please think again that Storm is already widely used system, which means that Storm should support lower version of JDK as possible to widen coverage of usages. It's why many OSPs couldn't update their codebase to JDK 1.8 though JDK 1.8 has released for a while. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
