[GitHub] storm pull request: Add a convenience target to use when debugging...

2015-12-28 Thread d2r
Github user d2r commented on the pull request:

https://github.com/apache/storm/pull/510#issuecomment-167629353
  
@l03wn3, is STORM_JAR_JVM_OPTS OK for debugging this way?

If so, would you close this pull request?  Otherwise, would you create a 
Jira issue for this change?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm pull request: Add a convenience target to use when debugging...

2015-04-08 Thread lazyval
Github user lazyval commented on the pull request:

https://github.com/apache/storm/pull/510#issuecomment-90884297
  
@Parth-Brahmbhatt +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm pull request: Add a convenience target to use when debugging...

2015-04-08 Thread l03wn3
Github user l03wn3 commented on the pull request:

https://github.com/apache/storm/pull/510#issuecomment-90841470
  
@HeartSaVioR Yes, precisely. I've been adding stuff to storm.py and then 
removing it, but since it's annoying and not convenient to edit the storm 
binary of the system, I decided to add another target instead. I know there's 
other less convenient ways, but this is much more convenient and does not 
require modifying system files.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm pull request: Add a convenience target to use when debugging...

2015-04-07 Thread l03wn3
GitHub user l03wn3 opened a pull request:

https://github.com/apache/storm/pull/510

Add a convenience target to use when debugging topologies locally



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/l03wn3/storm master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/510.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #510


commit d89dec6ed44140cc6db05894dff3c1069d6a265b
Author: Nils Loodin l...@spotify.com
Date:   2015-04-07T13:20:32Z

Add a convenience target to use when debugging topologies locally




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm pull request: Add a convenience target to use when debugging...

2015-04-07 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request:

https://github.com/apache/storm/pull/510#issuecomment-90728650
  
@Parth-Brahmbhatt 
Maybe @l03wn3 want to attach debugger with main process which submits 
topology, not deployed workers. But still I agree it doesn't need to add 
special command.

@l03wn3 
If I know storm.py right, for now you can try adding your arguments to 
system environment STORM_JAR_JVM_OPTS before executing storm jar.
Sure you can restore STORM_JAR_JVM_OPTS after doing this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---