[GitHub] storm pull request: HiveBolt: misc code cleanups
Github user dossett closed the pull request at: https://github.com/apache/storm/pull/610 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: HiveBolt: misc code cleanups
Github user lazyval commented on a diff in the pull request:
https://github.com/apache/storm/pull/610#discussion_r34056406
--- Diff:
external/storm-hive/src/main/java/org/apache/storm/hive/bolt/HiveBolt.java ---
@@ -262,7 +261,7 @@ private void retireEldestWriter() {
private int retireIdleWriters() {
int count = 0;
long now = System.currentTimeMillis();
-ArrayListHiveEndPoint retirees = new ArrayListHiveEndPoint();
+ArrayListHiveEndPoint retirees = new ArrayList();
--- End diff --
Diamond types are also Java 7 feature.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: HiveBolt: misc code cleanups
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/610#issuecomment-119069596 @dossett not sure why these changes necessary here --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: HiveBolt: misc code cleanups
GitHub user dossett opened a pull request: https://github.com/apache/storm/pull/610 HiveBolt: misc code cleanups Contributing back very minor cleanups as I am trying to learn more about Storm code: - javadoc fixes - consolidate exception catches - suppress unavoidable unchecked warnings - remove unnecessary type parameters from constructors where possible There should not be any functional changes introduced You can merge this pull request into a Git repository by running: $ git pull https://github.com/dossett/storm HiveBoltMisc Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/610.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #610 commit bf634e2d3d68e96cfcbcd3555f9d7bbdffa60c0a Author: Aaron Dossett aaron.doss...@target.com Date: 2015-06-30T20:55:23Z misc code cleanups for HiveBolt --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
