[GitHub] storm pull request: STORM-1549: Add support for resetting tuple ti...

[revans2]

Github user revans2 commented on the pull request:

https://github.com/apache/storm/pull/1107#issuecomment-197358536
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-1549: Add support for resetting tuple ti...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/1107


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-1549: Add support for resetting tuple ti...

[srdo]

Github user srdo commented on the pull request:

https://github.com/apache/storm/pull/1107#issuecomment-197016989
  
The test failure looks unrelated to this PR, was also happening on 
1.x-branch https://travis-ci.org/apache/storm/jobs/115948898


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-1549: Add support for resetting tuple ti...

[srdo]

Github user srdo commented on the pull request:

https://github.com/apache/storm/pull/1107#issuecomment-190949609
  
@revans2 Sure, I'll leave this open then. Here's the master version of this 
PR https://github.com/apache/storm/pull/1174


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-1549: Add support for resetting tuple ti...

[revans2]

Github user revans2 commented on the pull request:

https://github.com/apache/storm/pull/1107#issuecomment-190905862
  
@srdo If you want to get the changes into 1.x keep this around.  master and 
1.x have diverged enough that it is not a simple sherry-pick any more for this 
part of the code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-1549: Add support for resetting tuple ti...

[srdo]

Github user srdo commented on the pull request:

https://github.com/apache/storm/pull/1107#issuecomment-190881185
  
Great. I'll make another PR when I've made these changes on master. Should 
I close this one?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-1549: Add support for resetting tuple ti...

[revans2]

Github user revans2 commented on the pull request:

https://github.com/apache/storm/pull/1107#issuecomment-190858491
  
@srdo Sorry I have been really behind on reviews.  The code and the concept 
seem sound.  I have not thought through all of the implications of this, but as 
of now I am +1 for this.

The only real issue is that we need a pull request/feature to go into 
master before we can do something for 1.x-branch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-1549: Add support for resetting tuple ti...

[srdo]

Github user srdo commented on the pull request:

https://github.com/apache/storm/pull/1107#issuecomment-190826744
  
Anyone have any feedback on this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-1549: Add support for resetting tuple ti...

[srdo]

GitHub user srdo opened a pull request:

https://github.com/apache/storm/pull/1107

STORM-1549: Add support for resetting tuple timeout from bolts via the 
OutputCollector

See https://issues.apache.org/jira/browse/STORM-1549.

Other than implementing tuple timeout reset, I made a minor change to 
assert-loop in integration_test.clj so it doesn't hang on failing tests. It 
should now fail the test after 10 seconds. I hope that's okay.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/srdo/storm 1.x-branch

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/1107.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1107


commit 406052cdc7138046a79104fc5c6f72212415f7f2
Author: Stig Rohde Døssing 
Date:   2016-02-14T01:39:42Z

STORM-1549: Add support for resetting tuple timeout from bolts via the 
OutputCollector




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---