[GitHub] storm pull request: STORM-378,SleepSpoutWaitStrategy.emptyEmit sho...
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/295#issuecomment-61860848 -1 I agree with @HeartSaVioR that if we want an implementation of `ISpoutWaitStrategy` that takes into account the `streak` parameter, it should be a separate implementation and `SleepSpoutWaitStrategy` should be left as-is. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-378,SleepSpoutWaitStrategy.emptyEmit sho...
Github user clockfly commented on the pull request: https://github.com/apache/storm/pull/295#issuecomment-61634029 To make the whole topology responsive, the spout need to stay active to pull data frequently from acker or system tick. When setting topology.sleep.spout.wait.strategy.time.ms to 1 ms, it should be good enough, the system load is relatively small. What is the motivation to make it increasing? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-378,SleepSpoutWaitStrategy.emptyEmit sho...
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/295#issuecomment-61767078 To make it clear, PR points to increase/decrease sleep time with streak. Fixed sleep time is configurable so it doesn't matter how long it is, optimal value should be vary for workload. I think we can make new ISpoutWaitStrategy implementation that play with streak if we really need it. We definitely need wait strategy to always sleep same time (ex. 1ms), so it isn't a good idea to change existing class's behavior. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
