[GitHub] storm pull request: STORM-544 Fix outdated documents

2014-12-23 Thread revans2
Github user revans2 commented on the pull request:

https://github.com/apache/storm/pull/340#issuecomment-67962843
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm pull request: STORM-544 Fix outdated documents

2014-12-11 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request:

https://github.com/apache/storm/pull/340#issuecomment-66716251
  
I strongly think it should be addressed ASAP cause current Storm website 
contains broken things.
Could you take a look, please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm pull request: STORM-544 Fix outdated documents

2014-12-05 Thread HeartSaVioR
GitHub user HeartSaVioR opened a pull request:

https://github.com/apache/storm/pull/340

STORM-544 Fix outdated documents

1. 
storm-starter link from all (or most? I don't know) documents refers to 
https://github.com/nathanmarz/storm-starter, it should be 
https://github.com/apache/storm/tree/master/examples/storm-starter .

2. 
It seems that Storm project (including storm-starter) no longer uses 
Leiningen, right?
It it does, some documents should reflect that change.
https://storm.apache.org/documentation/Creating-a-new-Storm-project.html
says that storm project uses Leiningen yet.

3. https://storm.apache.org/documentation/Maven.html contains outdated 
contents.
It should reflect recent stable version of groupId and artifactId, and 
version.
Would it better to remove building user's project with Leiningen because 
Storm project doesn't use Leiningen?
Developing Storm section is completely outdated.

4. https://storm.apache.org/documentation/Maven.html
Markdown for code block is not working. xml tag is removed so we can't 
understand what it means.

5. Some repository links refer to incubator-storm, not storm.

6. multilang documents are outdated

a. Explanation for adapters is outdated. 
Storm have javascript implemenation so it doesn't need to rely on external, 
and many projects seems not maintained, or redirect us to forked project.
b. multilang-protocol is outdated.
Spout subprocess can take a sleep in next() but shouldn't much because of 
heartbeat check.
Bolt subprocess should handle heartbeat tuple, and send sync to let 
ShellBolt know it's alive.

7. Storm-kafka project is in Storm project now, not storm-contrib.

I fixed some of markdowns which are not exposed to website.
I also add some opinion about removing contents related to zeromq / jzmq 
from JIRA.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/HeartSaVioR/storm STORM-544

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/340.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #340


commit fbca53dd816c49e4a9622369112bd357c18ebba6
Author: Jungtaek Lim kabh...@gmail.com
Date:   2014-12-06T03:09:22Z

STORM-544 Fixed links : Storm-starter is now placed to Storm project

commit bba84548af6725037b47a0c3905c3f093ca3f18f
Author: Jungtaek Lim kabh...@gmail.com
Date:   2014-12-06T03:18:47Z

STORM-544 Remove contents related to Leiningen

commit c6e7ec8df3024f10fce822547f93cf90a6e4d844
Author: Jungtaek Lim kabh...@gmail.com
Date:   2014-12-06T03:25:15Z

STORM-544 Remove or replace outdated contents from Maven.md

commit a24aea5d9e15fbe4fd42f45ef0020a2c470b905d
Author: Jungtaek Lim kabh...@gmail.com
Date:   2014-12-06T03:26:26Z

STORM-544 Replace outdated groupId and artifactId from Maven.md

commit 9fff1d7b8674253f1f0853a65b8a9c8c40f6f0d3
Author: Jungtaek Lim kabh...@gmail.com
Date:   2014-12-06T03:30:41Z

Update README.markdown now that Storm has graduated from Incubator

commit 39de7bc9d4a073c2c2caed12a21244fa0cc245e9
Author: Jungtaek Lim kabh...@gmail.com
Date:   2014-12-06T03:39:10Z

Update repository link now that Storm has graduated from Incubator

commit 77ff701300d90b5e8b711797cf809dbe94af75a4
Author: Jungtaek Lim kabh...@gmail.com
Date:   2014-12-06T03:56:40Z

STORM-544 Explain STORM-513 (heartbeat) to multilang-protocol doc.

commit 0bacffb1c7e5f9d350aa518df950e9dcf41c8eda
Author: Jungtaek Lim kabh...@gmail.com
Date:   2014-12-06T04:07:27Z

STORM-544 Replace or remove outdated multilang adaptors

commit e48f5050399bc2d673ba09c64c5195c93419f5fe
Author: Jungtaek Lim kabh...@gmail.com
Date:   2014-12-06T04:12:12Z

Revert Update repository link now that Storm has graduated from Incubator

There're critical replacements which breaks link.
This reverts commit 39de7bc9d4a073c2c2caed12a21244fa0cc245e9.

Conflicts:
docs/about/multi-language.md

commit bc7570b7d9ed5bdf675b7893ef66c00362928823
Author: Jungtaek Lim kabh...@gmail.com
Date:   2014-12-06T04:26:14Z

STORM-544 Replace repository link from incubator-storm to storm

commit 26c7fecd2aaa4f4a027c08d4e623d01720475dc0
Author: Jungtaek Lim kabh...@gmail.com
Date:   2014-12-06T04:41:41Z

STORM-544 Replace storm-kafka repository link from storm-contrib to Storm




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---