[GitHub] storm pull request: STORM-924:Set the file mode of the files inclu...

2015-07-15 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request:

https://github.com/apache/storm/pull/614#issuecomment-121767694
  
I suffered this issue when I created binary dist file and install manually. 
bin/storm script doesn't have permission for execute.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm pull request: STORM-924:Set the file mode of the files inclu...

2015-07-05 Thread caofangkun
Github user caofangkun commented on the pull request:

https://github.com/apache/storm/pull/614#issuecomment-118686693
  
Thanks @HeartSaVioR . I have fixed as you mentioned.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm pull request: STORM-924:Set the file mode of the files inclu...

2015-07-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request:

https://github.com/apache/storm/pull/614#issuecomment-118436035
  
How about setting file mode to storm_env.ini too?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm pull request: STORM-924:Set the file mode of the files inclu...

2015-07-02 Thread lazyval
Github user lazyval commented on the pull request:

https://github.com/apache/storm/pull/613#issuecomment-118044177
  
:+1: 

For those who wonders what this octal numbers mean, there is a great 
[*humanizator*](http://permissions-calculator.org/decode/0644/).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm pull request: STORM-924:Set the file mode of the files inclu...

2015-07-02 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request:

https://github.com/apache/storm/pull/613#issuecomment-118211480
  
I like the change. It would be better to set files' mode explicitly 
whenever it needs.

Only thing that I'm afraid of is unrelated commits, which are having no 
meaning for Apache Storm repo.
Could you handle it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---