[GitHub] storm pull request: update readme.md

2016-05-16 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request:

https://github.com/apache/storm/pull/1399#issuecomment-219385870
  
@ddmonk Repo seems to be deleted. Are you still in favor of contributing 
this part? If not I'll file an issue and take this over.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm pull request: update readme.md

2016-05-15 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request:

https://github.com/apache/storm/pull/1399#issuecomment-219340140
  
+1
It should be backported to 1.x-branch, 1.0.x-branch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm pull request: update readme.md

2016-05-05 Thread ddmonk
GitHub user ddmonk opened a pull request:

https://github.com/apache/storm/pull/1399

update readme.md

fix the wrong commands`$ bin/storm sql order_filtering order_filtering.sql` 
to `$ bin/storm sql order_filtering.sql order_filtering`

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ddmonk/storm master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/1399.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1399


commit 75edcfc9bbed47328b10203b9a0c71f33c585760
Author: ddmonk 
Date:   2016-05-05T10:20:39Z

update readme.md

fix the wrong shell `$ bin/storm sql order_filtering order_filtering.sql` 
to `$ bin/storm sql order_filtering.sql order_filtering`




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm pull request: Update README.md

2014-11-03 Thread clockfly
Github user clockfly commented on the pull request:

https://github.com/apache/storm/pull/292#issuecomment-61600425
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm pull request: Update README.md

2014-11-03 Thread clockfly
Github user clockfly commented on the pull request:

https://github.com/apache/storm/pull/292#issuecomment-61601001
  
@lukedemi 

Please add the JIRA number to the title of the pull request?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] storm pull request: Update README.md

2014-10-24 Thread ptgoetz
Github user ptgoetz commented on the pull request:

https://github.com/apache/storm/pull/292#issuecomment-60419239
  
+1

Thanks for fixing this!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---