[GitHub] storm pull request #1543: STORM-1939 Ignore InterruptedException on ShellBol...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/1543


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1543: STORM-1939 Ignore InterruptedException on ShellBol...

[abhishekagarwal87]

Github user abhishekagarwal87 commented on a diff in the pull request:

https://github.com/apache/storm/pull/1543#discussion_r70785048
  
--- Diff: storm-core/src/jvm/org/apache/storm/task/ShellBolt.java ---
@@ -158,8 +158,8 @@ public void execute(Tuple input) {
 
 _pendingWrites.putBoltMsg(boltMsg);
 } catch(InterruptedException e) {
-String processInfo = _process.getProcessInfoString() + 
_process.getProcessTerminationInfoString();
-throw new RuntimeException("Error during multilang processing 
" + processInfo, e);
+// It's likely that Bolt is shutting down so no need to throw 
RuntimeException
--- End diff --

My bad @HeartSaVioR. You can merge this for now. I have captured the 
improvement in 
https://issues.apache.org/jira/browse/STORM-1600


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1543: STORM-1939 Ignore InterruptedException on ShellBol...

[HeartSaVioR]

Github user HeartSaVioR commented on a diff in the pull request:

https://github.com/apache/storm/pull/1543#discussion_r70780928
  
--- Diff: storm-core/src/jvm/org/apache/storm/task/ShellBolt.java ---
@@ -158,8 +158,8 @@ public void execute(Tuple input) {
 
 _pendingWrites.putBoltMsg(boltMsg);
 } catch(InterruptedException e) {
-String processInfo = _process.getProcessInfoString() + 
_process.getProcessTerminationInfoString();
-throw new RuntimeException("Error during multilang processing 
" + processInfo, e);
+// It's likely that Bolt is shutting down so no need to throw 
RuntimeException
--- End diff --

@abhishekagarwal87 Do you have update on this? If your work is expected to 
take longer, please review this first and we could handle your improvement by 
separate issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1543: STORM-1939 Ignore InterruptedException on ShellBol...

[abhishekagarwal87]

Github user abhishekagarwal87 commented on a diff in the pull request:

https://github.com/apache/storm/pull/1543#discussion_r69857393
  
--- Diff: storm-core/src/jvm/org/apache/storm/task/ShellBolt.java ---
@@ -158,8 +158,8 @@ public void execute(Tuple input) {
 
 _pendingWrites.putBoltMsg(boltMsg);
 } catch(InterruptedException e) {
-String processInfo = _process.getProcessInfoString() + 
_process.getProcessTerminationInfoString();
-throw new RuntimeException("Error during multilang processing 
" + processInfo, e);
+// It's likely that Bolt is shutting down so no need to throw 
RuntimeException
--- End diff --

It will be good to have a jvm wide flag to indicate whether jvm shutdown is 
in progress. There is also a java hack for the same. I can add that flag in a 
separate PR. Do you mind holding onto this PR till I come up with that? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1543: STORM-1939 Ignore InterruptedException on ShellBol...

[HeartSaVioR]

GitHub user HeartSaVioR opened a pull request:

https://github.com/apache/storm/pull/1543

STORM-1939 Ignore InterruptedException on ShellBoltMessageQueue

InterruptedException makes false alarm for ShellBolt shutting down.
Since it's likely throwing InterruptedException when ShellBolt is shutting 
down, so we're ok to just consume that and continue.

Please see https://issues.apache.org/jira/browse/STORM-1939 for more 
details.

It should be applied to master, 1.x, 1.0.x branches.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/HeartSaVioR/storm STORM-1939

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/1543.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1543


commit 675e45547c2a27bcab4fcd1ce95ab51bc68cfbbe
Author: Jungtaek Lim 
Date:   2016-07-07T03:58:37Z

STORM-1939 Ignore InterruptedException on ShellBoltMessageQueue

* Since it's likely throwing InterruptedException when ShellBolt is 
shutting down
  * so we're ok to just consume that and continue




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---