[GitHub] storm pull request #1810: STORM-2204 Adding Bolt side caching for HBase Look...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/1810


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1810: STORM-2204 Adding Bolt side caching for HBase Look...

[vesense]

Github user vesense commented on a diff in the pull request:

https://github.com/apache/storm/pull/1810#discussion_r92120117
  
--- Diff: external/storm-hbase/pom.xml ---
@@ -87,5 +87,9 @@
 
 
 
+
+   com.google.guava
+   guava
--- End diff --

same as above.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1810: STORM-2204 Adding Bolt side caching for HBase Look...

[vesense]

Github user vesense commented on a diff in the pull request:

https://github.com/apache/storm/pull/1810#discussion_r92120044
  
--- Diff: external/storm-hbase/pom.xml ---
@@ -87,5 +87,9 @@
 
 
 
+
+   com.google.guava
--- End diff --

Please use white space instead of tab space.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1810: STORM-2204 Adding Bolt side caching for HBase Look...

[HeartSaVioR]

Github user HeartSaVioR commented on a diff in the pull request:

https://github.com/apache/storm/pull/1810#discussion_r90638449
  
--- Diff: 
external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/HBaseLookupBolt.java
 ---
@@ -56,6 +66,30 @@ public HBaseLookupBolt withConfigKey(String configKey){
 this.configKey = configKey;
 return this;
 }
+
+@SuppressWarnings({ "unchecked", "rawtypes" })
+   @Override
+public void prepare(Map map, TopologyContext topologyContext, 
OutputCollector collector) {
+   super.prepare(map, topologyContext, collector);
+   cacheEnabled = 
Boolean.parseBoolean(map.getOrDefault("hbase.cache.enable", 
"false").toString());
--- End diff --

@ambud 
As I said from #1783 getOrDefault() is not compiled with JDK7. Please build 
with JDK7 before submitting pull request.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1810: STORM-2204 Adding Bolt side caching for HBase Look...

[ambud]

GitHub user ambud opened a pull request:

https://github.com/apache/storm/pull/1810

STORM-2204 Adding Bolt side caching for HBase Lookup Bolt for 1.x branch



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ambud/storm 1.x-branch

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/1810.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1810


commit d4f996d9a17289b9c08a500c327e469b69384aeb
Author: ambud 
Date:   2016-12-01T20:22:42Z

Bolt side caching for HBase Lookup Bolt for 1.x branch




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---