[GitHub] storm pull request #2809: STORM-3199: Remove metrics-ganglia due to LGPL dep...

2018-08-27 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/2809


---

[GitHub] storm pull request #2809: STORM-3199: Remove metrics-ganglia due to LGPL dep...

2018-08-26 Thread HeartSaVioR 
Github user HeartSaVioR commented on a diff in the pull request:

https://github.com/apache/storm/pull/2809#discussion_r212838254
  
--- Diff: pom.xml ---
@@ -1011,12 +1005,12 @@
 log4j
 log4j
 
-
-org.slf4j
+   
--- End diff --

@srdo Looks like some nits on indentation. could you fix them?


---

[GitHub] storm pull request #2809: STORM-3199: Remove metrics-ganglia due to LGPL dep...

2018-08-18 Thread srdo 
GitHub user srdo opened a pull request:

https://github.com/apache/storm/pull/2809

STORM-3199: Remove metrics-ganglia due to LGPL dependency (1.x)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/srdo/storm STORM-3199-1.x

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/2809.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2809


commit 42981a09361e34cac639a867fa32134c76e4cbbc
Author: Stig Rohde Døssing 
Date:   2018-08-16T18:04:11Z

STORM-3199: Remove metrics-ganglia due to LGPL dependency




---