[GitHub] storm pull request #2842: STORM-3229: Add in better error reporting

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/2842


---

[GitHub] storm pull request #2842: STORM-3229: Add in better error reporting

[danny0405]

Github user danny0405 commented on a diff in the pull request:

https://github.com/apache/storm/pull/2842#discussion_r218691752
  
--- Diff: 
storm-client/src/jvm/org/apache/storm/security/auth/workertoken/WorkerTokenAuthorizer.java
 ---
@@ -112,13 +112,21 @@ private static IStormClusterState 
buildStateIfNeeded(Map conf, T
 if (keyCache == null) {
 return Optional.empty();
 }
+byte[] user = null;
+WorkerTokenInfo deser = null;
+try {
+user = Base64.getDecoder().decode(userName);
+deser = Utils.deserialize(user, WorkerTokenInfo.class);
+} catch (Exception e) {
+LOG.debug("Could not decode {}, might just be a plain digest 
request...", userName, e);
+return Optional.empty();
--- End diff --

Could we change to LOG.INFO if the request it not that frequent，we can 
see more details from the log.


---

[GitHub] storm pull request #2842: STORM-3229: Add in better error reporting

[revans2]

GitHub user revans2 opened a pull request:

https://github.com/apache/storm/pull/2842

STORM-3229:  Add in better error reporting



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/revans2/incubator-storm STORM-3229

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/2842.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2842


commit b1a535de35b8813a84d1cf6d95bc811fa0a58381
Author: Robert (Bobby) Evans 
Date:   2018-09-18T22:03:39Z

STORM-3229:  Add in better error reporting




---