[jira] [Commented] (STORM-1643) Performance Fix: Optimize clojure lookups related to throttling and stats
[ https://issues.apache.org/jira/browse/STORM-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15204576#comment-15204576 ] Roshan Naik commented on STORM-1643: [~revans2] This is for 1.x. Wrt 2.x... the fixes are small enough that we could optionally choose to not wait for the Java rewrite. > Performance Fix: Optimize clojure lookups related to throttling and stats > - > > Key: STORM-1643 > URL: https://issues.apache.org/jira/browse/STORM-1643 > Project: Apache Storm > Issue Type: Bug >Reporter: Roshan Naik >Assignee: Roshan Naik > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-1643) Performance Fix: Optimize clojure lookups related to throttling and stats
[ https://issues.apache.org/jira/browse/STORM-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15204568#comment-15204568 ] Roshan Naik commented on STORM-1643: :key lookups in Clojure are expensive. And some of keys like :storm-conf are being looked up multiple times. Optimizing these by looking up once and reusing improves performance. Will attach profiler screenshots demonstrating the before and after report. > Performance Fix: Optimize clojure lookups related to throttling and stats > - > > Key: STORM-1643 > URL: https://issues.apache.org/jira/browse/STORM-1643 > Project: Apache Storm > Issue Type: Bug >Reporter: Roshan Naik >Assignee: Roshan Naik > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-1643) Performance Fix: Optimize clojure lookups related to throttling and stats
[ https://issues.apache.org/jira/browse/STORM-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15204340#comment-15204340 ] Robert Joseph Evans commented on STORM-1643: What version is this against? Because if it is for 2.x/master we are in the process of moving everything to java so doing a lot of these optimizations would be premature. If this is for 1.x or 0.10 it would be god to know so we can test the correct thing. > Performance Fix: Optimize clojure lookups related to throttling and stats > - > > Key: STORM-1643 > URL: https://issues.apache.org/jira/browse/STORM-1643 > Project: Apache Storm > Issue Type: Bug >Reporter: Roshan Naik >Assignee: Roshan Naik > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
