[jira] [Commented] (STORM-1737) storm-kafka-client has compilation errors with Apache Kafka 0.10

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/STORM-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15379691#comment-15379691
 ] 

ASF GitHub Bot commented on STORM-1737:
---

Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/1556


> storm-kafka-client has compilation errors with Apache Kafka 0.10
> 
>
> Key: STORM-1737
> URL: https://issues.apache.org/jira/browse/STORM-1737
> Project: Apache Storm
>  Issue Type: Bug
>Reporter: Sriharsha Chintalapani
>Assignee: Hugo Louro
>Priority: Blocker
> Fix For: 2.0.0, 1.1.0
>
>
> when compiled with Apache Kafka 0.10 branch getting following errors
> {code}
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[163,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[166,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[175,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[177,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[252,41]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (STORM-1737) storm-kafka-client has compilation errors with Apache Kafka 0.10

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/STORM-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378057#comment-15378057
 ] 

ASF GitHub Bot commented on STORM-1737:
---

Github user harshach commented on the issue:

https://github.com/apache/storm/pull/1556
  
+1.


> storm-kafka-client has compilation errors with Apache Kafka 0.10
> 
>
> Key: STORM-1737
> URL: https://issues.apache.org/jira/browse/STORM-1737
> Project: Apache Storm
>  Issue Type: Bug
>Reporter: Sriharsha Chintalapani
>Assignee: Hugo Louro
>Priority: Blocker
>
> when compiled with Apache Kafka 0.10 branch getting following errors
> {code}
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[163,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[166,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[175,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[177,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[252,41]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (STORM-1737) storm-kafka-client has compilation errors with Apache Kafka 0.10

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/STORM-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15377113#comment-15377113
 ] 

ASF GitHub Bot commented on STORM-1737:
---

Github user hmcl commented on the issue:

https://github.com/apache/storm/pull/1556
  
@harshach @HeartSaVioR @abhishekagarwal87, thank you for your feedback. The 
updated ReadME, including the added Wildcard Support will be out in a few mins.


> storm-kafka-client has compilation errors with Apache Kafka 0.10
> 
>
> Key: STORM-1737
> URL: https://issues.apache.org/jira/browse/STORM-1737
> Project: Apache Storm
>  Issue Type: Bug
>Reporter: Sriharsha Chintalapani
>Assignee: Hugo Louro
>Priority: Blocker
>
> when compiled with Apache Kafka 0.10 branch getting following errors
> {code}
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[163,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[166,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[175,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[177,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[252,41]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (STORM-1737) storm-kafka-client has compilation errors with Apache Kafka 0.10

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/STORM-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375146#comment-15375146
 ] 

ASF GitHub Bot commented on STORM-1737:
---

Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/1556
  
Sorry to not clear on `where`: I mean which PR (or new issue) will handle 
updating the doc. Now I'm +1 once @hmcl updates the doc.


> storm-kafka-client has compilation errors with Apache Kafka 0.10
> 
>
> Key: STORM-1737
> URL: https://issues.apache.org/jira/browse/STORM-1737
> Project: Apache Storm
>  Issue Type: Bug
>Reporter: Sriharsha Chintalapani
>Assignee: Hugo Louro
>Priority: Blocker
> Fix For: 1.0.2
>
>
> when compiled with Apache Kafka 0.10 branch getting following errors
> {code}
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[163,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[166,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[175,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[177,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[252,41]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (STORM-1737) storm-kafka-client has compilation errors with Apache Kafka 0.10

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/STORM-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375118#comment-15375118
 ] 

ASF GitHub Bot commented on STORM-1737:
---

Github user harshach commented on the issue:

https://github.com/apache/storm/pull/1556
  
@HeartSaVioR As stated before we can add this to README of 
storm-kafka-client


> storm-kafka-client has compilation errors with Apache Kafka 0.10
> 
>
> Key: STORM-1737
> URL: https://issues.apache.org/jira/browse/STORM-1737
> Project: Apache Storm
>  Issue Type: Bug
>Reporter: Sriharsha Chintalapani
>Assignee: Hugo Louro
>Priority: Blocker
> Fix For: 1.0.2
>
>
> when compiled with Apache Kafka 0.10 branch getting following errors
> {code}
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[163,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[166,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[175,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[177,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[252,41]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (STORM-1737) storm-kafka-client has compilation errors with Apache Kafka 0.10

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/STORM-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375119#comment-15375119
 ] 

ASF GitHub Bot commented on STORM-1737:
---

Github user harshach commented on the issue:

https://github.com/apache/storm/pull/1556
  
@hmcl can you update the README with a Note: supports from kaka-client 0.10 
version on wards


> storm-kafka-client has compilation errors with Apache Kafka 0.10
> 
>
> Key: STORM-1737
> URL: https://issues.apache.org/jira/browse/STORM-1737
> Project: Apache Storm
>  Issue Type: Bug
>Reporter: Sriharsha Chintalapani
>Assignee: Hugo Louro
>Priority: Blocker
> Fix For: 1.0.2
>
>
> when compiled with Apache Kafka 0.10 branch getting following errors
> {code}
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[163,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[166,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[175,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[177,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[252,41]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (STORM-1737) storm-kafka-client has compilation errors with Apache Kafka 0.10

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/STORM-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375103#comment-15375103
 ] 

ASF GitHub Bot commented on STORM-1737:
---

Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/1556
  
Where we would want to update support versions on storm-kafka-client? 
I'd be +1 when we're clear to where we handle that thing.


> storm-kafka-client has compilation errors with Apache Kafka 0.10
> 
>
> Key: STORM-1737
> URL: https://issues.apache.org/jira/browse/STORM-1737
> Project: Apache Storm
>  Issue Type: Bug
>Reporter: Sriharsha Chintalapani
>Assignee: Hugo Louro
>Priority: Blocker
> Fix For: 1.0.2
>
>
> when compiled with Apache Kafka 0.10 branch getting following errors
> {code}
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[163,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[166,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[175,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[177,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[252,41]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (STORM-1737) storm-kafka-client has compilation errors with Apache Kafka 0.10

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/STORM-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374456#comment-15374456
 ] 

ASF GitHub Bot commented on STORM-1737:
---

Github user abhishekagarwal87 commented on the issue:

https://github.com/apache/storm/pull/1556
  
I will make the scope changes in #1482 


> storm-kafka-client has compilation errors with Apache Kafka 0.10
> 
>
> Key: STORM-1737
> URL: https://issues.apache.org/jira/browse/STORM-1737
> Project: Apache Storm
>  Issue Type: Bug
>Reporter: Sriharsha Chintalapani
>Assignee: Hugo Louro
>Priority: Blocker
> Fix For: 1.0.2
>
>
> when compiled with Apache Kafka 0.10 branch getting following errors
> {code}
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[163,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[166,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[175,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[177,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[252,41]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (STORM-1737) storm-kafka-client has compilation errors with Apache Kafka 0.10

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/STORM-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374448#comment-15374448
 ] 

ASF GitHub Bot commented on STORM-1737:
---

Github user harshach commented on the issue:

https://github.com/apache/storm/pull/1556
  
@abhishekagarwal87 We can put that in the README on which version we are 
going to support for storm-kafka-client.
agree on making the dependencies provided.


> storm-kafka-client has compilation errors with Apache Kafka 0.10
> 
>
> Key: STORM-1737
> URL: https://issues.apache.org/jira/browse/STORM-1737
> Project: Apache Storm
>  Issue Type: Bug
>Reporter: Sriharsha Chintalapani
>Assignee: Hugo Louro
>Priority: Blocker
> Fix For: 1.0.2
>
>
> when compiled with Apache Kafka 0.10 branch getting following errors
> {code}
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[163,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[166,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[175,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[177,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[252,41]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (STORM-1737) storm-kafka-client has compilation errors with Apache Kafka 0.10

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/STORM-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374422#comment-15374422
 ] 

ASF GitHub Bot commented on STORM-1737:
---

Github user abhishekagarwal87 commented on the issue:

https://github.com/apache/storm/pull/1556
  
@harshach just wanted to make sure that compatibility of kafka 0.10  with 
0.9 broker has been tested. 

Also given that there are three version lines of kafka client and two 
different kafka modules within storm, we should clearly document which 
combinations of kafka-client are supported. 

e.g.
storm-kafka supports kafka client 0.8.x and 0.9.x
storm-kafka-client supports kafka client 0.10.x

Apart from that kafka dependencies should be marked provided, so that users 
are forced to chose a kafka client version explicitly. Whether the kafka client 
version chosen by user works with broker, should be left for user to decide. 


> storm-kafka-client has compilation errors with Apache Kafka 0.10
> 
>
> Key: STORM-1737
> URL: https://issues.apache.org/jira/browse/STORM-1737
> Project: Apache Storm
>  Issue Type: Bug
>Reporter: Sriharsha Chintalapani
>Assignee: Hugo Louro
>Priority: Blocker
> Fix For: 1.0.2
>
>
> when compiled with Apache Kafka 0.10 branch getting following errors
> {code}
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[163,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[166,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[175,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[177,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[252,41]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (STORM-1737) storm-kafka-client has compilation errors with Apache Kafka 0.10

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/STORM-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374088#comment-15374088
 ] 

ASF GitHub Bot commented on STORM-1737:
---

Github user harshach commented on the issue:

https://github.com/apache/storm/pull/1556
  
@HeartSaVioR we released 1.0 like few weeks back and even they are using 
the new consumer api in 0.10 will be api compatible with 0.9 as well it just 
the parameter types that are changed. 


> storm-kafka-client has compilation errors with Apache Kafka 0.10
> 
>
> Key: STORM-1737
> URL: https://issues.apache.org/jira/browse/STORM-1737
> Project: Apache Storm
>  Issue Type: Bug
>Reporter: Sriharsha Chintalapani
>Assignee: Hugo Louro
>Priority: Blocker
> Fix For: 1.0.2
>
>
> when compiled with Apache Kafka 0.10 branch getting following errors
> {code}
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[163,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[166,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[175,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[177,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[252,41]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (STORM-1737) storm-kafka-client has compilation errors with Apache Kafka 0.10

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/STORM-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374087#comment-15374087
 ] 

ASF GitHub Bot commented on STORM-1737:
---

Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/1556
  
And let's clarify: what I'm thinking about is not only API level 
compatibility but Kafka client - broker version compatibility. We modified 
storm-kafka version to 0.8 due to this issue.


> storm-kafka-client has compilation errors with Apache Kafka 0.10
> 
>
> Key: STORM-1737
> URL: https://issues.apache.org/jira/browse/STORM-1737
> Project: Apache Storm
>  Issue Type: Bug
>Reporter: Sriharsha Chintalapani
>Assignee: Hugo Louro
>Priority: Blocker
> Fix For: 1.0.2
>
>
> when compiled with Apache Kafka 0.10 branch getting following errors
> {code}
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[163,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[166,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[175,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[177,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[252,41]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (STORM-1737) storm-kafka-client has compilation errors with Apache Kafka 0.10

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/STORM-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374082#comment-15374082
 ] 

ASF GitHub Bot commented on STORM-1737:
---

Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/1556
  
@hmcl Please update README.md to describe this module is compatible with 
0.10.0.

@harshach We're having potential users which already uses 
storm-kafka-client with Kafka 0.9. It might be better for them to guide not 
updating their storm-kafka-client version as same as storm-core due to client 
version change, or dropping usage of storm-kafka-client and back to storm-kafka.


> storm-kafka-client has compilation errors with Apache Kafka 0.10
> 
>
> Key: STORM-1737
> URL: https://issues.apache.org/jira/browse/STORM-1737
> Project: Apache Storm
>  Issue Type: Bug
>Reporter: Sriharsha Chintalapani
>Assignee: Hugo Louro
>Priority: Blocker
> Fix For: 1.0.2
>
>
> when compiled with Apache Kafka 0.10 branch getting following errors
> {code}
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[163,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[166,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[175,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[177,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[252,41]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (STORM-1737) storm-kafka-client has compilation errors with Apache Kafka 0.10

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/STORM-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374079#comment-15374079
 ] 

ASF GitHub Bot commented on STORM-1737:
---

Github user harshach commented on the issue:

https://github.com/apache/storm/pull/1556
  
@HeartSaVioR Yes. Users can still use the storm-kafka connector (old api) 
to connect to any version of kafka. Given that this is new consumer api we 
better move to compatible API soon. Hence the reason to push this as part of 
1.0.2 release.


> storm-kafka-client has compilation errors with Apache Kafka 0.10
> 
>
> Key: STORM-1737
> URL: https://issues.apache.org/jira/browse/STORM-1737
> Project: Apache Storm
>  Issue Type: Bug
>Reporter: Sriharsha Chintalapani
>Assignee: Hugo Louro
>Priority: Blocker
> Fix For: 1.0.2
>
>
> when compiled with Apache Kafka 0.10 branch getting following errors
> {code}
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[163,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[166,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[175,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[177,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[252,41]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (STORM-1737) storm-kafka-client has compilation errors with Apache Kafka 0.10

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/STORM-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374053#comment-15374053
 ] 

ASF GitHub Bot commented on STORM-1737:
---

Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/1556
  
@harshach 
Sorry I've confused with compatibility between client and broker version. 
Seems like kafka 0.9 broker is compatible with kafka 0.8 client. I guess you're 
based on this. Is it correct?


> storm-kafka-client has compilation errors with Apache Kafka 0.10
> 
>
> Key: STORM-1737
> URL: https://issues.apache.org/jira/browse/STORM-1737
> Project: Apache Storm
>  Issue Type: Bug
>Reporter: Sriharsha Chintalapani
>Assignee: Hugo Louro
>Priority: Blocker
> Fix For: 1.0.2
>
>
> when compiled with Apache Kafka 0.10 branch getting following errors
> {code}
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[163,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[166,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[175,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[177,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[252,41]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (STORM-1737) storm-kafka-client has compilation errors with Apache Kafka 0.10

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/STORM-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374039#comment-15374039
 ] 

ASF GitHub Bot commented on STORM-1737:
---

Github user harshach commented on the issue:

https://github.com/apache/storm/pull/1556
  
@HeartSaVioR I don't think this patch need to wait on storm-kafka changes 
in STORM-1876. Irrespective both these patches storm-kafka will work against 
0.8, 0.9 and 0.10


> storm-kafka-client has compilation errors with Apache Kafka 0.10
> 
>
> Key: STORM-1737
> URL: https://issues.apache.org/jira/browse/STORM-1737
> Project: Apache Storm
>  Issue Type: Bug
>Reporter: Sriharsha Chintalapani
>Assignee: Hugo Louro
>Priority: Blocker
> Fix For: 1.0.2
>
>
> when compiled with Apache Kafka 0.10 branch getting following errors
> {code}
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[163,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[166,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[175,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[177,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[252,41]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (STORM-1737) storm-kafka-client has compilation errors with Apache Kafka 0.10

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/STORM-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374037#comment-15374037
 ] 

ASF GitHub Bot commented on STORM-1737:
---

Github user harshach commented on the issue:

https://github.com/apache/storm/pull/1556
  
@HeartSaVioR 0.9 users won't be able to use the new API anyway. So why are 
we worried about that part. ). 0.9 users can still use storm-kafka but the new 
kafka consumer in storm-kafka-client


> storm-kafka-client has compilation errors with Apache Kafka 0.10
> 
>
> Key: STORM-1737
> URL: https://issues.apache.org/jira/browse/STORM-1737
> Project: Apache Storm
>  Issue Type: Bug
>Reporter: Sriharsha Chintalapani
>Assignee: Hugo Louro
>Priority: Blocker
> Fix For: 1.0.2
>
>
> when compiled with Apache Kafka 0.10 branch getting following errors
> {code}
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[163,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[166,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[175,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[177,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[252,41]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (STORM-1737) storm-kafka-client has compilation errors with Apache Kafka 0.10

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/STORM-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374020#comment-15374020
 ] 

ASF GitHub Bot commented on STORM-1737:
---

Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/1556
  
What's our plan to support version lines of Kafka? I think we need to guide 
storm-kafka to users that for 0.8 you need to blabla, and for 0.9, and for 0.10.
And storm-kafka-client is no longer compatible with 0.9, it would be better 
to go with [STORM-1876](https://issues.apache.org/jira/browse/STORM-1876) 
(#1482). If this patch merged in without STORM-1876, 0.9 users should download 
the code, and **change directory to external/storm-kafka**, and build module 
with proper `kafka.version` and `kafka.artifact.id` parameters.


> storm-kafka-client has compilation errors with Apache Kafka 0.10
> 
>
> Key: STORM-1737
> URL: https://issues.apache.org/jira/browse/STORM-1737
> Project: Apache Storm
>  Issue Type: Bug
>Reporter: Sriharsha Chintalapani
>Assignee: Hugo Louro
>Priority: Blocker
> Fix For: 1.0.2
>
>
> when compiled with Apache Kafka 0.10 branch getting following errors
> {code}
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[163,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[166,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[175,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[177,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[252,41]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (STORM-1737) storm-kafka-client has compilation errors with Apache Kafka 0.10

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/STORM-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15373974#comment-15373974
 ] 

ASF GitHub Bot commented on STORM-1737:
---

Github user HeartSaVioR commented on a diff in the pull request:

https://github.com/apache/storm/pull/1556#discussion_r70542939
  
--- Diff: 
external/storm-kafka/src/test/org/apache/storm/kafka/KafkaTestBroker.java ---
@@ -17,21 +17,21 @@
  */
 package org.apache.storm.kafka;
 
+import org.apache.commons.io.FileUtils;
 import org.apache.curator.framework.CuratorFramework;
 import org.apache.curator.framework.CuratorFrameworkFactory;
 import org.apache.curator.framework.imps.CuratorFrameworkState;
 import org.apache.curator.retry.ExponentialBackoffRetry;
 import org.apache.curator.test.InstanceSpec;
 import org.apache.curator.test.TestingServer;
 
-import kafka.server.KafkaConfig;
-import kafka.server.KafkaServerStartable;
-import org.apache.commons.io.FileUtils;
-
 import java.io.File;
 import java.io.IOException;
 import java.util.Properties;
 
+import kafka.server.KafkaConfig;
+import kafka.server.KafkaServerStartable;
+
 /**
--- End diff --

Out of scope, but we need to get rid of this comment.


> storm-kafka-client has compilation errors with Apache Kafka 0.10
> 
>
> Key: STORM-1737
> URL: https://issues.apache.org/jira/browse/STORM-1737
> Project: Apache Storm
>  Issue Type: Bug
>Reporter: Sriharsha Chintalapani
>Assignee: Hugo Louro
>Priority: Blocker
> Fix For: 1.0.2
>
>
> when compiled with Apache Kafka 0.10 branch getting following errors
> {code}
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[163,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[166,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[175,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[177,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[252,41]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (STORM-1737) storm-kafka-client has compilation errors with Apache Kafka 0.10

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/STORM-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15373052#comment-15373052
 ] 

ASF GitHub Bot commented on STORM-1737:
---

Github user harshach commented on the issue:

https://github.com/apache/storm/pull/1556
  
+1


> storm-kafka-client has compilation errors with Apache Kafka 0.10
> 
>
> Key: STORM-1737
> URL: https://issues.apache.org/jira/browse/STORM-1737
> Project: Apache Storm
>  Issue Type: Bug
>Reporter: Sriharsha Chintalapani
>Assignee: Hugo Louro
>Priority: Blocker
> Fix For: 1.0.2
>
>
> when compiled with Apache Kafka 0.10 branch getting following errors
> {code}
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[163,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[166,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[175,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[177,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[252,41]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (STORM-1737) storm-kafka-client has compilation errors with Apache Kafka 0.10

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/STORM-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15373048#comment-15373048
 ] 

ASF GitHub Bot commented on STORM-1737:
---

GitHub user hmcl opened a pull request:

https://github.com/apache/storm/pull/1556

STORM-1737: storm-kafka-client has compilation errors with Apache Kafka 0.10



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/hmcl/storm-apache STORM-1737

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/storm/pull/1556.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1556


commit 04f00e56beb9799dc8b8fc732271b786ced5c21e
Author: Hugo Louro 
Date:   2016-04-29T16:18:05Z

STORM-1737: storm-kafka-client has compilation errors with Apache Kafka 0.10




> storm-kafka-client has compilation errors with Apache Kafka 0.10
> 
>
> Key: STORM-1737
> URL: https://issues.apache.org/jira/browse/STORM-1737
> Project: Apache Storm
>  Issue Type: Bug
>Reporter: Sriharsha Chintalapani
>Assignee: Hugo Louro
>Priority: Blocker
> Fix For: 1.0.2
>
>
> when compiled with Apache Kafka 0.10 branch getting following errors
> {code}
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[163,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[166,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[175,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[177,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[252,41]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (STORM-1737) storm-kafka-client has compilation errors with Apache Kafka 0.10

[Hugo Louro (JIRA)]

[ 
https://issues.apache.org/jira/browse/STORM-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15371323#comment-15371323
 ] 

Hugo Louro commented on STORM-1737:
---

[~kabhwan] as of release 0.10.0 the @InterfaceStability.Unstable annotation was 
removed from the Consumer interface.

I am working on this now. I will a PR by EOD

> storm-kafka-client has compilation errors with Apache Kafka 0.10
> 
>
> Key: STORM-1737
> URL: https://issues.apache.org/jira/browse/STORM-1737
> Project: Apache Storm
>  Issue Type: Bug
>Reporter: Sriharsha Chintalapani
>Assignee: Hugo Louro
>Priority: Blocker
> Fix For: 1.0.2
>
>
> when compiled with Apache Kafka 0.10 branch getting following errors
> {code}
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[163,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[166,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[175,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[177,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[252,41]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (STORM-1737) storm-kafka-client has compilation errors with Apache Kafka 0.10

[Jungtaek Lim (JIRA)]

[ 
https://issues.apache.org/jira/browse/STORM-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15370040#comment-15370040
 ] 

Jungtaek Lim commented on STORM-1737:
-

If this issue can be fixed by several days I'm OK to mark this as 'Blocker', 
but if not I don't think this issue should block releasing 1.0.2.
Yes Kafka is a kind of de-facto standard queue now so we should consider Kafka 
as first class, but Apache Kafka 0.10 was released just 1 month ago and no 
other streaming frameworks seem support Kafka 0.10.

Btw, can we make storm-kafka-client not using methods marked as 'Unstable'? 
Since it's marked as 'Unstable' Kafka community can change that at other minor 
updates, and I don't think we should follow their changes ASAP.

> storm-kafka-client has compilation errors with Apache Kafka 0.10
> 
>
> Key: STORM-1737
> URL: https://issues.apache.org/jira/browse/STORM-1737
> Project: Apache Storm
>  Issue Type: Bug
>Reporter: Sriharsha Chintalapani
>Assignee: Hugo Louro
>Priority: Blocker
> Fix For: 1.0.2
>
>
> when compiled with Apache Kafka 0.10 branch getting following errors
> {code}
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[163,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[166,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[175,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[177,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[252,41]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (STORM-1737) storm-kafka-client has compilation errors with Apache Kafka 0.10

[Sriharsha Chintalapani (JIRA)]

[ 
https://issues.apache.org/jira/browse/STORM-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369241#comment-15369241
 ] 

Sriharsha Chintalapani commented on STORM-1737:
---

The above issue due to the api change from new kafka consumer 0.9 to 0.10. 
Given that Kafka Consumer interface marked as unstable we should make this 
change on our side by updating the pom.xml kafka.version to 0.10 and make the 
required api changes in kafka spout.

> storm-kafka-client has compilation errors with Apache Kafka 0.10
> 
>
> Key: STORM-1737
> URL: https://issues.apache.org/jira/browse/STORM-1737
> Project: Apache Storm
>  Issue Type: Bug
>Reporter: Sriharsha Chintalapani
>Assignee: Hugo Louro
>Priority: Blocker
> Fix For: 1.0.2
>
>
> when compiled with Apache Kafka 0.10 branch getting following errors
> {code}
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[163,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[166,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[175,51]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[177,45]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> [ERROR] 
> /Users/harsha/code/hwx/storm/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java:[252,41]
>  incompatible types: org.apache.kafka.common.TopicPartition cannot be 
> converted to java.util.Collection
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)