[jira] [Commented] (STORM-575) Ability to specify Jetty host to bind to
[ https://issues.apache.org/jira/browse/STORM-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14257151#comment-14257151 ] ASF GitHub Bot commented on STORM-575: -- Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/334 Ability to specify Jetty host to bind to Key: STORM-575 URL: https://issues.apache.org/jira/browse/STORM-575 Project: Apache Storm Issue Type: Improvement Reporter: Matthew Siegel Assignee: Matthew Siegel Priority: Minor Fix For: 0.10.0 In addition to being able to specify the port that the UI (Jetty) binds to, I need to be able to specify the host/interface that the UI binds to. Currently defaults to '0.0.0.0', all interfaces. Default will remain 0.0.0.0, and 'ui.host' config item to be added -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-575) Ability to specify Jetty host to bind to
[ https://issues.apache.org/jira/browse/STORM-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14230119#comment-14230119 ] ASF GitHub Bot commented on STORM-575: -- Github user msiegel07 closed the pull request at: https://github.com/apache/storm/pull/329 Ability to specify Jetty host to bind to Key: STORM-575 URL: https://issues.apache.org/jira/browse/STORM-575 Project: Apache Storm Issue Type: Improvement Reporter: Matthew Siegel Priority: Minor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-575) Ability to specify Jetty host to bind to
[ https://issues.apache.org/jira/browse/STORM-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14230240#comment-14230240 ] ASF GitHub Bot commented on STORM-575: -- GitHub user msiegel07 opened a pull request: https://github.com/apache/storm/pull/334 STORM-575: Specify UI/Jetty interface to bind to (ui.host) You can merge this pull request into a Git repository by running: $ git pull https://github.com/msiegel07/storm master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/334.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #334 commit 72279c7c339425ebf71d1cf1f5495c28ab67fcec Author: Matt Siegel matthew.sie...@solers.com Date: 2014-12-01T18:52:54Z STORM-575: Specify UI/Jetty interface to bind to (ui.host) Ability to specify Jetty host to bind to Key: STORM-575 URL: https://issues.apache.org/jira/browse/STORM-575 Project: Apache Storm Issue Type: Improvement Reporter: Matthew Siegel Priority: Minor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-575) Ability to specify Jetty host to bind to
[ https://issues.apache.org/jira/browse/STORM-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14226654#comment-14226654 ] ASF GitHub Bot commented on STORM-575: -- Github user msiegel07 commented on the pull request: https://github.com/apache/storm/pull/329#issuecomment-64694837 Submitted STORM-575. Ability to specify Jetty host to bind to Key: STORM-575 URL: https://issues.apache.org/jira/browse/STORM-575 Project: Apache Storm Issue Type: Improvement Reporter: Matthew Siegel Priority: Minor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-575) Ability to specify Jetty host to bind to
[ https://issues.apache.org/jira/browse/STORM-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14226914#comment-14226914 ] ASF GitHub Bot commented on STORM-575: -- Github user harshach commented on the pull request: https://github.com/apache/storm/pull/329#issuecomment-64720994 +1 Ability to specify Jetty host to bind to Key: STORM-575 URL: https://issues.apache.org/jira/browse/STORM-575 Project: Apache Storm Issue Type: Improvement Reporter: Matthew Siegel Priority: Minor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-575) Ability to specify Jetty host to bind to
[
https://issues.apache.org/jira/browse/STORM-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14226946#comment-14226946
]
ASF GitHub Bot commented on STORM-575:
--
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/329#issuecomment-64722744
This looks fine to me +1. My only concern is that this pull request is
against 0.9.3-branch and not master. I will leave it up to @ptgoetz if he
wants to have the 0.9.3 line accept new features and continue on. Otherwise we
really should just have this point to master.
The upmerge to master is fairly straight forward but there was one
conflict, that was not trivial.
```
diff --git a/storm-core/src/clj/backtype/storm/ui/core.clj
b/storm-core/src/clj/backtype/storm/ui/core.clj
index 3dc7396..c272cf0 100644
--- a/storm-core/src/clj/backtype/storm/ui/core.clj
+++ b/storm-core/src/clj/backtype/storm/ui/core.clj
@@ -978,6 +978,7 @@
filters-confs [{:filter-class (conf UI-FILTER)
:filter-params (conf UI-FILTER-PARAMS)}]]
(storm-run-jetty {:port (conf UI-PORT)
+:host (conf UI-HOST)
:configurator (fn [server]
(doseq [connector (.getConnectors
server)]
(.setRequestHeaderSize connector
header-buffer-size))
```
Ability to specify Jetty host to bind to
Key: STORM-575
URL: https://issues.apache.org/jira/browse/STORM-575
Project: Apache Storm
Issue Type: Improvement
Reporter: Matthew Siegel
Priority: Minor
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (STORM-575) Ability to specify Jetty host to bind to
[ https://issues.apache.org/jira/browse/STORM-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14227006#comment-14227006 ] ASF GitHub Bot commented on STORM-575: -- Github user Parth-Brahmbhatt commented on the pull request: https://github.com/apache/storm/pull/329#issuecomment-64726991 +1 (nonbinding) Ability to specify Jetty host to bind to Key: STORM-575 URL: https://issues.apache.org/jira/browse/STORM-575 Project: Apache Storm Issue Type: Improvement Reporter: Matthew Siegel Priority: Minor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-575) Ability to specify Jetty host to bind to
[ https://issues.apache.org/jira/browse/STORM-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14227101#comment-14227101 ] ASF GitHub Bot commented on STORM-575: -- Github user msiegel07 commented on the pull request: https://github.com/apache/storm/pull/329#issuecomment-64734276 Do you want me to do a pull request against master? Close this one? Ability to specify Jetty host to bind to Key: STORM-575 URL: https://issues.apache.org/jira/browse/STORM-575 Project: Apache Storm Issue Type: Improvement Reporter: Matthew Siegel Priority: Minor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
