[GitHub] storm pull request #2632: spelling fixes

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/2632


---

[GitHub] storm pull request #2629: [STORM-3023] fix the issue that Storm UI not showi...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/2629


---

[GitHub] storm pull request #2634: [STORM-3021] Fix wrong usages of Config.TOPOLOGY_W...

[Ethanlm]

Github user Ethanlm commented on a diff in the pull request:

https://github.com/apache/storm/pull/2634#discussion_r181472816
  
--- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java 
---
@@ -305,8 +305,9 @@ private void setupFlushTupleTimer(final Map topologyConf, final
 }
 
 private void setupBackPressureCheckTimer(final Map 
topologyConf) {
--- End diff --

`topologyConf`  used in this function 


---

[GitHub] storm pull request #2634: [STORM-3021] Fix wrong usages of Config.TOPOLOGY_W...

[agresch]

Github user agresch commented on a diff in the pull request:

https://github.com/apache/storm/pull/2634#discussion_r181480542
  
--- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java 
---
@@ -305,8 +305,9 @@ private void setupFlushTupleTimer(final Map topologyConf, final
 }
 
 private void setupBackPressureCheckTimer(final Map 
topologyConf) {
--- End diff --

My bad.  


---

[GitHub] storm pull request #2628: STORM-2908 Document Metrics V2 for 2.0.0

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/storm/pull/2628


---

[GitHub] storm issue #2632: spelling fixes

[HeartSaVioR]

Github user HeartSaVioR commented on the issue:

https://github.com/apache/storm/pull/2632
  
Never mind. It is really tiny and doc change so might not matter anyway.


---

Configuration mapping between storm-kafka & storm-kafka-client

[Srishty Agrawal]

Hi,

Is there a document which contains mapping of configurations from
storm-kafka SpoutConfig to storm-kafka-client KafkaSpoutConfig? I am
working towards migrating Storm-0.9.6 topologies to use Storm-1.0.6.

I have compiled all the information I could find online in this gist
,
although I am not sure how correct it is.

Thanks,
Srishty Agrawal

[GitHub] storm pull request #2634: [STORM-3021] Fix wrong usages of Config.TOPOLOGY_W...

[erikdw]

Github user erikdw commented on a diff in the pull request:

https://github.com/apache/storm/pull/2634#discussion_r181535091
  
--- Diff: storm-client/src/jvm/org/apache/storm/Config.java ---
@@ -372,9 +374,10 @@
 /**
  * How many executors to spawn for ackers.
  *
- * By not setting this variable or setting it as null, Storm will 
set the number of acker executors
- * to be equal to the number of workers configured for this topology. 
If this variable is set to 0,
- * then Storm will immediately ack tuples as soon as they come off the 
spout, effectively disabling reliability.
+ * By not setting this variable or setting it as null, Storm will 
set the number of acker executor to be equal to
--- End diff --

nit: please restore pluralization of `executor`.  i.e., `number of acker 
executors`.


---

Re: New Committer/PMC Member: Roshan Naik

[Srishty Agrawal]

Congratulations Roshan!

On Wed, Apr 11, 2018 at 11:50 AM, Seema Joshi 
wrote:

> Congrats Roshan!!
>
> On Sat, Apr 7, 2018 at 12:15 AM, Roshan Naik  >
> wrote:
>
> > Thanks to everyone here and on the PMC list ! -Roshan
> >
> >
> > Sent from Yahoo Mail for iPhone
> >
> >
> > On Friday, April 6, 2018, 3:41 PM, Raghav Kumar Gautam <
> rag...@apache.org>
> > wrote:
> >
> > Congratulations Roshan !!!
> >
> >
> > On 2018/04/06 10:59:07, Satish Duggana  wrote:
> > > Congratulations Roshan!!>
> > >
> > >
> > >
> > > On Fri, Apr 6, 2018 at 10:06 AM, Erik Weathers <>
> > > eweath...@groupon.com.invalid> wrote:>
> > >
> > > > Congrats Roshan!!>
> > > >>
> > > > On Thu, Apr 5, 2018 at 8:26 PM Ethan Li  wrote:>
> > > >>
> > > > > Congratulations! Roshan>
> > > > >>
> > > > > Ethan Li>
> > > > >>
> > > > > > On Apr 5, 2018, at 21:40, Jungtaek Lim  wrote:>
> > > > > >>
> > > > > > Congrats Roshan!>
> > > > > >>
> > > > > > 2018년 4월 6일 (금) 오전 11:39, P. Taylor Goetz 님이
> 작성:>
> > > > > >>
> > > > > >> Please join me in congratulating and welcoming Roshan Naik as
> the>
> > > > latest>
> > > > > >> Apache Storm committer and PMC member.>
> > > > > >>>
> > > > > >> Welcome Roshan!>
> > > > > >>>
> > > > > >> -Taylor>
> > > > > >>>
> > > > > >>>
> > > > >>
> > > >>
> > >
> >
> >
> >
>
>
> --
> Seema Joshi
> Manager, Data Infrastructure | GROUPON
> sjo...@groupon.com 
>



-- 
Thanks,
Srishty Agrawal

[GitHub] storm issue #2000: STORM-2411 Setting topology.eventlogger.executors=0 in de...

[roshannaik]

Github user roshannaik commented on the issue:

https://github.com/apache/storm/pull/2000
  
thanks.


---

[GitHub] storm pull request #2634: [STORM-3021] Fix wrong usages of Config.TOPOLOGY_W...

[agresch]

Github user agresch commented on a diff in the pull request:

https://github.com/apache/storm/pull/2634#discussion_r181427545
  
--- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java 
---
@@ -305,8 +305,9 @@ private void setupFlushTupleTimer(final Map topologyConf, final
 }
 
 private void setupBackPressureCheckTimer(final Map 
topologyConf) {
--- End diff --

remove unused topologyConf


---