svn commit: rev 51792 - struts/trunk/xdocs/proposals
Author: sraeburn Date: Fri Oct 1 23:22:05 2004 New Revision: 51792 Modified: struts/trunk/xdocs/proposals/workflow.xml Log: Testing SVN commit Modified: struts/trunk/xdocs/proposals/workflow.xml == --- struts/trunk/xdocs/proposals/workflow.xml (original) +++ struts/trunk/xdocs/proposals/workflow.xml Fri Oct 1 23:22:05 2004 @@ -14,8 +14,8 @@ Work on this initiative has stalled. It is recommended that interested parties look to the a href=http://jakarta.apache.org/commons/jelly/index.html;Commons Jelly/a product. -A way to persist the workflow state between sessions is needed, but Jelly otherwise fills the needs -identified by this proosal. +A way to persist the workflow state between sessions is needed, but Jelly +otherwise fills the needs identified by this proosal. /p /section - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: rev 51793 - struts/trunk/xdocs/proposals
Author: sraeburn Date: Fri Oct 1 23:31:37 2004 New Revision: 51793 Modified: struts/trunk/xdocs/proposals/workflow.xml Log: Test commit from Eclipse Modified: struts/trunk/xdocs/proposals/workflow.xml == --- struts/trunk/xdocs/proposals/workflow.xml (original) +++ struts/trunk/xdocs/proposals/workflow.xml Fri Oct 1 23:31:37 2004 @@ -14,8 +14,7 @@ Work on this initiative has stalled. It is recommended that interested parties look to the a href=http://jakarta.apache.org/commons/jelly/index.html;Commons Jelly/a product. -A way to persist the workflow state between sessions is needed, but Jelly -otherwise fills the needs identified by this proosal. +A way to persist the workflow state between sessions is needed, but Jelly otherwise fills the needs identified by this proosal. /p /section - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18169] - Resource attribute of msg tag in the validation.xml doesn't work as anticipated
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=18169. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=18169 Resource attribute of msg tag in the validation.xml doesn't work as anticipated [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID | --- Additional Comments From [EMAIL PROTECTED] 2004-10-02 07:08 --- Struts validator ingnores 'resource' attribute of 'msg' element in 'field' element in validation.xml and continues using resource bundle even if 'resource' is set to false. This is the reason why the message is left blank. Struts version: 1.2.4 OS: Win XP - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: rev 51787 - struts/trunk/conf/share
So, what's up with key word expansion? My change to that file, was to add a space, remove it, then save it. On commit I see that $Date$ was changed, and locally it was expanded correctly, but 'Header' and 'Revision' were not. Is there some svn configuration change we are missing or do we need to change the key words? -- James Mitchell Software Engineer / Open Source Evangelist EdgeTech, Inc. 678.910.8017 AIM: jmitchtx - Original Message - From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Friday, October 01, 2004 11:17 PM Subject: svn commit: rev 51787 - struts/trunk/conf/share Author: jmitchell Date: Fri Oct 1 20:17:23 2004 New Revision: 51787 Modified: struts/trunk/conf/share/validator-rules.xml Log: no changes, just testing Modified: struts/trunk/conf/share/validator-rules.xml == --- struts/trunk/conf/share/validator-rules.xml (original) +++ struts/trunk/conf/share/validator-rules.xml Fri Oct 1 20:17:23 2004 @@ -4,7 +4,7 @@ !-- $Header: /home/cvs/jakarta-struts/conf/share/validator-rules.xml,v 1.52 2004/07/25 12:00:20 niallp Exp $ $Revision: 1.52 $ - $Date: 2004/07/25 12:00:20 $ + $Date$ This file contains the default Struts Validator pluggable validator definitions. It should be placed somewhere under /WEB-INF and - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: rev 51799 - struts/trunk/xdocs/proposals
Author: germuska Date: Sat Oct 2 06:24:29 2004 New Revision: 51799 Modified: struts/trunk/xdocs/proposals/workflow.xml Log: correct typo; test svn commits Modified: struts/trunk/xdocs/proposals/workflow.xml == --- struts/trunk/xdocs/proposals/workflow.xml (original) +++ struts/trunk/xdocs/proposals/workflow.xml Sat Oct 2 06:24:29 2004 @@ -14,7 +14,7 @@ Work on this initiative has stalled. It is recommended that interested parties look to the a href=http://jakarta.apache.org/commons/jelly/index.html;Commons Jelly/a product. -A way to persist the workflow state between sessions is needed, but Jelly otherwise fills the needs identified by this proosal. +A way to persist the workflow state between sessions is needed, but Jelly otherwise fills the needs identified by this proposal. /p /section - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Struts + Maven + SVN
repository connectionscm|svn|http|//svn.apache.org/repos/asf/struts/trunk/connection developerConnectionscm|svn|https|//my-site.org/ repos/asf/struts/trunk/developerConnection urlhttp://svn.apache.org/repos/asf/struts/trunk/url /repository You must also add this property before to enable the changelog plugin: maven.changelog.factory = org.apache.maven.svnlib.SvnChangeLogFactory I tested it and it works. I attached the diff file. Arnaud [EMAIL PROTECTED] Index: project.properties === --- project.properties (revision 51799) +++ project.properties (working copy) @@ -1,7 +1,7 @@ # --- # P R O J E C T P R O P E R T I E S - Modeled after Turbine project.properties # -# $Id: project.properties,v 1.13 2004/08/14 00:08:48 husted Exp $ +# $Id$ # # Do not change this file. Please use build.properties in this directory # to do site or installation specific changes to the project build. @@ -11,6 +11,9 @@ maven.checkstyle.properties = conf/qa/CheckStyle.xml +# ChangeLog Plugin Factory for SVN +maven.changelog.factory = org.apache.maven.svnlib.SvnChangeLogFactory + #keep ant maven directories seperate. maven.build.dir=m-target Index: project.xml === --- project.xml (revision 51799) +++ project.xml (working copy) @@ -22,13 +22,11 @@ siteAddressstruts.apache.org/siteAddress siteDirectory/www/jakarta.apache.org/struts/siteDirectory distributionDirectory/www/apache.mirrors.pair.com/jakarta/struts//distributionDirectory -!-- repository -connectionscm:cvs:pserver:[EMAIL PROTECTED]:/home/cvspublic:jakarta-struts/connection -developerConnectionscm:cvs:pserver:[EMAIL PROTECTED]:/home/cvs:jakarta-struts/developerConnection -urlhttp://cvs.apache.org/viewcvs/jakarta-struts//url +connectionscm|svn|http|//svn.apache.org/repos/asf/struts/trunk/connection +developerConnectionscm|svn|https|//my-site.org/ repos/asf/struts/trunk/developerConnection +urlhttp://svn.apache.org/repos/asf/struts/trunk/url /repository - -- versions version id1.0.2/id @@ -370,7 +368,7 @@ reportmaven-jdepend-plugin/report reportmaven-checkstyle-plugin/report reportmaven-changes-plugin/report -!-- reportmaven-changelog-plugin/report -- +reportmaven-changelog-plugin/report reportmaven-file-activity-plugin/report reportmaven-developer-activity-plugin/report reportmaven-javadoc-plugin/report - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Struts + Maven + SVN
Thank you, that is exactly what I was missing. I just committed the change. -- James Mitchell Software Engineer / Open Source Evangelist EdgeTech, Inc. 678.910.8017 AIM: jmitchtx - Original Message - From: Arnaud HERITIER [EMAIL PROTECTED] To: Struts Developers List [EMAIL PROTECTED] Sent: Saturday, October 02, 2004 10:43 AM Subject: Struts + Maven + SVN repository connectionscm|svn|http|//svn.apache.org/repos/asf/struts/trunk/connection developerConnectionscm|svn|https|//my-site.org/ repos/asf/struts/trunk/developerConnection urlhttp://svn.apache.org/repos/asf/struts/trunk/url /repository You must also add this property before to enable the changelog plugin: maven.changelog.factory = org.apache.maven.svnlib.SvnChangeLogFactory I tested it and it works. I attached the diff file. Arnaud [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: rev 51803 - struts/trunk
Author: jmitchell Date: Sat Oct 2 08:20:57 2004 New Revision: 51803 Modified: struts/trunk/project.properties struts/trunk/project.xml Log: Fix for maven build since conversion to svn - Thank you Arnaud Modified: struts/trunk/project.properties == --- struts/trunk/project.properties (original) +++ struts/trunk/project.properties Sat Oct 2 08:20:57 2004 @@ -1,7 +1,7 @@ # --- # P R O J E C T P R O P E R T I E S - Modeled after Turbine project.properties # -# $Id: project.properties,v 1.13 2004/08/14 00:08:48 husted Exp $ +# $Id$ # # Do not change this file. Please use build.properties in this directory # to do site or installation specific changes to the project build. @@ -125,3 +125,7 @@ # in order to deploy to the repository: #ssh configuration settings just require your apache id to log on with #maven.username=apache-user-name (DON'T UNCOMMENT THIS LINE IN SHARED project.propert + +maven.changelog.factory = org.apache.maven.svnlib.SvnChangeLogFactory + + Modified: struts/trunk/project.xml == --- struts/trunk/project.xml(original) +++ struts/trunk/project.xmlSat Oct 2 08:20:57 2004 @@ -22,13 +22,11 @@ siteAddressstruts.apache.org/siteAddress siteDirectory/www/jakarta.apache.org/struts/siteDirectory distributionDirectory/www/apache.mirrors.pair.com/jakarta/struts//distributionDirectory -!-- repository -connectionscm:cvs:pserver:[EMAIL PROTECTED]:/home/cvspublic:jakarta-struts/connection -developerConnectionscm:cvs:pserver:[EMAIL PROTECTED]:/home/cvs:jakarta-struts/developerConnection -urlhttp://cvs.apache.org/viewcvs/jakarta-struts//url +connectionscm|svn|http|//svn.apache.org/repos/asf/struts/trunk/connection + developerConnectionscm|svn|https|//svn.apache.org/repos/asf/struts/trunk/developerConnection +urlhttp://svn.apache.org/repos/asf/struts/trunk/url /repository - -- versions version id1.0.2/id @@ -370,7 +368,7 @@ reportmaven-jdepend-plugin/report reportmaven-checkstyle-plugin/report reportmaven-changes-plugin/report -!-- reportmaven-changelog-plugin/report -- +reportmaven-changelog-plugin/report reportmaven-file-activity-plugin/report reportmaven-developer-activity-plugin/report reportmaven-javadoc-plugin/report - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[Apache Struts Wiki] Updated: StrutsCatalogLazyList
Date: 2004-10-02T10:29:22
Editor: HubertRabago [EMAIL PROTECTED]
Wiki: Apache Struts Wiki
Page: StrutsCatalogLazyList
URL: http://wiki.apache.org/struts/StrutsCatalogLazyList
Introduce the nested tags alternative.
Change Log:
--
@@ -33,6 +33,20 @@
When the form is submitted BeanUtils will first call the getSkills(index) method to
retrieve the indexed bean followed by setSkillId(..) on the retrieved bean.
+
+=== Using nested tags ===
+
+An easy-to-use alternative to the html iterate tag and indexed attribute are the
nested tags. The nested tag equivalent of the example above would be:
+
+{{{
+ nested:iterate property=skills
+ nested:text property=skillId/
+ /nested:iterate
+}}}
+
+The generated html would be the same.
+
+
== Lazy List Behaviour ==
A common problem with indexed properties, is that people then get index out of
range errors with ActionForms that are in Request scope. The indexed property (List
or Array) needs to be able to automatically ''grow'' during the ActionForm population
process. The key to achieving this is in the get(index) method.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
SVN keywords (was Re: svn commit: rev 51787 - struts/trunk/conf/share)
It looks like we'll need to change the keywords, since SVN uses a different set. ;-( The SVN keywords are documented here: http://svnbook.red-bean.com/svnbook-1.1/ch07s02.html#svn-ch-7-sect-2.3.4 I would suggest that we drop all of what we are using now (Header, Revision and Date) and simply use Id, which is a compressed combination of the other keywords. As fas as I can tell, it's essentially the same as Id on CVS, which is what I tend to use when the choice is up to me. But let's make sure we agree before making sweeping changes! ;-) -- Martin Cooper On Sat, 2 Oct 2004 08:34:50 -0400, James Mitchell [EMAIL PROTECTED] wrote: So, what's up with key word expansion? My change to that file, was to add a space, remove it, then save it. On commit I see that $Date$ was changed, and locally it was expanded correctly, but 'Header' and 'Revision' were not. Is there some svn configuration change we are missing or do we need to change the key words? -- James Mitchell Software Engineer / Open Source Evangelist EdgeTech, Inc. 678.910.8017 AIM: jmitchtx - Original Message - From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Friday, October 01, 2004 11:17 PM Subject: svn commit: rev 51787 - struts/trunk/conf/share Author: jmitchell Date: Fri Oct 1 20:17:23 2004 New Revision: 51787 Modified: struts/trunk/conf/share/validator-rules.xml Log: no changes, just testing Modified: struts/trunk/conf/share/validator-rules.xml == --- struts/trunk/conf/share/validator-rules.xml (original) +++ struts/trunk/conf/share/validator-rules.xml Fri Oct 1 20:17:23 2004 @@ -4,7 +4,7 @@ !-- $Header: /home/cvs/jakarta-struts/conf/share/validator-rules.xml,v 1.52 2004/07/25 12:00:20 niallp Exp $ $Revision: 1.52 $ - $Date: 2004/07/25 12:00:20 $ + $Date$ This file contains the default Struts Validator pluggable validator definitions. It should be placed somewhere under /WEB-INF and - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: SVN keywords (was Re: svn commit: rev 51787 - struts/trunk/conf/share)
I'm +1 for $Id$. Craig On Sat, 2 Oct 2004 11:21:59 -0700, Martin Cooper [EMAIL PROTECTED] wrote: It looks like we'll need to change the keywords, since SVN uses a different set. ;-( The SVN keywords are documented here: http://svnbook.red-bean.com/svnbook-1.1/ch07s02.html#svn-ch-7-sect-2.3.4 I would suggest that we drop all of what we are using now (Header, Revision and Date) and simply use Id, which is a compressed combination of the other keywords. As fas as I can tell, it's essentially the same as Id on CVS, which is what I tend to use when the choice is up to me. But let's make sure we agree before making sweeping changes! ;-) -- Martin Cooper On Sat, 2 Oct 2004 08:34:50 -0400, James Mitchell [EMAIL PROTECTED] wrote: So, what's up with key word expansion? My change to that file, was to add a space, remove it, then save it. On commit I see that $Date$ was changed, and locally it was expanded correctly, but 'Header' and 'Revision' were not. Is there some svn configuration change we are missing or do we need to change the key words? -- James Mitchell Software Engineer / Open Source Evangelist EdgeTech, Inc. 678.910.8017 AIM: jmitchtx - Original Message - From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Friday, October 01, 2004 11:17 PM Subject: svn commit: rev 51787 - struts/trunk/conf/share Author: jmitchell Date: Fri Oct 1 20:17:23 2004 New Revision: 51787 Modified: struts/trunk/conf/share/validator-rules.xml Log: no changes, just testing Modified: struts/trunk/conf/share/validator-rules.xml == --- struts/trunk/conf/share/validator-rules.xml (original) +++ struts/trunk/conf/share/validator-rules.xml Fri Oct 1 20:17:23 2004 @@ -4,7 +4,7 @@ !-- $Header: /home/cvs/jakarta-struts/conf/share/validator-rules.xml,v 1.52 2004/07/25 12:00:20 niallp Exp $ $Revision: 1.52 $ - $Date: 2004/07/25 12:00:20 $ + $Date$ This file contains the default Struts Validator pluggable validator definitions. It should be placed somewhere under /WEB-INF and - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[Apache Struts Wiki] Updated: StrutsCatalogLazyList
Date: 2004-10-02T11:41:05 Editor: NiallPemberton [EMAIL PROTECTED] Wiki: Apache Struts Wiki Page: StrutsCatalogLazyList URL: http://wiki.apache.org/struts/StrutsCatalogLazyList no comment Change Log: -- @@ -46,6 +46,7 @@ The generated html would be the same. +'''N.B.''' More info on using 'nested' tags is available [http://struts.apache.org/api/org/apache/struts/taglib/nested/package-summary.html#package_description here]. == Lazy List Behaviour == - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: rev 51809 - struts/trunk/doc/faqs
Author: martinc Date: Sat Oct 2 11:54:43 2004 New Revision: 51809 Modified: struts/trunk/doc/faqs/newbie.xml Log: Convert a tab to spaces. The Gump buid was failing, even when mine was not, and this is the only thing I could see at the location flagged that was different from anything else. With any luck, Gump will be happy now. Modified: struts/trunk/doc/faqs/newbie.xml == --- struts/trunk/doc/faqs/newbie.xml(original) +++ struts/trunk/doc/faqs/newbie.xmlSat Oct 2 11:54:43 2004 @@ -41,7 +41,7 @@ a href=#actionFormsWhither ActionForms?/a /li - li +li a href=#actionFormInterfaceWhy is ActionForm a base class rather than an interface?/a /li - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: SVN keywords (was Re: svn commit: rev 51787 - struts/trunk/conf/share)
On Sat, 2 Oct 2004 11:21:59 -0700, Martin Cooper [EMAIL PROTECTED] wrote: I would suggest that we drop all of what we are using now (Header, Revision and Date) and simply use Id, which is a compressed combination of the other keywords. As fas as I can tell, it's essentially the same as Id on CVS, which is what I tend to use when the choice is up to me. +1 for $Id$ -- Joe Germuska [EMAIL PROTECTED] http://blog.germuska.com In fact, when I die, if I don't hear 'A Love Supreme,' I'll turn back; I'll know I'm in the wrong place. - Carlos Santana - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31514] New: - Either insufficient docs on validwhen or a bug
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31514. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31514 Either insufficient docs on validwhen or a bug Summary: Either insufficient docs on validwhen or a bug Product: Struts Version: 1.2.4 Platform: PC OS/Version: Windows XP Status: NEW Severity: Major Priority: Other Component: Validator Framework AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] There are six fields in the form I receive. All are required and integers. I try to use validwhen to validate one of them against the others in the following way: field property=END_DATE_DAY depends=required,integer,validwhen arg0 key=End day resource=false/ msg name=validwhen key=errors.startEndDate2 resource=true/ var var-nametest/var-name var-value((*this* = START_DATE_DAY) or ((END_DATE_MONTH - START_DATE_MONTH) (12 * (START_DATE_YEAR - END_DATE_YEAR/var-value /var /field The idea is quite simple, 'start date' cannot be later than 'end date'. As a result this does not work, even if (*this* = START_DATE_DAY) is true. The documentation on validwhen is negligible. That is why I could not figure out whether it is a bug or unsupported feature. Anyway, more documentation should be provided on the feature, at least in Javadocs. Thanks! - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31514] - Either insufficient docs on validwhen or a bug
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31514. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31514 Either insufficient docs on validwhen or a bug --- Additional Comments From [EMAIL PROTECTED] 2004-10-03 03:11 --- Saying it doesn't work isn't enough information - you need to say what happens. Does it always pass validation, fail validation or throw some kind of error? I would suggest trying it with something simpler - maybe just the (*this* = START_DATE_DAY) test first and see if that works. Have you looked at the Designing Complex Validations with validwhen section in the User Guide: http://struts.apache.org/userGuide/dev_validator.html - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31514] - Either insufficient docs on validwhen or a bug
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31514. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31514 Either insufficient docs on validwhen or a bug --- Additional Comments From [EMAIL PROTECTED] 2004-10-03 03:47 --- Sorry for being inaccurate. What I meant is that it never passes validation. After a more deep testing session I figured out what the problem was. Seems like I got confused by the phrase from the docs: If both items to be compared are convertable to ints, a numeric comparison is done, otherwise a string comparison is done. Especially the word 'convertable'. The values are integers but are stored in the form bean as strings. That's why for example 14 comes before 2 and made me think that the validator always returned false. Thank you! - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31514] - Either insufficient docs on validwhen or a bug
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31514. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31514 Either insufficient docs on validwhen or a bug --- Additional Comments From [EMAIL PROTECTED] 2004-10-03 03:50 --- Still, I think that this correlation between types in form beans and validwhen expressions should be mentioned in the docs. Thanks! - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31468] - Wrong code in struts-blank example with struts1.2.4
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31468. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31468 Wrong code in struts-blank example with struts1.2.4 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||DUPLICATE --- Additional Comments From [EMAIL PROTECTED] 2004-10-03 03:53 --- *** This bug has been marked as a duplicate of 31399 *** - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31399] - blank struts webapp
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31399. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31399 blank struts webapp [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2004-10-03 03:53 --- *** Bug 31468 has been marked as a duplicate of this bug. *** - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31514] - Either insufficient docs on validwhen or a bug
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31514. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31514 Either insufficient docs on validwhen or a bug [EMAIL PROTECTED] changed: What|Removed |Added Severity|Major |Enhancement Component|Validator Framework |Documentation --- Additional Comments From [EMAIL PROTECTED] 2004-10-03 04:16 --- I think you're right the phrase you mention does imply that in your case a numeric coomparison should have been done - both your Strings are convertable to Integers. Looking at the ValidWhenParser.g source file - it only tries to do a numeric comparison when at least one of the items is an Integer. Either, as you say, the docs need clarifying - or change validwhen to try to convert both Strings to Integer. IMO changing validwhen would be a good option as this is probably a common scenario (all my ActionForm's are String properties). Niall - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31514] - Either insufficient docs on validwhen or a bug
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31514. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31514 Either insufficient docs on validwhen or a bug --- Additional Comments From [EMAIL PROTECTED] 2004-10-03 05:28 --- Sorry for bothering again, but I think that the same problem occurs again with Integer and even primitive int types. The validator does string comparison anyway. I've looked through the code and it seems that all starts before ValidWhenParser.g Studying the stack trace I noticed that the getter methods of my ValidatorForm are invoked only by org.apache.commons.validator.util.ValidatorUtils.getValueAsString (ValidatorUtils.java:105) If you look at the method validateValidWhen in class ValidWhen (line 69) the field value is converted to String regardless of its initial type (lines 78 and 94-98). And the line 77 - validator.getParameterValue(Validator.BEAN_PARAM) - seems quite mysterious to me, might be just the part I'm missing. So the problem might be caused by wrong type recognition by the ValidWhenParser and it does string comparison. Struts version: 1.2.4 Thanks again! - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: rev 51823 - struts/trunk/src/share/org/apache/struts/validator/validwhen
Author: niallp
Date: Sat Oct 2 22:42:01 2004
New Revision: 51823
Modified:
struts/trunk/src/share/org/apache/struts/validator/validwhen/ValidWhenParser.g
struts/trunk/src/share/org/apache/struts/validator/validwhen/ValidWhenParser.java
Log:
Bug 31514 Do numeric compare when both items convertable to Integer - reported by
Yegor Jbanov
Modified:
struts/trunk/src/share/org/apache/struts/validator/validwhen/ValidWhenParser.g
==
--- struts/trunk/src/share/org/apache/struts/validator/validwhen/ValidWhenParser.g
(original)
+++ struts/trunk/src/share/org/apache/struts/validator/validwhen/ValidWhenParser.g
Sat Oct 2 22:42:01 2004
@@ -2,7 +2,7 @@
/*
* $Header:
/home/cvs/jakarta-struts/src/share/org/apache/struts/validator/validwhen/ValidWhenParser.g,v
1.7 2004/09/03 18:06:58 niallp Exp $
* $Revision: 1.7 $
- * $Date: 2004/09/03 18:06:58 $
+ * $Date$
*
* Copyright 2003-2004 The Apache Software Foundation.
*
@@ -77,8 +77,12 @@
return (v1 != v2);
}
}
-if (!Integer.class.isInstance(v1)
- !Integer.class.isInstance(v2)) {
+ if ((Integer.class.isInstance(v1) ||
+ String.class.isInstance(v1))
+ (Integer.class.isInstance(v2) ||
+ String.class.isInstance(v2))) {
+ intCompare = true;
+ } else {
intCompare = false;
}
if (intCompare) {
Modified:
struts/trunk/src/share/org/apache/struts/validator/validwhen/ValidWhenParser.java
==
--- struts/trunk/src/share/org/apache/struts/validator/validwhen/ValidWhenParser.java
(original)
+++ struts/trunk/src/share/org/apache/struts/validator/validwhen/ValidWhenParser.java
Sat Oct 2 22:42:01 2004
@@ -1,9 +1,9 @@
// $ANTLR 2.7.2: ValidWhenParser.g - ValidWhenParser.java$
/*
- * $Header:
/home/cvs/jakarta-struts/src/share/org/apache/struts/validator/validwhen/ValidWhenParser.java,v
1.10 2004/09/03 18:06:58 niallp Exp $
- * $Revision: 1.10 $
- * $Date: 2004/09/03 18:06:58 $
+ * $Header:
/home/cvs/jakarta-struts/src/share/org/apache/struts/validator/validwhen/ValidWhenParser.g,v
1.7 2004/09/03 18:06:58 niallp Exp $
+ * $Revision: 1.7 $
+ * $Date$
*
* Copyright 2003-2004 The Apache Software Foundation.
*
@@ -89,8 +89,12 @@
return (v1 != v2);
}
}
-if (!Integer.class.isInstance(v1)
- !Integer.class.isInstance(v2)) {
+ if ((Integer.class.isInstance(v1) ||
+ String.class.isInstance(v1))
+ (Integer.class.isInstance(v2) ||
+ String.class.isInstance(v2))) {
+ intCompare = true;
+ } else {
intCompare = false;
}
if (intCompare) {
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: rev 51824 - struts/trunk/src/test/org/apache/struts/validator
Author: niallp Date: Sat Oct 2 22:49:55 2004 New Revision: 51824 Modified: struts/trunk/src/test/org/apache/struts/validator/TestValidWhen.java Log: Add validwhen test to compare two Strings containing numbers Modified: struts/trunk/src/test/org/apache/struts/validator/TestValidWhen.java == --- struts/trunk/src/test/org/apache/struts/validator/TestValidWhen.java (original) +++ struts/trunk/src/test/org/apache/struts/validator/TestValidWhen.javaSat Oct 2 22:49:55 2004 @@ -1,7 +1,7 @@ /* * $Header: /home/cvs/jakarta-struts/src/test/org/apache/struts/validator/TestValidWhen.java,v 1.1 2004/09/03 18:12:26 niallp Exp $ * $Revision: 1.1 $ - * $Date: 2004/09/03 18:12:26 $ + * $Date$ * * Copyright 2004 The Apache Software Foundation. * @@ -176,6 +176,11 @@ // Octal doParse((integerValue1 == 0173), testBean , 0, integerValue1, true); + +// Test 'String' numbers +PojoBean stringBean = new PojoBean(11, 2); +doParse((stringValue1 stringValue2), stringBean , 0, stringValue1, true); +doParse((stringValue1 stringValue2), stringBean , 0, stringValue1, false); } - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31514] - Either insufficient docs on validwhen or a bug
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31514. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31514 Either insufficient docs on validwhen or a bug --- Additional Comments From [EMAIL PROTECTED] 2004-10-03 05:55 --- I've changed validwhen so that if the items are either Strings or Integers it tries to do a numeric compare. It works for two Strings containing numbers - and I believe it will resolve the issue you're raising about converting the field to a String. It should be available in the next nightly build (dated 3rd October 2004) - if you could try that build out I would appreciate it. It should be available here in a few hours time: http://cvs.apache.org/builds/jakarta-struts/nightly/ Niall - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
