[GitHub] struts pull request: New result 'JSONActionRedirectResult' in json...

[cnenning]

Github user cnenning commented on the pull request:

https://github.com/apache/struts/pull/72#issuecomment-172772942
  
> Merged #72.


Yay, I got it landed :)



This Email was scanned by Sophos Anti Virus



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

[GitHub] struts pull request: WW-4589 do not overwrite explicit method name

[rpii]

GitHub user rpii opened a pull request:

https://github.com/apache/struts/pull/81

WW-4589 do not overwrite explicit method name

Lukasz,

here is a proposed fix for WW-4589.  This makes sure a url specified method 
name is not overwritten by an implied method name.  It passes the unit tests 
that I have added

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rpii/struts WW-4589

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/struts/pull/81.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #81


commit 1fb695a82b589cdd6e7b5bc2501dfec6b95c906e
Author: petersr 
Date:   2016-01-19T22:02:57Z

WW-4589 do not overwrite explicit method name




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

Build failed in Jenkins: Struts-JDK8-master #78

[Apache Jenkins Server]

See 

Changes:

[cnenning] Adds new result 'JSONActionRedirectResult' to json-plugin. Contains

[cnenning] made methods non static and private, javadoc updates

[cnenning] increased visibilty of methods and constants for better extensibility

--
[...truncated 90694 lines...]
[INFO] Uploaded: 
https://repository.apache.org/content/repositories/snapshots/org/apache/struts/struts2-dwr-plugin/2.5-SNAPSHOT/struts2-dwr-plugin-2.5-20160119.225058-131.jar
 (11 KB at 71.8 KB/sec)
[INFO] Uploading: 
https://repository.apache.org/content/repositories/snapshots/org/apache/struts/struts2-dwr-plugin/2.5-SNAPSHOT/struts2-dwr-plugin-2.5-20160119.225058-131.pom
[INFO] Uploaded: 
https://repository.apache.org/content/repositories/snapshots/org/apache/struts/struts2-dwr-plugin/2.5-SNAPSHOT/struts2-dwr-plugin-2.5-20160119.225058-131.pom
 (2 KB at 11.9 KB/sec)
[INFO] Downloading: 
https://repository.apache.org/content/repositories/snapshots/org/apache/struts/struts2-dwr-plugin/maven-metadata.xml
[INFO] Downloaded: 
https://repository.apache.org/content/repositories/snapshots/org/apache/struts/struts2-dwr-plugin/maven-metadata.xml
 (2 KB at 8.3 KB/sec)
[INFO] Uploading: 
https://repository.apache.org/content/repositories/snapshots/org/apache/struts/struts2-dwr-plugin/2.5-SNAPSHOT/maven-metadata.xml
[INFO] Uploaded: 
https://repository.apache.org/content/repositories/snapshots/org/apache/struts/struts2-dwr-plugin/2.5-SNAPSHOT/maven-metadata.xml
 (2 KB at 7.3 KB/sec)
[INFO] Uploading: 
https://repository.apache.org/content/repositories/snapshots/org/apache/struts/struts2-dwr-plugin/maven-metadata.xml
[INFO] Uploaded: 
https://repository.apache.org/content/repositories/snapshots/org/apache/struts/struts2-dwr-plugin/maven-metadata.xml
 (2 KB at 6.6 KB/sec)
[INFO] Uploading: 
https://repository.apache.org/content/repositories/snapshots/org/apache/struts/struts2-dwr-plugin/2.5-SNAPSHOT/struts2-dwr-plugin-2.5-20160119.225058-131-sources.jar
[INFO] Uploaded: 
https://repository.apache.org/content/repositories/snapshots/org/apache/struts/struts2-dwr-plugin/2.5-SNAPSHOT/struts2-dwr-plugin-2.5-20160119.225058-131-sources.jar
 (8 KB at 48.3 KB/sec)
[INFO] Uploading: 
https://repository.apache.org/content/repositories/snapshots/org/apache/struts/struts2-dwr-plugin/2.5-SNAPSHOT/maven-metadata.xml
[INFO] Uploaded: 
https://repository.apache.org/content/repositories/snapshots/org/apache/struts/struts2-dwr-plugin/2.5-SNAPSHOT/maven-metadata.xml
 (2 KB at 9.2 KB/sec)
[INFO] Uploading: 
https://repository.apache.org/content/repositories/snapshots/org/apache/struts/struts2-dwr-plugin/2.5-SNAPSHOT/struts2-dwr-plugin-2.5-20160119.225058-131-javadoc.jar
[INFO] Uploaded: 
https://repository.apache.org/content/repositories/snapshots/org/apache/struts/struts2-dwr-plugin/2.5-SNAPSHOT/struts2-dwr-plugin-2.5-20160119.225058-131-javadoc.jar
 (32 KB at 200.4 KB/sec)
[INFO] Uploading: 
https://repository.apache.org/content/repositories/snapshots/org/apache/struts/struts2-dwr-plugin/2.5-SNAPSHOT/maven-metadata.xml
[INFO] Uploaded: 
https://repository.apache.org/content/repositories/snapshots/org/apache/struts/struts2-dwr-plugin/2.5-SNAPSHOT/maven-metadata.xml
 (2 KB at 8.8 KB/sec)
[INFO] 
[INFO] 
[INFO] Building Struts 2 Tiles Plugin 2.5-SNAPSHOT
[INFO] 
[INFO] 
[INFO] >>> maven-source-plugin:2.3:jar (default-cli) @ struts2-tiles-plugin >>>
[WARNING] Failed to notify spy hudson.maven.Maven3Builder$JenkinsEventSpy: null
[INFO] 
[INFO] <<< maven-source-plugin:2.3:jar (default-cli) @ struts2-tiles-plugin <<<
[INFO] Downloading: 
http://repo.maven.apache.org/maven2/org/apache/tiles/tiles-api/3.0.5/tiles-api-3.0.5.pom
[INFO] Downloaded: 
http://repo.maven.apache.org/maven2/org/apache/tiles/tiles-api/3.0.5/tiles-api-3.0.5.pom
 (4 KB at 24.1 KB/sec)
[INFO] Downloading: 
http://repo.maven.apache.org/maven2/org/apache/tiles/tiles-parent/3.0.5/tiles-parent-3.0.5.pom
[INFO] Downloaded: 
http://repo.maven.apache.org/maven2/org/apache/tiles/tiles-parent/3.0.5/tiles-parent-3.0.5.pom
 (16 KB at 210.1 KB/sec)
[INFO] Downloading: 
http://repo.maven.apache.org/maven2/org/apache/tiles/tiles-master/6/tiles-master-6.pom
[INFO] Downloaded: 
http://repo.maven.apache.org/maven2/org/apache/tiles/tiles-master/6/tiles-master-6.pom
 (12 KB at 210.6 KB/sec)
[INFO] Downloading: 
http://repo.maven.apache.org/maven2/org/apache/tiles/tiles-request-api/1.0.6/tiles-request-api-1.0.6.pom
[INFO] Downloaded: 
http://repo.maven.apache.org/maven2/org/apache/tiles/tiles-request-api/1.0.6/tiles-request-api-1.0.6.pom
 (2 KB at 29.5 KB/sec)
[INFO] Downloading: 
http://repo.maven.apache.org/maven2/org/apache/tiles/tiles-request/1.0.6/tiles-request-1.0.6.pom
[INFO] Downloaded: 

Re: [GitHub] struts pull request: WW-4590 - Allow to use multiple names in resu...

[Chris Pratt]

I can't see a reason not to support both.
  (*Chris*)

On Tue, Jan 19, 2016 at 12:06 PM, swiftelan  wrote:

> Github user swiftelan commented on the pull request:
>
> https://github.com/apache/struts/pull/75#issuecomment-172970495
>
> @aleksandr-m
>
> An annotation attribute that is defined as an array does not have to
> have the curly braces to define a single value for that attribute.
>
> Basing a Java API for configuration on XML syntax is a poor
> implementation. Why not support the entire XML configuration syntax in the
> annotation? Java has APIs to express a collection of items. It is much
> easier to utilize an array than a comma separated value attribute. The
> array allows the developer to clearly express their intent. Utilizing an
> array does not require parsing when the configuration value is accessed.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
> For additional commands, e-mail: dev-h...@struts.apache.org
>
>

[GitHub] struts pull request: WW-4590 - Allow to use multiple names in resu...

[aleksandr-m]

Github user aleksandr-m commented on the pull request:

https://github.com/apache/struts/pull/75#issuecomment-172982203
  
@swiftelan So you are proposing to change only type? The name of the 
attribute will stay the same i.e `name`, right? There is still some chance that 
something going to break, note that `ResultInfo` depends on `Result`'s `name`. 
But it is better than changing the name.

@lukaszlenart WDYT about changing `Result`'s `name` to `String[] name() 
default com.opensymphony.xwork2.Action.SUCCESS;` and probably removing `public 
ResultInfo(Result, PackageConfig, String, Class, Map)` constructor?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

[GitHub] struts pull request: WW-4590 - Allow to use multiple names in resu...

[aleksandr-m]

Github user aleksandr-m commented on a diff in the pull request:

https://github.com/apache/struts/pull/75#discussion_r50173826
  
--- Diff: 
core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java
 ---
@@ -777,11 +777,21 @@ protected Class verifyResultType(String className, 
Location loc) {
 }
 params.putAll(resultParams);
 
-ResultConfig resultConfig = new 
ResultConfig.Builder(resultName, resultClass)
-.addParams(params)
-.location(DomHelper.getLocationObject(element))
-.build();
-results.put(resultConfig.getName(), resultConfig);
+Set resultNamesSet;
+if (",".equals(resultName.trim())) {
+resultNamesSet = new HashSet<>(1);
+resultNamesSet.add(resultName);
--- End diff --

It looks a bit odd, agree. :) But it is supported right now and it is 
better than mapping `,` to `success` or not creating result at all.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

[GitHub] struts pull request: WW-4590 - Allow to use multiple names in resu...

[lukaszlenart]

Github user lukaszlenart commented on a diff in the pull request:

https://github.com/apache/struts/pull/75#discussion_r50163270
  
--- Diff: 
core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java
 ---
@@ -777,11 +777,21 @@ protected Class verifyResultType(String className, 
Location loc) {
 }
 params.putAll(resultParams);
 
-ResultConfig resultConfig = new 
ResultConfig.Builder(resultName, resultClass)
-.addParams(params)
-.location(DomHelper.getLocationObject(element))
-.build();
-results.put(resultConfig.getName(), resultConfig);
+Set resultNamesSet;
+if (",".equals(resultName.trim())) {
+resultNamesSet = new HashSet<>(1);
+resultNamesSet.add(resultName);
--- End diff --

No, I think why `,` is a valid result name :) But that's ok, I mean your 
proposal :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

[GitHub] struts pull request: WW-4590 - Allow to use multiple names in resu...

[lukaszlenart]

Github user lukaszlenart commented on a diff in the pull request:

https://github.com/apache/struts/pull/75#discussion_r50221451
  
--- Diff: 
core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java
 ---
@@ -777,11 +777,21 @@ protected Class verifyResultType(String className, 
Location loc) {
 }
 params.putAll(resultParams);
 
-ResultConfig resultConfig = new 
ResultConfig.Builder(resultName, resultClass)
-.addParams(params)
-.location(DomHelper.getLocationObject(element))
-.build();
-results.put(resultConfig.getName(), resultConfig);
+Set resultNamesSet;
+if (",".equals(resultName.trim())) {
+resultNamesSet = new HashSet<>(1);
+resultNamesSet.add(resultName);
--- End diff --

Right, thanks for explanation!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

[GitHub] struts pull request: WW-4590 - Allow to use multiple names in resu...

[lukaszlenart]

Github user lukaszlenart commented on the pull request:

https://github.com/apache/struts/pull/75#issuecomment-173117164
  
@aleksandr-m I'm ok with that and I agree with @swiftelan - let's follow 
standards


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

[GitHub] struts pull request: WW-4412 Context started without being closed

[lukaszlenart]

Github user lukaszlenart commented on a diff in the pull request:

https://github.com/apache/struts/pull/79#discussion_r50108754
  
--- Diff: 
plugins/tiles/src/main/java/org/apache/struts2/views/tiles/TilesResult.java ---
@@ -110,7 +110,9 @@ public void doExecute(String location, ActionInvocation 
invocation) throws Excep
 HttpServletResponse httpResponse = 
ServletActionContext.getResponse();
 
 Request request = new ServletRequest(applicationContext, 
httpRequest, httpResponse);
-
+
+container.startContext(request);
 container.render(location, request);
+container.endContext(request);
--- End diff --

This isn't needed, `container.render` starts and ends context.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

[GitHub] struts pull request: WW-4412 Context started without being closed

[victorsosa]

GitHub user victorsosa opened a pull request:

https://github.com/apache/struts/pull/79

WW-4412  Context started without being closed

Patch for WW-4412

Context started without being closed

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/victorsosa/struts patch

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/struts/pull/79.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #79


commit 6bc2afbc5d39902c26afa957533872a0e2dd38e3
Author: Lukasz Lenart 
Date:   2016-01-18T14:55:59Z

WW-4412
Context started without being closed

Now it is started and closed

commit c167d6c855f9f3f5863d8fa20ab45aa28cb77486
Author: victor sosa 
Date:   2016-01-19T12:25:29Z

Merge pull request #1 from apache/master

update pull

commit af42137b539cadca21413c7a438e258a844b3dbb
Author: victor sosa 
Date:   2016-01-19T12:30:07Z

Merge pull request #2 from victorsosa/master

update pull




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

[GitHub] struts pull request: WW-4456 Got NPE when File Upload Limitation e...

[victorsosa]

GitHub user victorsosa opened a pull request:

https://github.com/apache/struts/pull/80

WW-4456 Got NPE when File Upload Limitation exceeds in portal env



HI Lukasz,

This is a proposal to fix WW-4456 - Got NPE when File Upload Limitation 
exceeds in portal env.

We should catch in any case a FileUploadException, then try to cast down if 
we want any info about the exception. Valid subtype of FileUploadException:
InvalidContentTypeException
IOFileUploadException
SizeLimitExceededException
FileSizeLimitExceededException

I couldn't get the complete test on a running test env, because I had 
issues getting the logging to work.

But it seems to works.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/victorsosa/struts ww-4456

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/struts/pull/80.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #80


commit c167d6c855f9f3f5863d8fa20ab45aa28cb77486
Author: victor sosa 
Date:   2016-01-19T12:25:29Z

Merge pull request #1 from apache/master

update pull

commit bc8d37464756bf821acae003c6a140af6dcbaf09
Author: Victor Sosa 
Date:   2016-01-19T12:54:15Z

WW-4456 - Got NPE when File Upload Limitation exceeds in portal env.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

[GitHub] struts pull request: WW-4412 Context started without being closed

[victorsosa]

Github user victorsosa closed the pull request at:

https://github.com/apache/struts/pull/79


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

[GitHub] struts pull request: WW-4412 Context started without being closed

[victorsosa]

Github user victorsosa commented on a diff in the pull request:

https://github.com/apache/struts/pull/79#discussion_r50120845
  
--- Diff: 
plugins/tiles/src/main/java/org/apache/struts2/views/tiles/TilesResult.java ---
@@ -110,7 +110,9 @@ public void doExecute(String location, ActionInvocation 
invocation) throws Excep
 HttpServletResponse httpResponse = 
ServletActionContext.getResponse();
 
 Request request = new ServletRequest(applicationContext, 
httpRequest, httpResponse);
-
+
+container.startContext(request);
 container.render(location, request);
+container.endContext(request);
--- End diff --

OK, i will close the PR then :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

[GitHub] struts pull request: Locale aware converters

[lukaszlenart]

Github user lukaszlenart closed the pull request at:

https://github.com/apache/struts/pull/37


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

[GitHub] struts pull request: WW-4412 Context started without being closed

[lukaszlenart]

Github user lukaszlenart commented on the pull request:

https://github.com/apache/struts/pull/79#issuecomment-172878561
  
Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

Re: Struts 2.5 BETA3

[Lukasz Lenart]

I see no objections, starting with BETA3

2016-01-18 15:58 GMT+01:00 Lukasz Lenart :
> If no objections I am going prepare BETA3 release
>
> 2016-01-11 14:53 GMT+01:00 Christoph Nenning :
>>> @Christoph I was able to resolve the issue with that warning about
>>> Custom EL ... also fixed the problem with loading ftl layouts - you
>>> must define a proper templateType ->
>>> https://github.com/lukaszlenart/struts2-tiles-demo/commit/
>>> dc52bc82895dc664ff0db0bb8ca330a13e48c169
>>> - I will add this to docs and I can port this example to be part of
>>> the struts-examples
>>>
>>
>>
>> Ahh, now I see it ;)
>>
>>
>>
>> This Email was scanned by Sophos Anti

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

[GitHub] struts pull request: WW-4590 - Allow to use multiple names in resu...

[swiftelan]

Github user swiftelan commented on the pull request:

https://github.com/apache/struts/pull/75#issuecomment-172880314
  
Annotations allow multivalued attributes in the form of arrays. Using this 
makes it obvious that you can supply multiple result names for a single result 
configuration.

@Action(results = {
@Result(name={"error", "input"}, location="input-form.jsp"),
@Result(name="success", location="success.jsp")
})




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org