[GitHub] struts pull request: WW-4594: Configure TilesDefs by annotating Ac...

[cnenning]

Github user cnenning commented on a diff in the pull request:

https://github.com/apache/struts/pull/85#discussion_r50693282
  
--- Diff: 
plugins/tiles/src/test/java/org/apache/struts2/tiles/TestStrutsTilesAnnotationProcessor.java
 ---
@@ -0,0 +1,148 @@
+package org.apache.struts2.tiles;
+
+import java.util.List;
+import java.util.Set;
+
+import org.apache.struts2.tiles.annotation.TilesDefinition;
+import org.apache.tiles.Attribute;
+import org.apache.tiles.Definition;
+import org.apache.tiles.Expression;
+import org.junit.Test;
+
+import org.junit.Assert;
+
+public class TestStrutsTilesAnnotationProcessor {
--- End diff --

oh, of course :sweat_smile:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

[GitHub] struts pull request: WW-4594: Configure TilesDefs by annotating Ac...

[cnenning]

GitHub user cnenning opened a pull request:

https://github.com/apache/struts/pull/85

WW-4594: Configure TilesDefs by annotating Actions

Adds annotations for each element from `tiles.xml` to annotate actions. 
Those annotations are processed by a new class in tiles-plugin which is used by 
TilesResult.

With those annotations it is possible to keep `tiles.xml` very short (e.g. 
just put layout in there) and configure concrete tiles-definitions just by 
annotating actions.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cnenning/struts master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/struts/pull/85.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #85


commit d9f4054b1367cd7ab6e3f22b9cc677f62def4e83
Author: cnenning 
Date:   2016-01-22T13:59:48Z

fixed tiles showcase by setting dtd to 3.0

commit 9ac326aa2458fe43140c1b13b61c87752d282e3d
Author: cnenning 
Date:   2016-01-22T14:27:09Z

Added tiles annotations, see WW-4594.

Added tiles annotations, created StrutsTilesAnnotationProcessor to
create Definitons from them and using it in TilesResult.

commit e50c37c5ba5781900edf53f9ec71b8649471d448
Author: cnenning 
Date:   2016-01-22T14:27:50Z

added sample for tiles annotations

commit d76357fd829a3ea8ddca21d625c49b606cca88d5
Author: cnenning 
Date:   2016-01-25T10:23:10Z

added tests for StrutsTilesAnnotationProcessor

commit a53deac7ce8732053edd43dddac329448055aef0
Author: cnenning 
Date:   2016-01-25T12:39:47Z

updated javadoc

commit b1588ddc84d876a676bab66ad80ec34637e98536
Author: cnenning 
Date:   2016-01-25T12:50:45Z

fixed line endings




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

Re: [VOTE] Struts 2.5 BETA3

[Lukasz Lenart]

2016-01-22 18:26 GMT+01:00 Greg Huber :
> Best I can come up with is
> com.opensymphony.xwork2.config.implActionConfigMatcher creates a new
> ActionConfig but then only uses the default allowed names:
>
> return new ActionConfig.Builder(pkgName, orig.getName(), className)
> .methodName(methodName)
> .addParams(params)
> .addResultConfigs(results)
> .addInterceptors(orig.getInterceptors())
> .addExceptionMappings(exs)
> .location(orig.getLocation())
> .build();
>
> Could use the original by appending
> .addAllowedMethod(orig.getAllowedMethods()), but I guess it should come
> from the ActionConfig stored in the packageContext or where the orig gets
> its allowedMethods from.

Great! Thanks for locating this, could you register a ticket in JIRA?


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

Re: [CLOSED][VOTE] Struts 2.5 BETA3

[Lukasz Lenart]

Vote passed with result:

[X] Beta - 3x +1 (binding)


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

2016-01-21 14:56 GMT+01:00 Lukasz Lenart :
> The Apache Struts 2.5 BETA3 test build is now available.
>
> New in BETA1
> - XWork source was merged into Struts Core source, it means that there
> be no more xwork artifact nor dedicated jar
> - OGNL was upgraded to version 3.0.11 and it breaks access to
> properties as it follows Java Bean Specification, see WW-4207 and
> WW-3909
> - Spring dependency for tests and spring plugin was upgraded to
> version 4.1.6, see WW-4510.
> - Struts2 internal logging api was marked as deprecated and was
> replaced with new Log4j2 api as logging layer, see WW-4504.
> - Struts2 is now build with JDK7, see WW-4503.
> - New plugin to support bean validation is now part of the
> distribution, see WW-4505.
> - Deprecated plugins are now removed from the distribution and are not
> longer supported anymore.
> - - Dojo Plugin
> - - Codebehind Plugin
> - - JSF Plugin
> - - Struts1 Plugin
>
> New in BETA2
> - New security option was added - Strict Method Invocation (also known
> as Strict DMI), see WW-4540
> - Add support for latest stable AngularJS in Maven archetype, see WW-4522
>
> New in BETA3
> - Dropped support for id and name - replaced with var, see WW-2069
> - Dedicated archive with a minimal set of dependencies was introduced,
> see WW-4570
> - It is possible to use multiple names when defining a result, see WW-4590
> - Rest plugin honors Accept header, see WW-4588
> - New result 'JSONActionRedirectResult' in json-plugin was defined, see 
> WW-4591
> - Tiles plugin was upgrade to the latest Tiles 3 and tiles3-plugin was
> dropped, see WW-4584
> - JasperReports plugins was upgraded to JasperReport 6.0, see WW-4381
> - OGNL was upgraded to version 3.0.11 and it breaks access to
> properties as it follows Java Bean Specification, see WW-4207 and
> WW-3909
> - - and then OGNL was upgraded to version 3.1.1, see WW-4561
> - - and then OGNL was upgraded to version 3.2.1, see WW-4577
>
> Release notes
> * https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5
>
> Distribution:
> * https://dist.apache.org/repos/dist/dev/struts/2.5-BETA3/
>
> Maven 2 staging repository:
> * https://repository.apache.org/content/repositories/staging/
>
> Once you have had a chance to review the test build, please respond
> with a vote on its quality:
>
> [ ] Leave at test build
> [ ] Alpha
> [ ] Beta
> [ ] General Availability (GA)
>
> Everyone who has tested the build is invited to vote. Votes by PMC
> members are considered binding. A vote passes if there are at least
> three binding +1s and more +1s than -1s.
>
> The vote will remain open for at least 72 hours, longer upon request.
> A vote can be amended at any time to upgrade or downgrade the quality
> of the release based on future experience. If an initial vote
> designates the build as "Beta", the release will be submitted for
> mirroring and announced to the user list. Once released as a public
> beta, subsequent quality votes on a build may be held on the user
> list.
>
> As always, the act of voting carries certain obligations. A binding
> vote not only states an opinion, but means that the voter is agreeing
> to help do the work.
>
>
> Kind regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

Re: [VOTE] Struts 2.5 BETA3

[Greg Huber]

OK WW-4596.

I did try to find out where the orig object comes from to create pull
request, but I was unable to fathom it out. Needs better documentation in
the source.  So I guess a finial solution would be better form someone who
understands what is going on.

Cheers Greg.

On 25 January 2016 at 11:04, Lukasz Lenart  wrote:

> 2016-01-22 18:26 GMT+01:00 Greg Huber :
> > Best I can come up with is
> > com.opensymphony.xwork2.config.implActionConfigMatcher creates a new
> > ActionConfig but then only uses the default allowed names:
> >
> > return new ActionConfig.Builder(pkgName, orig.getName(), className)
> > .methodName(methodName)
> > .addParams(params)
> > .addResultConfigs(results)
> > .addInterceptors(orig.getInterceptors())
> > .addExceptionMappings(exs)
> > .location(orig.getLocation())
> > .build();
> >
> > Could use the original by appending
> > .addAllowedMethod(orig.getAllowedMethods()), but I guess it should come
> > from the ActionConfig stored in the packageContext or where the orig gets
> > its allowedMethods from.
>
> Great! Thanks for locating this, could you register a ticket in JIRA?
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
> For additional commands, e-mail: dev-h...@struts.apache.org
>
>