Re: Struts 2.3.31 & 2.5.3

2016-09-28 Thread Lukasz Lenart
2016-09-28 13:11 GMT+02:00 Johannes Geppert :
> Sounds good! :-)
>
> Does this 2.5.3 version is then based on ASM5 libs?

Yes, https://issues.apache.org/jira/browse/WW-4646


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org



Jenkins build is still unstable: Struts-JDK9-master #24

2016-09-28 Thread Apache Jenkins Server
See 


-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org



Re: Struts 2.3.31 & 2.5.3

2016-09-28 Thread Johannes Geppert
Sounds good! :-)

Does this 2.5.3 version is then based on ASM5 libs?

Best Regards

Johannes

#
web: http://www.jgeppert.com
twitter: http://twitter.com/jogep

2016-09-28 11:45 GMT+02:00 Lukasz Lenart :

> Hi,
>
> It's time to prepare new releases, please inform if you have any other
> outstanding issues that should be addressed before pushing out a new
> release :)
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
> For additional commands, e-mail: dev-h...@struts.apache.org
>
>


Struts 2.3.31 & 2.5.3

2016-09-28 Thread Lukasz Lenart
Hi,

It's time to prepare new releases, please inform if you have any other
outstanding issues that should be addressed before pushing out a new
release :)


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org



Re: [jira] [Commented] (WW-4628) Space character and includeParams

2016-09-28 Thread Lukasz Lenart
Because of reverse merges - it happens when you do merge the `master`
back into your PR branch. I'm trying to avoid doing such till I don't
have conflicts.


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

2016-09-28 10:48 GMT+02:00 Christoph Nenning :
> Why was this reverted?
>
> Obviously the revert was part of PR 108, but why?
>
>
>
>
> "ASF subversion and git services (JIRA)"  schrieb am
> 28.09.2016 10:37:21:
>
>> From: "ASF subversion and git services (JIRA)" 
>> To: iss...@struts.apache.org,
>> Date: 28.09.2016 10:37
>> Subject: [jira] [Commented] (WW-4628) Space character and includeParams
>>
>>
>> [ https://issues.apache.org/jira/browse/WW-4628?
>> page=com.atlassian.jira.plugin.system.issuetabpanels:comment-
>> tabpanel=15528913#comment-15528913 ]
>>
>> ASF subversion and git services commented on WW-4628:
>> -
>>
>> Commit d9fe1406ee287226704fdd5e3a53d59e6b0a556f in struts's branch
>> refs/heads/master from [~ghuber]
>> [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=d9fe140 ]
>>
>> Revert "WW-4628: proper decoding of parameters in query-string"
>>
>> This reverts commit ef9c66118ede16f3ff239ea864641d5bdadeecae.
>>
>>
>> > Space character and includeParams
>> > -
>> >
>> > Key: WW-4628
>> > URL: https://issues.apache.org/jira/browse/WW-4628
>> > Project: Struts 2
>> >  Issue Type: Bug
>> >Affects Versions: 2.3.28
>> >Reporter: Pierre-Yves Soblet
>> >Assignee: Christoph Nenning
>> > Fix For: 2.3.31, 2.5.3
>> >
>> > Attachments: Struts2UrlTest.zip
>> >
>> >
>> > With this JSP snippet using Struts 2 taglib:
>> > {code}
>> > myParameter=[]
>> > 
>> > 
>> > 
>> > 
>> >  value="%{#parameters['myParameter']}"/>
>> > 
>> > {code}
>> > When the action is called with a parameter containing a space
>> (which is escaped in the URL) :
>> > {code}
>> > localhost:8080/url?myParameter=with+space
>> > {code}
>> > The output is as follows :
>> > {code}
>> > myParameter=[with space]
>> > /url.action?myParameter=with%2Bspace
>> > /url.action?myParameter=with+space
>> > {code}
>> > The *includeParams* attribute of the “url” tag seems to transform
>> the "space" character into the "plus" character (both in their url-
>> encoded forms).
>>
>>
>>
>> --
>> This message was sent by Atlassian JIRA
>> (v6.3.4#6332)
>
>
> This Email was scanned by Sophos Anti Virus

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org



Re: [jira] [Commented] (WW-4628) Space character and includeParams

2016-09-28 Thread Christoph Nenning
Why was this reverted?

Obviously the revert was part of PR 108, but why?




"ASF subversion and git services (JIRA)"  schrieb am 
28.09.2016 10:37:21:

> From: "ASF subversion and git services (JIRA)" 
> To: iss...@struts.apache.org, 
> Date: 28.09.2016 10:37
> Subject: [jira] [Commented] (WW-4628) Space character and includeParams
> 
> 
> [ https://issues.apache.org/jira/browse/WW-4628?
> page=com.atlassian.jira.plugin.system.issuetabpanels:comment-
> tabpanel=15528913#comment-15528913 ] 
> 
> ASF subversion and git services commented on WW-4628:
> -
> 
> Commit d9fe1406ee287226704fdd5e3a53d59e6b0a556f in struts's branch 
> refs/heads/master from [~ghuber]
> [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=d9fe140 ]
> 
> Revert "WW-4628: proper decoding of parameters in query-string"
> 
> This reverts commit ef9c66118ede16f3ff239ea864641d5bdadeecae.
> 
> 
> > Space character and includeParams
> > -
> >
> > Key: WW-4628
> > URL: https://issues.apache.org/jira/browse/WW-4628
> > Project: Struts 2
> >  Issue Type: Bug
> >Affects Versions: 2.3.28
> >Reporter: Pierre-Yves Soblet
> >Assignee: Christoph Nenning
> > Fix For: 2.3.31, 2.5.3
> >
> > Attachments: Struts2UrlTest.zip
> >
> >
> > With this JSP snippet using Struts 2 taglib:
> > {code}
> > myParameter=[]
> > 
> > 
> > 
> > 
> > 
> > 
> > {code}
> > When the action is called with a parameter containing a space 
> (which is escaped in the URL) :
> > {code}
> > localhost:8080/url?myParameter=with+space
> > {code}
> > The output is as follows :
> > {code}
> > myParameter=[with space]
> > /url.action?myParameter=with%2Bspace
> > /url.action?myParameter=with+space 
> > {code}
> > The *includeParams* attribute of the “url” tag seems to transform 
> the "space" character into the "plus" character (both in their url-
> encoded forms).
> 
> 
> 
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)


This Email was scanned by Sophos Anti Virus


[GitHub] struts pull request #108: ConversionErrorInterceptor to extend MethodFilterI...

2016-09-28 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/struts/pull/108


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org