DO NOT REPLY [Bug 34445] - use charsets given by browser for form field encodings
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34445. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34445 [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|CLOSED --- Additional Comments From [EMAIL PROTECTED] 2007-02-25 05:10 --- see also Bug 41697 -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34445] - use charsets given by browser for form field encodings
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=34445.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=34445
--- Additional Comments From [EMAIL PROTECTED] 2006-02-11 17:52 ---
I need to look more closely at the code, but maybe replacing getString
(encoding) with getString() will do the job, since the Commons DiskFileUpload
already knows the request's character encoding.
If that doesn't work, then I think we should just use DiskFileItem's getCharSet
() method - it is public, but not part of the FileItem API. However since
CommonsMultipartRequestHandler always uses DiskFileItem - then using it should
work, something like...
String encoding = null;
if (item instanceof DiskFileItem) {
((DiskFileItem)item).getCharSet();
}
if (encoding == null) {
encoding = request.getCharacterEncoding();
}
I'll try to get back to this later
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34445] - use charsets given by browser for form field encodings
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34445. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34445 --- Additional Comments From [EMAIL PROTECTED] 2006-02-12 07:53 --- Created an attachment (id=17664) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=17664action=view) Patch for CommonsMultipartRequestHandler Doesn't look like the first option is possible, so I went for the second - using DiskFileItem's getCharSet() method. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34445] - use charsets given by browser for form field encodings
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34445. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34445 --- Additional Comments From [EMAIL PROTECTED] 2005-05-04 16:30 --- There was no intent to duplicate anything. It just appeared the easiest to use the public ParameterParser. Agreed, if the FileItem interface could be enhanced with a getCharacterEncoding(), this would be more elegant. Martin, is there any new release scheduled anytime soon? -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34445] - use charsets given by browser for form field encodings
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=34445.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=34445
--- Additional Comments From [EMAIL PROTECTED] 2005-05-04 02:08 ---
Firstly, the suggested fix is dependant on features in Commons FileUpload that
have not yet been released. Therefore this patch cannot be considered until
there has been a release of FileUpload and Struts has changed its depedency to
the new version.
Secondly, I agree with Martin regarding ParameterParser. From what I see, the
solution is duplicating the logic in DiskFileItem's getString() method, which
calls the getCharSet() method to parse the content type to determine the
charset. Maybe the getCharset() method should be part of the FileItem interface
(or getCharacterEncoding() to keep it in line with the Request's method) and
that way the solution then becomes simple
String encoding = item.getCharacterEncoding();
if (encoding == null) {
encoding = request.getCharacterEncoding();
}
Whatever the solution though, if the fix for Bug 20813 is supposed to enable
FileUpload to handle item specific character encodings, then it seems wrong to
me to have to duplicate part of that solution in Struts.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34445] - use charsets given by browser for form field encodings
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=34445. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=34445 --- Additional Comments From [EMAIL PROTECTED] 2005-04-22 05:35 --- I'd prefer not to use FileUpload's ParameterParser to handle this in Struts, since that class isn't intended to be public / used by packages other than FileUpload itself. Let me give it some thought. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
