Re: [VOTE] Apache Struts 6.0.1

2022-08-23 Thread Johannes Geppert 
Thanks a lot Lukasz!

Lukasz Lenart  schrieb am Di., 23. Aug. 2022,
20:33:

> Fix under way
> https://github.com/apache/struts/pull/590
>
> wt., 23 sie 2022 o 20:22 Lukasz Lenart 
> napisał(a):
> >
> > Ok, this looks like a bug in CspInterceptor and connected
> > DefaultCspSettings - it assumes the session already exists which isn't
> > true
> > https://issues.apache.org/jira/browse/WW-5215
> >
> > I will prepare a fix and then issue a new 6.0.2 release.
> >
> > Thanks!
> > --
> > Łukasz
> > + 48 606 323 122 http://www.lenart.org.pl/
> >
> > wt., 23 sie 2022 o 14:05 Johannes Geppert  napisał(a):
> > >
> > > no, unfortunately not. I have already tried both versions.
> > >
> > > #
> > > web: http://www.jgeppert.com
> > > twitter: http://twitter.com/jogep
> > >
> > >
> > >
> > > Am Di., 23. Aug. 2022 um 13:41 Uhr schrieb Lukasz Lenart <
> > > lukaszlen...@apache.org>:
> > >
> > > > wt., 23 sie 2022 o 13:37 Johannes Geppert 
> napisał(a):
> > > > >
> > > > > Hi Lukasz,
> > > > >
> > > > > I just checked if it is easy to migrate the AWS serverless
> implementation
> > > > >  from
> Struts2
> > > > to
> > > > > 6.0.0.
> > > > > Unfortunately it looks like the session handling has changed a bit
> and
> > > > > raises a null pointer exception.
> > > > >
> > > > > ERROR DefaultDispatcherErrorHandler Exception occurred during
> processing
> > > > > request: null
> > > > >  java.lang.NullPointerException
> > > > > at
> > > > >
> > > >
> com.amazonaws.serverless.proxy.internal.servlet.AwsHttpServletRequest.getSession(AwsHttpServletRequest.java:139)
> > > > > at
> > > > >
> > > >
> javax.servlet.http.HttpServletRequestWrapper.getSession(HttpServletRequestWrapper.java:270)
> > > > > at
> org.apache.struts2.dispatcher.SessionMap.put(SessionMap.java:171)
> > > > > at
> > > > >
> > > >
> org.apache.struts2.interceptor.csp.DefaultCspSettings.associateNonceWithSession(DefaultCspSettings.java:83)
> > > > > at
> > > > >
> > > >
> org.apache.struts2.interceptor.csp.DefaultCspSettings.addCspHeaders(DefaultCspSettings.java:71)
> > > > > at
> > > > >
> > > >
> org.apache.struts2.interceptor.csp.CspInterceptor.beforeResult(CspInterceptor.java:49)
> > > > > at
> > > > >
> > > >
> com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:274)
> > > > >
> > > > > Any idea about the root cause and hint to the possible change?
> > > >
> > > > Does it work with 6.0.0? And it's  probably related to this change
> > > > https://issues.apache.org/jira/browse/WW-5203
> > > >
> > > > So maybe it need to be reverted
> > > >
> > > >
> > > > Regards
> > > > --
> > > > Łukasz
> > > > + 48 606 323 122 http://www.lenart.org.pl/
> > > >
> > > > -
> > > > To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
> > > > For additional commands, e-mail: dev-h...@struts.apache.org
> > > >
> > > >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
> For additional commands, e-mail: dev-h...@struts.apache.org
>
>

Re: [VOTE] Apache Struts 6.0.1

2022-08-23 Thread Lukasz Lenart 
Fix under way
https://github.com/apache/struts/pull/590

wt., 23 sie 2022 o 20:22 Lukasz Lenart  napisał(a):
>
> Ok, this looks like a bug in CspInterceptor and connected
> DefaultCspSettings - it assumes the session already exists which isn't
> true
> https://issues.apache.org/jira/browse/WW-5215
>
> I will prepare a fix and then issue a new 6.0.2 release.
>
> Thanks!
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> wt., 23 sie 2022 o 14:05 Johannes Geppert  napisał(a):
> >
> > no, unfortunately not. I have already tried both versions.
> >
> > #
> > web: http://www.jgeppert.com
> > twitter: http://twitter.com/jogep
> >
> >
> >
> > Am Di., 23. Aug. 2022 um 13:41 Uhr schrieb Lukasz Lenart <
> > lukaszlen...@apache.org>:
> >
> > > wt., 23 sie 2022 o 13:37 Johannes Geppert  napisał(a):
> > > >
> > > > Hi Lukasz,
> > > >
> > > > I just checked if it is easy to migrate the AWS serverless 
> > > > implementation
> > > >  from Struts2
> > > to
> > > > 6.0.0.
> > > > Unfortunately it looks like the session handling has changed a bit and
> > > > raises a null pointer exception.
> > > >
> > > > ERROR DefaultDispatcherErrorHandler Exception occurred during processing
> > > > request: null
> > > >  java.lang.NullPointerException
> > > > at
> > > >
> > > com.amazonaws.serverless.proxy.internal.servlet.AwsHttpServletRequest.getSession(AwsHttpServletRequest.java:139)
> > > > at
> > > >
> > > javax.servlet.http.HttpServletRequestWrapper.getSession(HttpServletRequestWrapper.java:270)
> > > > at org.apache.struts2.dispatcher.SessionMap.put(SessionMap.java:171)
> > > > at
> > > >
> > > org.apache.struts2.interceptor.csp.DefaultCspSettings.associateNonceWithSession(DefaultCspSettings.java:83)
> > > > at
> > > >
> > > org.apache.struts2.interceptor.csp.DefaultCspSettings.addCspHeaders(DefaultCspSettings.java:71)
> > > > at
> > > >
> > > org.apache.struts2.interceptor.csp.CspInterceptor.beforeResult(CspInterceptor.java:49)
> > > > at
> > > >
> > > com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:274)
> > > >
> > > > Any idea about the root cause and hint to the possible change?
> > >
> > > Does it work with 6.0.0? And it's  probably related to this change
> > > https://issues.apache.org/jira/browse/WW-5203
> > >
> > > So maybe it need to be reverted
> > >
> > >
> > > Regards
> > > --
> > > Łukasz
> > > + 48 606 323 122 http://www.lenart.org.pl/
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
> > > For additional commands, e-mail: dev-h...@struts.apache.org
> > >
> > >

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

Re: [VOTE] Apache Struts 6.0.1

2022-08-23 Thread Lukasz Lenart 
Ok, this looks like a bug in CspInterceptor and connected
DefaultCspSettings - it assumes the session already exists which isn't
true
https://issues.apache.org/jira/browse/WW-5215

I will prepare a fix and then issue a new 6.0.2 release.

Thanks!
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

wt., 23 sie 2022 o 14:05 Johannes Geppert  napisał(a):
>
> no, unfortunately not. I have already tried both versions.
>
> #
> web: http://www.jgeppert.com
> twitter: http://twitter.com/jogep
>
>
>
> Am Di., 23. Aug. 2022 um 13:41 Uhr schrieb Lukasz Lenart <
> lukaszlen...@apache.org>:
>
> > wt., 23 sie 2022 o 13:37 Johannes Geppert  napisał(a):
> > >
> > > Hi Lukasz,
> > >
> > > I just checked if it is easy to migrate the AWS serverless implementation
> > >  from Struts2
> > to
> > > 6.0.0.
> > > Unfortunately it looks like the session handling has changed a bit and
> > > raises a null pointer exception.
> > >
> > > ERROR DefaultDispatcherErrorHandler Exception occurred during processing
> > > request: null
> > >  java.lang.NullPointerException
> > > at
> > >
> > com.amazonaws.serverless.proxy.internal.servlet.AwsHttpServletRequest.getSession(AwsHttpServletRequest.java:139)
> > > at
> > >
> > javax.servlet.http.HttpServletRequestWrapper.getSession(HttpServletRequestWrapper.java:270)
> > > at org.apache.struts2.dispatcher.SessionMap.put(SessionMap.java:171)
> > > at
> > >
> > org.apache.struts2.interceptor.csp.DefaultCspSettings.associateNonceWithSession(DefaultCspSettings.java:83)
> > > at
> > >
> > org.apache.struts2.interceptor.csp.DefaultCspSettings.addCspHeaders(DefaultCspSettings.java:71)
> > > at
> > >
> > org.apache.struts2.interceptor.csp.CspInterceptor.beforeResult(CspInterceptor.java:49)
> > > at
> > >
> > com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:274)
> > >
> > > Any idea about the root cause and hint to the possible change?
> >
> > Does it work with 6.0.0? And it's  probably related to this change
> > https://issues.apache.org/jira/browse/WW-5203
> >
> > So maybe it need to be reverted
> >
> >
> > Regards
> > --
> > Łukasz
> > + 48 606 323 122 http://www.lenart.org.pl/
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
> > For additional commands, e-mail: dev-h...@struts.apache.org
> >
> >

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

Re: [VOTE] Apache Struts 6.0.1

2022-08-23 Thread Johannes Geppert 
no, unfortunately not. I have already tried both versions.

#
web: http://www.jgeppert.com
twitter: http://twitter.com/jogep



Am Di., 23. Aug. 2022 um 13:41 Uhr schrieb Lukasz Lenart <
lukaszlen...@apache.org>:

> wt., 23 sie 2022 o 13:37 Johannes Geppert  napisał(a):
> >
> > Hi Lukasz,
> >
> > I just checked if it is easy to migrate the AWS serverless implementation
> >  from Struts2
> to
> > 6.0.0.
> > Unfortunately it looks like the session handling has changed a bit and
> > raises a null pointer exception.
> >
> > ERROR DefaultDispatcherErrorHandler Exception occurred during processing
> > request: null
> >  java.lang.NullPointerException
> > at
> >
> com.amazonaws.serverless.proxy.internal.servlet.AwsHttpServletRequest.getSession(AwsHttpServletRequest.java:139)
> > at
> >
> javax.servlet.http.HttpServletRequestWrapper.getSession(HttpServletRequestWrapper.java:270)
> > at org.apache.struts2.dispatcher.SessionMap.put(SessionMap.java:171)
> > at
> >
> org.apache.struts2.interceptor.csp.DefaultCspSettings.associateNonceWithSession(DefaultCspSettings.java:83)
> > at
> >
> org.apache.struts2.interceptor.csp.DefaultCspSettings.addCspHeaders(DefaultCspSettings.java:71)
> > at
> >
> org.apache.struts2.interceptor.csp.CspInterceptor.beforeResult(CspInterceptor.java:49)
> > at
> >
> com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:274)
> >
> > Any idea about the root cause and hint to the possible change?
>
> Does it work with 6.0.0? And it's  probably related to this change
> https://issues.apache.org/jira/browse/WW-5203
>
> So maybe it need to be reverted
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
> For additional commands, e-mail: dev-h...@struts.apache.org
>
>

Re: [VOTE] Apache Struts 6.0.1

2022-08-23 Thread Lukasz Lenart 
wt., 23 sie 2022 o 13:37 Johannes Geppert  napisał(a):
>
> Hi Lukasz,
>
> I just checked if it is easy to migrate the AWS serverless implementation
>  from Struts2 to
> 6.0.0.
> Unfortunately it looks like the session handling has changed a bit and
> raises a null pointer exception.
>
> ERROR DefaultDispatcherErrorHandler Exception occurred during processing
> request: null
>  java.lang.NullPointerException
> at
> com.amazonaws.serverless.proxy.internal.servlet.AwsHttpServletRequest.getSession(AwsHttpServletRequest.java:139)
> at
> javax.servlet.http.HttpServletRequestWrapper.getSession(HttpServletRequestWrapper.java:270)
> at org.apache.struts2.dispatcher.SessionMap.put(SessionMap.java:171)
> at
> org.apache.struts2.interceptor.csp.DefaultCspSettings.associateNonceWithSession(DefaultCspSettings.java:83)
> at
> org.apache.struts2.interceptor.csp.DefaultCspSettings.addCspHeaders(DefaultCspSettings.java:71)
> at
> org.apache.struts2.interceptor.csp.CspInterceptor.beforeResult(CspInterceptor.java:49)
> at
> com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:274)
>
> Any idea about the root cause and hint to the possible change?

Does it work with 6.0.0? And it's  probably related to this change
https://issues.apache.org/jira/browse/WW-5203

So maybe it need to be reverted


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

Re: [VOTE] Apache Struts 6.0.1

2022-08-23 Thread Johannes Geppert 
Hi Lukasz,

I just checked if it is easy to migrate the AWS serverless implementation
 from Struts2 to
6.0.0.
Unfortunately it looks like the session handling has changed a bit and
raises a null pointer exception.

ERROR DefaultDispatcherErrorHandler Exception occurred during processing
request: null
 java.lang.NullPointerException
at
com.amazonaws.serverless.proxy.internal.servlet.AwsHttpServletRequest.getSession(AwsHttpServletRequest.java:139)
at
javax.servlet.http.HttpServletRequestWrapper.getSession(HttpServletRequestWrapper.java:270)
at org.apache.struts2.dispatcher.SessionMap.put(SessionMap.java:171)
at
org.apache.struts2.interceptor.csp.DefaultCspSettings.associateNonceWithSession(DefaultCspSettings.java:83)
at
org.apache.struts2.interceptor.csp.DefaultCspSettings.addCspHeaders(DefaultCspSettings.java:71)
at
org.apache.struts2.interceptor.csp.CspInterceptor.beforeResult(CspInterceptor.java:49)
at
com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:274)

Any idea about the root cause and hint to the possible change?

Best Regards

Johannes




#
web: http://www.jgeppert.com
twitter: http://twitter.com/jogep



Am Di., 23. Aug. 2022 um 09:57 Uhr schrieb Lukasz Lenart <
lukaszlen...@apache.org>:

> The Apache Struts 6.0.1 test build is available. With this release the
> following issues were addressed:
>
> Bug
> [WW-5185] - TilesDefinition is not found and the request for a Struts
> action fails after an upgrade from Struts 2.5.30 to Struts 6.0.
> [WW-5189] - Add missing struts-6.0.dtd
> [WW-5190] - StackOverflowError when dispatching to JSP
> [WW-5191] - template/simple/textarea.ftl not rendering parameters correctly
> [WW-5192] - radiomap.ftl not setting enum key values
> [WW-5194] - UIBean.evaluateParams() throws an IllegalStateException
> when getting the nonce out of a session that has been invalidated.
> [WW-5195] - Dispatcher: Infinite loop with dispatcher FORWARD
> [WW-5197] - java.lang.UnsupportedOperationException in the date component
> [WW-5198] - textarea's maxlength attribute displays in tag's body
> [WW-5203] - lazyPolicyBuilder in DefaultCspSettings is not lazy
> [WW-5205] - REST plugin cannot start due to injection error
> [WW-5207] - Convention Plugin - support for ASM 9
>
> New Feature
> [WW-5187] - java.lang.NoClassDefFoundError:
> org/apache/struts2/views/velocity/VelocityManager
>
> Improvement
> [WW-5188] - Use 6.0 marker instead of 2.6
>
> Dependency
> [WW-5193] - Use proper hibernate-validator groupId and upgrade to
> version 6.1.3.Final
> [WW-5201] - Bump Log4j2 to 2.18.0
> [WW-5202] - Update jasperreports to 6.19.1 and exclude optional itext
> from jasperreports
> [WW-5204] - Upgrade to OGNL 3.3.3
> [WW-5208] - Update hibernate-validator to 6.2.4
>
> Release notes:
> * https://cwiki.apache.org/confluence/display/WW/Version+Notes+6.0.1
>
> Github release
> * https://github.com/apache/struts/releases/tag/STRUTS_6_0_1
>
> Distribution:
> * https://dist.apache.org/repos/dist/dev/struts/6.0.1/
>
> Maven 2 staging repository:
> * https://repository.apache.org/content/repositories/staging/
>
> Once you have had a chance to review the test build, please respond
> with a vote on its quality:
>
> [ ] Leave at test build
> [ ] Alpha
> [ ] Beta
> [ ] General Availability (GA)
>
> Everyone who has tested the build is invited to vote. Votes by PMC
> members are considered binding. A vote passes if there are at least
> three binding +1s and more +1s than -1s.
>
> The vote will remain open for at least 72 hours, longer upon request.
> A vote can be amended at any time to upgrade or downgrade the quality
> of the release based on future experience. If an initial vote
> designates the build as "Beta", the release will be submitted for
> mirroring and announced to the user list. Once released as a public
> beta, subsequent quality votes on a build may be held on the user
> list.
>
> As always, the act of voting carries certain obligations. A binding
> vote not only states an opinion, but means that the voter is agreeing
> to help do the work.
>
>
> Kind regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
> For additional commands, e-mail: dev-h...@struts.apache.org
>
>