Re: 1.3.0 Release - Next Steps

[Ted Husted]

The documentation refactorings are going well, but I'd like to set
that aside for now and hop over to the Applications subproject, which
is mentioned from time to time on the other docs.

If anyone wants to jump in on the docs, please feel free. There's
enough done now to set the direction for the rest. Contributions from
non-committers are also welcome. Patches work just as well against XML
as they do against Java source :)

-Ted.


On 7/30/05, Ted Husted <[EMAIL PROTECTED]> wrote:
> Basically, all we need to do is
>
> * address any outstanding problem reports,
> * update the release notes,
> * test,
> * tag,
> * roll,
> * post, and
> * vote.
>
> If the release is voted past test build, then we can sign it and link
> it from the website.
>
> If the release makes GA, or will be widely distributed, then we can
> enter into the mirroring system.
>
> Of course, the more often we release, the easier this guantlet
> becomes. If the volunteers had time, and there were changes to
> distribute, we've often said that we'd like to release every few
> weeks,
>
> But, first things first, we should resolve the problem reports and roll 1.3.0.
>
> I went through the short list last night and pruned a couple that were
> resolved or redundant.
>
> The rest seem to have patches or coding advice that we could follow.
> Off hand, I don't see any problem with applying the rest of the
> tickets, so we should start doing that as we have time.
>
> When you are ready to code, just post a comment to the ticket that you
> are applying the fix now, and have at it. I won't get back to this
> myself until early Monday morning, but then I can devote some time
> each weekday morning. (It would be a great Monday morning surprise to
> come back and find everything resolved!)
>
> For the 1.3.0 release, I think addressing the problem tickets is
> enough. But, for 1.3.1, we should also take a look at any enhancement
> reports with patches.
>
> At some point, we should reduce the enhancement reports *without*
> patches to a omnibus "wish list" or "idea jar", so we can see the
> forest for the trees. Of course, anyone with a Bugzilla and a Wiki
> account could help with something like this. Once upon a time, I
> started an idea jar page here:
>
> * http://wiki.apache.org/struts/StrutsIdeaJar
>
> But, IMHO, focussing first on tickets with patches is vital. The
> primary role of the committers and PMC is to help the community create
> and maintain Struts. The community does this by supplying patches, and
> Job One of the PMC should be to ensure that all patches are applied or
> declined with cause.
>
> An Apache project is not about a few shining stars, it's about a
> thousand points of light, and those lights speak to us through patches
> :)
>
> Aside from the problem tickets, we have another twenty-odd enhancement
> tickets with patches, which could be the focus of 1.3.1. There are
> several Bugzilla query links on the Roadmap page.
>
> * http://struts.apache.org/roadmap.html
>
> But, again, for 1.3.0, let's resolve the problems that can be
> resolved, and get something out on the floor :)
>
> -Ted.
>


--
HTH, Ted.
http://www.husted.com/poe/

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r290423 - in /struts/sandbox/trunk/overdrive/Nexus: Web/GridControl.ascx.cs postbuild.bat

[husted]

Author: husted
Date: Tue Sep 20 04:51:49 2005
New Revision: 290423

URL: http://svn.apache.org/viewcvs?rev=290423&view=rev
Log:
OVR-21
* Automatically update item key property in base class. 

Added:
struts/sandbox/trunk/overdrive/Nexus/postbuild.bat
Modified:
struts/sandbox/trunk/overdrive/Nexus/Web/GridControl.ascx.cs

Modified: struts/sandbox/trunk/overdrive/Nexus/Web/GridControl.ascx.cs
URL: 
http://svn.apache.org/viewcvs/struts/sandbox/trunk/overdrive/Nexus/Web/GridControl.ascx.cs?rev=290423&r1=290422&r2=290423&view=diff
==
--- struts/sandbox/trunk/overdrive/Nexus/Web/GridControl.ascx.cs (original)
+++ struts/sandbox/trunk/overdrive/Nexus/Web/GridControl.ascx.cs Tue Sep 20 
04:51:49 2005
@@ -491,6 +491,8 @@
// Handled by StepList_PageIndexChanged
break;
case msg_ITEM_COMMAND:
+   string key = Grid.DataKeys[index] as 
string;
+   list_ItemKey = key;
list_Item_Click(index);
break;
default:

Added: struts/sandbox/trunk/overdrive/Nexus/postbuild.bat
URL: 
http://svn.apache.org/viewcvs/struts/sandbox/trunk/overdrive/Nexus/postbuild.bat?rev=290423&view=auto
==
--- struts/sandbox/trunk/overdrive/Nexus/postbuild.bat (added)
+++ struts/sandbox/trunk/overdrive/Nexus/postbuild.bat Tue Sep 20 04:51:49 2005
@@ -0,0 +1,3 @@
+REM %LOCAL_CACHE% doesn't work.
+CD %4
+COPY %1%2.* ..\local-cache\%3



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r290424 - in /struts/core/trunk/xdocs/userGuide: building_view.xml preface.xml

[husted]

Author: husted
Date: Tue Sep 20 04:55:58 2005
New Revision: 290424

URL: http://svn.apache.org/viewcvs?rev=290424&view=rev
Log:
Fixes to Site and Core docs, as suggested by Christian Meder.

Modified:
struts/core/trunk/xdocs/userGuide/building_view.xml
struts/core/trunk/xdocs/userGuide/preface.xml

Modified: struts/core/trunk/xdocs/userGuide/building_view.xml
URL: 
http://svn.apache.org/viewcvs/struts/core/trunk/xdocs/userGuide/building_view.xml?rev=290424&r1=290423&r2=290424&view=diff
==
--- struts/core/trunk/xdocs/userGuide/building_view.xml (original)
+++ struts/core/trunk/xdocs/userGuide/building_view.xml Tue Sep 20 04:55:58 2005
@@ -28,7 +28,7 @@
 
 Features provided by Struts Core for direct use by view components
 include Message Resources
-for internationaling text and images,
+for localizing text and images,
 and FormBeans to provide for automatic
 population and validation.
 
@@ -220,7 +220,7 @@
 Note: While the examples given here use JSP and custom 
tags,
 the ActionForm beans and the other Struts controller components are
 View neutral. 
-Struts can be used with Coccoon, Velocity Templates, XSLT, and any other
+Struts can be used with Cocoon, Velocity Templates, XSLT, and any other
 presentation technology that can be rendered via a Java servlet. 
 
 

Modified: struts/core/trunk/xdocs/userGuide/preface.xml
URL: 
http://svn.apache.org/viewcvs/struts/core/trunk/xdocs/userGuide/preface.xml?rev=290424&r1=290423&r2=290424&view=diff
==
--- struts/core/trunk/xdocs/userGuide/preface.xml (original)
+++ struts/core/trunk/xdocs/userGuide/preface.xml Tue Sep 20 04:55:58 2005
@@ -176,7 +176,7 @@
   To implement its Chain, the Request Processor uses the
   http://jakarta.apache.org/commons/chain/";>
   Chain of Responsibility component in the Jakarta Commons
-  provides a standard implementation of the CoR pattern,
+  which provides a standard implementation of the CoR pattern,
   along with various implementations of the Context and
   Command objects used by the Chain to service a request.
   
@@ -196,7 +196,7 @@
   
   
   http://www.infonoia.com/en/content.jsp?d=inf.05.06&pr=1";>
-  Better Code with Struts 1t.3
+  Better Code with Struts 1.3
   
   
   
@@ -852,7 +852,7 @@
 
 
 
-The features provided by the Struts Core framework relies on a number 
of objects that are
+The features provided by the Struts Core framework rely on a number of 
objects that are
 usually deployed using a configuration file written in
 http://www.w3.org/XML/";>Extensible Markup Language. XML is 
also used to
 configure Java web applications; so, this is yet another familiar approach.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r290425 - /struts/site/trunk/xdocs/mail.xml

[husted]

Author: husted
Date: Tue Sep 20 04:57:26 2005
New Revision: 290425

URL: http://svn.apache.org/viewcvs?rev=290425&view=rev
Log:
Fixes to Site and Core docs, as suggested by Christian Meder.

Modified:
struts/site/trunk/xdocs/mail.xml

Modified: struts/site/trunk/xdocs/mail.xml
URL: 
http://svn.apache.org/viewcvs/struts/site/trunk/xdocs/mail.xml?rev=290425&r1=290424&r2=290425&view=diff
==
--- struts/site/trunk/xdocs/mail.xml (original)
+++ struts/site/trunk/xdocs/mail.xml Tue Sep 20 04:57:26 2005
@@ -28,7 +28,7 @@
 A mailing list is an electronic discussion forum that anyone can
 subscribe to. When someone sends an email message to the mailing list,
 a copy of that message is broadcast to everyone who is subscribed to
-that mailing list. Mailing lists are the primary meands of communication
+that mailing list. Mailing lists are the primary means of communication
 for people working within the Apache Struts Project.
 
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r290426 - in /struts/site/trunk/xdocs: helping.xml navigation.xml volunteers.xml

[husted]

Author: husted
Date: Tue Sep 20 04:57:52 2005
New Revision: 290426

URL: http://svn.apache.org/viewcvs?rev=290426&view=rev
Log:
Routine fixes and changes. 

Modified:
struts/site/trunk/xdocs/helping.xml
struts/site/trunk/xdocs/navigation.xml
struts/site/trunk/xdocs/volunteers.xml

Modified: struts/site/trunk/xdocs/helping.xml
URL: 
http://svn.apache.org/viewcvs/struts/site/trunk/xdocs/helping.xml?rev=290426&r1=290425&r2=290426&view=diff
==
--- struts/site/trunk/xdocs/helping.xml (original)
+++ struts/site/trunk/xdocs/helping.xml Tue Sep 20 04:57:52 2005
@@ -49,6 +49,9 @@
 
 How can I help the next release along?
 
+
+How can I help make the decisions?
+
 
 
 
@@ -630,6 +633,9 @@
 "http://apache.org/foundation/how-it-works.html";>
 How the ASF Works" and the
 Apache Struts Charter.
+For more about project infrastructure,
+see "Project Maintenance and Resources" in the
+http://wiki.apache.org/struts/";>Apache Struts wiki.
 
 
 

Modified: struts/site/trunk/xdocs/navigation.xml
URL: 
http://svn.apache.org/viewcvs/struts/site/trunk/xdocs/navigation.xml?rev=290426&r1=290425&r2=290426&view=diff
==
--- struts/site/trunk/xdocs/navigation.xml (original)
+++ struts/site/trunk/xdocs/navigation.xml Tue Sep 20 04:57:52 2005
@@ -91,7 +91,7 @@
 />
 http://svn.apache.org/viewcvs.cgi/struts/site/trunk/?root=Apache-SVN";
+href="http://svn.apache.org/viewcvs.cgi/struts/";
 />
 
   

Modified: struts/site/trunk/xdocs/volunteers.xml
URL: 
http://svn.apache.org/viewcvs/struts/site/trunk/xdocs/volunteers.xml?rev=290426&r1=290425&r2=290426&view=diff
==
--- struts/site/trunk/xdocs/volunteers.xml (original)
+++ struts/site/trunk/xdocs/volunteers.xml Tue Sep 20 04:57:52 2005
@@ -115,7 +115,7 @@
 
Oleg Alexeev
 
-   >Rob Leland
+   Rob Leland
 
Arron Bates
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r290448 - in /struts/sandbox/trunk/overdrive/Nexus/Web: FindControl.ascx FindControl.ascx.cs FindControl.ascx.resx Web.csproj

[husted]

Author: husted
Date: Tue Sep 20 06:30:24 2005
New Revision: 290448

URL: http://svn.apache.org/viewcvs?rev=290448&view=rev
Log:
OVR-29
* Add a base FindControl. Typically, a FindControl will collect input to filter 
a list of entries displayed by a GridControl.

Added:
struts/sandbox/trunk/overdrive/Nexus/Web/FindControl.ascx
struts/sandbox/trunk/overdrive/Nexus/Web/FindControl.ascx.cs
struts/sandbox/trunk/overdrive/Nexus/Web/FindControl.ascx.resx
Modified:
struts/sandbox/trunk/overdrive/Nexus/Web/Web.csproj

Added: struts/sandbox/trunk/overdrive/Nexus/Web/FindControl.ascx
URL: 
http://svn.apache.org/viewcvs/struts/sandbox/trunk/overdrive/Nexus/Web/FindControl.ascx?rev=290448&view=auto
==
--- struts/sandbox/trunk/overdrive/Nexus/Web/FindControl.ascx (added)
+++ struts/sandbox/trunk/overdrive/Nexus/Web/FindControl.ascx Tue Sep 20 
06:30:24 2005
@@ -0,0 +1 @@
+<%@ Control Language="c#" AutoEventWireup="false" 
Codebehind="FindControl.ascx.cs" Inherits="WQD.Web.Controls.FindControl" 
TargetSchema="http://schemas.microsoft.com/intellisense/ie5"%>

Added: struts/sandbox/trunk/overdrive/Nexus/Web/FindControl.ascx.cs
URL: 
http://svn.apache.org/viewcvs/struts/sandbox/trunk/overdrive/Nexus/Web/FindControl.ascx.cs?rev=290448&view=auto
==
--- struts/sandbox/trunk/overdrive/Nexus/Web/FindControl.ascx.cs (added)
+++ struts/sandbox/trunk/overdrive/Nexus/Web/FindControl.ascx.cs Tue Sep 20 
06:30:24 2005
@@ -0,0 +1,106 @@
+using System;
+using System.Collections;
+using Nexus.Core.Helpers;
+using Nexus.Web.Controls;
+
+namespace WQD.Web.Controls
+{
+
+   /// 
+   /// Base class for find controls.
+   /// 
+   /// 
+   /// Typically, a FindControl will collect input 
+   /// to filter a list of entries displayed by a GridControl.
+   /// 
+   public class FindControl : ViewControl
+   {
+
+   /// 
+   /// Provide a field for the FindCommand property.
+   /// 
+   private string _FindCommand;
+   
+   /// 
+   /// Provide the command that will populate the data-entry 
controls.
+   /// 
+   public string FindCommand
+   {
+   get {return _FindCommand;}
+   set {_FindCommand = value;}
+   }
+
+   /// 
+   /// Expose values input by client 
+   /// for use by another component.
+   /// 
+   /// 
+   public virtual IDictionary Criteria
+   {
+   get
+   {
+   IViewHelper helper = Read(FindCommand);
+   if (!helper.IsNominal)
+   {
+   Page_Error = helper;
+   }
+   return helper.Criteria;
+   }
+   }
+
+   /// 
+   /// Prepare controls for data entry.
+   /// 
+   /// 
+   /// Preparation includes obtaining lists from the 
+   /// databases. 
+   /// Any errors are reported 
+   /// through the standard page error handler.
+   /// 
+   /// 
+   public virtual void Open()
+   {
+   if (IsPostBack) return;
+   IViewHelper helper = ExecuteBind(FindCommand);
+   if (!helper.IsNominal) Page_Error = helper;
+   }
+
+   /// 
+   /// Wire the event handlers and set defaults.
+   /// 
+   /// Source
+   /// Runtime parameters
+   /// 
+   private void Page_Load(object sender, System.EventArgs e)
+   {
+   // Put user code to initialize the page here
+   }
+
+   #region Web Form Designer generated code
+
+   /// 
+   /// Initialize components.
+   /// 
+   /// Runtime parameters
+   /// 
+   override protected void OnInit(EventArgs e)
+   {
+   //
+   // CODEGEN: This call is required by the ASP.NET Web 
Form Designer.
+   //
+   InitializeComponent();
+   base.OnInit(e);
+   }
+   
+   /// 
+   /// Required method for Designer support - do not 
modify
+   /// the contents of this method with the code 
editor.
+   /// 
+   /// 
+   private void InitializeComponent()
+   

svn commit: r290587 - /struts/sandbox/trunk/ti/jars/compiler-xdoclet/project.properties

[mrdon]

Author: mrdon
Date: Tue Sep 20 16:55:39 2005
New Revision: 290587

URL: http://svn.apache.org/viewcvs?rev=290587&view=rev
Log:
Setting the target class format for 1.4

Modified:
struts/sandbox/trunk/ti/jars/compiler-xdoclet/project.properties

Modified: struts/sandbox/trunk/ti/jars/compiler-xdoclet/project.properties
URL: 
http://svn.apache.org/viewcvs/struts/sandbox/trunk/ti/jars/compiler-xdoclet/project.properties?rev=290587&r1=290586&r2=290587&view=diff
==
--- struts/sandbox/trunk/ti/jars/compiler-xdoclet/project.properties (original)
+++ struts/sandbox/trunk/ti/jars/compiler-xdoclet/project.properties Tue Sep 20 
16:55:39 2005
@@ -1 +1,2 @@
 maven.compile.source=1.4
+maven.compile.target=1.4



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r290588 - /struts/sandbox/trunk/ti/jars/core/project.properties

[mrdon]

Author: mrdon
Date: Tue Sep 20 16:56:22 2005
New Revision: 290588

URL: http://svn.apache.org/viewcvs?rev=290588&view=rev
Log:
Adding java source and target as 1.4

Added:
struts/sandbox/trunk/ti/jars/core/project.properties

Added: struts/sandbox/trunk/ti/jars/core/project.properties
URL: 
http://svn.apache.org/viewcvs/struts/sandbox/trunk/ti/jars/core/project.properties?rev=290588&view=auto
==
--- struts/sandbox/trunk/ti/jars/core/project.properties (added)
+++ struts/sandbox/trunk/ti/jars/core/project.properties Tue Sep 20 16:56:22 
2005
@@ -0,0 +1,2 @@
+maven.compile.source=1.4
+maven.compile.target=1.4



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r290589 - /struts/sandbox/trunk/ti/wars/samples-xdoclet/src/java/pageflow/basic/Controller.java

[mrdon]

Author: mrdon
Date: Tue Sep 20 17:00:39 2005
New Revision: 290589

URL: http://svn.apache.org/viewcvs?rev=290589&view=rev
Log:
Fixed so xdoclet sample would compile under java 1.4

Modified:

struts/sandbox/trunk/ti/wars/samples-xdoclet/src/java/pageflow/basic/Controller.java

Modified: 
struts/sandbox/trunk/ti/wars/samples-xdoclet/src/java/pageflow/basic/Controller.java
URL: 
http://svn.apache.org/viewcvs/struts/sandbox/trunk/ti/wars/samples-xdoclet/src/java/pageflow/basic/Controller.java?rev=290589&r1=290588&r2=290589&view=diff
==
--- 
struts/sandbox/trunk/ti/wars/samples-xdoclet/src/java/pageflow/basic/Controller.java
 (original)
+++ 
struts/sandbox/trunk/ti/wars/samples-xdoclet/src/java/pageflow/basic/Controller.java
 Tue Sep 20 17:00:39 2005
@@ -1,6 +1,5 @@
 package pageflow.basic;
 
-import org.apache.ti.pageflow.annotations.ti;
 import org.apache.ti.pageflow.PageFlowController;
 import org.apache.ti.pageflow.Forward;
 import com.opensymphony.xwork.Action;



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Nightly builds

[James Mitchell]

I have finally gotten around to finishing the setup of my account on  
our zone (http://www.apache.org/dev/solaris-zones.html) and thanks to  
Martin and Google, I'm now able to fully build the nightly (by hand)  
of the entire Struts project.


For those who haven't been watching, the nightly builds that were  
happening on my machine began failing during the 'svn up' portion of  
the script.  This basically caused Maven do say "oh cool, nothings  
changed, let's not build any artifacts", and the rest of the shell  
script just happily uploads the same jars from the last build.  This  
explains the mismatch in date/name of some of the nightly artifacts.


So, where are we?
Currently, the latest build (nightly) is available here (http:// 
struts.zones.apache.org/~jmitchell/nightly/).  I also updated the  
readme on the regular nightly download page to point to this interim  
spot.  This is a manual process right now.



Where do we want to be?
Typically, nightlies are hosted from /www/cvs.apache.org/build/ 
{project}.
Right now, both Craig and my own personal machines are configured to  
pull from cvs/svn, run the build, and upload something to that  
location.  This can only happen as a cron job if we copy the  
appropriate ssh keys to the target server (no login prompted).


The question really comes down to "Where will the nightlies live?".

If we want to use some generic account on the zone to build the  
nightly, the script would need to either:
a) use someone's account (mine?) to build/scp the nightlies over to  
cvs.apache.org
b) build via a generic account and scp via a valid account (committer  
account on the zone)


Although, we can actually avoid all of this by just hosting the  
nightlies from the zone.  The url might look like this:

http://struts.zones.apache.org/~nightly/


Somewhat related - Craig, if you are interested, I'd be happy to help  
you move your nightly Ant builds to the new zone.




--
James Mitchell
Software Engineer / Open Source Evangelist
Consulting / Mentoring / Freelance
EdgeTech, Inc.
http://www.edgetechservices.net/
678.910.8017
AIM:   jmitchtx
Yahoo: jmitchtx
MSN:   [EMAIL PROTECTED]
Skype: callto://jmitchtx






-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r290616 - /struts/shale/trunk/core-library/src/java/org/apache/shale/view/AbstractFacesBean.java

[craigmcc]

Author: craigmcc
Date: Tue Sep 20 21:14:24 2005
New Revision: 290616

URL: http://svn.apache.org/viewcvs?rev=290616&view=rev
Log:
Make the message-queueing methods that take a component argument actually
pass on the corresponding client id in the FacesMessage instance.

PR:  Bugzilla #36714
Submitted By:  Ronald Holshausen 

Modified:

struts/shale/trunk/core-library/src/java/org/apache/shale/view/AbstractFacesBean.java

Modified: 
struts/shale/trunk/core-library/src/java/org/apache/shale/view/AbstractFacesBean.java
URL: 
http://svn.apache.org/viewcvs/struts/shale/trunk/core-library/src/java/org/apache/shale/view/AbstractFacesBean.java?rev=290616&r1=290615&r2=290616&view=diff
==
--- 
struts/shale/trunk/core-library/src/java/org/apache/shale/view/AbstractFacesBean.java
 (original)
+++ 
struts/shale/trunk/core-library/src/java/org/apache/shale/view/AbstractFacesBean.java
 Tue Sep 20 21:14:24 2005
@@ -248,8 +248,9 @@
  */
 protected void info(UIComponent component, String summary) {
 
-getFacesContext().addMessage(null,
-  new FacesMessage(FacesMessage.SEVERITY_INFO, summary, null));
+FacesContext context = getFacesContext();
+context.addMessage(component.getClientId(context),
+   new FacesMessage(FacesMessage.SEVERITY_INFO, summary, null));
 
 }
 
@@ -279,8 +280,9 @@
  */
 protected void warn(UIComponent component, String summary) {
 
-getFacesContext().addMessage(null,
-  new FacesMessage(FacesMessage.SEVERITY_WARN, summary, null));
+FacesContext context = getFacesContext();
+context.addMessage(component.getClientId(context),
+   new FacesMessage(FacesMessage.SEVERITY_WARN, summary, null));
 
 }
 
@@ -310,8 +312,9 @@
  */
 protected void error(UIComponent component, String summary) {
 
-getFacesContext().addMessage(null,
-  new FacesMessage(FacesMessage.SEVERITY_ERROR, summary, null));
+FacesContext context = getFacesContext();
+context.addMessage(component.getClientId(context),
+   new FacesMessage(FacesMessage.SEVERITY_ERROR, summary, null));
 
 }
 
@@ -341,8 +344,9 @@
  */
 protected void fatal(UIComponent component, String summary) {
 
-getFacesContext().addMessage(null,
-  new FacesMessage(FacesMessage.SEVERITY_FATAL, summary, null));
+FacesContext context = getFacesContext();
+context.addMessage(component.getClientId(context),
+   new FacesMessage(FacesMessage.SEVERITY_FATAL, summary, null));
 
 }
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 36714] - [shale] AbstractFacesBean message methods don't use the UIComponent parameter

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36714


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-09-21 06:14 ---
Good catch ... fixed in nightly build 20050921.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 36439] - [shale] Allow user to supply their own Dialog DTD

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36439





--- Additional Comments From [EMAIL PROTECTED]  2005-09-21 06:16 ---
(In reply to comment #3)

> Option #3 of course is the worst.  I thought about supplying my own mechanism
> but then I started thinking "This is getting to be less and less standardized
> and looking more like my original custom solution.

Of course, the fact that you want to customize the implementation classes for
the dialog state objects means you're already trying to be nonstandard :-).  It
might be worth exploring (on the dev list) what needs are driving this, to see
if we want to include them in the standard implementation.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r290619 - /struts/shale/trunk/core-library/src/test/org/apache/shale/view/ConcreteFacesBeanTestCase.java

[craigmcc]

Author: craigmcc
Date: Tue Sep 20 21:53:58 2005
New Revision: 290619

URL: http://svn.apache.org/viewcvs?rev=290619&view=rev
Log:
Update tests for AbstractFacesBean to include checking that messages get
queued correctly.

Modified:

struts/shale/trunk/core-library/src/test/org/apache/shale/view/ConcreteFacesBeanTestCase.java

Modified: 
struts/shale/trunk/core-library/src/test/org/apache/shale/view/ConcreteFacesBeanTestCase.java
URL: 
http://svn.apache.org/viewcvs/struts/shale/trunk/core-library/src/test/org/apache/shale/view/ConcreteFacesBeanTestCase.java?rev=290619&r1=290618&r2=290619&view=diff
==
--- 
struts/shale/trunk/core-library/src/test/org/apache/shale/view/ConcreteFacesBeanTestCase.java
 (original)
+++ 
struts/shale/trunk/core-library/src/test/org/apache/shale/view/ConcreteFacesBeanTestCase.java
 Tue Sep 20 21:53:58 2005
@@ -16,7 +16,11 @@
 
 package org.apache.shale.view;
 
+import java.util.Iterator;
 import java.util.Map;
+import javax.faces.application.FacesMessage;
+import javax.faces.application.FacesMessage.Severity;
+import javax.faces.component.UIViewRoot;
 import junit.framework.Test;
 import junit.framework.TestSuite;
 import org.apache.shale.test.base.AbstractJsfTestCase;
@@ -114,6 +118,91 @@
 }
 
 
+private Severity messagesAttachedSeverity[] = {
+FacesMessage.SEVERITY_ERROR,
+FacesMessage.SEVERITY_ERROR,
+FacesMessage.SEVERITY_ERROR,
+FacesMessage.SEVERITY_ERROR,
+FacesMessage.SEVERITY_FATAL,
+FacesMessage.SEVERITY_FATAL,
+FacesMessage.SEVERITY_FATAL,
+FacesMessage.SEVERITY_INFO,
+FacesMessage.SEVERITY_INFO,
+FacesMessage.SEVERITY_WARN,
+};
+
+private String messagesAttachedSummary[] = {
+"Error 0", "Error 1", "Error 2", "Error 3",
+"Fatal 0", "Fatal 1", "Fatal 2",
+"Info 0", "Info 1",
+"Warn 0",
+};
+
+
+// Test messages attached to a particular component
+public void testMessagesAttached() {
+
+UIViewRoot root = new UIViewRoot();
+root.setId("root");
+facesContext.setViewRoot(root);
+bean.error(root, "Error 0");
+bean.error(root, "Error 1");
+bean.error(root, "Error 2");
+bean.error(root, "Error 3");
+bean.fatal(root, "Fatal 0");
+bean.fatal(root, "Fatal 1");
+bean.fatal(root, "Fatal 2");
+bean.info(root, "Info 0");
+bean.info(root, "Info 1");
+bean.warn(root, "Warn 0");
+checkMessages(facesContext.getMessages(root.getClientId(facesContext)),
+  messagesAttachedSeverity,
+  messagesAttachedSummary);
+
+}
+
+
+private Severity messagesUnattachedSeverity[] = {
+FacesMessage.SEVERITY_ERROR,
+FacesMessage.SEVERITY_FATAL,
+FacesMessage.SEVERITY_FATAL,
+FacesMessage.SEVERITY_INFO,
+FacesMessage.SEVERITY_INFO,
+FacesMessage.SEVERITY_INFO,
+FacesMessage.SEVERITY_WARN,
+FacesMessage.SEVERITY_WARN,
+FacesMessage.SEVERITY_WARN,
+FacesMessage.SEVERITY_WARN,
+};
+
+private String messagesUnattachedSummary[] = {
+"Error 0",
+"Fatal 0", "Fatal 1",
+"Info 0", "Info 1", "Info 2",
+"Warn 0", "Warn 1", "Warn 2", "Warn 3",
+};
+
+
+// Test messages not attached to any particular component
+public void testMessagesUnattached() {
+
+bean.error("Error 0");
+bean.fatal("Fatal 0");
+bean.fatal("Fatal 1");
+bean.info("Info 0");
+bean.info("Info 1");
+bean.info("Info 2");
+bean.warn("Warn 0");
+bean.warn("Warn 1");
+bean.warn("Warn 2");
+bean.warn("Warn 3");
+checkMessages(facesContext.getMessages(null),
+  messagesUnattachedSeverity,
+  messagesUnattachedSummary);
+
+}
+
+
 // Test pristine instance
 public void testPristine() {
 
@@ -178,6 +267,21 @@
 assertEquals("baz", bean.getValue("#{foo.id}"));
 assertEquals("baz", ((ConcreteFacesBean) 
servletContext.getAttribute("foo")).getId());
 
+}
+
+
+// - Support 
Methods
+
+
+// Check the queued messages for correct severity and summary messages
+private void checkMessages(Iterator messages, Severity severity[], String 
summary[]) {
+int n = 0;
+while (messages.hasNext()) {
+FacesMessage message = (FacesMessage) messages.next();
+assertEquals(summary[n] + " severity", severity[n], 
message.getSeverity());
+assertEquals(summary[n] + " summary", summary[n], 
message.getSummary());
+n++;
+}
 }
 
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Nightly builds

[Craig McClanahan]

On 9/20/05, James Mitchell <[EMAIL PROTECTED]> wrote:
> 
> [snip]
> 
> Although, we can actually avoid all of this by just hosting the
> nightlies from the zone. The url might look like this:
> http://struts.zones.apache.org/~nightly/


I think this is the right long term answer. I suspect that, once the zones 
machine settles down, it will be more reliable than either yours or mine 
:-). And, we can make sure that more than just the two of us have the 
ability to fix things when they break.

The only short term concern is that the zones machine, AIUI, is still 
subject to being wiped and reinstalled. Anything we do there will need to be 
suitably backed up so we can reinstall quickly.

Somewhat related - Craig, if you are interested, I'd be happy to help
> you move your nightly Ant builds to the new zone.


That'd be very helpful, and I'll take you up on it. Lets focus on the Struts 
stuff first, then talk the Jakarta Commons folks into doing the same thing. 

--
> James Mitchell



Craig

DTDs on the website

[Wendy Smoak]

Currently we have several DTDs available online:
  http://struts.apache.org/dtds/

It looks like they are uploaded as needed, but not stored as part of the
site.  The corresponding directory, site/xdocs/dtds has some files that are
(according to README.txt) left over from the Ant build:
  http://svn.apache.org/viewcvs.cgi/struts/site/trunk/xdocs/dtds/?rev=290621

I'll remove those files in a day or so (unless someone objects).  The
question I have is whether to check in the current set of DTDs and maintain
them as part of the website, or just leave it as-is.

Craig, can the dialog and clay DTDs be put on the website?

--
Wendy



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: DTDs on the website

[Craig McClanahan]

On 9/20/05, Wendy Smoak <[EMAIL PROTECTED]> wrote:
> 
> 
> Craig, can the dialog and clay DTDs be put on the website?


Done.

--
> Wendy


Craig