Re: Destroy Of Interceptor

[Ted Husted]

+1

I haven't traced the code, but I believe we redeploy the Interceptors
in dev mode, making a destroy option more important.

On Dec 14, 2007 7:46 PM, Tom Schneider <[EMAIL PROTECTED]> wrote:
>
> You know, I think you're right!  I searched the entire codebase (both xwork
> and struts) and I have found nowhere where we call destroy() on the
> interceptors.  I guess that hasn't been an issue because if the destroy
> isn't being called, no big deal because your usually shutting down anyway.
>
> If we were to call destroy on the interceptors, I would expect it to happen
> in the cleanup() method of Dispatcher.  This is where all the rest of the
> cleanup happens.  At runtime, the list of interceptors is stored in the
> ActionConfig object.  (part of xwork)  Perhaps it might be a good idea to
> submit a patch that fixes this issue. :) (hint, hint)
> Tom
>
>
> Décio Heinzelmann Luckow wrote:
> >
> > Hi All,
> >
> > I´m studing Interceptors and I was looking for the local where Struts call
> > the destroy() method of Interceptor.
> >
> > The init() method is called at the same time of construction of
> > Interceptor,
> > but I can´t find where the destroy is called.
> >
> > Someone know where its happen?
> >
> > Tanks!
> >
> > Décio Heinzelmann Luckow
> >
> >
> >
> > -
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> >
> >
> >
>
> --
> View this message in context: 
> http://www.nabble.com/Destroy-Of-Interceptor-tp14338766p14339890.html
> Sent from the Struts - Dev mailing list archive at Nabble.com.
>
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>



-- 
HTH, Ted
 * 

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[s2] Build changes

[Don Brown]

FYI, I'm working on the XWork and Struts 2 builds, trying to do a few things:
 * Automatic deployment of xwork and struts 2 snapshots (by Bamboo)
 * Automatic deployment of struts 2 assemblies (by Bamboo)
 * One step creation of assemblies, including j4 backport jars

One of the stumbling points of the project right now is releases are
still not as easy as they should be and this makes it hard to get
users involved early.  By automatically deploying assemblies, users
can get usable versions of the code by downloading full builds that
even include docs.

Don

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [s2] Build changes

[Martin Gilday]

Sounds very useful, especially for people wanting to test out the latest
2.1.x.
Does this include getting artifacts published to a snapshot Struts 2
Maven repo (i.e. not central)?


- Original message -
From: "Don Brown" <[EMAIL PROTECTED]>
To: "Struts Developers List" 
Date: Sun, 16 Dec 2007 22:18:14 +1100
Subject: [s2] Build changes

FYI, I'm working on the XWork and Struts 2 builds, trying to do a few
things:
 * Automatic deployment of xwork and struts 2 snapshots (by Bamboo)
 * Automatic deployment of struts 2 assemblies (by Bamboo)
 * One step creation of assemblies, including j4 backport jars

One of the stumbling points of the project right now is releases are
still not as easy as they should be and this makes it hard to get
users involved early.  By automatically deploying assemblies, users
can get usable versions of the code by downloading full builds that
even include docs.

Don

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [s2] Build changes

[Don Brown]

On 12/17/07, Martin Gilday <[EMAIL PROTECTED]> wrote:
> Does this include getting artifacts published to a snapshot Struts 2
> Maven repo (i.e. not central)?

Yep, and as I mentioned, I'm hoping to get the full assembly builds
automatically published as well.

Don

>
>
> - Original message -
> From: "Don Brown" <[EMAIL PROTECTED]>
> To: "Struts Developers List" 
> Date: Sun, 16 Dec 2007 22:18:14 +1100
> Subject: [s2] Build changes
>
> FYI, I'm working on the XWork and Struts 2 builds, trying to do a few
> things:
>  * Automatic deployment of xwork and struts 2 snapshots (by Bamboo)
>  * Automatic deployment of struts 2 assemblies (by Bamboo)
>  * One step creation of assemblies, including j4 backport jars
>
> One of the stumbling points of the project right now is releases are
> still not as easy as they should be and this makes it hard to get
> users involved early.  By automatically deploying assemblies, users
> can get usable versions of the code by downloading full builds that
> even include docs.
>
> Don
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r604737 - /struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl

[Don Brown]

Don't forget to put the ticket number in the commit, cause that will
usually be the bit that has the link to the thread.

Don

On 12/17/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
> Author: davenewton
> Date: Sun Dec 16 15:14:16 2007
> New Revision: 604737
>
> URL: http://svn.apache.org/viewvc?rev=604737&view=rev
> Log:
> Patch for optiontransferselect.ftl null doubleListValue issue from Dale 
> Newfield.
>
> See thread at 
> http://www.nabble.com/-struts--2.0.11--optiontransferselect-limit--tt14344098.html#a14344098.
>
> Modified:
> 
> struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl
>
> Modified: 
> struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl
> URL: 
> http://svn.apache.org/viewvc/struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl?rev=604737&r1=604736&r2=604737&view=diff
> ==
> --- 
> struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl
>  (original)
> +++ 
> struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl
>  Sun Dec 16 15:14:16 2007
> @@ -261,7 +261,9 @@
>  <#t/>
>  <#assign doubleItemKeyStr = doubleItemKey.toString() /><#t/>
>  <#if parameters.doubleListValue?exists><#t/>
> -<#assign doubleItemValue = 
> stack.findString(parameters.doubleListValue) /><#t/>
> +<#if 
> stack.findString(parameters.doubleListValue)?has_content><#t/>
> +<#assign doubleItemValue = 
> stack.findString(parameters.doubleListValue) /><#t/>
> +<#t/>
>  <#else><#t/>
>  <#assign doubleItemValue = stack.findString('top') /><#t/>
>  <#t/>
>
>
>

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r604737 - /struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl

[Dave Newton]

Oh; didn't know there was a ticket, sorry.

d.

--- Don Brown <[EMAIL PROTECTED]> wrote:

> Don't forget to put the ticket number in the commit, cause that will
> usually be the bit that has the link to the thread.
> 
> Don
> 
> On 12/17/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
> > Author: davenewton
> > Date: Sun Dec 16 15:14:16 2007
> > New Revision: 604737
> >
> > URL: http://svn.apache.org/viewvc?rev=604737&view=rev
> > Log:
> > Patch for optiontransferselect.ftl null doubleListValue issue from Dale
> Newfield.
> >
> > See thread at
>
http://www.nabble.com/-struts--2.0.11--optiontransferselect-limit--tt14344098.html#a14344098.
> >
> > Modified:
> >
>
struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl
> >
> > Modified:
>
struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl
> > URL:
>
http://svn.apache.org/viewvc/struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl?rev=604737&r1=604736&r2=604737&view=diff
> >
>
==
> > ---
>
struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl
> (original)
> > +++
>
struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl
> Sun Dec 16 15:14:16 2007
> > @@ -261,7 +261,9 @@
> >  <#t/>
> >  <#assign doubleItemKeyStr = doubleItemKey.toString() /><#t/>
> >  <#if parameters.doubleListValue?exists><#t/>
> > -<#assign doubleItemValue =
> stack.findString(parameters.doubleListValue) /><#t/>
> > +<#if
> stack.findString(parameters.doubleListValue)?has_content><#t/>
> > +<#assign doubleItemValue =
> stack.findString(parameters.doubleListValue) /><#t/>
> > +<#t/>
> >  <#else><#t/>
> >  <#assign doubleItemValue = stack.findString('top') /><#t/>
> >  <#t/>
> >
> >
> >
> 
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 
> 


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r604737 - /struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl

[Don Brown]

Heh, that was the no-so-subtle hint :)

Don

On 12/17/07, Dave Newton <[EMAIL PROTECTED]> wrote:
> Oh; didn't know there was a ticket, sorry.
>
> d.
>
> --- Don Brown <[EMAIL PROTECTED]> wrote:
>
> > Don't forget to put the ticket number in the commit, cause that will
> > usually be the bit that has the link to the thread.
> >
> > Don
> >
> > On 12/17/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
> > > Author: davenewton
> > > Date: Sun Dec 16 15:14:16 2007
> > > New Revision: 604737
> > >
> > > URL: http://svn.apache.org/viewvc?rev=604737&view=rev
> > > Log:
> > > Patch for optiontransferselect.ftl null doubleListValue issue from Dale
> > Newfield.
> > >
> > > See thread at
> >
> http://www.nabble.com/-struts--2.0.11--optiontransferselect-limit--tt14344098.html#a14344098.
> > >
> > > Modified:
> > >
> >
> struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl
> > >
> > > Modified:
> >
> struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl
> > > URL:
> >
> http://svn.apache.org/viewvc/struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl?rev=604737&r1=604736&r2=604737&view=diff
> > >
> >
> ==
> > > ---
> >
> struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl
> > (original)
> > > +++
> >
> struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl
> > Sun Dec 16 15:14:16 2007
> > > @@ -261,7 +261,9 @@
> > >  <#t/>
> > >  <#assign doubleItemKeyStr = doubleItemKey.toString() /><#t/>
> > >  <#if parameters.doubleListValue?exists><#t/>
> > > -<#assign doubleItemValue =
> > stack.findString(parameters.doubleListValue) /><#t/>
> > > +<#if
> > stack.findString(parameters.doubleListValue)?has_content><#t/>
> > > +<#assign doubleItemValue =
> > stack.findString(parameters.doubleListValue) /><#t/>
> > > +<#t/>
> > >  <#else><#t/>
> > >  <#assign doubleItemValue = stack.findString('top') /><#t/>
> > >  <#t/>
> > >
> > >
> > >
> >
> > -
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> >
> >
>
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r604737 - /struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl

[Dave Newton]

--- Don Brown <[EMAIL PROTECTED]> wrote:
> Heh, that was the no-so-subtle hint :)

Oh, I get it now. I'm kinda slow today.

*Simpsons-esque "I will create tickets for bug fixes and enhancements"
chalkboard scrawling*

d.

> 
> On 12/17/07, Dave Newton <[EMAIL PROTECTED]> wrote:
> > Oh; didn't know there was a ticket, sorry.
> >
> > d.
> >
> > --- Don Brown <[EMAIL PROTECTED]> wrote:
> >
> > > Don't forget to put the ticket number in the commit, cause that will
> > > usually be the bit that has the link to the thread.
> > >
> > > Don
> > >
> > > On 12/17/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
> > > > Author: davenewton
> > > > Date: Sun Dec 16 15:14:16 2007
> > > > New Revision: 604737
> > > >
> > > > URL: http://svn.apache.org/viewvc?rev=604737&view=rev
> > > > Log:
> > > > Patch for optiontransferselect.ftl null doubleListValue issue from
> Dale
> > > Newfield.
> > > >
> > > > See thread at
> > >
> >
>
http://www.nabble.com/-struts--2.0.11--optiontransferselect-limit--tt14344098.html#a14344098.
> > > >
> > > > Modified:
> > > >
> > >
> >
>
struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl
> > > >
> > > > Modified:
> > >
> >
>
struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl
> > > > URL:
> > >
> >
>
http://svn.apache.org/viewvc/struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl?rev=604737&r1=604736&r2=604737&view=diff
> > > >
> > >
> >
>
==
> > > > ---
> > >
> >
>
struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl
> > > (original)
> > > > +++
> > >
> >
>
struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl
> > > Sun Dec 16 15:14:16 2007
> > > > @@ -261,7 +261,9 @@
> > > >  <#t/>
> > > >  <#assign doubleItemKeyStr = doubleItemKey.toString() /><#t/>
> > > >  <#if parameters.doubleListValue?exists><#t/>
> > > > -<#assign doubleItemValue =
> > > stack.findString(parameters.doubleListValue) /><#t/>
> > > > +<#if
> > > stack.findString(parameters.doubleListValue)?has_content><#t/>
> > > > +<#assign doubleItemValue =
> > > stack.findString(parameters.doubleListValue) /><#t/>
> > > > +<#t/>
> > > >  <#else><#t/>
> > > >  <#assign doubleItemValue = stack.findString('top')
> /><#t/>
> > > >  <#t/>
> > > >
> > > >
> > > >
> > >
> > > -
> > > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > > For additional commands, e-mail: [EMAIL PROTECTED]
> > >
> > >
> >
> >
> > -
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> >
> >
> 
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 
> 


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [struts-dev] svn commit: r604737 - /struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl

[Dale Newfield]

Dave Newton wrote:

--- Don Brown <[EMAIL PROTECTED]> wrote:

Heh, that was the no-so-subtle hint :)


Oh, I get it now. I'm kinda slow today.

*Simpsons-esque "I will create tickets for bug fixes and enhancements"
chalkboard scrawling*


It's my fault for being slow.  I'm still working through the bug and I 
think I've got a better patch in the works.  I will create a JIRA ticket 
and upload a complete patch when I've been able to fully test it.  (If 
that's the only change in the svn commit I'd just revert it, because it 
does still have a couple issues as is.)


-Dale

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [struts-dev] svn commit: r604737 - /struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl

[Dave Newton]

--- Dale Newfield <[EMAIL PROTECTED]> wrote:
> Dave Newton wrote:
> > --- Don Brown <[EMAIL PROTECTED]> wrote:
> >> Heh, that was the no-so-subtle hint :)
> > 
> > Oh, I get it now. I'm kinda slow today.
> > 
> > *Simpsons-esque "I will create tickets for bug fixes and enhancements"
> > chalkboard scrawling*
> 
> It's my fault for being slow.  I'm still working through the bug and I 
> think I've got a better patch in the works.  I will create a JIRA ticket 
> and upload a complete patch when I've been able to fully test it.  (If 
> that's the only change in the svn commit I'd just revert it, because it 
> does still have a couple issues as is.)

Meh; it's better than it was; for now I'd just as soon leave it just to make
sure *something* gets fixed about it, just in case nobody has a chance to do
anything with it. I'll back it out if you're dead set, though.

d.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [struts-dev] svn commit: r604737 - /struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl

[Dale Newfield]

Dave Newton wrote:

Meh; it's better than it was; for now I'd just as soon leave it just to make
sure *something* gets fixed about it, just in case nobody has a chance to do
anything with it. I'll back it out if you're dead set, though.


There's no impending release, so I guess it doesn't matter if it sits 
for a few days in a slightly different broken state than it's been in 
for a while.  Thanks for being so pro-active in the first place :-)


-Dale

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [struts-dev] svn commit: r604737 - /struts/struts2/trunk/core/src/main/resources/template/simple/optiontransferselect.ftl

[Dave Newton]

--- Dale Newfield <[EMAIL PROTECTED]> wrote:
> There's no impending release, so I guess it doesn't matter if it sits 
> for a few days in a slightly different broken state than it's been in 
> for a while.  Thanks for being so pro-active in the first place :-)

There are a lot of guard clauses that should probably be put in place all
over, although... I'm not sure if it should be handled in the templates or in
the backing Java classes. Ah well.

d.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [s2] Build changes

[Antonio Petrelli]

2007/12/16, Don Brown <[EMAIL PROTECTED]>:
>
> * One step creation of assemblies, including j4 backport jars



This might interest you, I noticed it was not applied:
http://jira.opensymphony.com/browse/XW-585

One of the stumbling points of the project right now is releases are
> still not as easy as they should be



Did you try to use the Maven release plugin? I configured it for Struts 2
and I hope to use it for the next Struts 2.1.x release, but the patch
mentioned above must be resolved to work.
BTW, I could help configuring the Maven release plugin for XWork, but I
think I can do it only in January.

Ciao
Antonio

Re: [s2] Build changes

[Don Brown]

Yep, if you look in the OpenSymphony maven 2 repository, you'll see
the -jdk14 jar.  I closed the ticket accordingly.

I'm working on cleaning up the assembly right now as it is rather out
of date.  I'm really hoping we can use the release plugin...will make
things much easier.

Don

On Dec 17, 2007 6:52 PM, Antonio Petrelli <[EMAIL PROTECTED]> wrote:
> 2007/12/16, Don Brown <[EMAIL PROTECTED]>:
> >
> > * One step creation of assemblies, including j4 backport jars
>
>
>
> This might interest you, I noticed it was not applied:
> http://jira.opensymphony.com/browse/XW-585
>
> One of the stumbling points of the project right now is releases are
> > still not as easy as they should be
>
>
>
> Did you try to use the Maven release plugin? I configured it for Struts 2
> and I hope to use it for the next Struts 2.1.x release, but the patch
> mentioned above must be resolved to work.
> BTW, I could help configuring the Maven release plugin for XWork, but I
> think I can do it only in January.
>
> Ciao
> Antonio
>

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]