Re: [VOTE] Struts Master 12

[Lukasz Lenart]

czw., 23 sie 2018 o 14:11 Lukasz Lenart  napisał(a):
> [ ] Leave at test build
> [ ] Alpha
> [ ] Beta
> [X] General Availability (GA)

+1 (binding)

It works but some tiny adjustments in the pom are needed, nothing to
be worry about :)


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

Re: [VOTE] Struts Master 12

[Yasser Zamani]

On 8/24/2018 11:57 AM, Lukasz Lenart wrote:
> czw., 23 sie 2018 o 14:11 Lukasz Lenart  napisał(a):
>> [ ] Leave at test build
>> [ ] Alpha
>> [ ] Beta
>> [X] General Availability (GA)
> 
> +1 (binding)
> 
> It works but some tiny adjustments in the pom are needed, nothing to
> be worry about :)

Did you mean the master branch of Struts could being built successfully
with this new dependency? (of course, with some tiny adjustments in the
pom). I don't have access to my PC now to test.

Thanks in advance!

Re: [VOTE] Struts Master 12

[Lukasz Lenart]

pt., 24 sie 2018 o 13:28 Yasser Zamani  napisał(a):
> Did you mean the master branch of Struts could being built successfully
> with this new dependency? (of course, with some tiny adjustments in the
> pom). I don't have access to my PC now to test.

Yes, something has changed in the rat-plugin, using the below snippet
fixes the issue (temporary, I'm working on a real solution):

true


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

Re: [VOTE] Struts Master 12

[Yasser Zamani]

On 8/24/2018 4:02 PM, Lukasz Lenart wrote:
> pt., 24 sie 2018 o 13:28 Yasser Zamani  napisał(a):
>> Did you mean the master branch of Struts could being built successfully
>> with this new dependency? (of course, with some tiny adjustments in the
>> pom). I don't have access to my PC now to test.
> 
> Yes, something has changed in the rat-plugin, using the below snippet
> fixes the issue (temporary, I'm working on a real solution):
> 
> true

+1 GA (binding)

Thanks for your works :)

Regards,
Yasser.

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

Build failed in Jenkins: Struts-master-JDK7-dependency-check #95

[Apache Jenkins Server]

See 


Changes:

[lukaszlenart] Adds Maven wrapper to allow use the latest Maven version

[lukaszlenart] Avoids parsing namespace when using existing namespace

[lukaszlenart] Increases scope when location parsing is avoided

[lukaszlenart] Upgrades Jackson libs to version 2.9.5

[lukaszlenart] Makes OgnlUtil more immutable

[lukaszlenart] Adds proper handling of primitive types

[lukaszlenart] Adds more general exclusion

[lukaszlenart] Validates action, namespace and method in the same way

[lukaszlenart] delete redundant code for performance

[lukaszlenart] Fixes how dependencies are injected into constructor

[lukaszlenart] add an extra unit test

[lukaszlenart] Fixes conflicts after cherry-picked changes from 2.5.x branch

[lukaszlenart] WW-4955 Upgrades OGNL to version 3.2.6

[lukaszlenart] Adds additional test to check is ArrayList.size() is accessible

--
[...truncated 1.42 MB...]
at org.testng.TestRunner.runWorkers(TestRunner.java:1147)
at org.testng.TestRunner.privateRunJUnit(TestRunner.java:690)
at org.testng.TestRunner.run(TestRunner.java:597)
at org.testng.SuiteRunner.runTest(SuiteRunner.java:317)
at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:312)
at org.testng.SuiteRunner.privateRun(SuiteRunner.java:274)
at org.testng.SuiteRunner.run(SuiteRunner.java:223)
at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86)
at org.testng.TestNG.runSuitesSequentially(TestNG.java:1039)
at org.testng.TestNG.runSuitesLocally(TestNG.java:964)
at org.testng.TestNG.run(TestNG.java:900)
at 
org.apache.maven.surefire.testng.TestNGExecutor.run(TestNGExecutor.java:135)
at 
org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.executeMulti(TestNGDirectoryTestSuite.java:198)
at 
org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.execute(TestNGDirectoryTestSuite.java:94)
at 
org.apache.maven.surefire.testng.TestNGProvider.invoke(TestNGProvider.java:146)
at 
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:373)
at 
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:334)
at 
org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:119)
at 
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:407)
2018-08-24 11:38:55,421 WARN  [main] xwork2.DefaultLocaleProvider 
(DefaultLocaleProvider.java:53) - Cannot convert [_] to proper locale
java.lang.IllegalArgumentException: Invalid locale format: _
at org.apache.commons.lang3.LocaleUtils.toLocale(LocaleUtils.java:102) 
~[commons-lang3-3.6.jar:3.6]
at 
com.opensymphony.xwork2.DefaultLocaleProvider.isValidLocaleString(DefaultLocaleProvider.java:51)
 [classes/:?]
at 
org.apache.struts2.interceptor.I18nInterceptor.getLocaleFromParam(I18nInterceptor.java:166)
 [classes/:?]
at 
org.apache.struts2.interceptor.I18nInterceptor$SessionLocaleHandler.find(I18nInterceptor.java:276)
 [classes/:?]
at 
org.apache.struts2.interceptor.I18nInterceptor.intercept(I18nInterceptor.java:104)
 [classes/:?]
at 
org.apache.struts2.interceptor.I18nInterceptorTest.testDefaultLocale(I18nInterceptorTest.java:88)
 [test-classes/:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
~[?:1.7.0_80]
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) 
~[?:1.7.0_80]
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 ~[?:1.7.0_80]
at java.lang.reflect.Method.invoke(Method.java:606) ~[?:1.7.0_80]
at junit.framework.TestCase.runTest(TestCase.java:176) 
[junit-4.12.jar:4.12]
at junit.framework.TestCase.runBare(TestCase.java:141) 
[junit-4.12.jar:4.12]
at junit.framework.TestResult$1.protect(TestResult.java:122) 
[junit-4.12.jar:4.12]
at junit.framework.TestResult.runProtected(TestResult.java:142) 
[junit-4.12.jar:4.12]
at junit.framework.TestResult.run(TestResult.java:125) 
[junit-4.12.jar:4.12]
at junit.framework.TestCase.run(TestCase.java:129) [junit-4.12.jar:4.12]
at junit.framework.TestSuite.runTest(TestSuite.java:252) 
[junit-4.12.jar:4.12]
at junit.framework.TestSuite.run(TestSuite.java:247) 
[junit-4.12.jar:4.12]
at org.testng.junit.JUnitTestRunner.doRun(JUnitTestRunner.java:250) 
[testng-5.14.10.jar:?]
at org.testng.junit.JUnitTestRunner.start(JUnitTestRunner.java:223) 
[testng-5.14.10.jar:?]
at org.testng.junit.JUnitTestRunner.run(JUnitTestRunner.java:211) 
[testng-5.14.10.jar:?]
at org.testng.TestRunner$1.run(TestRunner.java:659) 
[testng-5.14.10.jar:?]