[GitHub] [submarine] lowc1012 commented on issue #174: SUBMARINE-202. submarine core need to support MXNet
lowc1012 commented on issue #174: SUBMARINE-202. submarine core need to support MXNet URL: https://github.com/apache/submarine/pull/174#issuecomment-585545961 @yuanzac, @pingsutw Thanks for your review. I have tested on my YARN cluster. Yes, we can submit MXNet job with this PR. And I made some modifications, please review it . Thank you! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@submarine.apache.org For additional commands, e-mail: dev-h...@submarine.apache.org
[jira] [Resolved] (SUBMARINE-323) Submarine release scripts
[ https://issues.apache.org/jira/browse/SUBMARINE-323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zac Zhou resolved SUBMARINE-323. Fix Version/s: 0.4.0 Resolution: Fixed Issue resolved by pull request 175 [https://github.com/apache/submarine/pull/175] > Submarine release scripts > - > > Key: SUBMARINE-323 > URL: https://issues.apache.org/jira/browse/SUBMARINE-323 > Project: Apache Submarine > Issue Type: New Feature > Components: CI/CD >Reporter: Zhankun Tang >Assignee: Zhankun Tang >Priority: Major > Labels: pull-request-available > Fix For: 0.4.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Automate steps of making a release for release manager. It should do at least > the following: > # Generate source tarball, binary tarball with the licence and sign them. > # Upload the submarine jars to maven central repo > # Upload artifacts to apache dist server > It's better if it can support Jira cleanup, source code branching/tagging, > submarine SDK repo uploading. etc. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@submarine.apache.org For additional commands, e-mail: dev-h...@submarine.apache.org
[jira] [Work logged] (SUBMARINE-323) Submarine release scripts
[ https://issues.apache.org/jira/browse/SUBMARINE-323?focusedWorklogId=386375=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386375 ] ASF GitHub Bot logged work on SUBMARINE-323: Author: ASF GitHub Bot Created on: 13/Feb/20 03:14 Start Date: 13/Feb/20 03:14 Worklog Time Spent: 10m Work Description: asfgit commented on pull request #175: SUBMARINE-323. Add how to release guide and scripts. URL: https://github.com/apache/submarine/pull/175 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 386375) Remaining Estimate: 0h Time Spent: 10m > Submarine release scripts > - > > Key: SUBMARINE-323 > URL: https://issues.apache.org/jira/browse/SUBMARINE-323 > Project: Apache Submarine > Issue Type: New Feature > Components: CI/CD >Reporter: Zhankun Tang >Assignee: Zhankun Tang >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Automate steps of making a release for release manager. It should do at least > the following: > # Generate source tarball, binary tarball with the licence and sign them. > # Upload the submarine jars to maven central repo > # Upload artifacts to apache dist server > It's better if it can support Jira cleanup, source code branching/tagging, > submarine SDK repo uploading. etc. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@submarine.apache.org For additional commands, e-mail: dev-h...@submarine.apache.org
[jira] [Updated] (SUBMARINE-323) Submarine release scripts
[ https://issues.apache.org/jira/browse/SUBMARINE-323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SUBMARINE-323: - Labels: pull-request-available (was: ) > Submarine release scripts > - > > Key: SUBMARINE-323 > URL: https://issues.apache.org/jira/browse/SUBMARINE-323 > Project: Apache Submarine > Issue Type: New Feature > Components: CI/CD >Reporter: Zhankun Tang >Assignee: Zhankun Tang >Priority: Major > Labels: pull-request-available > > Automate steps of making a release for release manager. It should do at least > the following: > # Generate source tarball, binary tarball with the licence and sign them. > # Upload the submarine jars to maven central repo > # Upload artifacts to apache dist server > It's better if it can support Jira cleanup, source code branching/tagging, > submarine SDK repo uploading. etc. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@submarine.apache.org For additional commands, e-mail: dev-h...@submarine.apache.org
[GitHub] [submarine] asfgit closed pull request #175: SUBMARINE-323. Add how to release guide and scripts.
asfgit closed pull request #175: SUBMARINE-323. Add how to release guide and scripts. URL: https://github.com/apache/submarine/pull/175 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@submarine.apache.org For additional commands, e-mail: dev-h...@submarine.apache.org
[submarine] branch master updated: SUBMARINE-323. Add how to release guide and scripts.
This is an automated email from the ASF dual-hosted git repository.
zhouquan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/submarine.git
The following commit(s) were added to refs/heads/master by this push:
new 9cff5f4 SUBMARINE-323. Add how to release guide and scripts.
9cff5f4 is described below
commit 9cff5f4442fcbd30ee29e4b213d0d99ac4d5d27e
Author: Zhankun Tang
AuthorDate: Fri Feb 7 11:15:56 2020 +0800
SUBMARINE-323. Add how to release guide and scripts.
### What is this PR for?
Submarine release scripts and guide
### What type of PR is it?
Feature
### Todos
* [1] - Automate steps in cicd images
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-323
### How should this be tested?
When a committer is preparing a new release, this can be verified.
Zhankun has gone through the guide with the scripts. No big issue found yet.
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes
Author: Zhankun Tang
Closes #175 from tangzhankun/SUBMARINE-323 and squashes the following
commits:
621eb39 [Zhankun Tang] discard TonY submodule commmand when publishing to
mvn
fe2119e [Zhankun Tang] discard TonY submodule commmand when creating release
026d435 [Zhankun Tang] SUBMRINE-323. How to release guide and scripts.
---
dev-support/cicd/HowToRelease.md| 185
dev-support/cicd/README.md | 3 +-
dev-support/cicd/common_release.sh | 65 +
dev-support/cicd/create_release.sh | 106 +
dev-support/cicd/publish_release.sh | 172 +
5 files changed, 530 insertions(+), 1 deletion(-)
diff --git a/dev-support/cicd/HowToRelease.md b/dev-support/cicd/HowToRelease.md
new file mode 100644
index 000..5cd77e4
--- /dev/null
+++ b/dev-support/cicd/HowToRelease.md
@@ -0,0 +1,185 @@
+# How To Release Apache Submarine
+This document is for Apache Submarine committer and PMCs to do a new release.
+
+## Preparation
+If you have not already done so, generate your PGP key and append your
[signing key](http://www.apache.org/dev/release-signing.html#keys-policy) to
the [KEYS](https://dist.apache.org/repos/dist/release/submarine/KEYS) file.
Once you commit your changes (ask for PMC's help if you cannot), they will
automatically be propagated to the website. Also upload your key to a public
key server if you haven't.
+End users use the KEYS file to validate that releases were done by an Apache
committer.
+
+```
+# generate key and upload to the public
+gpg --gen-key
+gpg --list-sigs
+gpg --keyserver pgp.mit.edu --send-key
+gpg --refresh-keys --keyserver pgp.mit.edu
+# adding your key to submarine KEYS
+gpg --list-sigs >> ~/key.txt
+gpg --armor --export >> ~/key.txt
+svn co --depth immediates https://dist.apache.org/repos/dist apache-dist
+cd apache-dist
+svn update --set-depth infinity release/submarine
+cd release/submarine
+echo ~/key.txt >> KEYS
+svn add KEYS
+svn ci -m "Add 's key"
+```
+
+## Release Plan
+It's better to send a release plan email informing code freeze date and
release date.
+
+## Clean up the JIRA
+Bulk update JIRA to unassign from this release all issues that are open
non-blockers.
+Assuming we're releasing version X, use below advanced filter in [submarine
issue page](https://issues.apache.org/jira/projects/SUBMARINE). For instance,
if we're releasing 0.3.0.
+```
+project in ("Apache Submarine") AND "Target Version" = 0.3.0 AND
statusCategory != Done
+```
+Click "tools"-> "bulk update" to edit all issues:
+1. Change the target version to X+1. Here it is 0.4.0
+2. Add a comment to inform contributors. Like this "Bulk update due to
releasing 0.3.0. Please change it back if you think this is a blocker."
+
+Do a double-check to confirm that there's no issues found with the above
filter. And send mail to the develeper list informing that we should mark
"Target version" to 0.4.0 when creating new JIRAs.
+
+## Tagging
+Once the JIRA is cleaned up, we can tag the candidate release with below steps:
+```
+export version=0.3.0
+export cversion=0.3.0-RC0
+export tag=release-$cversion
+git tag -s release-$version -m "Release candidate - $version"
+# Verify the tag is signed with your GPG key
+git tag -v release-$cversion
+# Push the tag to upstream
+git push origin release-$cversion
+```
+
+## Build Artifacts
+
+The submarine artifacts consists of GPG signed source code tarball, binary
tarball and docker images.
+```
+cd submarine/dev-support/cicd/
+./create_release.sh $version $tag
+#Move the artifacts to a folder instead of /tmp/
+mv /tmp/submarine-release ~/
+```
+
+## Upload Artifacts For Vote
+Before the uploading, we need to do some basic testing for the release
candidates. For instance, build from the
[jira] [Resolved] (SUBMARINE-344) Add submarine site dockerfile
[ https://issues.apache.org/jira/browse/SUBMARINE-344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zac Zhou resolved SUBMARINE-344. Fix Version/s: 0.4.0 Resolution: Fixed Issue resolved by pull request 177 [https://github.com/apache/submarine/pull/177] > Add submarine site dockerfile > - > > Key: SUBMARINE-344 > URL: https://issues.apache.org/jira/browse/SUBMARINE-344 > Project: Apache Submarine > Issue Type: Sub-task > Components: CI/CD >Reporter: Liu Xun >Assignee: Zhankun Tang >Priority: Major > Labels: pull-request-available > Fix For: 0.4.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Now the official website of submarine is at: > https://github.com/apache/submarine-site.git > Use jekyll to convert markdown documents into html files, > Show it on submarine.apache.org. > Now jekyll's service is running through docker. We need to add an image > apache/submairne:site-0.3.0-SNAPSHOT for developing the official website. > This docker needs to meet the following requirements. > 1. This docker has built-in jekyll service, we can use the docker image here > as our base image. If possible, I recommend using jekyll/jekyll:minimal, > because the mirror volume is relatively small. > 2. We need to follow the git component in submairne:site-0.3.0-SNAPSHOT, so > that we can use the git clone command directly in the container > git clone https://github.com/apache/submarine-site.git > git checkout master > Allow the maintenance staff to modify the complete in the container, generate > html files through jekyll, > Upload the markdown file to the master branch and the html file to the > asf-site branch. > 3. Just like submarine-cicd, > https://github.com/apache/submarine/tree/master/dev-support/cicd#docker-mode > It can support setting the git account and password as the container's > startup command through the docker environment variable, and running this > container will allow git to log in with a username and password. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@submarine.apache.org For additional commands, e-mail: dev-h...@submarine.apache.org
[GitHub] [submarine] asfgit closed pull request #177: SUBMARINE-344. Support update submarine site in CICD image
asfgit closed pull request #177: SUBMARINE-344. Support update submarine site in CICD image URL: https://github.com/apache/submarine/pull/177 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@submarine.apache.org For additional commands, e-mail: dev-h...@submarine.apache.org
[submarine] branch master updated: SUBMARINE-344. Support update submarine site in CICD image
This is an automated email from the ASF dual-hosted git repository.
zhouquan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/submarine.git
The following commit(s) were added to refs/heads/master by this push:
new 39cbe9f SUBMARINE-344. Support update submarine site in CICD image
39cbe9f is described below
commit 39cbe9f87742aef86563e7c3255fd4a235afb2c1
Author: Zhankun Tang
AuthorDate: Tue Feb 11 10:51:53 2020 +0800
SUBMARINE-344. Support update submarine site in CICD image
### What is this PR for?
Support update submarine site in CICD image
### What type of PR is it?
Feature
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-344
### How should this be tested?
A committer use the build_and_start_cicd_image.sh to start the CICD image.
Choose item 2 on the menu.
Use vim to edit the submarine-site files and access 0.0.0.0:4000 with a
browser.
Type "exit" when finishing all the changes.
Input the commit message.
Check the submarine.apache.org to see changes take effect.
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes
Author: Zhankun Tang
Closes #177 from tangzhankun/SUBMARINE-344 and squashes the following
commits:
58aaa2f [Zhankun Tang] Move checkout branch before the git pull operation
771b431 [Zhankun Tang] Checkout master branch at the beginning to support
re-run of entry.sh when starting an existing CICD image container
03cf937 [Zhankun Tang] Update cicd readme.md
121b727 [Zhankun Tang] Support update submarine site in CICD image
---
dev-support/cicd/Dockerfile| 11
dev-support/cicd/README.md | 15 +++--
dev-support/cicd/build_and_start_cicd_image.sh | 2 +-
dev-support/cicd/entry.sh | 81 ++
4 files changed, 100 insertions(+), 9 deletions(-)
diff --git a/dev-support/cicd/Dockerfile b/dev-support/cicd/Dockerfile
index 8517083..88caad8 100644
--- a/dev-support/cicd/Dockerfile
+++ b/dev-support/cicd/Dockerfile
@@ -36,4 +36,15 @@ ADD \
ENV \
SUBMARINE_HOME=/submarine \
PYTHON_VENV_PATH=/root
+
+RUN apt-get update && apt-get -y install bundler
+
+RUN \
+ cd / && \
+ git clone https://gitbox.apache.org/repos/asf/submarine-site.git && \
+ cd /submarine-site && bundle update
+
+ENV \
+ SUBMARINE_SITE=/submarine-site
+
CMD /entry.sh
diff --git a/dev-support/cicd/README.md b/dev-support/cicd/README.md
index f6c5bad..b021404 100644
--- a/dev-support/cicd/README.md
+++ b/dev-support/cicd/README.md
@@ -45,22 +45,21 @@ export APACHE_NAME='Your apache name'
And you'll see output like below and then you can decide what to accomplish.
```
-$ docker run -it -e JIRA_USERNAME="${JIRA_USERNAME}" -e
JIRA_PASSWORD="${JIRA_PASSWORD}" -e APACHE_ID="${APACHE_ID}" -e
APACHE_NAME="${APACHE_NAME}" --rm submarine-cicd
+$ docker run -it -e JIRA_USERNAME="${JIRA_USERNAME}" -e
JIRA_PASSWORD="${JIRA_PASSWORD}" -e APACHE_ID="${APACHE_ID}" -e
APACHE_NAME="${APACHE_NAME}" -p 4000:4000 --rm submarine-cicd
```
The screen outputs the following information:
```
Menu:
-1. Merge PR
-Enter Menu ID:1
- Merge PR Begin
-Got JIRA name: username
-
-Enter Your Apache committer ID:
+ 1. Merge PR
+ 2. Update Submarine Website
+Enter Menu ID:
```
-## Manual mode
+As you can see, the Docker mode support several features like merging PR and
updating the web site. Choose the task you need to do and follow the popup tip
to go on.
+
+## Manual mode (Not Recommended)
First, You need install `python 2.7.13` and `pip insall jira`
diff --git a/dev-support/cicd/build_and_start_cicd_image.sh
b/dev-support/cicd/build_and_start_cicd_image.sh
index ff3b0ed..e5b4001 100755
--- a/dev-support/cicd/build_and_start_cicd_image.sh
+++ b/dev-support/cicd/build_and_start_cicd_image.sh
@@ -18,4 +18,4 @@ set -e
printf "Building Submarine CI/CD Image.\n"
docker build -t submarine-cicd .
printf "Start Submarine CI/CD.\n"
-docker run -it --rm submarine-cicd
+docker run -it --rm -p 4000:4000 submarine-cicd
diff --git a/dev-support/cicd/entry.sh b/dev-support/cicd/entry.sh
index 253aa21..e75a12b 100755
--- a/dev-support/cicd/entry.sh
+++ b/dev-support/cicd/entry.sh
@@ -20,11 +20,15 @@ set -e
function start_menu(){
printf "Menu:\n"
printf "\t1. Merge PR\n"
+ printf "\t2. Update Submarine Website\n"
read -p "Enter Menu ID:" menu_id
case $menu_id in
"1")
merge_pr
;;
+"2")
+ update_submarine_site
+;;
"*")
printf "unknown. Exiting."
;;
@@ -67,6 +71,7 @@ function merge_pr(){
echo "Got Apache name: ${apache_name}"
cd $SUBMARINE_HOME
+ git checkout master
git pull
git config user.name "${apache_name}"
git config user.email "${apache_id}@apache.org"
@@
[jira] [Work logged] (SUBMARINE-344) Add submarine site dockerfile
[ https://issues.apache.org/jira/browse/SUBMARINE-344?focusedWorklogId=386370=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386370 ] ASF GitHub Bot logged work on SUBMARINE-344: Author: ASF GitHub Bot Created on: 13/Feb/20 03:10 Start Date: 13/Feb/20 03:10 Worklog Time Spent: 10m Work Description: asfgit commented on pull request #177: SUBMARINE-344. Support update submarine site in CICD image URL: https://github.com/apache/submarine/pull/177 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 386370) Remaining Estimate: 0h Time Spent: 10m > Add submarine site dockerfile > - > > Key: SUBMARINE-344 > URL: https://issues.apache.org/jira/browse/SUBMARINE-344 > Project: Apache Submarine > Issue Type: Sub-task > Components: CI/CD >Reporter: Liu Xun >Assignee: Zhankun Tang >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Now the official website of submarine is at: > https://github.com/apache/submarine-site.git > Use jekyll to convert markdown documents into html files, > Show it on submarine.apache.org. > Now jekyll's service is running through docker. We need to add an image > apache/submairne:site-0.3.0-SNAPSHOT for developing the official website. > This docker needs to meet the following requirements. > 1. This docker has built-in jekyll service, we can use the docker image here > as our base image. If possible, I recommend using jekyll/jekyll:minimal, > because the mirror volume is relatively small. > 2. We need to follow the git component in submairne:site-0.3.0-SNAPSHOT, so > that we can use the git clone command directly in the container > git clone https://github.com/apache/submarine-site.git > git checkout master > Allow the maintenance staff to modify the complete in the container, generate > html files through jekyll, > Upload the markdown file to the master branch and the html file to the > asf-site branch. > 3. Just like submarine-cicd, > https://github.com/apache/submarine/tree/master/dev-support/cicd#docker-mode > It can support setting the git account and password as the container's > startup command through the docker environment variable, and running this > container will allow git to log in with a username and password. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@submarine.apache.org For additional commands, e-mail: dev-h...@submarine.apache.org
[GitHub] [submarine] yuanzac commented on issue #174: SUBMARINE-202. submarine core need to support MXNet
yuanzac commented on issue #174: SUBMARINE-202. submarine core need to support MXNet URL: https://github.com/apache/submarine/pull/174#issuecomment-585521799 Any more comments? @lowc1012, @pingsutw, @liuxunorg, @tangzhankun This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@submarine.apache.org For additional commands, e-mail: dev-h...@submarine.apache.org
[GitHub] [submarine] yuanzac commented on a change in pull request #179: SUBMARINE-377. [SDK] Submit a job by pysubamrine
yuanzac commented on a change in pull request #179: SUBMARINE-377. [SDK] Submit
a job by pysubamrine
URL: https://github.com/apache/submarine/pull/179#discussion_r378623370
##
File path:
submarine-server/server-submitter/submitter-yarn/src/main/java/org/apache/submarine/server/submitter/yarn/YarnUtils.java
##
@@ -46,129 +44,61 @@
private static final Log LOG = LogFactory.getLog(YarnUtils.class);
public static Configuration tonyConfFromClientContext(
- ParametersHolder parameters) throws YarnException, ParseException {
+ RunJobParameters parameters, Framework framework) throws
YarnException, ParseException {
Configuration tonyConf = new Configuration();
// Add tony.xml for configuration.
tonyConf.addResource(Constants.TONY_XML);
tonyConf.setStrings(TonyConfigurationKeys.FRAMEWORK_NAME,
-parameters.getFramework().getValue());
+framework.getValue());
tonyConf.setStrings(TonyConfigurationKeys.APPLICATION_NAME,
-parameters.getParameters().getName());
-tonyConf.setStrings(
-TonyConfigurationKeys.getInstancesKey(Constants.WORKER_JOB_NAME),
-parameters.getOptionValue(CliConstants.N_WORKERS));
-if (parameters.getOptionValue(CliConstants.N_PS) != null) {
- tonyConf.setStrings(
- TonyConfigurationKeys.getInstancesKey(Constants.PS_JOB_NAME),
- parameters.getOptionValue(CliConstants.N_PS));
-}
-// Resources for PS & Worker
-if (parameters.getOptionValue(CliConstants.PS_RES) != null) {
Review comment:
Got you~
With this modification, does it still work when yaml is used to submit a job?
I just want to make sure that function is not affected.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@submarine.apache.org
For additional commands, e-mail: dev-h...@submarine.apache.org
[jira] [Updated] (SUBMARINE-384) Add EditorConfig metafile to reduce growth of the indentation mess
[ https://issues.apache.org/jira/browse/SUBMARINE-384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zac Zhou updated SUBMARINE-384: --- Fix Version/s: 0.4.0 Resolution: Fixed Status: Resolved (was: Patch Available) Issue resolved by pull request 181 [https://github.com/apache/submarine/pull/181] > Add EditorConfig metafile to reduce growth of the indentation mess > -- > > Key: SUBMARINE-384 > URL: https://issues.apache.org/jira/browse/SUBMARINE-384 > Project: Apache Submarine > Issue Type: New Feature >Reporter: Wanqiang Ji >Assignee: Wanqiang Ji >Priority: Major > Labels: pull-request-available > Fix For: 0.4.0 > > Time Spent: 20m > Remaining Estimate: 0h > > EditorConfig helps maintain consistent coding styles for multiple developers > working on the same project across various editors and IDEs. Considering the > growth of community development, we need to add the file in the project. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@submarine.apache.org For additional commands, e-mail: dev-h...@submarine.apache.org
[GitHub] [submarine] asfgit closed pull request #181: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess
asfgit closed pull request #181: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess URL: https://github.com/apache/submarine/pull/181 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@submarine.apache.org For additional commands, e-mail: dev-h...@submarine.apache.org
[submarine] branch master updated: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess
This is an automated email from the ASF dual-hosted git repository.
zhouquan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/submarine.git
The following commit(s) were added to refs/heads/master by this push:
new e3b5c5c SUBMARINE-384. Add EditorConfig metafile to reduce growth of
the indentation mess
e3b5c5c is described below
commit e3b5c5cda9c8cc59ddc8a2406fac4211c68b17cf
Author: Wanqiang Ji
AuthorDate: Mon Feb 10 23:52:20 2020 +0800
SUBMARINE-384. Add EditorConfig metafile to reduce growth of the
indentation mess
### What is this PR for?
To reduce growth of the indentation mess
### What type of PR is it?
[Improvement]
### Todos
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-384
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Author: Wanqiang Ji
Closes #181 from jiwq/SUBMARINE-384 and squashes the following commits:
d381931 [Wanqiang Ji] SUBMARINE-384. Add EditorConfig metafile to reduce
growth of the indentation mess
---
.editorconfig | 27 +++
pom.xml | 1 +
2 files changed, 28 insertions(+)
diff --git a/.editorconfig b/.editorconfig
new file mode 100644
index 000..59e9dc4
--- /dev/null
+++ b/.editorconfig
@@ -0,0 +1,27 @@
+# EditorConfig is awesome: http://EditorConfig.org
+
+# top-most EditorConfig file
+root = true
+
+[*]
+charset = utf-8
+end_of_line = lf
+insert_final_newline = true
+trim_trailing_whitespace = true
+
+# tab indentation (no size specified)
+[{Makefile,go.mod,go.sum,*.go}]
+indent_style = tab
+
+# 2 space indentation
+[*.{java,sh,json,xml}]
+indent_style = space
+indent_size = 2
+
+# 4 space indentation
+[*.{py,R,js}]
+indent_style = space
+indent_size = 4
+
+[*.java]
+max_line_length = 100
diff --git a/pom.xml b/pom.xml
index cca02cd..56754c5 100644
--- a/pom.xml
+++ b/pom.xml
@@ -465,6 +465,7 @@
.github/*
.gitignore
.gitmodules
+.editorconfig
LICENSE
license_header
**/*.iml
-
To unsubscribe, e-mail: dev-unsubscr...@submarine.apache.org
For additional commands, e-mail: dev-h...@submarine.apache.org
[jira] [Work logged] (SUBMARINE-384) Add EditorConfig metafile to reduce growth of the indentation mess
[ https://issues.apache.org/jira/browse/SUBMARINE-384?focusedWorklogId=386349=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386349 ] ASF GitHub Bot logged work on SUBMARINE-384: Author: ASF GitHub Bot Created on: 13/Feb/20 01:59 Start Date: 13/Feb/20 01:59 Worklog Time Spent: 10m Work Description: asfgit commented on pull request #181: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess URL: https://github.com/apache/submarine/pull/181 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 386349) Time Spent: 20m (was: 10m) > Add EditorConfig metafile to reduce growth of the indentation mess > -- > > Key: SUBMARINE-384 > URL: https://issues.apache.org/jira/browse/SUBMARINE-384 > Project: Apache Submarine > Issue Type: New Feature >Reporter: Wanqiang Ji >Assignee: Wanqiang Ji >Priority: Major > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > EditorConfig helps maintain consistent coding styles for multiple developers > working on the same project across various editors and IDEs. Considering the > growth of community development, we need to add the file in the project. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@submarine.apache.org For additional commands, e-mail: dev-h...@submarine.apache.org
[GitHub] [submarine] asfgit closed pull request #180: SUBMARINE-379. Delete invalid .gitmodules file
asfgit closed pull request #180: SUBMARINE-379. Delete invalid .gitmodules file URL: https://github.com/apache/submarine/pull/180 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@submarine.apache.org For additional commands, e-mail: dev-h...@submarine.apache.org
[jira] [Resolved] (SUBMARINE-379) Delete invalid .gitmodules file
[ https://issues.apache.org/jira/browse/SUBMARINE-379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Xun resolved SUBMARINE-379. --- Fix Version/s: 0.4.0 Resolution: Fixed Issue resolved by pull request 180 [https://github.com/apache/submarine/pull/180] > Delete invalid .gitmodules file > --- > > Key: SUBMARINE-379 > URL: https://issues.apache.org/jira/browse/SUBMARINE-379 > Project: Apache Submarine > Issue Type: Bug > Components: Build >Reporter: Liu Xun >Assignee: Liu Xun >Priority: Major > Labels: pull-request-available > Fix For: 0.4.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Deleted the tony submodule in > https://issues.apache.org/jira/browse/SUBMARINE-371, but forgot to delete the > submodule file. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@submarine.apache.org For additional commands, e-mail: dev-h...@submarine.apache.org
[submarine] branch master updated: SUBMARINE-379. Delete invalid .gitmodules file
This is an automated email from the ASF dual-hosted git repository. liuxun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/submarine.git The following commit(s) were added to refs/heads/master by this push: new e03b08f SUBMARINE-379. Delete invalid .gitmodules file e03b08f is described below commit e03b08fa6b7d33f7f577c651229c4fafeb9227b7 Author: Xun Liu AuthorDate: Wed Feb 12 13:09:02 2020 +0800 SUBMARINE-379. Delete invalid .gitmodules file ### What is this PR for? Deleted the tony submodule in https://issues.apache.org/jira/browse/SUBMARINE-371, but forgot to delete the .gitmodules file and configure in pom.xml. ### What type of PR is it? [Bug Fix] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/SUBMARINE-379 ### How should this be tested? * https://travis-ci.org/liuxunorg/submarine/builds/648431616 ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Xun Liu Closes #180 from liuxunorg/SUBMARINE-379 and squashes the following commits: 4ad157b [Xun Liu] fix 3d1089e [Xun Liu] SUBMARINE-379. Delete invalid .gitmodules file --- .gitignore| 1 - .gitmodules | 0 pom.xml | 2 -- submarine-workbench/interpreter/README.md | 21 - 4 files changed, 24 deletions(-) diff --git a/.gitignore b/.gitignore index 3c4db43..52be391 100644 --- a/.gitignore +++ b/.gitignore @@ -58,7 +58,6 @@ venv.bak/ *.jar target dev-support/mini-submarine/database -submodules/tony/tony-core/build submarine-workbench/workbench-web/node submarine-workbench/workbench-web/node_modules submarine-workbench/workbench-web/dist diff --git a/.gitmodules b/.gitmodules deleted file mode 100644 index e69de29..000 diff --git a/pom.xml b/pom.xml index de191ee..cca02cd 100644 --- a/pom.xml +++ b/pom.xml @@ -443,7 +443,6 @@ true - com/linkedin/tony/rpc/proto/*,com/linkedin/tony/events/* @@ -483,7 +482,6 @@ **/*.json **/*.conf **/*.yaml -**/src/main/java/com/linkedin/tony/events/* **/src/main/resources/META-INF/services/org.apache.hadoop.security.SecurityInfo **/src/test/resources/typicalHistFolder/job1/application123-1-1-user1-SUCCEEDED.jhist **/conf/routes diff --git a/submarine-workbench/interpreter/README.md b/submarine-workbench/interpreter/README.md deleted file mode 100644 index 9483549..000 --- a/submarine-workbench/interpreter/README.md +++ /dev/null @@ -1,21 +0,0 @@ - -# Interpreter parent module - -### Compile the interpreter parent module separately -``` -cd /submarine # submarine project root path -mvn install package -DskipTests -pl '!submarine-all,!submarine-core,!submarine-dist,!submarine-runtime/tony-runtime,!submodules/tony,!submodules/tony/tony-mini,!submodules/tony/tony-core,!submodules/tony/tony-proxy,!submodules/tony/tony-portal,!submodules/tony/tony-azkaban,!submodules/tony/tony-cli,!submarine-workbench,!submarine-workbench/workbench-web,!submarine-workbench/workbench-server,!submarine-dist' -``` - To unsubscribe, e-mail: dev-unsubscr...@submarine.apache.org For additional commands, e-mail: dev-h...@submarine.apache.org
[jira] [Work logged] (SUBMARINE-379) Delete invalid .gitmodules file
[ https://issues.apache.org/jira/browse/SUBMARINE-379?focusedWorklogId=386323=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386323 ] ASF GitHub Bot logged work on SUBMARINE-379: Author: ASF GitHub Bot Created on: 13/Feb/20 00:29 Start Date: 13/Feb/20 00:29 Worklog Time Spent: 10m Work Description: asfgit commented on pull request #180: SUBMARINE-379. Delete invalid .gitmodules file URL: https://github.com/apache/submarine/pull/180 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 386323) Time Spent: 20m (was: 10m) > Delete invalid .gitmodules file > --- > > Key: SUBMARINE-379 > URL: https://issues.apache.org/jira/browse/SUBMARINE-379 > Project: Apache Submarine > Issue Type: Bug > Components: Build >Reporter: Liu Xun >Assignee: Liu Xun >Priority: Major > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > Deleted the tony submodule in > https://issues.apache.org/jira/browse/SUBMARINE-371, but forgot to delete the > submodule file. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@submarine.apache.org For additional commands, e-mail: dev-h...@submarine.apache.org
[GitHub] [submarine] pingsutw commented on issue #181: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess
pingsutw commented on issue #181: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess URL: https://github.com/apache/submarine/pull/181#issuecomment-585223596 Okay. If it's not conflicted, I thought we don't need to change it. Thanks @jiwq. LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@submarine.apache.org For additional commands, e-mail: dev-h...@submarine.apache.org
[GitHub] [submarine] jiwq commented on issue #181: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess
jiwq commented on issue #181: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess URL: https://github.com/apache/submarine/pull/181#issuecomment-585217039 > There is an EditConfig file in `submarine-workbench/workbench-web/.editorconfig`, Do we need to combine to this config (`./submarine/.editorconfig`) @pingsutw Thanks for your focus, I think it's not conflicted. On the contrary, the subproject should better own itself EditorConfig. Any thoughts? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@submarine.apache.org For additional commands, e-mail: dev-h...@submarine.apache.org
[GitHub] [submarine] jiwq commented on a change in pull request #181: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess
jiwq commented on a change in pull request #181: SUBMARINE-384. Add
EditorConfig metafile to reduce growth of the indentation mess
URL: https://github.com/apache/submarine/pull/181#discussion_r378262508
##
File path: .editorconfig
##
@@ -0,0 +1,25 @@
+# EditorConfig is awesome: http://EditorConfig.org
+
+# top-most EditorConfig file
+root = true
+
+# newline ending every file; no trailing space
+[*]
+charset = utf-8
+insert_final_newline = true
+trim_trailing_whitespace = false
+
+# tab indentation (no size specified)
+[{Makefile,go.mod,go.sum,*.go}]
+indent_style = tab
+
+# 2 space indentation
+[*.{java,json,sh}]
+indent_style = space
+indent_size = 2
+
+# 4 space indentation
+[*.{py,R,xml,js}]
Review comment:
Done.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@submarine.apache.org
For additional commands, e-mail: dev-h...@submarine.apache.org
[GitHub] [submarine] jiwq edited a comment on issue #181: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess
jiwq edited a comment on issue #181: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess URL: https://github.com/apache/submarine/pull/181#issuecomment-585211977 > With this EditorConfig file, what settings need to be set in the development tool (e.g., IDEA)? Hi @liuxunorg, high-frequency IDEs(IDEA/PyCharm/WebStorm/VisualStudio and so on) come bundled with native support for EditorConfig. So the user do not need extra work. More info see [here](https://editorconfig.org/). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@submarine.apache.org For additional commands, e-mail: dev-h...@submarine.apache.org
[GitHub] [submarine] jiwq commented on issue #181: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess
jiwq commented on issue #181: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess URL: https://github.com/apache/submarine/pull/181#issuecomment-585211977 > With this EditorConfig file, what settings need to be set in the development tool (e.g., IDEA)? High-frequency IDEs(IDEA/PyCharm/WebStorm/VisualStudio and so on) come bundled with native support for EditorConfig. So the user do not need extra work. More info see [here](https://editorconfig.org/). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@submarine.apache.org For additional commands, e-mail: dev-h...@submarine.apache.org
[GitHub] [submarine] jiwq commented on a change in pull request #181: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess
jiwq commented on a change in pull request #181: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess URL: https://github.com/apache/submarine/pull/181#discussion_r378253807 ## File path: .editorconfig ## @@ -0,0 +1,25 @@ +# EditorConfig is awesome: http://EditorConfig.org + +# top-most EditorConfig file +root = true + +# newline ending every file; no trailing space Review comment: Done. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@submarine.apache.org For additional commands, e-mail: dev-h...@submarine.apache.org
[GitHub] [submarine] pingsutw commented on issue #181: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess
pingsutw commented on issue #181: SUBMARINE-384. Add EditorConfig metafile to reduce growth of the indentation mess URL: https://github.com/apache/submarine/pull/181#issuecomment-585154100 There is an EditConfig file in `submarine-workbench/workbench-web/.editorconfig`, Do we need to combine to this config (`./submarine/.editorconfig`) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@submarine.apache.org For additional commands, e-mail: dev-h...@submarine.apache.org
[GitHub] [submarine] pingsutw commented on issue #179: SUBMARINE-377. [SDK] Submit a job by pysubamrine
pingsutw commented on issue #179: SUBMARINE-377. [SDK] Submit a job by pysubamrine URL: https://github.com/apache/submarine/pull/179#issuecomment-585119393 Update patch. - remove pb2*.py that generated from protobuf - update readme This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@submarine.apache.org For additional commands, e-mail: dev-h...@submarine.apache.org
