Re: svn commit: r1890239 - in /subversion/site/staging: docs/community-guide/general.part.html faq.html

2021-05-27 Thread Daniel Sahlberg
Den tors 27 maj 2021 kl 20:21 skrev Nathan Hartman :

> On Thu, May 27, 2021 at 1:52 PM Daniel Shahaf 
> wrote:
>
>> s...@apache.org wrote on Thu, 27 May 2021 07:12 +00:00:
>> > Add links to libera.chat's new web interface.
>> >
>> > +++ subversion/site/staging/docs/community-guide/general.part.html Thu
>> May 27 07:12:43 2021
>> > +or via the https://web.libera.chat/?channel=svn-dev;
>> > +>libera.chat IRC webchat interface.
>> >
>> > +++ subversion/site/staging/faq.html Thu May 27 07:12:43 2021
>> > +  the https://web.libera.chat/?channel=#svn;>web
>> interface or
>>
>> One of the new links has a «#» and one doesn't.  Double-checking that
>> they're both correct?
>
>
> Nope. On my system the link to #svn works; the link to svn-dev without the
> # pre-populates the field with #libera instead.
>
> Also the first link says "libera.chat IRC webchat interface" while the
> second just says "web interface," but that might be intentional.
>

While I was looking at the website I updated this as well, r1890256.

/Daniel Sahlberg


Re: svn commit: r1890232 - in /subversion/site/staging: docs/community-guide/general.part.html faq.html index.html

2021-05-27 Thread Daniel Sahlberg
Den tors 27 maj 2021 kl 02:14 skrev Nathan Hartman :

> Otherwise LGTM. Thanks so much!
>
> Nathan
>

Thanks, Nathan! Committed r1890255

/Daniel Sahlberg


Re: svn commit: r1890239 - in /subversion/site/staging: docs/community-guide/general.part.html faq.html

2021-05-27 Thread Nathan Hartman
On Thu, May 27, 2021 at 1:52 PM Daniel Shahaf 
wrote:

> s...@apache.org wrote on Thu, 27 May 2021 07:12 +00:00:
> > Add links to libera.chat's new web interface.
> >
> > +++ subversion/site/staging/docs/community-guide/general.part.html Thu
> May 27 07:12:43 2021
> > +or via the https://web.libera.chat/?channel=svn-dev;
> > +>libera.chat IRC webchat interface.
> >
> > +++ subversion/site/staging/faq.html Thu May 27 07:12:43 2021
> > +  the https://web.libera.chat/?channel=#svn;>web
> interface or
>
> One of the new links has a «#» and one doesn't.  Double-checking that
> they're both correct?


Nope. On my system the link to #svn works; the link to svn-dev without the
# pre-populates the field with #libera instead.

Also the first link says "libera.chat IRC webchat interface" while the
second just says "web interface," but that might be intentional.

Nathan


Re: svn commit: r1890239 - in /subversion/site/staging: docs/community-guide/general.part.html faq.html

2021-05-27 Thread Daniel Shahaf
s...@apache.org wrote on Thu, 27 May 2021 07:12 +00:00:
> Add links to libera.chat's new web interface.
> 
> +++ subversion/site/staging/docs/community-guide/general.part.html Thu May 27 
> 07:12:43 2021
> +or via the https://web.libera.chat/?channel=svn-dev;
> +>libera.chat IRC webchat interface.
>  
> +++ subversion/site/staging/faq.html Thu May 27 07:12:43 2021
> +  the https://web.libera.chat/?channel=#svn;>web interface 
> or

One of the new links has a «#» and one doesn't.  Double-checking that they're 
both correct?

Cheers,

Daniel


Re: svn commit: r1890223 - /subversion/trunk/subversion/svn_private_config.hw

2021-05-27 Thread Daniel Shahaf
b...@qqmail.nl wrote on Thu, 27 May 2021 11:51 +00:00:
> We will need a few more patches to really support ARM64 builds. Once I 
> get things working I’ll add a pull request.

Neither backport.pl nor backport.py support pull requests, so the RM
would have to merge it manually.

> Most likely I will release a SlikSvn client release for ARM64 with that 
> support if everything comes together… But cross compiling on Windows is 
> quite new for most of our dependencies, and ARM64 is new as well so 
> most dependencies need patches (except for those building via CMake)

Is the relation between not needing patches and using CMake merely
correlation or also causation?

Cheers,

Daniel


RE: svn commit: r1890223 - /subversion/trunk/subversion/svn_private_config.hw

2021-05-27 Thread bert
We will need a few more patches to really support ARM64 builds. Once I get 
things working I’ll add a pull request.

 

Most likely I will release a SlikSvn client release for ARM64 with that support 
if everything comes together… But cross compiling on Windows is quite new for 
most of our dependencies, and ARM64 is new as well so most dependencies need 
patches (except for those building via CMake)

 

  Bert

 

Van: Nathan Hartman  
Verzonden: woensdag 26 mei 2021 15:00
Aan: dev@subversion.apache.org
Onderwerp: Re: svn commit: r1890223 - 
/subversion/trunk/subversion/svn_private_config.hw

 

On Wed, May 26, 2021 at 8:31 AM mailto:rhuij...@apache.org> > wrote:

Author: rhuijben
Date: Wed May 26 12:31:05 2021
New Revision: 1890223

URL: http://svn.apache.org/viewvc?rev=1890223 
 =rev
Log:
* subversion/svn_private_config.hw
  Properly identify Windows on ARM/ARM64, instead of breaking the build.

Modified:
subversion/trunk/subversion/svn_private_config.hw

Modified: subversion/trunk/subversion/svn_private_config.hw
URL: 
http://svn.apache.org/viewvc/subversion/trunk/subversion/svn_private_config.hw?rev=1890223
 

 =1890222=1890223=diff
==
--- subversion/trunk/subversion/svn_private_config.hw (original)
+++ subversion/trunk/subversion/svn_private_config.hw Wed May 26 12:31:05 2021
@@ -39,6 +39,10 @@
 #define SVN_BUILD_TARGET "ia64-microsoft-windows"
 #elif defined( _M_IX86)
 #define SVN_BUILD_TARGET "x86-microsoft-windows"
+#elif defined(_M_ARM64)
+#define SVN_BUILD_TARGET "arm64-microsoft-windows"
+#elif defined(_M_ARM)
+#define SVN_BUILD_TARGET "arm-microsoft-windows"
 #else
 #error Unsupported build target.
 #endif

 

 

This looks like it should be nominated for backport, though I don't have an ARM 
Windows machine to test with.

 

Nathan