On Tue, Aug 29, 2023 at 6:05 AM Daniel Sahlberg wrote:
>
> On 2022/06/30 14:04:08 Daniel Sahlberg wrote:
> > Den tors 30 juni 2022 kl 15:45 skrev Nathan Hartman <
> > hartman.nat...@gmail.com>:
> >
> > > Recent breakage in the PO files wasn't detected by the buildbot so I
> > > went digging.
> > >
> > > The buildbot infrastructure changed recently. Builders are now listed at
> > > [1].
> > >
> > > At this time, svn-backport-conflicts-1.10.x and
> > > svn-backport-conflicts-1.14.x are happy.
> > >
> > > But svn-trunk-nightly is broken. All builds show FAILURE, like this:
> > >
> > > [[[
> > > ./nightly.sh -d ../uploads
> > > in dir /home/buildslave/slave/svn-trunk-nightly/build (timeout 1200 secs)
> > > watching logfiles {}
> > > argv: [b'./nightly.sh', b'-d', b'../uploads']
> > > environment:
> > > HOME=/home/buildslave
> > > LANG=en_US.UTF-8
> > > LESSCLOSE=/usr/bin/lesspipe %s %s
> > > LESSOPEN=| /usr/bin/lesspipe %s
> > > LOGNAME=buildslave
> > > MAIL=/var/mail/buildslave
> > > MANPATH=:/opt/puppetlabs/puppet/share/man
> > > OLDPWD=/home/buildslave
> > >
> > > PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/opt/puppetlabs/bin
> > > PWD=/home/buildslave/slave/svn-trunk-nightly/build
> > > SHELL=/bin/bash
> > > SHLVL=1
> > > TERM=xterm
> > > USER=buildslave
> > >
> > > VIRTUALENVWRAPPER_SCRIPT=/usr/share/virtualenvwrapper/virtualenvwrapper.sh
> > > XDG_DATA_DIRS=/usr/local/share:/usr/share:/var/lib/snapd/desktop
> > > _=../slave-install/bin/buildbot-worker
> > > _VIRTUALENVWRAPPER_API= mkvirtualenv rmvirtualenv lsvirtualenv
> > > showvirtualenv workon add2virtualenv cdsitepackages cdvirtualenv
> > > lssitepackages toggleglobalsitepackages cpvirtualenv
> > > setvirtualenvproject mkproject cdproject mktmpenv mkvirtualenv
> > > rmvirtualenv lsvirtualenv showvirtualenv workon add2virtualenv
> > > cdsitepackages cdvirtualenv lssitepackages toggleglobalsitepackages
> > > cpvirtualenv setvirtualenvproject mkproject cdproject mktmpenv
> > > using PTY: False
> > > ./nightly.sh: 1: cd: can't cd to ../uploads
> > > program finished with exit code 2
> > > elapsedTime=0.004434
> > > ]]]
> > >
> > > The error is in the third-to-last row, "can't cd to ../uploads".
> > >
> > > I don't know how to fix this so maybe someone can offer guidance.
> > >
> > > Any pointers?
> > >
> >
> > Maybe
> > https://svn.apache.org/repos/infra/infrastructure/buildbot2/projects/subversion.py
> > (I don't know if this file is in use or if it was migrated to github, Infra
> > seems to have moved in that direction lately).
> >
> > Search for ## Nightly Snapshots ##. One of the first steps is to call
> > nightly.sh with the arguments -d and ../upload. Nightly.sh
> > (/tools/dist/nightly.sh) in turn tries to do cd $OPTARG when called with
> > the -d argument.
> >
> > Maybe the build configuration needs a step to verify that the ../upload
> > folder actually exists? Maybe it was added manually on the old buildbot
> > machine and it was never added to the script thus got lost during migration
> > to the new buildbots?
> >
>
> Only got around to look at this now. I added a step to "mkdir ../uploads" and
> things proceeded a little bit further but fails because the the relase.py [1]
> depend on the backport python module [2].
>
> I also found this old thread [3] where it seems it hasn't worked since about
> 2017.
>
> From what I understand the purpose of this job is to create a nightly release
> tarball, it doesn't actually build something. There is a separate job
> svn-warnings (which by the way also doesn't work, but I think that will be
> resolved by moving to another build host) that will do an actual build
> triggered by .
>
> I don't really see the point of a nightly tarball, for bleeding
> edge/developers it is probably as easy to run from a /trunk checkout.
>
> I'm proposing to completely eliminate the svn-trunk-nightly buildbot job.
> (Will do this later this week unless someone objects).
>
> Kind regards,
> Daniel Sahlberg
>
> [1] https://svn.apache.org/repos/asf/subversion/trunk/tools/dist/release.py
> [2] https://svn.apache.org/repos/asf/subversion/trunk/tools/dist/backport/
> [3] https://lists.apache.org/thread/1mkzl84fdx6jp8kgqq74cm2v56xntbs8
I'm +1 to remove the nightly tarball job for multiple reasons. Anyway,
no one complained that they're already missing, and have been for some
time.
It looks like the work is done in tools/dist/nightly.sh, with
additional logic in tools/dist/dist.sh and tools/dist/release.py to
special-case the nightlies.
Also, the section #nightlies in site/publish/source-code.html contains
a link to https://ci.apache.org/projects/subversion/nightlies/index.html,
which is 404 since the CI migrated.
I was interrupted in the middle and wasn't able to search exhaustively
for all nightly-tarball-related stuff, but let me know if you need
help...
Cheers,
Nathan
