Re: hello

2023-05-22 Thread Pavel Lyalyakin via dev
On Mon, May 22, 2023 at 1:48 PM Yaniv Waldman  wrote:
>
> Hello
>
> I hope you can assist me
>
>
>
> I had to reinstall collabnet subversion svn server, and some of my 
> repositories are not working.
>
> I assume it’s because different versions.
>
>
>
> My svn server is 3.3.1
>
>
>
> The error is –
>
>
>
> Python Traceback
>
>
>
> Traceback (most recent call last): File "C:\csvn\lib\viewvc\viewvc.py", line 
> 4872, in main request.run_viewvc() File "C:\csvn\lib\viewvc\viewvc.py", line 
> 321, in run_viewvc self.repos.open() File 
> "C:\csvn\lib\viewvc\vclib\svn\svn_repos.py", line 387, in open self.repos = 
> repos.svn_repos_open(self.rootpath) File 
> "C:\csvn\lib\svn-python\libsvn\repos.py", line 211, in svn_repos_open return 
> _repos.svn_repos_open(*args) SubversionException: 160043 - Expected FS format 
> between '1' and '4'; found format '6
>
>
>
> I think I need to upgrade to version 4.0.11
>
> But I can’t find any site with this installation file.
>
>
>
> Can you help me with that please  ?
>
>
>
> Yaniv
>
> Benarit LTD
>
>

The actual error is "Expected FS format between '1' and '4'; found
format '6". It appears that your repositories were created with a more
recent format (or upgraded to it with `svnadmin upgrade`) and your
outdated SVN Edge installation doesn't know how to work with them.
AFAIK, SVN Edge 3.3.x was linked with SVN 1.7.x, and SVN Edge 4.0.x
was linked with SVN 1.8.x that introduced a new version of the
repository format. So I guess that installing SVN Edge 4.0.x will
resolve that error.

Two important notes:
* The latest and current version of SVN is 1.14.x. SVN versions 1.7.x
and 1.8.x are not supported, so your SVN Edge versions are linked
against outdated and non-supported versions of SVN.
* You've contacted a wrong mailing list. All SVN usage questions
should be posted to the users@ mailing list[1].

[1]: https://subversion.apache.org/mailing-lists.html

--
With best regards,
Pavel Lyalyakin
VisualSVN Team


Re: "copy.c' line 1187: assertion failed (! svn_path_is_empty(path))" when running `svn move `

2023-04-07 Thread Pavel Lyalyakin via dev
On Fri, Apr 7, 2023 at 12:53 AM Daniel Sahlberg 
wrote:

> Den tis 7 mars 2023 kl 20:24 skrev Pavel Lyalyakin via dev <
> dev@subversion.apache.org>:
>
>> Hello,
>>
>> I seem to have found a new bug (I can't find similar reports) so I
>> thought I'd report it to this mailing list. Sorry if it's a known issue.
>>
>> I believe that the command shouldn't work anyway, right? But it shouldn't
>> assert either.
>>
>> The SVN client crashes when I run the following command:
>> [[[
>> svn move https://svn1.mydomain.com/svn/MyRepo/
>> https://svn1.mydomain.com/svn/MyRepo/trunk -m "Test Commit"
>> ]]]
>> [[[
>> svn: E235000: In file '..\..\..\subversion\libsvn_client\copy.c' line
>> 1187: assertion failed (! svn_path_is_empty(path))
>> ]]]
>>
>> SRC URL points to a root of a repository. DST URL points to a
>> non-existent subdirectory.
>>
>
> Hi
>
> I think I have found the root cause and the relevant commit. I will
> document my findings so far in case someone else would like to look at it,
> I need to do some more analysis before I'm ready to suggest a solution.
>
> In subversion/libsvn_client/copy.c, setup_copy, there is a check:
>
> [[[
>  if (svn_dirent_is_child(pair->src_abspath_or_url,
>   pair->dst_abspath_or_url, iterpool))
> return svn_error_createf
>   (SVN_ERR_UNSUPPORTED_FEATURE, NULL,
>_("Cannot copy path '%s' into its own child '%s'"),
>svn_dirent_local_style(pair->src_abspath_or_url, pool),
>svn_dirent_local_style(pair->dst_abspath_or_url, pool));
> ]]]
>
> This should prevent the assertion and instead give a reasonable error
> message.
>
> However, a few lines above, this code is only executed
>
> [[[
>   if (!srcs_are_urls && !dst_is_url)
> ]]]
>
> This condition seems to come from r846422, with a log message referencing
> issue SVN-1367 (from 2003!). There is a reasonable argument in the issue
> description on why this condition was added (it was supposed to manage svn
> copy). There is an argument "is_move" to the function, so it might be
> reasonable to also look at that variable in the above condition.
>
> Kind regards,
> Daniel
>

Daniel,

Thank you for looking into this!

On a side note, this seems to be a rare problem. I don't see any other
reports of this particular assertion (error message).

-- 
With best regards,
Pavel Lyalyakin
VisualSVN Team


"copy.c' line 1187: assertion failed (! svn_path_is_empty(path))" when running `svn move `

2023-03-07 Thread Pavel Lyalyakin via dev
Hello,

I seem to have found a new bug (I can't find similar reports) so I thought
I'd report it to this mailing list. Sorry if it's a known issue.

I believe that the command shouldn't work anyway, right? But it shouldn't
assert either.

The SVN client crashes when I run the following command:
[[[
svn move https://svn1.mydomain.com/svn/MyRepo/
https://svn1.mydomain.com/svn/MyRepo/trunk -m "Test Commit"
]]]
[[[
svn: E235000: In file '..\..\..\subversion\libsvn_client\copy.c' line 1187:
assertion failed (! svn_path_is_empty(path))
]]]

SRC URL points to a root of a repository. DST URL points to a non-existent
subdirectory.

svn, version 1.14.2 (r1899510)
   compiled Feb 21 2023, 03:04:00 on x86_64-microsoft-windows6.2.9200

Thank you.

-- 
With best regards,
Pavel Lyalyakin
VisualSVN Team


Re: Tree conflict resolution removes unversioned files from the working copy

2022-11-20 Thread Pavel Lyalyakin via dev
On Sun, Nov 20, 2022 at 10:42 PM Daniel Sahlberg <
daniel.l.sahlb...@gmail.com> wrote:

> Den sön 20 nov. 2022 kl 19:16 skrev Pavel Lyalyakin via dev <
> dev@subversion.apache.org>:
>
>> Hello,
>>
>> As reported in this users@ thread[1][2], it appears that running `svn
>> update` can silently remove unversioned files in the working copy when
>> automatically resolving a tree conflict. Note that when I run `svn update`
>> with the `--accept postpone` option, the unversioned file remains in the
>> working copy.
>>
>> Should I create a ticket in Jira? I have a reproduction script for
>> Windows and macOS.
>>
>
> I think this qualifies for a ticket!
>
>
>> I guess that the macOS script also works on Linux.
>>
>
> The script seems to work under Linux (at least Ubuntu 22.04 running on
> WSL). As far as I understand, the issue is the same: unversionedfile.txt is
> missing after the rename).
>
> [[[
> daniel@DESKTOP-DT42993:~/marcel-bug-report/working-copy-one$ svn resolve
> Searching tree conflict details for 'RenamedDir/myfile.txt' in repository:
> Checking r2... done
> Tree conflict on 'RenamedDir/myfile.txt':
> A new file appeared during update to r3; it was added by daniel in r2.
> An unversioned file was found in the working copy.
> Select: (p) Postpone, (r) Mark as resolved, (m) Merge the files, (h) Help,
> (q) Quit resolution:
> ]]]
>
> Note that the error message mention "[a]n unversioned file", however the
> conflict is on the versioned file.
>
> Kind regards,
> Daniel
>

I've just created SVN-4910: https://issues.apache.org/jira/browse/SVN-4910

Thank you!

-- 
With best regards,
Pavel Lyalyakin
VisualSVN Team


Tree conflict resolution removes unversioned files from the working copy

2022-11-20 Thread Pavel Lyalyakin via dev
Hello,

As reported in this users@ thread[1][2], it appears that running `svn
update` can silently remove unversioned files in the working copy when
automatically resolving a tree conflict. Note that when I run `svn update`
with the `--accept postpone` option, the unversioned file remains in the
working copy.

Should I create a ticket in Jira? I have a reproduction script for Windows
and macOS. I guess that the macOS script also works on Linux.

Windows:

svn, version 1.14.2 (r1899510)
   compiled Aug 12 2022, 12:55:13 on x86_64-microsoft-windows6.2.9200
[[[
mkdir C:\marcel-bug-report
svnadmin create C:\marcel-bug-report\MyRepo
svn mkdir file:///C:/marcel-bug-report/MyRepo/MyDir -m "Adding a new
directory"

svn checkout file:///C:/marcel-bug-report/MyRepo/
C:\marcel-bug-report\working-copy-one
echo foo > C:\marcel-bug-report\working-copy-one\MyDir\myfile.txt
svn add C:\marcel-bug-report\working-copy-one\MyDir\myfile.txt
svn commit C:\marcel-bug-report\working-copy-one\ -m "Adding a new file"
echo bar > C:\marcel-bug-report\working-copy-one\MyDir\myfile.txt
echo baz > C:\marcel-bug-report\working-copy-one\MyDir\unversionedfile.txt

svn move file:///C:/marcel-bug-report/MyRepo/MyDir
file:///C:/marcel-bug-report/MyRepo/RenamedDir -m "Renaming a directory"

svn update C:\marcel-bug-report\working-copy-one
]]]

macOS

svn, version 1.14.2 (r1899510)
   compiled Apr 13 2022, 14:56:48 on arm-apple-darwin21.3.0
[[[
mkdir $HOME/marcel-bug-report
svnadmin create $HOME/marcel-bug-report/MyRepo
svn mkdir file:///$HOME/marcel-bug-report/MyRepo/MyDir -m "Adding a new
directory"

svn checkout file:///$HOME/marcel-bug-report/MyRepo/
$HOME/marcel-bug-report/working-copy-one
echo foo > $HOME/marcel-bug-report/working-copy-one/MyDir/myfile.txt
svn add $HOME/marcel-bug-report/working-copy-one/MyDir/myfile.txt
svn commit $HOME/marcel-bug-report/working-copy-one/ -m "Adding a new file"
echo bar > $HOME/marcel-bug-report/working-copy-one/MyDir/myfile.txt
echo baz >
$HOME/marcel-bug-report/working-copy-one/MyDir/unversionedfile.txt

svn move file:///$HOME/marcel-bug-report/MyRepo/MyDir
file:///$HOME/marcel-bug-report/MyRepo/RenamedDir -m "Renaming a directory"

svn update $HOME/marcel-bug-report/working-copy-one/
]]]

Thank you.

[1]: https://lists.apache.org/thread/qmg6xqs5xpjr6kyhblwxvnhykobxwm8x
[2]: https://lists.apache.org/thread/phpotj6pvvcmlt1vx9y7lbn6vof0d6y2

-- 
With best regards,
Pavel Lyalyakin
VisualSVN Team


Re: missing --force option for "svn log" (useful with --diff)

2022-07-29 Thread Pavel Lyalyakin via dev
On Fri, Jul 29, 2022 at 5:30 PM Branko Čibej  wrote:
>
> On 16.07.2022 16:23, Vincent Lefevre wrote:
> > When using "svn log --diff", one may need diff options.
> > One has --diff-cmd, --internal-diff and -x, but --force
> > is missing, though it would be useful too (in particular
> > with --diff-cmd to textify diff inputs).
>
> What would --force do?

I believe that this post is relevant to Vincent's request:
https://stackoverflow.com/q/72815562.

-- 
With best regards,
Pavel Lyalyakin
VisualSVN Team


Re: Web site notice regarding log4j

2021-12-15 Thread Pavel Lyalyakin
On Thu, Dec 16, 2021 at 1:33 AM Mark Phippard  wrote:

> On Wed, Dec 15, 2021 at 4:59 PM Pavel Lyalyakin
>  wrote:
> >
>
> > It seems that the list markup is wrong. There should be  (unordered
> list) tag instead of  (paragraph).
> >
> > I also think that it makes sense to include links to the SVN Edge's
> page[1] and the announcement made by VisualSVN Team[2]. E.g., something
> like "some vendors have already announced that their distributions are not
> vulnerable to CVE-2021-44228".
> >
> > some vendors already announced that their distros are not vulnerable
> >
> > [1]:
> https://ctf.open.collab.net/sf/wiki/do/viewPage/projects.svnedge/wiki/Log4Shell
> > [2]:
> https://www.visualsvn.com/company/news/visualsvn-products-are-not-affected-by-CVE-2021-44228
>
> I am fine if we want to do this ... it was one of the reasons I added
> the page. That said, I tend to think we should not take this on as it
> creates a possible need for us to maintain this info and add to it
> over time. I am not sure we should do this as I think we want the
> vendors to own this responsibility.
>
> We should really be encouraging users to seek these answers from the
> place they are obtaining their Subversion server.
>
> Mark
>

We don't need to maintain this particular text after it gets fully reviewed
and published. I assume that this is a news entry, not a wiki page. It has
a fixed date and time of publication. In this case it should be absolutely
fine to write, review and approve the text and never update it unless
strictly necessary. I think that the following wording could be used:
[[[
Subversion contributors suggest verifying with your vendor if the
distribution you use is vulnerable. At the time of writing, some vendors
have already announced that their distributions are not vulnerable to
CVE-2021-44228:

]]]

At the same time, I think it is true that this text could live without any
links.

PS I also think it would be best to first use the staging part of the
website to write the news entry. When done and reviewed, publish it to the
production site.

-- 
With best regards,
Pavel Lyalyakin
VisualSVN Team


Re: Web site notice regarding log4j

2021-12-15 Thread Pavel Lyalyakin
On Thu, Dec 16, 2021 at 12:50 AM Daniel Sahlberg <
daniel.l.sahlb...@gmail.com> wrote:

> Den ons 15 dec. 2021 kl 15:32 skrev Mark Phippard :
>
>> On Wed, Dec 15, 2021 at 7:25 AM Pavel Lyalyakin
>>  wrote:
>> >
>> >
>> >
>> > On Wed, Dec 15, 2021 at 2:13 PM Daniel Sahlberg <
>> daniel.l.sahlb...@gmail.com> wrote:
>> >>
>> >> Hi,
>> >>
>> >> There has been several different requests regarding if Subversion is
>> vulnerable to the latest log4j problem. Should we write a new item about
>> this for the web site? Several people (Pavel Lyalyakin, Mark Phippard) has
>> made valuable comments and I can (with their permission) distil some
>> condensed reply.
>> >>
>> >> Kind regards,
>> >> Daniel
>> >
>> >
>> > There is one piece of information that hasn't been mentioned yet.
>> Subversion repository hooks can be written in practically any programming
>> language including Java. I see that there are instructions on the web for
>> writing Java-based hooks that use Log4j as a dependency (google "writing
>> subversion hooks in java"). Users have to examine their hook scripts to
>> ensure that they are not vulnerable.
>> >
>> > BTW, you can find the announcement from VisualSVN Team regarding
>> CVE-44228 (Log4Shell) at
>> https://www.visualsvn.com/company/news/visualsvn-products-are-not-affected-by-CVE-2021-44228
>> .
>>
>> I suspect we do not want to be responsible for providing all of these
>> links here but I created a similar page for SVN Edge here:
>>
>>
>> https://ctf.open.collab.net/sf/wiki/do/viewPage/projects.svnedge/wiki/Log4Shell
>>
>> Mark
>>
>
> https://subversion.apache.org/#news-20211215
>
> (waiting for the native-english-speakers to roast me :-) )
>

It seems that the list markup is wrong. There should be  (unordered
list) tag instead of  (paragraph).

I also think that it makes sense to include links to the SVN Edge's page[1]
and the announcement made by VisualSVN Team[2]. E.g., something like "some
vendors have already announced that their distributions are not vulnerable
to CVE-2021-44228".

some vendors already announced that their distros are not vulnerable

[1]:
https://ctf.open.collab.net/sf/wiki/do/viewPage/projects.svnedge/wiki/Log4Shell
[2]:
https://www.visualsvn.com/company/news/visualsvn-products-are-not-affected-by-CVE-2021-44228

-- 
With best regards,
Pavel Lyalyakin
VisualSVN Team


Re: Web site notice regarding log4j

2021-12-15 Thread Pavel Lyalyakin
On Wed, Dec 15, 2021 at 2:13 PM Daniel Sahlberg 
wrote:

> Hi,
>
> There has been several different requests regarding if Subversion is
> vulnerable to the latest log4j problem. Should we write a new item about
> this for the web site? Several people (Pavel Lyalyakin, Mark Phippard) has
> made valuable comments and I can (with their permission) distil some
> condensed reply.
>
> Kind regards,
> Daniel
>

There is one piece of information that hasn't been mentioned yet.
Subversion repository hooks can be written in practically any programming
language including Java. I see that there are instructions on the web for
writing Java-based hooks that use Log4j as a dependency (google "writing
subversion hooks in java"). Users have to examine their hook scripts to
ensure that they are not vulnerable.

BTW, you can find the announcement from VisualSVN Team regarding CVE-44228
(Log4Shell) at
https://www.visualsvn.com/company/news/visualsvn-products-are-not-affected-by-CVE-2021-44228
.

Thank you!

-- 
With best regards,
Pavel Lyalyakin
VisualSVN Team


"util.c' line 96: assertion failed" when repository URL has "username:password@"

2021-07-27 Thread Pavel Lyalyakin
Hello,

Is it supported to enter "username:password@" in the URL with the SVN
command-line client?

The SVN client crashes when I run the following command:
[[[
svn info https://username:passw...@svn.apache.org/repos/asf/subversion/trunk
]]]

[[[
svn: E235000: In file '..\..\..\subversion\libsvn_client\util.c' line 96:
assertion failed (svn_uri__is_ancestor(pathrev->repos_root_url, url))
]]]

svn, version 1.14.1 (r1886195) on Windows.

Found this at https://stackoverflow.com/q/68502915/761095.

-- 
With best regards,
Pavel Lyalyakin
VisualSVN Team


Re: 20th anniversary press?

2020-01-27 Thread Pavel Lyalyakin
On Tue, Jan 21, 2020 at 3:08 PM Julian Foad  wrote:
>
> Nathan Hartman wrote:
> > Would someone who has a LinkedIn account be kind enough to post a very
> > polite request for testimonials there?
> >
> > Also, would it be appropriate and acceptable to post this request to our
> > own users@ list?
>
> I say yes.
>
> It was said recently (as well as long ago), on the Svn PMC's [1] private
> mailing list, that a press release (PR) should be organized in private
> so it makes a "splash" (a surprise) to maximize impact in the press.  I
> understand the intent behind that, from the marketing point of view, but
> in this open community I place higher value on publicly involving
> community members who are not members of the PMC.  If that results in
> lower "splash" value, that's fine: community over PR.
>
> Still, while publicly soliciting testimonials (and any other ideas), we
> can minimize the dilution effect by collecting them and drafting the
> text in private: the press shouldn't be finding the whole thing is
> previously published.  Let's be open that that's what we're doing, and
> endeavour to include any non-PMC-members who wish to be included.  (If
> someone wants to be included in that part, e.g. seeing the draft, please
> say and we'll work to find a satisfactory way to include you.)
>
> To that end, let's ask that contacts send their actual quotes to
> private@ in the first place.  Nathan is co-ordinating the drafting and
> any privately solicited quotes there anyway, aren't you?
>
> - Julian
>
>
> [1] PMC: the project management committee, roughly equals "committers",
>  https://www.apache.org/foundation/governance/pmcs
>

Hello,

We at VisualSVN want to contribute to the press release, and I will
try to collect testimonials from our users. I will follow up on the
results in a week or so.

--
With best regards,
Pavel Lyalyakin
VisualSVN Team


Re: SvnMerkleizer: announcement

2019-06-17 Thread Pavel Lyalyakin
Hello,

On Fri, Jun 14, 2019 at 6:22 PM Paul Hammant  wrote:
>
> URL: https://github.com/paul-hammant/SvnMerkleizer
>
> It's a Java process that runs alongside Apache and MOD_DAV_SVN to make a
full Merkle tree of the repo. Implicitly too, any sub-directory within. It
attempts to maintain different trees for people with different read
permissions/groups. Coming with it, a Docker image that sets it all up
together. Really that last is a demo, but it does place the SvnMerkleizer
within the same directory structure as the Subversion repo itself. See
within the line of code for that

https://github.com/paul-hammant/SvnMerkleizer-all-in-one/blob/master/vh-davsvn.conf#L8

404 Not Found

> While Svn keeps SHA1 for each file resource within the repo, it does not
do that for directories. Hence I made this tech.
>
> Along the way I created a "service virtualization" tech called Servirtium
that is more interesting to enterprise Java teams than anyone else, but
some of the tests for SvnMerkleizer use Servirtium to record 15K PROPFINDS
and OPTIONS operations and allow them to be used in playback.
>
> Pull Requests accepted.
>
> - Paul

--
With best regards,
Pavel Lyalyakin
VisualSVN Team


Re: The future of the Subversion book

2018-09-07 Thread Pavel Lyalyakin
Hello,

On Wed, Sep 5, 2018 at 10:39 PM, C. Michael Pilato  wrote:
>
> Hello, all!
>
> It's been a long while since I interacted with any degree of regularity with 
> this community, and I've had to come to terms with some essential truths.
>
> First, my time as an active Subversion developer has *definitely* passed.  
> Oh, I may get a chance to return to it at some point in the (likely distant) 
> future, but without CollabNet commissioning my efforts here, I simply don't 
> have the extra cycles these days to offer.  Given that my contributions over 
> the last few years can be measured in the smallest of numbers, this isn't 
> news to anyone here and certainly has no effect on the trajectory and 
> velocity of the project!
>
> Of greater concern to (at least) myself is that the cognitive distance I have 
> from Subversion these days -- combined with the craziness of just life as an 
> twice-employed[1], soccer-coaching, father of three -- means that the 
> Subversion book is getting next-to-zero attention, too.  Oh, I'm still paying 
> attention to the work our translators are doing, and wordsmithing here and 
> there as concerns are raised.  But the (as-yet-unfinished) trunk of the book 
> is still attached to Subversion 1.8, which means that this community has 
> pounded out all kinds of improvements whose documentation is mostly limited 
> to release notes and email threads.  Put simply, the service that Ben and 
> Fitz (both long gone from contributing to the book at all) and I formerly 
> offered to the wider Subversion community has arguably now become a 
> disservice.
>
> I'm done telling myself that I can fix this by re-engaging and taking up 
> authorship again.  That just isn't gonna happen.  It's time to pass the torch 
> to someone else, and I would love to immediately begin tossing around some 
> ideas toward this end.
>
> To be clear, red-bean.com is happy to continue hosting the book's HTML/PDF 
> builds.  The source lives at SourceForge these days, and I can grant commit 
> permissions (or transfer ownership) as needed.  Moreover, there's no deadline 
> for maintainership handoff that I'm trying to impose or anything.  I want to 
> do what's best for the Subversion ecosystem, whatever this community 
> determines that to be.
>
> Feel free to consider alternate approaches, too, such as conversion of the 
> book's content into a Wiki.  But I would caution against doing anything that 
> discourages or complicates the workflow of the book's translators, especially 
> since they are the only ones actually doing anything in the project at all!  
> :-)
>
> So what do you think?
>
> -- Mike
>
>
> [1] Beyond my regular CollabNet work week, I give additional hours as a
> member of the staff of my local church.

A bit off-topic for this thread, but I want to say that I'd love
SVNBook to move to SVN 1.10 version. There are several open
milesone-1.8 tickets[1], though and 1.8 version needs a read-through
before branching[2].

The progress is tracked here[3] and if - I'm not mistaken - the Step
3: Review Subcommands/Options can be considered Done.

[1]: 
https://sourceforge.net/p/svnbook/tickets/milestone/en-1.8/?filter=%7B%22status%22%3A[%22New%22%2C%22Started%22]%7D
[2]: https://www.red-bean.com/pipermail/svnbook-dev/2016-March/016318.html
[3]: https://sourceforge.net/p/svnbook/wiki/SvnBook18Status/

-- 
With best regards,
Pavel Lyalyakin
VisualSVN Team


Re: svn commit: r1814018 - /subversion/site/staging/quick-start.html

2017-11-14 Thread Pavel Lyalyakin
Hello Daniel,

On Tue, Nov 14, 2017 at 4:41 PM, Daniel Shahaf <d...@daniel.shahaf.name> wrote:
> Daniel Shahaf wrote on Fri, 03 Nov 2017 20:13 +:
>> Pavel Lyalyakin wrote on Fri, 03 Nov 2017 17:56 +0300:
>> > Fixed in r1814193.
>> >
>> > Changed to "" as we use it on other pages.
>>
>> Thanks, Pavel.  Looks good to me (with the followup in r1814194).
>
> To be clear, that was meant as a "+1 to merge r1814018, r1814193,
> r1814194 to publish/".
>
> You made some other commits to quick-start that haven't been merged to
> publish/ yet, haven't you?  What are they waiting for?

You are right. There is a +1 from you and it has been much longer than 72 hours
so it seems that there is a lazy consensus. :)

I've promoted the changes made to /staging/quickstart.html in r1815233.

>> Cheers,
>>
>> Daniel

--
With best regards,
Pavel Lyalyakin


Re: svn commit: r1814018 - /subversion/site/staging/quick-start.html

2017-11-03 Thread Pavel Lyalyakin
Hello,

On Thu, Nov 2, 2017 at 2:05 AM, Daniel Shahaf <d...@daniel.shahaf.name> wrote:
>
> lyalya...@apache.org wrote on Wed, 01 Nov 2017 22:44 +:
> > +++ subversion/site/staging/quick-start.html Wed Nov  1 22:44:22 2017
> > @@ -80,8 +80,8 @@ we recommend you do a Web search for  > -The repository acts as a single source of truth and – as a central
> > -storage – it contains the complete history of changes of the versioned
> > +The repository acts as a single source of truth and - as a central
> > +storage - it contains the complete history of changes of the versioned
>
> Pavel, that's not the correct fix.  The original text used a U+2013 EN
> DASH, which you changed to an ASCII hyphen.  The correct fix would be to
> use U+2014 EM DASH.  (The escape sequence is "", although I for
> one wouldn't object to using a literal "—".)
>
> Thanks for spotting this!
>
> Daniel

Fixed in r1814193.

Changed to "" as we use it on other pages.

-- 
With best regards,
Pavel Lyalyakin


Re: [PATCH] Let's rework the Quick Start page (publish/quick-start.html)

2017-10-03 Thread Pavel Lyalyakin
Hello Johan,

On Tue, Oct 3, 2017 at 1:58 PM, Johan Corveleyn <jcor...@gmail.com> wrote:
>
> On Tue, Oct 3, 2017 at 11:37 AM, Daniel Shahaf <d...@daniel.shahaf.name> 
> wrote:
> > Pavel Lyalyakin wrote on Mon, 02 Oct 2017 13:41 +0300:
> >> I am going to work on further improvements and as soon as they are ready, 
> >> I will
> >> start a new [PATCH] thread. However, what about creating a lightweight 
> >> branch[1]
> >> for this doc task? I know that a lightweight branch can be created for code
> >> changes, but the site/ does not have branches at all. I am not sure about 
> >> that.
> >
> > We can certainly create branches of the site.  E.g., we could copy 
> > site/publish/
> > to site/staging/ and even have it served as 
> > http://subversion.staging.apache.org/
> > for ease of previewing.
> >
> > I'll let Johan respond to the other parts of your question :-).
>
> Hi Pavel,
>
> I've commit your v3 patch in r1810571 (I just did a small tweak to the
> commit message: "Reworking" -> "Rework", i.e. we prefer to use
> imperative in log messages when describing what you've done).
>
> I agree it would be easier if you could commit directly (either to
> some "staging" branch, or to the site directly). I'm working on making
> that happen, stay tuned ... :-).

It would be great. Thank you. :)

> --
> Johan

--
With best regards,
Pavel Lyalyakin
VisualSVN Team


[PATCH] Let's rework the Quick Start page (publish/quick-start.html)

2017-09-22 Thread Pavel Lyalyakin
Hello,

It appears that the current SVN Quick Start page[1] is kind of desolate; there
is a discussion about updating it[2]. I want to volunteer for this task and I am
attaching a patch. :)

My idea is to provide novice SVN end users with a quick reference on the most
basic concepts and operations:
* checkout a working copy,
* update the working copy,
* modify the data in the working copy and commit it,
* make a branch or tag.

A user who needs help on how to begin working with SVN does not have to dive
into the SVNBook. Yes, he will read the SVNBook some time later to learn more
about basic operations and to find out about the magic of the complex ones. But
not on his first day when the only commands he needs are `svn checkout` and
`svn commit`.

Log Message:
[[[
  * publish/quick-start.html:
Reworking the SVN Quick Start page as discussed in

https://lists.apache.org/thread.html/da5b9f351a1bf2456aeb85e24ed88ff30b544a70995638af684684f1@%3Cdev.subversion.apache.org%3E
]]]

[1]: https://subversion.apache.org/quick-start
[2]: 
https://lists.apache.org/thread.html/da5b9f351a1bf2456aeb85e24ed88ff30b544a70995638af684684f1@%3Cdev.subversion.apache.org%3E
Index: publish/quick-start.html
===
--- publish/quick-start.html(revision 1808237)
+++ publish/quick-start.html(working copy)
@@ -17,62 +17,433 @@
 
 Apache Subversion: Quick Start
 
-
-Graphical user interface (GUI) clients
-  
-
+
+  
+Installing the SVN client
+  
+  
+Understanding the terms
+  
+  
+Basic tasks
+  
+  
+Branching and tagging
+  
+  
+Getting more help
+  
+
 
-If you are not familiar with Subversion, you may be better served by a
-graphical client.  (The Subversion project only maintains a command-line-based
-clients, but a number of third parties maintain graphical clients that build on
-our API (for programmers).)  We do not maintain
-a list of such clients; instead, we recommend you do a Web search for
-Subversion GUI client.
-
-
-
-
-Make an existing directory a working copy of a new repository
-  
-
-
-The following commands will convert a ./my-directory/ containing
-files into a working copy of a newly-created repository:
-
-On Unix:
-
+  
+
+  Installing the SVN client
+  
+
+
+  Install the svn client to start collaborating on the project
+  that is using Subversion as its version control system.
+
+
+  To install the client program, you can build it yourself from a source
+  code release or download a binary package.  The list of sites where you
+  can obtain a pre-built Subversion client is available at the
+  official binary packages page.  If you want
+  to compile the software for yourself, grab the source at the
+  Source Code page.
+
+
+  Right after you install the client you should be able to test it by
+  issuing the svn command.  You should see the following output:
+
 
-$ mkdir -p $HOME/.svnrepos/
-$ svnadmin create ~/.svnrepos/my-repos
-$ svn mkdir -m "Create directory structure." 
file://$HOME/.svnrepos/my-repos/trunk file://$HOME/.svnrepos/my-repos/branches 
file://$HOME/.svnrepos/my-repos/tags
-$ cd my-directory
-$ svn checkout file://$HOME/.svnrepos/my-repos/trunk ./
-$ svn add --force ./
-$ svn commit -m "Initial import"
-$ svn up
+$ svn
+Type 'svn help' for usage.
 
+
+  Now you can start using the command line client to interact with the 
+  remote repository.
+
+
+  
+If you are not familiar with Subversion, you may be better served by a
+graphical client.  We do not maintain a list of such clients; instead,
+we recommend you do a Web search for Subversion GUI client.
+  
+
+  
 
-On Windows:
+  
+
+  Understanding the terms
+  
+
+
+  
+What is a Repository?
+
+  
+  
+The repository is a version control database that often resides on a
+server and is usually exposed either by Apache HTTP Server
+(mod_dav_svn) or svnserve server.  The repository acts as a single
+source of truth and – as a central storage – it contains the complete
+history of changes of the versioned data in form of revisions.
+  
+  
+Repository URL examples:
+  
+  
+
+  Apache HTTP Server: 
https://svn.example.com/repos/MyRepo/MyProject/trunk
+
+
+  svnserve: svn://svn.example.com/repos/MyRepo/MyProject/trunk
+
+
+  Direct access (Unix-style): 
file://var/svn/repos/MyRepo/MyProject/trunk
+
+
+  Direct access (Windows-style): 
file:///C:/Repositories/MyRepo/MyProject/trunk
+
+  
+
+
+  
+What is a Working Copy?
+
+  
+  
+The working copy is your local and private workspace that you use to
+interact with the central Subversion repository.  You use 

[PATCH] Add missing svn:eol-style=native property to site's text files

2017-09-22 Thread Pavel Lyalyakin
Hello,

Subj.

Log Message:
[[[
* publish/faq.en.html
  publish/mail
  publish/quick-start.html
  README
  TODO

  Add missing svn:eol-style=native property.

  Patch by Pavel Lyalyakin <pavel.lyalyakin[_at_]visualsvn.com>
]]]

Thank you!

--
With best regards,
Pavel Lyalyakin
VisualSVN Team
Index: publish/faq.en.html
===
--- publish/faq.en.html (revision 1809322)
+++ publish/faq.en.html (working copy)

Property changes on: publish/faq.en.html
___
Added: svn:eol-style
## -0,0 +1 ##
+native
\ No newline at end of property
Index: publish/mail
===
--- publish/mail(revision 1809322)
+++ publish/mail(working copy)

Property changes on: publish/mail
___
Added: svn:eol-style
## -0,0 +1 ##
+native
\ No newline at end of property
Index: publish/quick-start.html
===
--- publish/quick-start.html(revision 1809322)
+++ publish/quick-start.html(working copy)

Property changes on: publish/quick-start.html
___
Added: svn:eol-style
## -0,0 +1 ##
+native
\ No newline at end of property
Index: README
===
--- README  (revision 1809322)
+++ README  (working copy)

Property changes on: README
___
Added: svn:eol-style
## -0,0 +1 ##
+native
\ No newline at end of property
Index: TODO
===
--- TODO(revision 1809322)
+++ TODO(working copy)

Property changes on: TODO
___
Added: svn:eol-style
## -0,0 +1 ##
+native
\ No newline at end of property


Re: Tip of the day: Cheatsheet for common cmdline client operations

2017-09-20 Thread Pavel Lyalyakin
Hello,

On Tue, Sep 19, 2017 at 12:42 AM, Johan Corveleyn <jcor...@gmail.com> wrote:
>
> On Mon, Sep 18, 2017 at 6:00 PM, Pavel Lyalyakin
> <pavel.lyalya...@visualsvn.com> wrote:
> > Hello,
> >
> > On Fri, Sep 15, 2017 at 11:57 PM, Johan Corveleyn <jcor...@gmail.com> wrote:
> >> On Thu, Sep 14, 2017 at 5:27 PM, Pavel Lyalyakin
> >> <pavel.lyalya...@visualsvn.com> wrote:
> >> ...
> >>> I've spent some time to materialize the Quick Start document that I
> >>> think will be helpful for novice SVN users. At the moment, it provides
> >>> the most basic guidance which should be enough for "quick start".
> >>> However, it lacks "Viewing the history of changes" section that is not
> >>> ready yet. As of merging, I'd better provide a link to relevant
> >>> SVNBook sections. Merging is not a basic topic and should not be
> >>> described in a Quick Start guide, IMO.
> >>
> >> Hi Pavel,
> >>
> >> Nice! I've done a quick scan and it looks good in general. I'll try to
> >> go through it in detail this weekend, if I find some time.
> >>
> >> Your "quick start" is much larger than the old one (so we have to be
> >> careful that it's still as short as possible, to be "quick"), but I
> >> think it's good that you added some explanation of the basic concepts,
> >> and try to take the user along the most basic commands. The old "quick
> >> start" was more in the style of "here is some bait, don't be afraid to
> >> give it a try, and look for more docs". But now that I've read your
> >> patch (diagonally), I like it.
> >
> > Thank you. :)
> >
> > I consider the current patch as a basis for further work on this
> > document. I am not comfortable with rolling out a patch for
> > non-discussed document. But if we agree on the structure and topics
> > that should be covered, it is going to be easier to compose the doc
> > and review it.
>
> Ack. I didn't get around to a detailed review last weekend, and am
> totally swamped during this week, sorry. Maybe one of the other people
> on this list can go through it and provide some feedback?
>
> Otherwise, maybe I can pick it up again next weekend or the week after.

Got it. I'm thinking about making a new version of the patch taking
your suggestions into consideration till the end of the week. I guess
that I will send them in a separate new "[PATCH] ... thread" per patch
submission guidelines
(http://subversion.apache.org/docs/community-guide/general.html#patches).
That would be the correct way to send the patch to the mailing list
for a review.

> >>> I'm attaching two patches. I would greatly appreciate a review,
> >>> comments and suggestions. Here we go:
> >>> 1. svn-quick-start-eol-native-v1.patch.txt
> >>>Log Message:
> >>>[[[
> >>>Add missing svn:eol-style=native property to publish/quick-start.html
> >>>]]]
> >>
> >> Sure, of course.
> >>
> >>> 2. svn-updated-quick-start-v1.patch.txt
> >>> Log Message:
> >>>[[[
> >>>* publish/quick-start.html:
> >>>  Updating the SVN Quick Start guide as suggested in
> >>>  
> >>> https://lists.apache.org/thread.html/ea3462042131baac9c702fd4f19ae292c25ef20527d27db449e90f0e@%3Cdev.subversion.apache.org%3E
> >>>]]]
> >>
> >> Okay, I'll try to go through it in detail.
> >>
> >>>> > The question is: what kind of topics should the quick start page cover?
> >>>> >
> >>>> > My idea is that the page should provide task-based guidance for SVN 
> >>>> > end user on
> >>>> > how to
> >>>> > * checkout a working copy,
> >>>> > * update the working copy,
> >>>> > * modify the data in the working copy and commit it,
> >>>> > * make a branch or tag,
> >>>> > * perform a simple merge.
> >>>>
> >>>> Sounds terrific.
> >>>>
> >>>> The current quickstart page focuses on "how do I quickly set up a my
> >>>> own little repository, locally (with file:///) and put some stuff in
> >>>> there". Like a beginning user / student / ... perhaps would like to
> >>>> version his own files. I think it's a good way to introduce the
> >>>> concepts of repository and working copy, and h

Re: Tip of the day: Cheatsheet for common cmdline client operations

2017-09-14 Thread Pavel Lyalyakin
Hello,

On Wed, Aug 30, 2017 at 11:22 PM, Johan Corveleyn <jcor...@gmail.com> wrote:
>
> On Tue, Aug 29, 2017 at 2:15 PM, Pavel Lyalyakin
> <pavel.lyalya...@visualsvn.com> wrote:
> > Hello,
> >
> > On Fri, Aug 25, 2017 at 2:03 PM, Johan Corveleyn <jcor...@gmail.com> wrote:
> >>
> >> [ cc -= svnbook-dev, as I guess this will not become book-material.
> >> More below ... ]
> >>
> >> On Thu, Jul 13, 2017 at 6:34 PM, C. Michael Pilato
> >> <cmpil...@red-bean.com> wrote:
> >> > On Thu, Jul 13, 2017 at 11:21 AM, Daniel Shahaf <d...@daniel.shahaf.name>
> >> > wrote:
> >> >>
> >> >> [moving from users@ ]
> >> >>
> >> >> Daniel Shahaf wrote on Fri, 30 Jun 2017 09:15 +:
> >> >> > I just ran into the following cheatsheet:
> >> >> >
> >> >> > http://www.chim.unifi.it/~signo/did/etc/subversion/neat.html
> >> >> >
> >> >> > It covers the normal multi-user workflow, branching, etc..
> >> >> >
> >> >> > (Kudos to the author, Giorgio Signorini, not to me.)
> >> >>
> >> >> As some of you know, the author gave us permission to incorporate that
> >> >> cheatsheet into the official documentation.  Any volunteers to start the
> >> >> process?
> >> >>
> >> >> Cheers,
> >> >>
> >> >> Daniel
> >> >>
> >> > With respect to the author and the work he's done, I'm not really 
> >> > interested
> >> > in us maintaining yet another collection of the same information already
> >> > covered -- in some cases multiple times, when you factor in the reference
> >> > sections -- by the book.  At best this cheatsheet would be an appendix.  
> >> > I'm
> >> > happy to link to the cheatsheet from from the book website, though.
> >> >
> >> > -- Mike
> >>
> >> FWIW, I think this cheatsheet is quite good and valuable (though I
> >> agree there is a lot of overlap with existing documentation),
> >> especially for newcomers. Just to have a good summary / reminder of
> >> common things you'll encounter.
> >>
> >> We have our own quickstart page: http://subversion.apache.org/quick-start
> >>
> >> How about:
> >>
> >> - Putting a link at the bottom of that page (there is already a link
> >> to the quickstart section of the book), linking to the original
> >> webpage of the author.
> >>
> >> or
> >>
> >> - Incorporating (some of) the content of that cheatsheet directly on
> >> http://subversion.apache.org/quick-start, so it's right there in front
> >> of you ...
> >>
> >>
> >> The latter option would be my personal preference (putting my user /
> >> admin hat on) -- I like having short info right in front of me in the
> >> right place -- but obviously imposes some amount of doc-maintenance
> >> work on "us".
> >>
> >> Maybe someone on this list would be willing to take this doc-task
> >> (migrating the current content, and keep an eye on keeping it up to
> >> date)?
> >>
> >> --
> >> Johan
> >
> > IMO, this doc-task has to be reworded into composing a walkthrough for SVN 
> > end
> > user who wants to start performing basic version control tasks over remote
> > repository, but did not read SVNBook or other SVN-related documentation. 
> > What do
> > you think?
> >
> > I feel that the cheatsheet[1] needs to be reworked or at least 
> > restructured. In
> > the current state I feel that it is just personal notes that describe 
> > various
> > common SVN tasks, actions and tricks. Cheatsheet or personal notes is not
> > a "quick start" guide.
>
> Hm, I guess you're right. Though I think there is also a place for
> snippets / reminders / recipes (common SVN tasks, actions and tricks),
> I suppose a good walkthrough is even better for bootstrapping new
> users.
>
> > Anyway, I like the idea of adding some of the content from the cheatsheet to
> > the quick start page[2] and I would be glad to take this task.
>
> That would be great!

I've spent some time to materialize the Quick Start document that I
think will be helpful for novice SVN users. At the moment, it provides
the most basic guidance which should be enough for "quick start".
However, it lacks "Viewing

Re: Tip of the day: Cheatsheet for common cmdline client operations

2017-08-29 Thread Pavel Lyalyakin
Hello,

On Fri, Aug 25, 2017 at 2:03 PM, Johan Corveleyn <jcor...@gmail.com> wrote:
>
> [ cc -= svnbook-dev, as I guess this will not become book-material.
> More below ... ]
>
> On Thu, Jul 13, 2017 at 6:34 PM, C. Michael Pilato
> <cmpil...@red-bean.com> wrote:
> > On Thu, Jul 13, 2017 at 11:21 AM, Daniel Shahaf <d...@daniel.shahaf.name>
> > wrote:
> >>
> >> [moving from users@ ]
> >>
> >> Daniel Shahaf wrote on Fri, 30 Jun 2017 09:15 +:
> >> > I just ran into the following cheatsheet:
> >> >
> >> > http://www.chim.unifi.it/~signo/did/etc/subversion/neat.html
> >> >
> >> > It covers the normal multi-user workflow, branching, etc..
> >> >
> >> > (Kudos to the author, Giorgio Signorini, not to me.)
> >>
> >> As some of you know, the author gave us permission to incorporate that
> >> cheatsheet into the official documentation.  Any volunteers to start the
> >> process?
> >>
> >> Cheers,
> >>
> >> Daniel
> >>
> > With respect to the author and the work he's done, I'm not really interested
> > in us maintaining yet another collection of the same information already
> > covered -- in some cases multiple times, when you factor in the reference
> > sections -- by the book.  At best this cheatsheet would be an appendix.  I'm
> > happy to link to the cheatsheet from from the book website, though.
> >
> > -- Mike
>
> FWIW, I think this cheatsheet is quite good and valuable (though I
> agree there is a lot of overlap with existing documentation),
> especially for newcomers. Just to have a good summary / reminder of
> common things you'll encounter.
>
> We have our own quickstart page: http://subversion.apache.org/quick-start
>
> How about:
>
> - Putting a link at the bottom of that page (there is already a link
> to the quickstart section of the book), linking to the original
> webpage of the author.
>
> or
>
> - Incorporating (some of) the content of that cheatsheet directly on
> http://subversion.apache.org/quick-start, so it's right there in front
> of you ...
>
>
> The latter option would be my personal preference (putting my user /
> admin hat on) -- I like having short info right in front of me in the
> right place -- but obviously imposes some amount of doc-maintenance
> work on "us".
>
> Maybe someone on this list would be willing to take this doc-task
> (migrating the current content, and keep an eye on keeping it up to
> date)?
>
> --
> Johan

IMO, this doc-task has to be reworded into composing a walkthrough for SVN end
user who wants to start performing basic version control tasks over remote
repository, but did not read SVNBook or other SVN-related documentation. What do
you think?

I feel that the cheatsheet[1] needs to be reworked or at least restructured. In
the current state I feel that it is just personal notes that describe various
common SVN tasks, actions and tricks. Cheatsheet or personal notes is not
a "quick start" guide.

Anyway, I like the idea of adding some of the content from the cheatsheet to
the quick start page[2] and I would be glad to take this task.

The question is: what kind of topics should the quick start page cover?

My idea is that the page should provide task-based guidance for SVN end user on
how to
* checkout a working copy,
* update the working copy,
* modify the data in the working copy and commit it,
* make a branch or tag,
* perform a simple merge.

BTW, don't miss SVN-related docs on StackOverflow Documentation[3]. I'm pretty
sure that some of the topics from that doc will be useful.

[1]: http://www.chim.unifi.it/~signo/did/etc/subversion/neat.html
[2]: http://subversion.apache.org/quick-start
[3]: https://stackoverflow.com/documentation/svn/topics

--
With best regards,
Pavel Lyalyakin
VisualSVN Team


Re: No lock on path '/foo.txt' in filesystem 'GUID' (160040) APR does not understand this error code

2017-08-24 Thread Pavel Lyalyakin
Hello Stefan,

On Tue, Aug 22, 2017 at 7:38 PM, Stefan Hett <ste...@egosoft.com> wrote:
>
> Hi Pavel,
>
>
> On 8/22/2017 5:44 PM, Pavel Lyalyakin wrote:
>>
>> Hello,
>>
>> It seems that I've reproduced a bug:
>> 1. svn lock foo.txt
>> 2. svn rename foo.txt bar.txt
>> 3. svn commit -m MyCommit
>>
>> No errors or other symptoms on client side, but there is an error in
>> Apache logs:
>> [[[
>> No lock on path '/foo.txt' in filesystem 
>> 'f8388469-131a-5745-bb04-c2e5033b8b08'
>> (160040) APR does not understand this error code[client 192.168.0.1]
>> ]]]
>>
>> Tested with SVN 1.9.7 command line client and mod_dav_svn via HTTP and HTTPS:
>>
>> Subversion 1.8.18
>> Apache HTTP Server 2.4.26
>> (Subversion Edge 5.2.1)
>>
>> Subversion 1.9.7
>> Apache HTTP Server 2.2.34
>> (VisualSVN Server 3.6.4)
>>
>> --
>> With best regards,
>> Pavel Lyalyakin
>> VisualSVN Team
>>
> This sounds highly similiar to the issue described in 
> https://issues.apache.org/jira/browse/SVN-2534.
>
> While the (repro-)case is slightly different (uses pre-commit hooks to 
> demonstrate the problem) to me it sounds like basically the same underlying 
> problem. Do you agree?
>
> --
> Regards,
> Stefan Hett

I see that both issues are about locks and involve `svn rename` / `svn
move`. However, I'm not sure whether that's the same problem. I do not
understand why the reproduction script in SVN-2534[1] includes hook
scripts. It seems to me that the reproduction script in SVN-2534 is
overcomplicated and could be reduced. If it really is the same
problem, then my repro could be helpful.

[1]: https://issues.apache.org/jira/browse/SVN-2534

--
With best regards,
Pavel Lyalyakin
VisualSVN Team


[PATCH] Typofix to tools/dist/templates/rc-release-ann.ezt

2017-08-24 Thread Pavel Lyalyakin
Hello,

Subj.

[[[
* tools/dist/templates/rc-release-ann.ezt
  Typofix: ... than persistent data ... > ... that persistent data ...
]]]

--
With best regards,
Pavel Lyalyakin
VisualSVN Team


typofix-rc-release-ann.ezt.patch
Description: Binary data


No lock on path '/foo.txt' in filesystem 'GUID' (160040) APR does not understand this error code

2017-08-22 Thread Pavel Lyalyakin
Hello,

It seems that I've reproduced a bug:
1. svn lock foo.txt
2. svn rename foo.txt bar.txt
3. svn commit -m MyCommit

No errors or other symptoms on client side, but there is an error in
Apache logs:
[[[
No lock on path '/foo.txt' in filesystem 'f8388469-131a-5745-bb04-c2e5033b8b08'
(160040) APR does not understand this error code[client 192.168.0.1]
]]]

Tested with SVN 1.9.7 command line client and mod_dav_svn via HTTP and HTTPS:

Subversion 1.8.18
Apache HTTP Server 2.4.26
(Subversion Edge 5.2.1)

Subversion 1.9.7
Apache HTTP Server 2.2.34
(VisualSVN Server 3.6.4)

--
With best regards,
Pavel Lyalyakin
VisualSVN Team


Re: Proposal: mod_authz_svn to get an option to inform clients that resource 'cannot be written to'

2017-07-19 Thread Pavel Lyalyakin
Hello,

What is the story? How is this going to help Subversion users?

The idea sounds interesting. However, I'm not sure how it will help
the users. I don't mind whether I have Read Only or Read / Write
access to an FTP resource or another kind of remote data. I just know
whether I have access to the resource or not. IMO, this is a
communication problem and it's not what SVN has to solve.

On Wed, Jul 19, 2017 at 6:25 PM, Paul Hammant <p...@hammant.org> wrote:
> So maybe the header added to HTTP GETs of resources would be:
>
> resource-is-not-modifiable-by-you: true
>
> In the absence of this new feature of Subversion
>
> I'm going to have to encode something verbose in the repo itself as hidden
> files:
>
> /.sync/server-settings/users//readonly-masks.txt
>
> And I would generate those masks from dav_svn.authz for that user (on the
> server side). The file would be Globbing/regex-ish, of course.
>
> Regards,
>
> - Paul



-- 
With best regards,
Pavel Lyalyakin
VisualSVN Team


Re: Proposal: new fsfs.conf properties

2017-07-11 Thread Pavel Lyalyakin
Hello Paul,

On Sat, Jul 8, 2017 at 2:51 AM, Paul Hammant <p...@hammant.org> wrote:
>
> 1. compression-exempt-suffixes = mp3,mp4,jpeg
>
> 2. deltification-exempt-suffixes = mp3,mp4,jpeg
>
> Regardless of the setting of 'compression-level', #1 above two mean certain 
> things can skip the compression attempt.  It must give up at a certain point 
> right?
>
> Same for deltification re #2
>
> I'm assuming debate happens now. Then y'all let me go off and diligently file 
> a Jira ticket for this feature request, or I slink away suitably admonished...
>
> - Paul

I'm not sure whether this is going to be useful. How do you expect
these exemptions to help Subversion users? What's the story?

-- 
With best regards,
Pavel Lyalyakin
VisualSVN Team


SVN 1.9.5 & 1.1.10-dev: checkout.c line 87: assertion failed (svn_uri_is_canonical(url, scratch_pool))

2017-03-24 Thread Pavel Lyalyakin
Hello,

I'm not sure whether this problem is known, but I can reproduce it with SVN
1.9.5 and 1.10.0-dev-r1771118 clients.

SVN fails with assertion failed error when I run a `svn checkout` command
providing file://C:\repos argument on Windows. Note that there are only two
slashes after file: schema.
[[[
svn: E235000: In file '..\..\..\subversion\libsvn_client\checkout.c' line
87: assertion failed (svn_uri_is_canonical(url, scratch_pool))
]]]

Here is a command that should fail:
[[[
svn co file://C:\repo
]]]

I guess that I should get an error in this case:
[[[
svn: E17: Illegal repository URL
]]]

--
With best regards,
Pavel Lyalyakin
VisualSVN Team


Re: Let's add issue 4129 error wordings to relevant docs

2016-12-26 Thread Pavel Lyalyakin
Hello Daniel,

On Fri, Dec 23, 2016 at 11:14 PM, Daniel Shahaf <d...@daniel.shahaf.name> wrote:
>
> Pavel Lyalyakin wrote on Fri, Dec 23, 2016 at 22:31:02 +0300:
> > Index: issue4129.txt
> > ===
> > --- issue4129.txt (revision 1775883)
> > +++ issue4129.txt (working copy)
> > @@ -12,6 +12,16 @@
> >  revision would be reported as belonging to the previous revision that 
> > touched
> >  the file being annotated.
> >
> > +Beginning with SVN 1.8.0, 'svnadmin verify' produces one of these errors in
> > +case it detects this problem:
> > +[[[
> > +svnadmin: E160004: Mergeinfo-count discrepancy on '0-221.0.r64541/774830': 
> > expected 417247173744278003+0, counted 42834
> > +]]]
> > +
> > +[[[
> > +svnadmin: E160004: r1234's root node's predecessor is r1232 but should be 
> > r1233
> > +]]]
> > +
>
> There are several other error messages in libsvn_fs_fs that have
> comments associating them with issue #4129, so I don't think the
> text should imply that these two messages are the only possible
> manifestations of issue #4129.

It's definitely makes sense to include other relevant errors messages.
I've originally specified only the errors that have been recently
reported to users@ mailing list and the ones mentioned in docs. But
what are those other messages?

>From what I see now, there are 4 variants of messages `svnadmin
verify` will produce when it encounters #4129:

[[[
svnadmin: E160004: Mergeinfo-count discrepancy on
'0-221.0.r64541/774830': expected 417247173744278003+0, counted 42834
]]]
[[[
svnadmin: E160004: r1234's root node's predecessor is r1232 but should be r1233
]]]
[[[
svnadmin: E160004: Predecessor count mismatch: ARG has ARG, but ARG has ARG
]]]
[[[
svnadmin: E160004: Transaction TXN's root node's predecessor is rREV
but should be rREV
]]]

It is this list complete?

> Also, please use the text/plain MIME type for attachments.

Oops. Thanks for noticing that. :)

-- 
With best regards,
Pavel Lyalyakin
VisualSVN Team


Let's add issue 4129 error wordings to relevant docs

2016-12-23 Thread Pavel Lyalyakin
Hello,

There is an entry #4129[1] in Subversion's issue tracker, an entry in
Subversion 1.8 release notes[2] and a short doc about the problem[3].
I don't see any wordings of the errors that could occur with this
problem in none of the mentioned texts. That is why it seems to me
that a user who encounters this issue does not have enough information
to be able to identify and resolve it.

The patch attached adds the wordings of the errors to SVN 1.8 release
notes[2] and issue4129 doc[3] that 'svnadmin verify' produces when it
detects the problem. I've already added a comment to [1].

I'm sure that these wordings will help users to find the resolution
via web search.

[1]: https://issues.apache.org/jira/browse/SVN-4129
[2]: http://subversion.apache.org/docs/release-notes/1.8.html#verify-issue4129
[3]: https://svn.apache.org/repos/asf/subversion/site/publish/docs/issue4129.txt

-- 
With best regards,
Pavel Lyalyakin
VisualSVN Team


issue4129-error-wordings-verify.patch
Description: Binary data


Inconsistent 'show help' commands in `svn resolve` (property conflicts vs text conflicts)

2016-06-13 Thread Pavel Lyalyakin
Hello,

I've been checking the conflict resolution tool to make necessary
adjustments to SVNBook 1.8 and noticed that text conflict resolution offers
to press (s) key to show the full list of available commands (e.g. like on
this screen output[*]):
[[[
show all options (s):
]]]
[[[
(s)  - show this list (also 'h', '?')
]]]
As you see, it accepts (s), (?) and (h) keys to show the list of all
available commands.

However, the property conflict resolution tool has a different text and it
does not accept (s) and (?) keys:
[[[
$ svn resolve Makefile
Conflict for property 'abc' discovered on 'Makefile'.
local add, incoming add upon update
Select: (p) postpone, (mf) my version, (tf) their version,
(dc) display conflict, (e) edit property, (q) quit resolution,
(h) help: s
Unrecognized option.
]]]
[[[
(h)  - show this help (also '?')
]]]

Was there any special reason to switch (h)elp option to (s)how all options?

IMO, both tools and the new tree conflict resolution tool have to be
consistent when it comes to the commands they accept. But I'm not sure
whether (h)elp is better than (s)how all options as the default key for
'help'.

[*]: http://svnbook.red-bean.com/en/1.8/svn.tour.cycle.html#idp8043776

-- 
With best regards,
Pavel Lyalyakin
VisualSVN Team


[PATCH] SVNBook is now hosted on SourceForge, not Google Code

2016-05-31 Thread Pavel Lyalyakin
Hello,

README[*] still tells that SVNBook is hosted on Google Code.
The attached patch updates the README file with the correct repository URL.

Log Message:
[[[
* README
  Correct the svnbook sources URL (now hosted on SourceForge).
]]]

[*]: https://svn.apache.org/repos/asf/subversion/trunk/README

-- 
With best regards,
Pavel Lyalyakin
VisualSVN Team
Index: README
===
--- README	(revision 1719400)
+++ README	(working copy)
@@ -36,10 +36,10 @@
 
   It is written in DocBook XML, and the sources can be found at:
 
- http://svnbook.googlecode.com/svn/trunk/
+ http://svn.code.sf.net/p/svnbook/source/trunk/
  
   If you wish to build the documentation from source, read the
-  src/en/README file within the book source.
+  en/README file within the book source.
 
 
 


Re: `svn help` output in SVN 1.8 and 1.9

2016-05-27 Thread Pavel Lyalyakin
Hello Stefan,

On Fri, May 27, 2016 at 12:39 AM, Stefan Sperling <s...@apache.org> wrote:
>
> Hi Pavel,
>
> This change was intentional.

Got it! Thank you. I just wanted to be sure that this was an
intentional change. :)

-- 
With best regards,
Pavel Lyalyakin
VisualSVN Team


`svn help` output in SVN 1.8 and 1.9

2016-05-26 Thread Pavel Lyalyakin
Hello,

I'm reading through the nightly SVNBook 1.8 and make more or less
necessary changes to complete it and begin the work on SVNBook 1.9.
I've just noticed that the output of `svn help` is slightly different
in SVN 1.8 and 1.9 command-line clients.

SVN 1.8 shows the version number (take a look at the second line):
[[[
usage: svn  [options] [args]
Subversion command-line client, version 1.8.13.
Type 'svn help ' for help on a specific subcommand.
]]]

SVN 1.9 does not show the version number:
[[[
usage: svn  [options] [args]
Subversion command-line client.
]]]

Was there any special reason to hide the version number here? Or is it a bug?

-- 
With best regards,
Pavel Lyalyakin
VisualSVN Team


Re: [PATCH] add FAQ section about "bad request" errors

2016-05-26 Thread Pavel Lyalyakin
Hello Stefan,

On Thu, May 26, 2016 at 3:03 AM, Stefan <luke1...@posteo.de> wrote:

> Hi Pavel,
>
> To still get something out of that, I'm atm considering to write a quick
> blog entry on my own blog and send a quick announcement to the SVN users
> mailing list so just in case s/o runs into the problem, there's a chance he
> can build upon the investigation work done here already. I'd really much
> appreciate if you would review the blog post before I put it live, so I can
> incorporate any feedback you might have beforehand. What do you think?
>

Sure, I would be glad to help. This approach looks great!

>
> The recommendation for the LimitRquestFieldSize was based on the statement
> from Bert in this post [2]: "The real fix for delete, replace, etc. of
> trees with many locks is to somehow allow the headers to go through, but
> this requires a config change from the admin." and Philip's reference to
> that config setting in a comment [3] on SVN-4557.
>

Thanks for pointing me to these statements. Note that Bert tells that this
kind of locking causing the errors is kind of (very) unexpected scenario,
and it's still unclear why some users try to lock large sets of repository
items.

 --
With best regards,
Pavel Lyalyakin
VisualSVN Team


Re: [PATCH] add FAQ section about "bad request" errors

2016-05-24 Thread Pavel Lyalyakin
ese problems can occur. But, again,
I don't think that the official Subversion FAQ is the right place for
this.

--
With best regards,
Pavel Lyalyakin
VisualSVN Team


Re: [PATCH] add FAQ section about "bad request" errors

2016-05-23 Thread Pavel Lyalyakin
Hello,

On Fri, May 20, 2016 at 10:50 PM, Stefan <luke1...@posteo.de> wrote:
>
> On 5/15/2016 02:00, Stefan wrote:
> > Hi,
> >
> >
> > following patch adds a new entry to the FAQ's trouble shooting
> > section, documenting the known problem with large headers, exceeding
> > Apache httpd's LimitRequestFieldSize setting.
> >
> > [[[
> > Document known issue about long header sections causing problems with
> > Apache httpd.
> >
> > * docs/faq.html
> >   (Table of Contents): add link to new http-400 section
> >   (http-400): new trouble shooting section about http-400-error
> > ]]]
> Anybody feels like approving the change? Or is there anything I should
> improve in the patch before committing it?

This error can have different causes and that's why you should not put
an emphasis on some of them, while omitting other causes. And I don't
think that the entry on troubleshooting 400 'Bad Request' errors fits
FAQ format. There can be too many answers to the question "How can I
resolve it?". This error does not give enough information to provide a
reader with instructions on how to resolve it.

I mean that it is possible to get 400 'Bad request' error in numerous
other cases and pointing out just some of them on the FAQ page is not
the best idea. IMO, such FAQ entry can distract a reader from
identifying the real root cause of the problem. Just to name a couple
of additional examples when you can get 400 'Bad request' error:

* Unlocking a file with a stolen lock will result in 400 'Bad request'
  error. This problem is described in SVN-4372[1].

* Authenticating to the server using Negotiate/Kerberos when the
  particular user who's accessing the repository is a member of too
  many groups or has enormous SID history will result in 400
  'Bad request' error. This problem is described in the article
  "HTTP status 400 Bad Request error when a user connects to VisualSVN
  Server"[2].

And don't forget that an antivirus, active firewall or proxy server
can be the root cause as well[3].

BTW, the request field size limit should usually be between 8-16KB and
configuring it to be less can lead to getting 400 'Bad Headers' errors
too. On the other hand, configuring it to be larger than 16KB can be
bad from security and performance point of view. Therefore, you should
avoid telling the reader to change the limit without considering his
particular case.

That said, I think that this FAQ entry will confuse the reader rather
than help him to identify the root cause and resolve it. It'd be
better to mention that the problem can have a lot of various causes
and the reader has to check the server logs for clues. As always, it
makes sense to recommend using the latest Subversion version and
advise searching the Apache Subversion bug tracker for "Bad request"
errors. Checking antivirus, firewall and proxy is also recommended. If
nothing of this helped, contact users@ Subversion for help.

But these basic recommendations can be applied to the troubleshooting
of practically any generic error. That's why I don't think that 400
'Bad Request' needs a special entry in the FAQ.

[1]: https://issues.apache.org/jira/browse/SVN-4372
[2]: https://www.visualsvn.com/support/topic/00098/
[3]: 
https://mail-archives.apache.org/mod_mbox/subversion-users/201108.mbox/%3CCALb=wn=wuwkr392eyolp0f5e8b-k2vne1btu5lgvtuoegod...@mail.gmail.com%3E

--
With best regards,
Pavel Lyalyakin
VisualSVN Team


Missing images in TortoiseSVN Manual (403 Forbidden)

2015-08-18 Thread Pavel Lyalyakin
Hello,

I don't see any images when I navigate to
http://tortoisesvn.net/docs/release/TortoiseSVN_en/.  As an example, there
should be an image of The Import Dialog:
http://tortoisesvn.net/docs/release/TortoiseSVN_en/tsvn-qs-guide.html#tsvn-qs-import-dia

All images just give me 403 Forbidden error:
http://tortoisesvn.net/docs/release/TortoiseSVN_en/images/important.png.

--
With best regards,
Pavel Lyalyakin
VisualSVN Team


Re: Missing images in TortoiseSVN Manual (403 Forbidden)

2015-08-18 Thread Pavel Lyalyakin
Hello,

On Tue, Aug 18, 2015 at 2:10 PM, Stefan Hett ste...@egosoft.com wrote:

 Hi Pavel,

 Hello,

 I don't see any images when I navigate to
 http://tortoisesvn.net/docs/release/TortoiseSVN_en/. As an example,
 there should be an image of The Import Dialog:
 http://tortoisesvn.net/docs/release/TortoiseSVN_en/tsvn-qs-guide.html#tsvn-qs-import-dia

 All images just give me 403 Forbidden error:
 http://tortoisesvn.net/docs/release/TortoiseSVN_en/images/important.png.

 Did u send this to the wrong mailing list by accident?


Yes, wrong mailing list. Thanks for noticing! :)

--
With best regards,
Pavel Lyalyakin
VisualSVN Team


Re: FSFS Repository corruption on high load on Windows (was Re: svn commit: r1082451 - /subversion/trunk/subversion/libsvn_subr/io.c)

2013-05-20 Thread Pavel Lyalyakin
Hello pals,

To make sure that everyone can easily reproduce the corruption I'm
including the reproduction script below. The particular reproduction
script covers repository corruption with `svnadmin setrevprop` command
and immediate power failure / power reset.

Environment:

Windows Server 2008 R2 SP1,
Apache Subversion 1.7.9.

Reproduction script:

1. `svnadmin create MyRepo`
2. `echo HELLOWORLD  desc.txt`
3. `svnadmin setrevprop MyRepo -r 0 repository-desc desc.txt`
Immediately reset the machine after running the `svnadmin setrevprop`
command-line.
4. After machine restarts run `svnadmin verify MyRepo`

Getting:

[[
E22: Serialized hash missing terminator
]]

Thank you.

-- 
With best regards,
Pavel Lyalyakin
VisualSVN Team


Environment variables in hook scripts?

2013-03-21 Thread Pavel Lyalyakin
Hello,

In the official Apache Subversion FAQ I see the entry:
http://subversion.apache.org/faq.html#hook-debugging.

The entry says:

[[
Before Subversion calls a hook script, it removes all variables --
including $PATH on Unix, and %PATH% on Windows -- from the
environment. Therefore, your script can only run another program if
you spell out that program's absolute name.
]]

Is this statement true?

I've just tested this with Windows 7 64bit and Apache Subversion
1.7.8: NO environment variables get removed.

Am I doing something wrong? Is the FAQ entry obsolete?

--
With best regards,
Pavel Lyalyakin
VisualSVN Team