Re: svn commit: r1806548 - in /subversion/trunk/subversion: svn/svn.c svnbench/svnbench.c tests/cmdline/basic_tests.py

[Evgeny Kotkov]

Bert Huijben  writes:

>> As Julian discovered, '--search' as used with 'svn log' is may not suitable
>> for 'svn ls'.  File name matching should be case-sensitive and requires
>> full patterns just like e.g. the ordinary unix command line 'ls' command.
>>
>> Therefore, introduce a separate '--pattern' option for 'svn log' that works
>> similar to patterns with Unix command line 'ls'.  Since the actual matching
>> already confirms to that, we only need a different option pre-processing.
>
> Perhaps we could use --glob, to allow other syntax patterns later?
>
> Not sure... perhaps --glob is too technical.

My 2 cents on this would be that having "svn ls --pattern" and "svn log
--search" which only differ in terms of case sensitivity have a chance of
being confusing for the users.

Perhaps, a slightly better way would be to keep the case-insensitive behavior
by default, but add a "--case-sensitive" switch to handle the cases where
it's required?

That is,

svn ls --search

svn ls --search --case-sensitive


Regards,
Evgeny Kotkov

RE: svn commit: r1806548 - in /subversion/trunk/subversion: svn/svn.c svnbench/svnbench.c tests/cmdline/basic_tests.py

[Bert Huijben]

> -Original Message-
> From: stef...@apache.org [mailto:stef...@apache.org]
> Sent: dinsdag 29 augustus 2017 11:57
> To: comm...@subversion.apache.org
> Subject: svn commit: r1806548 - in /subversion/trunk/subversion: svn/svn.c
> svnbench/svnbench.c tests/cmdline/basic_tests.py
> 
> Author: stefan2
> Date: Tue Aug 29 09:56:31 2017
> New Revision: 1806548
> 
> URL: http://svn.apache.org/viewvc?rev=1806548=rev
> Log:
> As Julian discovered, '--search' as used with 'svn log' is may not suitable
> for 'svn ls'.  File name matching should be case-sensitive and requires
> full patterns just like e.g. the ordinary unix command line 'ls' command.
> 
> Therefore, introduce a separate '--pattern' option for 'svn log' that works
> similar to patterns with Unix command line 'ls'.  Since the actual matching
> already confirms to that, we only need a different option pre-processing.

Perhaps we could use --glob, to allow other syntax patterns later?

Not sure... perhaps --glob is too technical.

Bert