Re: Remove py2 support from mailer.py?

2024-05-11 Thread Daniel Sahlberg
Hi,

I agree that we should not, at this point in time, let Python 2
compatibility hold us back if things can be done more efficient in Python
3. It has previously been agreed that we don't aggressively remove Python 2
support in 1.14 but /trunk is fine for me.

Maybe we should also start a discussion about actively removing Python 2
support in /trunk, ie for Subversion 1.15. I'm by no means an expert but at
least there is some code in the bindings where we can remove some
#if/#ifdef. This way we don't have to test for Python 2 (which we SHOULD do
if we officially keep the code in place).

Kind regards,
Daniel Sahlberg


Den fre 10 maj 2024 kl 10:20 skrev Greg Stein :

> Hey all,
>
> I am proposing to remove py2 support from mailer.py. It is an anchor on
> some of the coding options within the module.
>
> I would suggest installations requiring py2 for mailer.py "just don't
> upgrade".
>
> This tool is not part of our core distribution, and I would further note
> that py2 was EOL'd in January 2020. I do not believe that Apache Subversion
> should support versions of Python that no longer receive updates (security,
> or otherwise).
>
> No rush on this, and no need for +1 responses ... I'm interested in people
> saying "keep py2 support" and the rationale. I'll give it a week before
> declaring consensus for removal, if there is no counter-argument.
>
> Thanks!
> -g
>
> ps. to be clear: the ASF *does not* use mailer.py today (we use Andre
> Malo's svnmailer). We intend to switch to the py3 version of mailer.py in
> the near future. I am adding features that the ASF needs (eg. around "don't
> send over-large commit emails")
>
>


Remove py2 support from mailer.py?

2024-05-10 Thread Greg Stein
Hey all,

I am proposing to remove py2 support from mailer.py. It is an anchor on
some of the coding options within the module.

I would suggest installations requiring py2 for mailer.py "just don't
upgrade".

This tool is not part of our core distribution, and I would further note
that py2 was EOL'd in January 2020. I do not believe that Apache Subversion
should support versions of Python that no longer receive updates (security,
or otherwise).

No rush on this, and no need for +1 responses ... I'm interested in people
saying "keep py2 support" and the rationale. I'll give it a week before
declaring consensus for removal, if there is no counter-argument.

Thanks!
-g

ps. to be clear: the ASF *does not* use mailer.py today (we use Andre
Malo's svnmailer). We intend to switch to the py3 version of mailer.py in
the near future. I am adding features that the ASF needs (eg. around "don't
send over-large commit emails")