Re: svn commit: r1891065 - in /subversion/site/staging-ng: ./ docs/community-guide/ docs/release-notes/ security/
On Thu, Jul 15, 2021 at 7:33 AM Daniel Sahlberg wrote: > > Den tis 13 juli 2021 kl 00:14 skrev Nathan Hartman : >> >> This is in fact a big improvement and most pages are behaving nicely >> now. However I noticed that there exist some other elements besides >> .. that are extending the viewport in a few places. One >> example of this is the mailing list page [1] where the table does it; >> another is the faq where one entry's title is extending the page width >> [2]. There are a few other places where one or two elements do it. I >> haven't yet looked into what the fix needs to be. It might be as >> simple as moving the "overflow-x: auto" to a different place. Other >> than this, the site altogether is well-behaved and much improved on >> mobile. >> >> [1] http://subversion-staging.apache.org/mailing-lists.html >> >> [2] http://subversion-staging.apache.org/faq.html#configure-sed-error > > > I solved the link issue by forcing wordwrapping on and which should > sort out [2] above, in addition there were some problems in HACKING. > Committed as r1891570. Thanks for fixing that. I don't know why, but the doesn't seem to wrap automatically on my device; I haven't investigated yet. Regarding the mailing-lists page, I wouldn't worry about the nested tables for now. I'd like to improve this page anyway, so the formatting can be updated at the same opportunity. Cheers, Nathan
Re: svn commit: r1891065 - in /subversion/site/staging-ng: ./ docs/community-guide/ docs/release-notes/ security/
Den tis 13 juli 2021 kl 00:14 skrev Nathan Hartman :
> This is in fact a big improvement and most pages are behaving nicely
> now. However I noticed that there exist some other elements besides
> .. that are extending the viewport in a few places. One
> example of this is the mailing list page [1] where the table does it;
> another is the faq where one entry's title is extending the page width
> [2]. There are a few other places where one or two elements do it. I
> haven't yet looked into what the fix needs to be. It might be as
> simple as moving the "overflow-x: auto" to a different place. Other
> than this, the site altogether is well-behaved and much improved on
> mobile.
>
> [1] http://subversion-staging.apache.org/mailing-lists.html
>
> [2] http://subversion-staging.apache.org/faq.html#configure-sed-error
I solved the link issue by forcing wordwrapping on and which
should sort out [2] above, in addition there were some problems in HACKING.
Committed as r1891570.
However I cannot easily solve [1] above. I've found some fairly complex CSS
that seems to partly do the trick, but since there are nested tables within
the table it doesn't seem to fully work. I will continue to investigate if
the table can be un-nested using colspan and rowspan but I'm running out of
time right now.
[[[
Index: style/site.css
===
--- style/site.css (revision 1891570)
+++ style/site.css (working copy)
@@ -172,6 +172,13 @@
tt, a {
overflow-wrap: break-word;
}
+table {
+ display: block;
+ max-width: -moz-fit-content;
+ max-width: fit-content;
+ margin: 0 auto;
+ overflow-x: auto;
+}
}
}
]]]
Kind regards,
Daniel Sahlberg
Re: svn commit: r1891065 - in /subversion/site/staging-ng: ./ docs/community-guide/ docs/release-notes/ security/
On Mon, Jul 12, 2021 at 2:15 PM Daniel Sahlberg
wrote:
>
> Den mån 12 juli 2021 kl 18:16 skrev Nathan Hartman :
>>
>> [...]
>>
>> These fixes have solved that issue; however pages that have
>> ... formatted text cause the viewport to stretch when the
>> lines of text are longer than can fit in the viewport. On some pages
>> there are some quite long lines of preformatted text. Adding a
>> "overflow-x: auto;" to the CSS for pre tags in site.css seems to fix
>> it without affecting readability: It allows the pre tag itself to
>> scroll if needed, but the rest of the page stays put; e.g.,:
>>
>> [[[
>>
>> Index: style/site.css
>> ===
>> --- style/site.css (revision 1891484)
>> +++ style/site.css (working copy)
>> @@ -54,6 +54,7 @@ pre {
>>padding: 0.25em;
>>margin: 0 2em;
>>font-size: 90%;
>> + overflow-x: auto;
>> }
>>
>> /*
>>
>> ]]]
>
>
> Good catch! Your patch seems fine to me. I committed to check on the staging
> site and it looks good both on my computer and in my phone.
This is in fact a big improvement and most pages are behaving nicely
now. However I noticed that there exist some other elements besides
.. that are extending the viewport in a few places. One
example of this is the mailing list page [1] where the table does it;
another is the faq where one entry's title is extending the page width
[2]. There are a few other places where one or two elements do it. I
haven't yet looked into what the fix needs to be. It might be as
simple as moving the "overflow-x: auto" to a different place. Other
than this, the site altogether is well-behaved and much improved on
mobile.
[1] http://subversion-staging.apache.org/mailing-lists.html
[2] http://subversion-staging.apache.org/faq.html#configure-sed-error
Nathan
Re: svn commit: r1891065 - in /subversion/site/staging-ng: ./ docs/community-guide/ docs/release-notes/ security/
Den mån 12 juli 2021 kl 18:16 skrev Nathan Hartman :
> [...]
>
> These fixes have solved that issue; however pages that have
> ... formatted text cause the viewport to stretch when the
> lines of text are longer than can fit in the viewport. On some pages
> there are some quite long lines of preformatted text. Adding a
> "overflow-x: auto;" to the CSS for pre tags in site.css seems to fix
> it without affecting readability: It allows the pre tag itself to
> scroll if needed, but the rest of the page stays put; e.g.,:
>
> [[[
>
> Index: style/site.css
> ===
> --- style/site.css (revision 1891484)
> +++ style/site.css (working copy)
> @@ -54,6 +54,7 @@ pre {
>padding: 0.25em;
>margin: 0 2em;
>font-size: 90%;
> + overflow-x: auto;
> }
>
> /*
>
> ]]]
>
Good catch! Your patch seems fine to me. I committed to check on the
staging site and it looks good both on my computer and in my phone.
Thanks!
/Daniel
Re: svn commit: r1891065 - in /subversion/site/staging-ng: ./ docs/community-guide/ docs/release-notes/ security/
On Sun, Jul 11, 2021 at 6:04 PM Daniel Sahlberg
wrote:
>
> Den sön 11 juli 2021 kl 17:53 skrev Nathan Hartman :
>>
>> One slight issue: It seems the viewport is set just *slightly* too
>> wide, at least on my device. This causes a little bit of unwanted
>> left/right scroll.
>>
>> In landscape orientation it is barely discernible (but it's there).
>>
>> In portrait orientation, a few pixels are cut off the right edge (but
>> can be scrolled horizontally into view).
>>
>> How many pixels? I think 8. I think it's caused by style/site.css,
>> where "#site-banner" has a padding of 8px. (Though there may be other
>> paddings that contribute.)
>
>
> It was actually 7 pixels, caused by a padding in the site-nav . I've
> moved it to the site-nav-menu in r1891461. It has the side effect that the
> hamburger is slightly closer to the left edge but I think it is acceptable.
>
>>
>> Why I think so: At the top of the page, the ASF banner, which appears
>> above the Subversion banner, seems to have the final N cut off from
>> the word "FOUNDATION" so that it appears to read "FOUNDATIO" until the
>> screen is scrolled slightly sideways. At first I thought it was caused
>> by the banner being too wide. But then I noticed that the viewport is
>> a little too wide in landscape orientation too, even though the banner
>> is narrower than the viewport in that orientation. Then I noticed that
>> the little gray gradient under the banners seems to have this extra
>> white padding on its right edge (so the blue "border-top" of
>> #site-content, and beneath it, the green "border-top" of #site-nav,
>> are wider than the #site-banner gradient) and that seems to be the
>> exact amount of unwanted scroll.
>
>
> The ASF logo contained an explicit size which broke the CSS media
> queries. I've removed it in r1891462. Looks much better now.
These fixes have solved that issue; however pages that have
... formatted text cause the viewport to stretch when the
lines of text are longer than can fit in the viewport. On some pages
there are some quite long lines of preformatted text. Adding a
"overflow-x: auto;" to the CSS for pre tags in site.css seems to fix
it without affecting readability: It allows the pre tag itself to
scroll if needed, but the rest of the page stays put; e.g.,:
[[[
Index: style/site.css
===
--- style/site.css (revision 1891484)
+++ style/site.css (working copy)
@@ -54,6 +54,7 @@ pre {
padding: 0.25em;
margin: 0 2em;
font-size: 90%;
+ overflow-x: auto;
}
/*
]]]
Cheers,
Nathan
Re: svn commit: r1891065 - in /subversion/site/staging-ng: ./ docs/community-guide/ docs/release-notes/ security/
Den sön 11 juli 2021 kl 17:53 skrev Nathan Hartman : > On Fri, Jul 9, 2021 at 4:22 PM Daniel Sahlberg > wrote: > > I merged the staging-ng branch to staging yesterday evening but forgot > to notify dev@. Please check https://subversion-staging.apache.org/ and > report any issues. > > > It's a big improvement for readability on mobile! > > One slight issue: It seems the viewport is set just *slightly* too > wide, at least on my device. This causes a little bit of unwanted > left/right scroll. > > In landscape orientation it is barely discernible (but it's there). > > In portrait orientation, a few pixels are cut off the right edge (but > can be scrolled horizontally into view). > > How many pixels? I think 8. I think it's caused by style/site.css, > where "#site-banner" has a padding of 8px. (Though there may be other > paddings that contribute.) > It was actually 7 pixels, caused by a padding in the site-nav . I've moved it to the site-nav-menu in r1891461. It has the side effect that the hamburger is slightly closer to the left edge but I think it is acceptable. > Why I think so: At the top of the page, the ASF banner, which appears > above the Subversion banner, seems to have the final N cut off from > the word "FOUNDATION" so that it appears to read "FOUNDATIO" until the > screen is scrolled slightly sideways. At first I thought it was caused > by the banner being too wide. But then I noticed that the viewport is > a little too wide in landscape orientation too, even though the banner > is narrower than the viewport in that orientation. Then I noticed that > the little gray gradient under the banners seems to have this extra > white padding on its right edge (so the blue "border-top" of > #site-content, and beneath it, the green "border-top" of #site-nav, > are wider than the #site-banner gradient) and that seems to be the > exact amount of unwanted scroll. > The ASF logo contained an explicit size which broke the CSS media queries. I've removed it in r1891462. Looks much better now. I can see it on my computer using Firefox once the window is made > narrow enough to switch to hamburger view. > I saw it as well on my computer using Edge, if I just looked close enough. Thanks for reviewing and drawing my attention to it. Kind regards, Daniel Sahlberg
Re: svn commit: r1891065 - in /subversion/site/staging-ng: ./ docs/community-guide/ docs/release-notes/ security/
On Fri, Jul 9, 2021 at 4:22 PM Daniel Sahlberg wrote: > I merged the staging-ng branch to staging yesterday evening but forgot to > notify dev@. Please check https://subversion-staging.apache.org/ and report > any issues. It's a big improvement for readability on mobile! One slight issue: It seems the viewport is set just *slightly* too wide, at least on my device. This causes a little bit of unwanted left/right scroll. In landscape orientation it is barely discernible (but it's there). In portrait orientation, a few pixels are cut off the right edge (but can be scrolled horizontally into view). How many pixels? I think 8. I think it's caused by style/site.css, where "#site-banner" has a padding of 8px. (Though there may be other paddings that contribute.) Why I think so: At the top of the page, the ASF banner, which appears above the Subversion banner, seems to have the final N cut off from the word "FOUNDATION" so that it appears to read "FOUNDATIO" until the screen is scrolled slightly sideways. At first I thought it was caused by the banner being too wide. But then I noticed that the viewport is a little too wide in landscape orientation too, even though the banner is narrower than the viewport in that orientation. Then I noticed that the little gray gradient under the banners seems to have this extra white padding on its right edge (so the blue "border-top" of #site-content, and beneath it, the green "border-top" of #site-nav, are wider than the #site-banner gradient) and that seems to be the exact amount of unwanted scroll. I can see it on my computer using Firefox once the window is made narrow enough to switch to hamburger view. (Still, it is a big improvement over publish, where making the viewport narrow causes the banners to get totally messed up.) Cheers, Nathan
Re: svn commit: r1891065 - in /subversion/site/staging-ng: ./ docs/community-guide/ docs/release-notes/ security/
Den lör 3 juli 2021 kl 00:23 skrev Daniel Sahlberg < daniel.l.sahlb...@gmail.com>: > Den lör 3 juli 2021 kl 00:07 skrev Nathan Hartman < > hartman.nat...@gmail.com>: > >> I lost the part of your reply where you mentioned merging to staging. >> I was hoping to test with a web server and browser, but it probably >> won't happen for at least a couple of days, so if you'd like, feel >> free to merge to staging, give everyone a few days to look at it, and >> worst case if there's a problem it can always be unmerged from staging >> (but I don't think that will need to happen). >> > > There are some changes in staging (http://->https:// migrating etc.) that > I would like to merge to publish first so we can keep the different changes > separate. Danielsh reviewed some parts of it but I don't think anyone has > looked at the links changes. I'm also waiting for response regarding > https:// for the SVN Book which is the main part of all remaining http:// > links. > I merged the staging-ng branch to staging yesterday evening but forgot to notify dev@. Please check https://subversion-staging.apache.org/ and report any issues. Kind regards, Daniel Sahlberg
Re: svn commit: r1891065 - in /subversion/site/staging-ng: ./ docs/community-guide/ docs/release-notes/ security/
Den lör 3 juli 2021 kl 00:07 skrev Nathan Hartman : > I lost the part of your reply where you mentioned merging to staging. > I was hoping to test with a web server and browser, but it probably > won't happen for at least a couple of days, so if you'd like, feel > free to merge to staging, give everyone a few days to look at it, and > worst case if there's a problem it can always be unmerged from staging > (but I don't think that will need to happen). > There are some changes in staging (http://->https:// migrating etc.) that I would like to merge to publish first so we can keep the different changes separate. Danielsh reviewed some parts of it but I don't think anyone has looked at the links changes. I'm also waiting for response regarding https:// for the SVN Book which is the main part of all remaining http:// links. Kind regards, Daniel Sahlberg
Re: svn commit: r1891065 - in /subversion/site/staging-ng: ./ docs/community-guide/ docs/release-notes/ security/
On Fri, Jul 2, 2021 at 5:28 PM Daniel Sahlberg wrote: >> Yes; also I did a little bit of graphics work with the various logo >> and icon files; mostly to rasterize the original vector artwork (in >> SVG format IIRC?) to various resolutions and formats expected by >> various browsers and smartphones, though I seem to recall that I had >> to do a little massaging of the vector formats for some reason. The >> one where I got "creative" was tile-wide.png; we didn't have a >> wide-format file so I made that as a placeholder. I wasn't very happy >> with it at the time but I just looked at it again and now I think it >> actually looks cool. Let me know what you think... > > > Not a graphics designer ;-) but I try to keep graphics elements separate (ie, > the square separate without any other elements intruding its space). We have > already, slightly, change the original logo by moving the text SUBVERSION > from within the square to outside of the square and adding some blue bars > above/below so I don't know how strict we should be with this "rule". > > As far as I can find this wide logo is used only in browserconfig.xml, which > in turn is only used for Internet Explorer and possibly Edge Legacy. As these > are both EOL, maybe the discussion is moot and we can remove > browserconfig.xml, tile.png and tile-wide.png? Sure, if it's not needed anymore then feel free to remove it. As to whether we have to strictly stay with the exact original logo without modifying it (i.e., keeping just the stylized S without the text under it), I don't really know, but we've had an altered version of the Subversion logo as the site logo for years, possibly decades actually. I lost the part of your reply where you mentioned merging to staging. I was hoping to test with a web server and browser, but it probably won't happen for at least a couple of days, so if you'd like, feel free to merge to staging, give everyone a few days to look at it, and worst case if there's a problem it can always be unmerged from staging (but I don't think that will need to happen). Thanks for driving this forward! Cheers, Nathan
Re: svn commit: r1891065 - in /subversion/site/staging-ng: ./ docs/community-guide/ docs/release-notes/ security/
Thanks for reviewing! Den tis 29 juni 2021 kl 17:16 skrev Nathan Hartman : > On Sun, Jun 27, 2021 at 5:28 PM Daniel Sahlberg > wrote: > > > > Den sön 27 juni 2021 kl 18:54 skrev Nathan Hartman < > hartman.nat...@gmail.com>: > >> > >> Thanks! Improving the website (especially mobile friendliness) is one > >> of the many things that has been on my ever-growing TODO list for a > >> long while > > > > > > I know the feeling! > > > >> > >> [...] if you'd like help, just say the word. > > > > > > Yes, please. You can start by reviewing r1891073. > > Done! See other thread... (Going over the other revisions too...) > Replies to your review in the other thread! > > I see you already did some work with site manifest etc, - the changes in > TEMPLATE should probably be added in all the HTML files as well. Except, > possibly, some IE specific things (x-ua-compatible, browserconfig.xml). > > Yes; also I did a little bit of graphics work with the various logo > and icon files; mostly to rasterize the original vector artwork (in > SVG format IIRC?) to various resolutions and formats expected by > various browsers and smartphones, though I seem to recall that I had > to do a little massaging of the vector formats for some reason. The > one where I got "creative" was tile-wide.png; we didn't have a > wide-format file so I made that as a placeholder. I wasn't very happy > with it at the time but I just looked at it again and now I think it > actually looks cool. Let me know what you think... > Not a graphics designer ;-) but I try to keep graphics elements separate (ie, the square separate without any other elements intruding its space). We have already, slightly, change the original logo by moving the text SUBVERSION from within the square to outside of the square and adding some blue bars above/below so I don't know how strict we should be with this "rule". As far as I can find this wide logo is used only in browserconfig.xml, which in turn is only used for Internet Explorer and possibly Edge Legacy. As these are both EOL, maybe the discussion is moot and we can remove browserconfig.xml, tile.png and tile-wide.png? References: Logo as suggested by Nathan: https://svn.apache.org/repos/asf/subversion/site/staging-ng/tile-wide.png Original logo as submitted by Tyrus Christiana: https://svn.apache.org/repos/asf/subversion/svn-logos/images/tyrus-svn2.png > > In another e-mail you mentioned that you also played with some design > ideas for the site. Did you consider a complete redesign? > > I didn't write any actual HTML, but I used [favorite page layout > software] just to play with different layout ideas, and I looked at a > great many websites for inspiration. Where I ran into some difficulty > is that I wanted to preserve the color scheme as much as possible > while going for a more modern look, but the "modern" look didn't > seem to fit well with the pastel blue and pastel green [1]. So I next > thought that those two colors could remain as "low key" while adding a > third, stronger color, such as a goldenrod variant, to give a strong > contrast. (Theoretically the "correct" opposing color to use with the > pastel blue is a light brownish, but I don't like how that looks.) > Anyway that's where I got stuck with a complete redesign, so I thought > it should be done in steps: to first make the site work better on > mobile, then think about a more heavy-duty change. > Alright. I think we should start by merging a more mobile friendly version to staging (and then to publishing) and we can discuss from there. [1] > Pastel blue R152 G176 B212 (H216deg S28% B83%) > Pastel green R175 G205 B98 (H77deg S52% B80%) > > Cheers, > Nathan >
Re: svn commit: r1891065 - in /subversion/site/staging-ng: ./ docs/community-guide/ docs/release-notes/ security/
On Sun, Jun 27, 2021 at 5:28 PM Daniel Sahlberg wrote: > > Den sön 27 juni 2021 kl 18:54 skrev Nathan Hartman : >> >> Thanks! Improving the website (especially mobile friendliness) is one >> of the many things that has been on my ever-growing TODO list for a >> long while > > > I know the feeling! > >> >> [...] if you'd like help, just say the word. > > > Yes, please. You can start by reviewing r1891073. Done! See other thread... (Going over the other revisions too...) > I see you already did some work with site manifest etc, - the changes in > TEMPLATE should probably be added in all the HTML files as well. Except, > possibly, some IE specific things (x-ua-compatible, browserconfig.xml). Yes; also I did a little bit of graphics work with the various logo and icon files; mostly to rasterize the original vector artwork (in SVG format IIRC?) to various resolutions and formats expected by various browsers and smartphones, though I seem to recall that I had to do a little massaging of the vector formats for some reason. The one where I got "creative" was tile-wide.png; we didn't have a wide-format file so I made that as a placeholder. I wasn't very happy with it at the time but I just looked at it again and now I think it actually looks cool. Let me know what you think... > In another e-mail you mentioned that you also played with some design ideas > for the site. Did you consider a complete redesign? I didn't write any actual HTML, but I used [favorite page layout software] just to play with different layout ideas, and I looked at a great many websites for inspiration. Where I ran into some difficulty is that I wanted to preserve the color scheme as much as possible while going for a more modern look, but the "modern" look didn't seem to fit well with the pastel blue and pastel green [1]. So I next thought that those two colors could remain as "low key" while adding a third, stronger color, such as a goldenrod variant, to give a strong contrast. (Theoretically the "correct" opposing color to use with the pastel blue is a light brownish, but I don't like how that looks.) Anyway that's where I got stuck with a complete redesign, so I thought it should be done in steps: to first make the site work better on mobile, then think about a more heavy-duty change. [1] Pastel blue R152 G176 B212 (H216deg S28% B83%) Pastel green R175 G205 B98 (H77deg S52% B80%) Cheers, Nathan
Re: svn commit: r1891065 - in /subversion/site/staging-ng: ./ docs/community-guide/ docs/release-notes/ security/
Den sön 27 juni 2021 kl 18:54 skrev Nathan Hartman : > Thanks! Improving the website (especially mobile friendliness) is one > of the many things that has been on my ever-growing TODO list for a > long while > I know the feeling! > [...] if you'd like help, just say the word. > Yes, please. You can start by reviewing r1891073. I see you already did some work with site manifest etc, - the changes in TEMPLATE should probably be added in all the HTML files as well. Except, possibly, some IE specific things (x-ua-compatible, browserconfig.xml). In another e-mail you mentioned that you also played with some design ideas for the site. Did you consider a complete redesign? Kind regards, Daniel Sahlberg
Re: svn commit: r1891065 - in /subversion/site/staging-ng: ./ docs/community-guide/ docs/release-notes/ security/
On Sat, Jun 26, 2021 at 2:11 PM Daniel Sahlberg wrote: > I think these catchup merges are quite fun to watch since they make a nice > summary of the events that has been going on. :-) > > For a summer project I will do some (minor) design work on the website. > Nothing big and professional like but > at least try to make the site a little bit more mobile friendly. I'm > thinking about adding a responsive stylesheet to fold the menu into a > hamburger on narrow viewports. > > I will do this on the staging-ng branch to keep staging open for regular > work and anyone interested would have to setup their own mirror ( > http://subversion-staging.apache.org/docs/community-guide/web.html#web_mirror > ). > > Feel free to comment if you have any ideas of what to do (and not to do)! > > Kind regards, > Daniel > Thanks! Improving the website (especially mobile friendliness) is one of the many things that has been on my ever-growing TODO list for a long while, and actually one of the issues that held it up was that I needed to research how to implement the hamburger menu so it works properly everywhere; more pressing work has always seemed to hold me back from it. I'd like to help if possible. Feel free to experiment however you'd like, and if you'd like help, just say the word. Cheers, Nathan Cheers, Nathan
Re: svn commit: r1891065 - in /subversion/site/staging-ng: ./ docs/community-guide/ docs/release-notes/ security/
I think these catchup merges are quite fun to watch since they make a nice summary of the events that has been going on. :-) For a summer project I will do some (minor) design work on the website. Nothing big and professional like but at least try to make the site a little bit more mobile friendly. I'm thinking about adding a responsive stylesheet to fold the menu into a hamburger on narrow viewports. I will do this on the staging-ng branch to keep staging open for regular work and anyone interested would have to setup their own mirror ( http://subversion-staging.apache.org/docs/community-guide/web.html#web_mirror ). Feel free to comment if you have any ideas of what to do (and not to do)! Kind regards, Daniel
