Re: [dev] [dwm] [bug] 5.9's first bug: magic float mode
Hi Peter,
On 11 July 2011 01:02, Peter John Hartman peterjohnhart...@gmail.com wrote:
Actually, this bug goes way back, but I thought I'd be the first to report
it, just to ruin dwm's birthday. The culprit is this chunk of code in
manage():
if(c-w == c-mon-mw c-h == c-mon-mh) {
// c-isfloating = True; pjh
c-x = c-mon-mx;
c-y = c-mon-my;
c-bw = 0;
}
Commenting out that line fixes it.
How you reproduce it is the fun bit.
(1) You have to have borderpx set to 0.
(2) You have to be in monocle mode.
[(3) You might also have to have statusbar hidden.]
(4) Open up a couple of apps.
Now, hit MODKEY+Shift+q, provided you have the dwm loop thing in your
.xinitrc. The windows all come back in floating mode, lovely enough.
Thanks for spotting. I applied it despite the fullscreen rework plans for now.
Current discussion on the mailing list is leaning to just eliminating that
chunk of code. Apparently, flash fullscreen requires it (which I haven't
been able to reproduce!) But why on earth is that code there, and can't
flash fullscreen be handled via a Rule?
I need to investigate when I added this chunk of code to remember why :)
Cheers,
--garbeam
Re: [dev] [dwm] [bug] 5.9's first bug: magic float mode
On Wed, Jul 20, 2011 at 8:39 PM, garbeam garb...@gmail.com wrote: Current discussion on the mailing list is leaning to just eliminating that chunk of code. Apparently, flash fullscreen requires it (which I haven't been able to reproduce!) But why on earth is that code there, and can't flash fullscreen be handled via a Rule? I can reproduce that fullscreen flash requires this. Flash creates a new window with unknown title and class and sets the _NET_WM_FULLSCREEN property. Maybe as a solution it makes sense to check for _NET_WM_FULLSCREEN property in manage() and set c-isfullscreen (and modify some layout functions). I stumbled on an old mailinglist post about this subject: http://permalink.gmane.org/gmane.comp.misc.suckless/2094 . --- Kind regards, Hiltjo
Re: [dev] [dwm] [bug] 5.9's first bug: magic float mode
I can reproduce that fullscreen flash requires this. Flash creates a new window with unknown title and class and sets the _NET_WM_FULLSCREEN property. Maybe as a solution it makes sense to check for _NET_WM_FULLSCREEN property in manage() and set c-isfullscreen (and modify some layout functions). I stumbled on an old mailinglist post about this subject: http://permalink.gmane.org/gmane.comp.misc.suckless/2094 . Ok, I can agree that flash fullscreen window is unknown, but does it *require* this? I've been watching flash without that line for weeks. Of course, if you *want* flash to float (for whatever god-forsaken reason) then you'll have a hard time making it float, but why would you want this? Maybe I'm wrong, but I can't reproduce a problem with flash in fullscreen mode that this line of code would fix. Peter -- sic dicit magister P PhD Candidate Collaborative Programme in Ancient and Medieval Philosophy University of Toronto http://individual.utoronto.ca/peterjh
[dev] [dwm] [bug] 5.9's first bug: magic float mode
Hi,
Actually, this bug goes way back, but I thought I'd be the first to report
it, just to ruin dwm's birthday. The culprit is this chunk of code in
manage():
if(c-w == c-mon-mw c-h == c-mon-mh) {
// c-isfloating = True; pjh
c-x = c-mon-mx;
c-y = c-mon-my;
c-bw = 0;
}
Commenting out that line fixes it.
How you reproduce it is the fun bit.
(1) You have to have borderpx set to 0.
(2) You have to be in monocle mode.
[(3) You might also have to have statusbar hidden.]
(4) Open up a couple of apps.
Now, hit MODKEY+Shift+q, provided you have the dwm loop thing in your
.xinitrc. The windows all come back in floating mode, lovely enough.
Current discussion on the mailing list is leaning to just eliminating that
chunk of code. Apparently, flash fullscreen requires it (which I haven't
been able to reproduce!) But why on earth is that code there, and can't
flash fullscreen be handled via a Rule?
Happy birthday dwm.
Peter
--
sic dicit magister P
PhD Candidate
Collaborative Programme in Ancient and Medieval Philosophy
University of Toronto
http://individual.utoronto.ca/peterjh
