Re: [dev] dwm 5.9 small patch for non xinerama users
On 26 July 2011 15:55, Connor Lane Smith c...@lubutu.com wrote: On 26 July 2011 14:36, mauro tonon tono...@gmail.com wrote: Sorry, i didn't mean the declaration but the pre-declaration or the prototype or how it is called... Yeah, it's missing. (grep says it's the only prototype missing, btw.) Yes, the whole lot xinerama stuff and the Monitor stuff will be decoupled for 6.0. I will incorporate these suggestions and patches. For the xr_* stuff I intend to put it into a separate file as well. Cheers, --garbeam
Re: [dev] dwm 5.9 small patch for non xinerama users
2011/7/25 Thomas Dahms thmsd...@googlemail.com: Hi, 2011/7/22 mauro tonon tono...@gmail.com: I noted that if i disable Xinerama, i don't use also the following functions: dirtomon, focusmon, tagmon. So, i think it is possible to hold all these functions between #ifdef XINERAMA ... #endif. The difference in the final binary file size is very little but... A possible patch is attached... What about prefixing these functions with something like xinerama_? They would then be all after another and a single ifdef would suffice instead of three. -- Thomas Dahms Right. I think there will be no difference in the final binary file, but the code would be simpler to read... I propose these substitutions in the name of the functions: dirtomon - xr_dirtotom focusmon - xr_focusmon tagmon - xr_tagmon isuniqegeom - xr_isuniquegeom and so it's possible to enclose all them between a single #ifdef ... #endif. By the way, where is the declaration of the isuniquegeom boolean function?
Re: [dev] dwm 5.9 small patch for non xinerama users
Grep is your friend. On Jul 26, 2011 9:10 AM, mauro tonon tono...@gmail.com wrote: 2011/7/25 Thomas Dahms thmsd...@googlemail.com: Hi, 2011/7/22 mauro tonon tono...@gmail.com: I noted that if i disable Xinerama, i don't use also the following functions: dirtomon, focusmon, tagmon. So, i think it is possible to hold all these functions between #ifdef XINERAMA ... #endif. The difference in the final binary file size is very little but... A possible patch is attached... What about prefixing these functions with something like xinerama_? They would then be all after another and a single ifdef would suffice instead of three. -- Thomas Dahms Right. I think there will be no difference in the final binary file, but the code would be simpler to read... I propose these substitutions in the name of the functions: dirtomon - xr_dirtotom focusmon - xr_focusmon tagmon - xr_tagmon isuniqegeom - xr_isuniquegeom and so it's possible to enclose all them between a single #ifdef ... #endif. By the way, where is the declaration of the isuniquegeom boolean function?
Re: [dev] dwm 5.9 small patch for non xinerama users
Hey, On 26 July 2011 14:36, mauro tonon tono...@gmail.com wrote: Sorry, i didn't mean the declaration but the pre-declaration or the prototype or how it is called... Yeah, it's missing. (grep says it's the only prototype missing, btw.) cls
Re: [dev] dwm 5.9 small patch for non xinerama users
Hi, 2011/7/22 mauro tonon tono...@gmail.com: I noted that if i disable Xinerama, i don't use also the following functions: dirtomon, focusmon, tagmon. So, i think it is possible to hold all these functions between #ifdef XINERAMA ... #endif. The difference in the final binary file size is very little but... A possible patch is attached... What about prefixing these functions with something like xinerama_? They would then be all after another and a single ifdef would suffice instead of three. -- Thomas Dahms
[dev] dwm 5.9 small patch for non xinerama users
Hi. I noted that if i disable Xinerama, i don't use also the following functions: dirtomon, focusmon, tagmon. So, i think it is possible to hold all these functions between #ifdef XINERAMA ... #endif. The difference in the final binary file size is very little but... A possible patch is attached... Bye, Mauro. dwm-5.9-patch_xine.diff Description: Binary data
[dev] dwm 5.9
Hi there, after exactly 5 years since the first commit into the current dwm mercurial repository I'm glad to announce the new dwm-5.9 release which comes packed with lot's of community driven bugfixes. It can be obtained from the following download URL: http://dl.suckless.org/dwm/dwm-5.9.tar.gz After this release, I plan more radical changes to the multiscreen code for the upcoming 6.0 series. Have fun! Cheers, --garbeam
