Re: [dev] dwm aesthetic 'bug'

2011-07-20 Thread garbeam 
On 12 July 2011 15:34, Connor Lane Smith c...@lubutu.com wrote:
 I noticed a slight aesthetic 'bug' in dwm's tile layout, which can
 cause the stack to 'shake' when your master changes, if your config.h
 respects resizehints, because it uses c-w instead of mw. Patch
 attached. (If I'm honest I don't know what corner case the inline ifs
 are for.)

Thanks, applied.

--garbeam

[dev] dwm aesthetic 'bug'

2011-07-12 Thread Connor Lane Smith 
Hey all,

I noticed a slight aesthetic 'bug' in dwm's tile layout, which can
cause the stack to 'shake' when your master changes, if your config.h
respects resizehints, because it uses c-w instead of mw. Patch
attached. (If I'm honest I don't know what corner case the inline ifs
are for.)

Thanks,
cls
diff -r 4548c824adac dwm.c
--- a/dwm.c	Sun Jul 10 21:25:23 2011 +0100
+++ b/dwm.c	Tue Jul 12 14:24:00 2011 +0100
@@ -1655,9 +1655,9 @@
 	if(--n == 0)
 		return;
 	/* tile stack */
-	x = (m-wx + mw  c-x + c-w) ? c-x + c-w + 2 * c-bw : m-wx + mw;
+	x = (m-wx  c-x) ? c-x + mw + 2 * c-bw : m-wx + mw;
 	y = m-wy;
-	w = (m-wx + mw  c-x + c-w) ? m-wx + m-ww - x : m-ww - mw;
+	w = (m-wx  c-x) ? m-wx + m-ww - x : m-ww - mw;
 	h = m-wh / n;
 	if(h  bh)
 		h = m-wh;