Re: [dev] [dwm] Style changes
On Sat, Apr 11, 2015 at 4:10 AM, Aaron Burrow burrows.l...@gmail.com wrote: If we're going to fix a bunch of formatting problems we should make sure the problem doesn't resurface. Put a commit hook on the git server that either validates formatting or does auto-formatting. It's a really awkward thing to suggest automagic for suckless. But seriously, all we were looking for was a script that would modify the contents of what users commit, because fuck their tastes, their checksums and their general expectations. cheers! mar77i
Re: [dev] [dwm] Style changes
Well, it would be identified as such, so you just go to the commit before that. In the end, this is a very weak argument. If you change the style early enough, the succeeding history will be fine. And when you go to the previous commit, you discover that it was another style change and you have to go before that again, and when you discover the actual commit, if you want to blame another line of this actual commit, maybe you discover that is another style change. Style changes makes difficult to follow the history of repositories (more difficult, not imposible), and it is the reason why,for example, they are not allowed in git project itself . We have some of these problems in st now (__20h__, pun for you :P). I realy hate the style of st, and it makes my life harder, because after some years with it, I don't get used to it, and I cannot use regular expressions in effective way (function braces are not in column 1), but I think we should not modify the style. Regards,
Re: [dev] [dwm] Style changes
If we're going to fix a bunch of formatting problems we should make sure the problem doesn't resurface. Put a commit hook on the git server that either validates formatting or does auto-formatting. On Fri, Apr 10, 2015 at 2:40 PM, Daniel Martí mv...@mvdan.cc wrote: On Fri, Apr 10, 2015 at 18:15:25 +0200, FRIGN wrote: Having a consistent style across suckless projects also makes sure that you don't have to update patches later on due to style changes. You raise a valid point, if in fact we are not to drastically change the style in the future :) While I agree that changing the style will break many patches, I'm all for doing it the sooner the better and be done with it. -- Daniel Martí - mv...@mvdan.cc - http://mvdan.cc/ PGP: A9DA 13CD F7A1 4ACD D3DE E530 F4CA FFDB 4348 041C
