[GitHub] coveralls commented on issue #3480: Improve code quality
coveralls commented on issue #3480: Improve code quality URL: https://github.com/apache/incubator-superset/pull/3480#issuecomment-330122801 [](https://coveralls.io/builds/13310759) Coverage decreased (-0.01%) to 69.131% when pulling **6e764baa60d6709dcd719bd4b7680bfc78de3f44 on timifasubaa:improve_code_quality** into **e22aecb0d1244bae49d3e5b36ef2f9ddc7517c1a on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3480: Improve code quality
coveralls commented on issue #3480: Improve code quality URL: https://github.com/apache/incubator-superset/pull/3480#issuecomment-330122804 [](https://coveralls.io/builds/13310759) Coverage decreased (-0.01%) to 69.131% when pulling **6e764baa60d6709dcd719bd4b7680bfc78de3f44 on timifasubaa:improve_code_quality** into **e22aecb0d1244bae49d3e5b36ef2f9ddc7517c1a on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3480: Improve code quality
coveralls commented on issue #3480: Improve code quality URL: https://github.com/apache/incubator-superset/pull/3480#issuecomment-330122803 [](https://coveralls.io/builds/13310759) Coverage decreased (-0.01%) to 69.131% when pulling **6e764baa60d6709dcd719bd4b7680bfc78de3f44 on timifasubaa:improve_code_quality** into **e22aecb0d1244bae49d3e5b36ef2f9ddc7517c1a on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3480: Improve code quality
coveralls commented on issue #3480: Improve code quality URL: https://github.com/apache/incubator-superset/pull/3480#issuecomment-330122802 [](https://coveralls.io/builds/13310759) Coverage decreased (-0.01%) to 69.131% when pulling **6e764baa60d6709dcd719bd4b7680bfc78de3f44 on timifasubaa:improve_code_quality** into **e22aecb0d1244bae49d3e5b36ef2f9ddc7517c1a on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] timifasubaa opened a new pull request #3480: Improve code quality
timifasubaa opened a new pull request #3480: Improve code quality URL: https://github.com/apache/incubator-superset/pull/3480 First pass of making the codebase more pep8 compliant. @mistercrunch This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] 1401062808 opened a new issue #3479: hi,i cannot pip install pymssql on windows ,please help me ,thanks a lot .
1401062808 opened a new issue #3479: hi,i cannot pip install pymssql on windows ,please help me ,thanks a lot . URL: https://github.com/apache/incubator-superset/issues/3479 Make sure these boxes are checked before submitting your issue - thank you! - [ ] I have checked the superset logs for python stacktraces and included it here as text if any - [ ] I have reproduced the issue with at least the latest released version of superset - [ ] I have checked the issue tracker for the same issue and I haven't found one similar  ### Superset version ### Expected results ### Actual results ### Steps to reproduce This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3473: Feature: Paired t-test table visualization
coveralls commented on issue #3473: Feature: Paired t-test table visualization URL: https://github.com/apache/incubator-superset/pull/3473#issuecomment-330103191 [](https://coveralls.io/builds/13309697) Coverage decreased (-0.2%) to 68.91% when pulling **156cbe7e247b98bb289559882412d66fde13ce00 on Mogball:mogball/feature/paired-ttest-viz** into **e22aecb0d1244bae49d3e5b36ef2f9ddc7517c1a on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3478: Feature: option to disable dashboard refresh staggering
coveralls commented on issue #3478: Feature: option to disable dashboard refresh staggering URL: https://github.com/apache/incubator-superset/pull/3478#issuecomment-330103114 [](https://coveralls.io/builds/13309671) Coverage remained the same at 69.142% when pulling **c622f9580a85cd4feda85f1f733a44a34a60 on Mogball:mogball/feature/dashboard_loading** into **e22aecb0d1244bae49d3e5b36ef2f9ddc7517c1a on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3478: Feature: option to disable dashboard refresh staggering
coveralls commented on issue #3478: Feature: option to disable dashboard refresh staggering URL: https://github.com/apache/incubator-superset/pull/3478#issuecomment-330101323 [](https://coveralls.io/builds/13309510) Coverage remained the same at 69.142% when pulling **0f84378cd4f88de2c75d0fa2ccf37a0cb7ca7786 on Mogball:mogball/feature/dashboard_loading** into **e22aecb0d1244bae49d3e5b36ef2f9ddc7517c1a on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3478: Feature: option to disable dashboard refresh staggering
coveralls commented on issue #3478: Feature: option to disable dashboard refresh staggering URL: https://github.com/apache/incubator-superset/pull/3478#issuecomment-330101324 [](https://coveralls.io/builds/13309510) Coverage remained the same at 69.142% when pulling **0f84378cd4f88de2c75d0fa2ccf37a0cb7ca7786 on Mogball:mogball/feature/dashboard_loading** into **e22aecb0d1244bae49d3e5b36ef2f9ddc7517c1a on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3478: Feature: option to disable dashboard refresh staggering
coveralls commented on issue #3478: Feature: option to disable dashboard refresh staggering URL: https://github.com/apache/incubator-superset/pull/3478#issuecomment-330101322 [](https://coveralls.io/builds/13309510) Coverage remained the same at 69.142% when pulling **0f84378cd4f88de2c75d0fa2ccf37a0cb7ca7786 on Mogball:mogball/feature/dashboard_loading** into **e22aecb0d1244bae49d3e5b36ef2f9ddc7517c1a on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3478: Feature: option to disable dashboard refresh staggering
coveralls commented on issue #3478: Feature: option to disable dashboard refresh staggering URL: https://github.com/apache/incubator-superset/pull/3478#issuecomment-330095751 [](https://coveralls.io/builds/13309073) Coverage remained the same at 69.142% when pulling **0d9a97e3ddbccdf1ab07ae406e0dd98d05ced96f on Mogball:mogball/feature/dashboard_loading** into **e22aecb0d1244bae49d3e5b36ef2f9ddc7517c1a on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3404: Feature: "Impersonate user" setting on Datasource
coveralls commented on issue #3404: Feature: "Impersonate user" setting on Datasource URL: https://github.com/apache/incubator-superset/pull/3404#issuecomment-330085819 [](https://coveralls.io/builds/13308761) Coverage decreased (-0.001%) to 69.14% when pulling **5c02f71826d0d008bdc9eeb0dd1b4bae21ad03bf on dmigo:master** into **e22aecb0d1244bae49d3e5b36ef2f9ddc7517c1a on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3404: Feature: "Impersonate user" setting on Datasource
coveralls commented on issue #3404: Feature: "Impersonate user" setting on Datasource URL: https://github.com/apache/incubator-superset/pull/3404#issuecomment-330085814 [](https://coveralls.io/builds/13308761) Coverage decreased (-0.001%) to 69.14% when pulling **5c02f71826d0d008bdc9eeb0dd1b4bae21ad03bf on dmigo:master** into **e22aecb0d1244bae49d3e5b36ef2f9ddc7517c1a on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3404: Feature: "Impersonate user" setting on Datasource
coveralls commented on issue #3404: Feature: "Impersonate user" setting on Datasource URL: https://github.com/apache/incubator-superset/pull/3404#issuecomment-330085815 [](https://coveralls.io/builds/13308761) Coverage decreased (-0.001%) to 69.14% when pulling **5c02f71826d0d008bdc9eeb0dd1b4bae21ad03bf on dmigo:master** into **e22aecb0d1244bae49d3e5b36ef2f9ddc7517c1a on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3404: Feature: "Impersonate user" setting on Datasource
coveralls commented on issue #3404: Feature: "Impersonate user" setting on Datasource URL: https://github.com/apache/incubator-superset/pull/3404#issuecomment-330085807 [](https://coveralls.io/builds/13308754) Coverage decreased (-0.001%) to 69.14% when pulling **5c02f71826d0d008bdc9eeb0dd1b4bae21ad03bf on dmigo:master** into **e22aecb0d1244bae49d3e5b36ef2f9ddc7517c1a on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3404: Feature: "Impersonate user" setting on Datasource
coveralls commented on issue #3404: Feature: "Impersonate user" setting on Datasource URL: https://github.com/apache/incubator-superset/pull/3404#issuecomment-330085821 [](https://coveralls.io/builds/13308761) Coverage decreased (-0.001%) to 69.14% when pulling **5c02f71826d0d008bdc9eeb0dd1b4bae21ad03bf on dmigo:master** into **e22aecb0d1244bae49d3e5b36ef2f9ddc7517c1a on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dmigo commented on a change in pull request #3404: Feature: "Impersonate user" setting on Datasource
dmigo commented on a change in pull request #3404: Feature: "Impersonate user"
setting on Datasource
URL:
https://github.com/apache/incubator-superset/pull/3404#discussion_r139320827
##
File path: superset/models/core.py
##
@@ -588,13 +589,15 @@ def set_sqlalchemy_uri(self, uri):
conn.password = password_mask if conn.password else None
self.sqlalchemy_uri = str(conn) # hides the password
-def get_sqla_engine(self, schema=None, nullpool=False):
+def get_sqla_engine(self, schema=None, nullpool=False, user_name=None):
extra = self.get_extra()
uri = make_url(self.sqlalchemy_uri_decrypted)
params = extra.get('engine_params', {})
if nullpool:
params['poolclass'] = NullPool
uri = self.db_engine_spec.adjust_database_uri(uri, schema)
+if self.impersonate_user:
+uri.username = user_name if user_name != None else g.user.username
Review comment:
done! ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] coveralls commented on issue #3478: Feature: option to disable dashboard refresh staggering
coveralls commented on issue #3478: Feature: option to disable dashboard refresh staggering URL: https://github.com/apache/incubator-superset/pull/3478#issuecomment-330081044 [](https://coveralls.io/builds/13308548) Coverage remained the same at 69.142% when pulling **1c9bbefacc6b9245ba6bec6bab6d20d8ccd71f07 on Mogball:mogball/feature/dashboard_loading** into **e22aecb0d1244bae49d3e5b36ef2f9ddc7517c1a on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3478: Feature: option to disable dashboard refresh staggering
coveralls commented on issue #3478: Feature: option to disable dashboard refresh staggering URL: https://github.com/apache/incubator-superset/pull/3478#issuecomment-330081042 [](https://coveralls.io/builds/13308548) Coverage remained the same at 69.142% when pulling **1c9bbefacc6b9245ba6bec6bab6d20d8ccd71f07 on Mogball:mogball/feature/dashboard_loading** into **e22aecb0d1244bae49d3e5b36ef2f9ddc7517c1a on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3478: Feature: option to disable dashboard refresh staggering
coveralls commented on issue #3478: Feature: option to disable dashboard refresh staggering URL: https://github.com/apache/incubator-superset/pull/3478#issuecomment-330081045 [](https://coveralls.io/builds/13308548) Coverage remained the same at 69.142% when pulling **1c9bbefacc6b9245ba6bec6bab6d20d8ccd71f07 on Mogball:mogball/feature/dashboard_loading** into **e22aecb0d1244bae49d3e5b36ef2f9ddc7517c1a on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3478: Feature: option to disable dashboard refresh staggering
coveralls commented on issue #3478: Feature: option to disable dashboard refresh staggering URL: https://github.com/apache/incubator-superset/pull/3478#issuecomment-330081043 [](https://coveralls.io/builds/13308548) Coverage remained the same at 69.142% when pulling **1c9bbefacc6b9245ba6bec6bab6d20d8ccd71f07 on Mogball:mogball/feature/dashboard_loading** into **e22aecb0d1244bae49d3e5b36ef2f9ddc7517c1a on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Mogball opened a new pull request #3478: Feature: option to disable dashboard refresh staggering
Mogball opened a new pull request #3478: Feature: option to disable dashboard
refresh staggering
URL: https://github.com/apache/incubator-superset/pull/3478
- Initial dashboard loading set a random delay (usually 0 to 5 seconds) on
slice rendering
- Triggering a dashboard refresh by changing filters or clicking "Refresh"
did not do this
Refreshing the dashboard now will either stagger or not stagger slice
rendering, regardless of how it is triggered, and there is the option to
disable this and set the stagger interval (in milliseconds) in the dashboard's
JSON Metadata: `{ ...
"stagger_refresh": false,
"stagger_time": 15000
}`
Default value is true and 5 seconds. Staggering is also more deterministic.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] coveralls commented on issue #3476: Miscvizcleanups
coveralls commented on issue #3476: Miscvizcleanups URL: https://github.com/apache/incubator-superset/pull/3476#issuecomment-330040106 [](https://coveralls.io/builds/13305950) Coverage increased (+0.01%) to 69.152% when pulling **6c94e2c1ae63750d3ab94ed03a2517ae0be3cde0 on xrmx:miscvizcleanups** into **e22aecb0d1244bae49d3e5b36ef2f9ddc7517c1a on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3477: docs: athena can be installed from pypi
coveralls commented on issue #3477: docs: athena can be installed from pypi URL: https://github.com/apache/incubator-superset/pull/3477#issuecomment-330039987 [](https://coveralls.io/builds/13305952) Coverage remained the same at 69.142% when pulling **fb8fa035b2fb24afa28325f8092fbace42dba42a on xrmx:athenadocs** into **e22aecb0d1244bae49d3e5b36ef2f9ddc7517c1a on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3477: docs: athena can be installed from pypi
coveralls commented on issue #3477: docs: athena can be installed from pypi URL: https://github.com/apache/incubator-superset/pull/3477#issuecomment-330039985 [](https://coveralls.io/builds/13305952) Coverage remained the same at 69.142% when pulling **fb8fa035b2fb24afa28325f8092fbace42dba42a on xrmx:athenadocs** into **e22aecb0d1244bae49d3e5b36ef2f9ddc7517c1a on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3477: docs: athena can be installed from pypi
coveralls commented on issue #3477: docs: athena can be installed from pypi URL: https://github.com/apache/incubator-superset/pull/3477#issuecomment-330039986 [](https://coveralls.io/builds/13305952) Coverage remained the same at 69.142% when pulling **fb8fa035b2fb24afa28325f8092fbace42dba42a on xrmx:athenadocs** into **e22aecb0d1244bae49d3e5b36ef2f9ddc7517c1a on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xrmx opened a new pull request #3477: docs: athena can be installed from pypi
xrmx opened a new pull request #3477: docs: athena can be installed from pypi URL: https://github.com/apache/incubator-superset/pull/3477 As sqlalchemy support has been merged and available in a release since a few. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #3475: viz: fix reversed stats_logger label
coveralls commented on issue #3475: viz: fix reversed stats_logger label URL: https://github.com/apache/incubator-superset/pull/3475#issuecomment-330038572 [](https://coveralls.io/builds/13305806) Coverage remained the same at 69.142% when pulling **f2254289891493219fbd430b1e36297926586d21 on xrmx:metricstypo** into **e22aecb0d1244bae49d3e5b36ef2f9ddc7517c1a on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xrmx opened a new pull request #3475: viz: fix reversed stats_logger label
xrmx opened a new pull request #3475: viz: fix reversed stats_logger label URL: https://github.com/apache/incubator-superset/pull/3475 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
